From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5177C5AD49 for ; Tue, 3 Jun 2025 22:15:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65B076B052A; Tue, 3 Jun 2025 18:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C8B6B052C; Tue, 3 Jun 2025 18:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FA766B052D; Tue, 3 Jun 2025 18:15:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 30DCC6B052A for ; Tue, 3 Jun 2025 18:15:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DF7115FD2C for ; Tue, 3 Jun 2025 22:15:30 +0000 (UTC) X-FDA: 83515496820.04.D4BBBEA Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) by imf20.hostedemail.com (Postfix) with ESMTP id 6C7B61C0004 for ; Tue, 3 Jun 2025 22:15:28 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=ILYYPhNM; dmarc=pass (policy=none) header.from=columbia.edu; spf=pass (imf20.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.135.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748988928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lfp69DiYOeQKA1pcsNzgw4KPGHdSjVYUj1VSH3quNCM=; b=E5YqRV9EjeEhInWLR4c0aZjTxaxuDwgOIpX17a6zWBl+F+/Xf2KcdKEwGoHDOpSVmPvbue 44I8ITl5QUKCRrKCbX6W8NNdC4ibOnxW1nejN7SralLJL0gUpI8QR6AyMiSGVnnRrQq8QK q00wHsRa1cSPE5RD8THFIEbcgqjrPHM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748988928; a=rsa-sha256; cv=none; b=3qE2uyCiiZQlZWXr72obYzRSn2cRDTYXq3+M2sf2LHkcXgQ/YyJtHmGuOVwH6s9RKL0S8h laCvSovqN/w1lyHuCVa0G4HBf0fbwq1VhJToEmAigcB9+UZw2e17ZXKPcJBtMPlLJZbY0t ra+dS/S8o9Fa8ElKrH0fakxurBexGKY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=ILYYPhNM; dmarc=pass (policy=none) header.from=columbia.edu; spf=pass (imf20.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.135.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu Received: from pps.filterd (m0167071.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 553L6OaH016376 for ; Tue, 3 Jun 2025 18:15:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pps01; bh=Lfp69DiYOeQKA1pcsNzgw4KPGHdSjVYUj1VSH3quNCM=; b=ILYYPhNMp9nd+ku4UA3Gik0QL3CXW5MM7ZS4qPGtIsMBAg2oyfYY6TvaseOOpfP6IYaq GLR1AtGDrP48EQ8LMzaKlvhxk/j+wFbAHWfiEE9NObS0vQCtD6qnRjKKd39ldsSVGDCa OxbGy1xKxClLMZSScE4BEgPgpRP22G+TYGc2dvAvZqF+XwxyX/tqQbteda/zrAOr66Lg QOMU+4UAHKI4Kpo8t1lQvp6aWBWw37iIbWZUsZvBMdk3/cGHNGhToPTkQHAwGsuFwANm 2tBDOzS81w2hIlsUIZyEiAp7+33qEZGk0N6ubGbkzcSpVx/4GAPMTnM8X1dUY1Vt4buQ iA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 46yxqt8ve5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Jun 2025 18:15:26 -0400 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a582e95cf0so33598841cf.1 for ; Tue, 03 Jun 2025 15:15:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748988906; x=1749593706; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lfp69DiYOeQKA1pcsNzgw4KPGHdSjVYUj1VSH3quNCM=; b=l6FiD4+CnSL90hWx1I6bYIyBuqqqU1ZB5xCK1OslGUraiwzsCe1GVi0fh3iGNp6Udn JnlNDQnyKO4+aZgqx0ZDoeaq7WU7qGO+PMR0HYBluisgovaEBn7r2GVCG5jXPLOo8zQJ w1IpkETm3d/vR6+e0Ufc1kmkuyOcIQ7iUqqfDHG0hrAM3omZjfM354ROQ3H3FsnPzhHP afLdl1+LRjt+pfEdC0/BhLjGqMOTjWW7VskXkesB/zv1YjNvAFzDbkmoA3teLBwTQROy CQJk3eBY7Sw6ntLLEHP1/ZQ7jhfqC/CF2SjaS/Q4eKNCj/u+DJI8UUTDFjC78TsjEmeo aZ6Q== X-Gm-Message-State: AOJu0YyhrMbHwmkCGQgVHw7JnzQlcI5TDbhkp4oJLQ0Ub5gi6ZtRxzfP GsLZV1fIiMNf8KBKyhOFUUcz/Ac37D98lGaZXo3pB6FiAZBbcen4XcYpKyKXpTGOaP//KaZawTY KEOTg8VnWw2y6lhIivR4SHiIW8H6JSa19WqxBpxB5vZIpFTZS X-Gm-Gg: ASbGncv6BA2iqRd/Jo1IRCNABuuSwXkGPZr3Ivl9HVwfkrMxnimO7mon6fVCemVLwY8 vD+QjYZmeUmxNnWBzSEcimXuCEIbyCdgu+0MfKw7heZSoofG3edSLo3vpiwUJvkMhYKfzpUl97J pIBu+3lQZ/0F8EKArHQJCgvVbqiJQIwFi/pPeaLy8RKPawAF5qLPWJFRpf/SwC1g7gMB00kUvfQ u6ynSaWeoLuhspJdkTdtuHvW6lsqI4ODuu8apqSW9bXs0NMUA9Txz4Crw+LAcTAJtpvYO+CTfM/ 1fCDxTp12HhctAuHJhiiQVc4fzqdxHZV1s2L9y+mA/VARRxlOvV+h9pyOg== X-Received: by 2002:a05:622a:4819:b0:494:b914:d140 with SMTP id d75a77b69052e-4a5a57f0ef2mr8844741cf.43.1748988906191; Tue, 03 Jun 2025 15:15:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3r+PJxJ7QkVzaMR5o9MP2GSalSCVTrXWtLu6GU0AT2AKuvSzgDe0WZeGkRGDRbidaKgnbkQ== X-Received: by 2002:a05:622a:4819:b0:494:b914:d140 with SMTP id d75a77b69052e-4a5a57f0ef2mr8844291cf.43.1748988905724; Tue, 03 Jun 2025 15:15:05 -0700 (PDT) Received: from [127.0.1.1] (nat-128-59-176-95.net.columbia.edu. [128.59.176.95]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a5919064dbsm33085741cf.53.2025.06.03.15.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 15:15:05 -0700 (PDT) From: Tal Zussman Date: Tue, 03 Jun 2025 18:14:22 -0400 Subject: [PATCH 3/3] userfaultfd: remove UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250603-uffd-fixes-v1-3-9c638c73f047@columbia.edu> References: <20250603-uffd-fixes-v1-0-9c638c73f047@columbia.edu> In-Reply-To: <20250603-uffd-fixes-v1-0-9c638c73f047@columbia.edu> To: Andrew Morton , Peter Xu , "Jason A. Donenfeld" , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Pavel Emelyanov , Andrea Arcangeli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1748988902; l=1458; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=g27oyTD6/jrBAqdANGNVmDLwLJKx2ZUNNdLuTW4r2Xc=; b=/XIMrYtbF5Y68qcMiwHj35HHywny0Un8ee+I0CUXo50KzxtW2KYaTD4j2taaBviXzq47kEjjp v0QqS3mP22GAE07Teo5dLuKCi931LxkSWAeIzPAUiVFzfkda3ZYvYQR X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-GUID: QV1rBYF61rUFvwbTG1chYHnA8cH_N4tr X-Proofpoint-ORIG-GUID: QV1rBYF61rUFvwbTG1chYHnA8cH_N4tr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjAzMDE5MyBTYWx0ZWRfX/uRHoIZFfAhm H1rv5hQTw9jpsSctZEMdT/q/N+evITUn1osq1NNXoJhMtJMig2oeKH9bIovOmjG0DWtGrgewITv Zgtx3NG0QQZM5FJG3BVUZwRn1qyMfl+jr975VBBT2IX0doulE5szo2QHhH6wPPBVnU+u5Mq4q/n 8nhThMBvB5QZA1TLLO4PwHEirZEygrRtU5i855C5oi2TeidwpXjTUmQl8ftoMx53OGt2Jczj3fD 3Sb/oqKeSkzCbGvV8R2/NPlKT9yMU8OGXTqr3YneOL4x4zLDdAYqtmrb6cILcDrDJSiG0map18y BICZ4pY6GdUNf6vc065mRhSdTKgHdUnFnEftVfoWk3dZ4tAZuT3AyLtDT5X8gdJyZ1AwX7r+kTz DC4Fz/Fh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-03_03,2025-06-03_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=10 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=459 clxscore=1015 impostorscore=0 spamscore=0 lowpriorityscore=10 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506030193 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6C7B61C0004 X-Stat-Signature: 5ai86w4g7nkq1tp6nx1ca6i9e9ikhymz X-Rspam-User: X-HE-Tag: 1748988928-939837 X-HE-Meta: U2FsdGVkX1+shddl48y905Ajuei9qxMcjJ3UpPT2NEc/fEyc45ib0gVxmkOKVQeT2FJ7VZwLzpfLIZT3UsEJ5yybX8dyjsfbFHCq1PIdEcYh9MfSup0hb4NhUMk71+pz6NHEfKlHAXR5MUvDTRCq8ncN5ZTYuXZCQPYiPgsmwmKZsL9nOjxyuTC/dSTIoe1Mfuw4aKCo16hwtEsWcPxi52N5wJbb+z2M+iSXRQE7+ZI207gUQXjuIlCJfbMNMDKEJz7PFO/51fydkuks1YXv07j5/cqkEk66t7BLZdH2CBThNkWsAciBWcl/RRlSoDOCltwGZxSqTalP+vT6aVmiKVSMRGYwXxDH+r7KQ656EqO+bEvWcnSi58i1d7PNGnENL0LZBtV3G4VNdZIMelWp0dFOpWPbUvBIy6OB2DZ7y/2YOMckpbkKjIsaYaBQHQDqTbVH+zHbOAc1WwCEQf/8TtSr9QQ8JT0NURfsBTuvjIlamOw/fqHZN2LNovJlaI+pwNIx/Uilv2Asog5enDAyLwj5gSrao2FYZ+4NObOx+Wy6Tl1KmJX30eQBGuSdBG5ym0fTzEvW5JOTezz75iJCBUyOaD5Ko+6sHIj5TIXyNlJSKa1/RNrBZuTdggRtODLBaf1swqh65K6FzrvjB4SQ0jkOL5RkREQ4JeozgymuDRh5bVn1Hu1aLcDToyZylewgxQH7hmFX5P3i0GH4MFbUngfUi0qtED2NdOaSb/3tIF/uuJ+9H3ZCUqmXlGFo/5Dzjosjp9P6316Zhw9D0QiE3HJ++9nxTdyhWu+G0O4Rx1v2Urmw+vVmtPINT0yk4Lbfp65p36cZ8KC+cm7W1bWgejf1iRkXbz/X0zIMpv44Lztjyzg2F426RHYXUTSjcPmvJ9MSFqjfv2ebem2abuuwX19yFCxkr4pPXSY95os5kAzoviA8MLjPVwjMs1qHxpmgdi0MErnYGWvmg8Untby tgY9CFOO 8OgKikTFoUiI+eTvEmatk3Vsm4FTe5SJF2HI2gFh52JJQzY9UxiNBq1tuapagRaI6qPgTLZG1G8zz46sYjzZe9+RUmWGsfERtURnXO8pb7xO5x4T4WMx8z4gikIvzNCOLEOz7r7z4PHTBKcGFWvICWWvdZImD7lEFPsSe3J6jQMb+esKc5LuqzsxbTwl+tumG4wgtpVfjMTY2C5iKDnA2qAotpyIeSHHF5eX4KhWv84TOshadzeohzbodNMLhIAMHrUTpRZ3dke/dUvuWQ4LKDiTJPugxWg/g3VDofImK6csY2AV1rjkAgD+qyCN9lL4C7MckO/su06tI/O2fdQDo+trhih6S6gRORc69juwTsk/o5fX0tQxMUoKR/OnqPAeFLec/UkT7c7r904A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET have been unused since they were added in commit 932b18e0aec6 ("userfaultfd: linux/userfaultfd_k.h"). Remove them and the associated BUILD_BUG_ON() checks. Signed-off-by: Tal Zussman --- fs/userfaultfd.c | 2 -- include/linux/userfaultfd_k.h | 4 ---- 2 files changed, 6 deletions(-) diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index 9289e30b24c4..00c6662ed9a5 100644 --- a/fs/userfaultfd.c +++ b/fs/userfaultfd.c @@ -2121,8 +2121,6 @@ static int new_userfaultfd(int flags) /* Check the UFFD_* constants for consistency. */ BUILD_BUG_ON(UFFD_USER_MODE_ONLY & UFFD_SHARED_FCNTL_FLAGS); - BUILD_BUG_ON(UFFD_CLOEXEC != O_CLOEXEC); - BUILD_BUG_ON(UFFD_NONBLOCK != O_NONBLOCK); if (flags & ~(UFFD_SHARED_FCNTL_FLAGS | UFFD_USER_MODE_ONLY)) return -EINVAL; diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h index f3b3d2c9dd5e..ccad58602846 100644 --- a/include/linux/userfaultfd_k.h +++ b/include/linux/userfaultfd_k.h @@ -30,11 +30,7 @@ * from userfaultfd, in order to leave a free define-space for * shared O_* flags. */ -#define UFFD_CLOEXEC O_CLOEXEC -#define UFFD_NONBLOCK O_NONBLOCK - #define UFFD_SHARED_FCNTL_FLAGS (O_CLOEXEC | O_NONBLOCK) -#define UFFD_FLAGS_SET (EFD_SHARED_FCNTL_FLAGS) /* * Start with fault_pending_wqh and fault_wqh so they're more likely -- 2.39.5