From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0CFCC5AD49 for ; Mon, 2 Jun 2025 16:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 390E36B02FD; Mon, 2 Jun 2025 12:53:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 340B36B02FE; Mon, 2 Jun 2025 12:53:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22FB66B02FF; Mon, 2 Jun 2025 12:53:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 04FC46B02FD for ; Mon, 2 Jun 2025 12:53:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4516B1D6A4A for ; Mon, 2 Jun 2025 16:53:38 +0000 (UTC) X-FDA: 83511056916.25.CD2D72E Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 62FE720005 for ; Mon, 2 Jun 2025 16:53:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BO9aNWA1; spf=pass (imf03.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748883216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xDHMuqo6RzMoJIRbVQT8ztx5HK0kzx4NSGfmPKbpaeM=; b=3B3TSwKGNdInYo/VqXevEDqHKwhMoweoIg7ut1/3ikznycClOZIovKb2PirlhsXJNI2aIp A4Mxp/q/oQX/00+guNsbnZCvBq8nq/u+lTowyAVcrLUqY7fFhcnemE7n0S7Mgb1wGMfyZ6 ImJTTIoQejiqtpN8hg7sq0s9Nfks5Xc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BO9aNWA1; spf=pass (imf03.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748883216; a=rsa-sha256; cv=none; b=yXr0CWbts3dIZxBQuYTScEdA5dlxr9rG9bjZY8RnzxwoAjHklq2G3DqvbGUvP4QMRevNVL ZgK4GhM/SZWUz5tJ+ZtsbxqrZXn5Kvu6EmqYMldeuaVUugUmD8C6UtK2Dwo+R/PVKHZoSF TqHzS+EVJgI73NbbW92oxeILCzT2oAk= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-e7dd151f79eso4313729276.2 for ; Mon, 02 Jun 2025 09:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748883215; x=1749488015; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xDHMuqo6RzMoJIRbVQT8ztx5HK0kzx4NSGfmPKbpaeM=; b=BO9aNWA1u+FcapOucTL3PDwtqAH62QXkVYNDCtBts9CDlVZ07dDJzafx8/rKBdrGnB 2lnJqAtM9bmhtQMTbMXoxc5m5vE8w3U6a8CzO29ogsv3T4sG9BA+I65yRblcpW4+FLOp U1dakoszymge0/ARcnoHASIrHcDvdwQjrs648+UyZT6rx6+1S0RysntCznr35BNGH1vY iD9qi2yhx9LAsQFNiEXkcm4WMLrOQHIdByyif3vphHfG/d3jZNuWsKeDuAYPw6OsvtoS GxGHMk8CtBbDv2530lwoHRcE+2eSiPvq1805VH9IFz5I7QvJfXZQQIFoJnhySwxX1uNq R7oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748883215; x=1749488015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xDHMuqo6RzMoJIRbVQT8ztx5HK0kzx4NSGfmPKbpaeM=; b=ZIehYMW8CYQ1Egb8wXuyLifWw0M/icAuEes3YlxuPaPRO82kMu6ogHKG6VMsohnKM0 TqLITRnUvu9D62RcMkrAyDFwvgqXJLdDHCeLs4Ox1jNPPF9zdtL9g/7DMwR0nzu+X0fo B0mJqcB5jHavTnsFP73R0bxoj+Vvo1qv0xrxtDVtHLF/LHQEmiCKF4bOL7D3SzhEKg7c o65sVAmUw5DGT/AOgpTYCOPyT6zZjgc9+Yso05iKASMIGSo7bO92XuaYaa23OsKqnQuV jLtibogFA75FLdWq2NsW5F0l+QDmlrXynOGUmy2thmMOBv9wLm5kLoowrnn2WPCesgj3 DJvA== X-Forwarded-Encrypted: i=1; AJvYcCWrL0Jr6twnPFE81a3bX1hgzqQ3gRUGj9i6aHwDHzWdhQEunZe/sZeT/ijmM3AXYnobFlW96aS+nA==@kvack.org X-Gm-Message-State: AOJu0Ywown2LWCG1QsAD/PNXeJRYK2iSqDsari3Hsl40J2DYF86hpBAa QrEYvvBdF5+lBZqBVcsFnl39iTpTkxhKGuwRjU1d10evcijxU1gc/cTc X-Gm-Gg: ASbGncsnEZMU2t9qp8zxKoVP2Nrh0N5hqZZDedeL/qKQSeVKcPtgLa6I74FpYcdDme2 l7yQwrqg/WeJ9EZzPzCj/OlXSUJIAPC7iIFoIDsyuJcp4/gAXKmHggUv8K/a/APOCPOh6R40mxC +O99erBscakUNGFkhIwFxxeApCS8Sbt02bfcP+yMCapzLRTU8vzG4auJSPBvyl4g+4S46/Q0M7p qZrEHIgwlrSLwgGrI6GQ0xymmlQDgKwg9KDlZztku9kOBAiq6Gc4mSxl+hQK49/wzbu+G10x+Dm yf7H6voT8EFwGkMcfL3TMH/grB82dcEJDUijc7oN+Huoz4r6EkE= X-Google-Smtp-Source: AGHT+IHn23nMGp0B35ZPqUDMayqPq1AMBdtqerU9zasbWOYSJSaq5D+zdFs6bGTN3Xvsede1apJ8jg== X-Received: by 2002:a05:690c:6a02:b0:70e:142d:9c69 with SMTP id 00721157ae682-70f97f2f43emr206017637b3.31.1748883215244; Mon, 02 Jun 2025 09:53:35 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:72::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-70f8abd6052sm21510437b3.24.2025.06.02.09.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 09:53:34 -0700 (PDT) From: Joshua Hahn To: Joshua Hahn Cc: Andrew Morton , Gregory Price , David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, kernel test robot Subject: Re: [PATCH 1/2] mm/mempolicy: Fix incorrect freeing of wi_kobj Date: Mon, 2 Jun 2025 09:53:31 -0700 Message-ID: <20250602165332.2746843-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250602162345.2595696-1-joshua.hahnjy@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 62FE720005 X-Stat-Signature: i8b6apkx6pm1a7pfr51bbc4u915ngrs5 X-Rspam-User: X-HE-Tag: 1748883216-328210 X-HE-Meta: U2FsdGVkX19dZ1aNQL0sEm6YBlDprSMJcTTlgSleMQKbNH5YrJ3Ed2jEEEcSz8yJ1mznxHuAprTbAAWKL1vOlYxV4VwUEDrHv1nfhzKGyqUPj2E484jQS3ZpOrRceeNHegQobJpiY7COPdPNzd7Q+6Dh6bI5AZ0EbYFsTO0AVJm/s5qS50JVsVdqKQfnHkeBdTi3yoq76ZrjzQHxluS0gPrZv9aZnk3n0E2w+eVtXt3K6TgZR9JtI0e7D0O5QBmO8Ii4MY/dWu3gFyst6SJRyeFAw7dFVzNsLA3XtXFzRLDcd8fmPWiRgPbguMO5fxoBd853eKq7u4Aoh/NJ+JDUTaMnapSuqkmCwfOk20P2zB/P3pacgGEMP53mffLI3rT3ZoYUFAZ4eLoi2Z8JmqiKVlz+C/lrsekwEQoK6EPUY7d+ecy4tU0bo6XPBohMG66GOE9tp6a7ApP37J1g5p/0F6UloROoP8k+P3G9d/e5Ia0vCPE0LFzMywthhBwMoI2pIIcOXEZmti+8xvauA4iDiyBnej4p7ilWmnwYtVCxzFxGuyD5uw7jC4DwC0/2Ax/UPBuwp+oRzLNq/c8qHlqRFwwVg8ViGrYZMEu6pY4T9dC7KHG8vPY9/0ElnZxhZhzj/PwbzLRxvKEAzwls51TpqBqGzL8/WDLjlYR37OLsc57okNWSUdAZLouZ3IoVBxZdtsgll5mMwnMyly7KCTwiKk8WEOQTBT82gib8aiwsSova+w6kL/3fW7A5USIvPe16dgD7c2lnYKLaVLZqKIcOIVk+SmyDgy0dcaZVqbkiLwp7X91Aul0Yrtr+kafsCijiwCBXi3W24I2nzsy1WyE0p53TEH1LU5I0IXPLLX8FKqxZMB9pfEVOrwuN3nSzpnGa3q4ZTFZlMKpLUXzRKZhF2plpGVT17+pTqo4prU9lxBA23qxGzlJpW6NNaFUwAo0WSX2LDCek3zINELnxDoO vH6RRGGq 05CnwB90NuNmtBjaMDjW0erI4AncvoMvGFOw1V+SZTjR2150/4SBPIvH+ynE5DCcpOFgSpuBoqT0rrB5NyP9KocQPRB2dE8QascARvKzMGkGWIPCOE7urM2eHPQaFHNJDCtBuRkTe7j3pd+u1mF7jG371LB7QsrVngzPy/XCY5qyqvtyovVYmAwkltgobZyRjHRzXJWpkdbv8re36GBWpHJ7kXPljAoS1UxcF9YiWcv2PMCm4WjSCpJouxct50WzHLeEzJucK3wF97b5f5JTnhlEB9NDWe1hGwzIyklMCgwrw75Nio84L8zkbvPWZXK+sc3c3H5zDACiYuLukQMDbcYuEXweYTDlPKt2V+z6969xwFA39M5Bip9S8iz10kSZJkAvy3KvEtZfU2wfOSal6S9OHOUM8lrvj0yt73wptICeHTtmNitINnb7Fwu7BL/6kzizvS3VuQcncPh1LFTXSI8hn4QgLnZq0yOZbiDPz8QwrEQ+SB4vKhdteoGWoYFK7Vs/Md7nNW498VaFSH+WVzm8FBB3+ofhT4ec76oiEleIwtEhjK3A7WxeWREkfMvfYSGzSh57M9GZ2fWeqo1LAorIChklQPyntTiBwB2CetD4y+Ys0qgoTbVAqajDgpIE7nqxH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Jun 2025 09:23:39 -0700 Joshua Hahn wrote: > We should not free wi_group->wi_kobj here. In the error path of > add_weighted_interleave_group() where this snippet is called from, > kobj_{del, put} is immediately called right after this section. Thus, > it is not only unnecessary but also incorrect to free it here. > Fixes: e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning") > Signed-off-by: Joshua Hahn > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202506011545.Fduxqxqj-lkp@intel.com/ > --- > mm/mempolicy.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 72fd72e156b1..3b1dfd08338b 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3708,15 +3708,13 @@ static void wi_state_free(void) > lockdep_is_held(&wi_state_lock)); > if (!old_wi_state) { > mutex_unlock(&wi_state_lock); > - goto out; > + return; > } > > rcu_assign_pointer(wi_state, NULL); > mutex_unlock(&wi_state_lock); > synchronize_rcu(); > kfree(old_wi_state); > -out: > - kfree(&wi_group->wi_kobj); > } > > static struct kobj_attribute wi_auto_attr = > -- > 2.47.1