From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F9ACC54FB3 for ; Mon, 2 Jun 2025 16:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 812DF6B02E9; Mon, 2 Jun 2025 12:23:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C3F16B02EB; Mon, 2 Jun 2025 12:23:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B3C36B02EC; Mon, 2 Jun 2025 12:23:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4BBBF6B02E9 for ; Mon, 2 Jun 2025 12:23:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5207B140BEA for ; Mon, 2 Jun 2025 16:23:50 +0000 (UTC) X-FDA: 83510981820.25.7EAA8E9 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf12.hostedemail.com (Postfix) with ESMTP id 83C9C40013 for ; Mon, 2 Jun 2025 16:23:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O4UGiPgi; spf=pass (imf12.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748881428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Fx/1udL/q8PlGAipoyIKl9RK0k/YkkPXl+dR5dADJ4o=; b=XYHRu5JAyLQBKKNbUVxS3VawKJ69YEo9csSesH9smanDbTJhCp8AJS+OZb7t/eILX8slV4 ycahFVoRDJjZT/200M/hWZaKTxdUHPgz2ircKmtgEN9wjiJkDEpPmFH5hEEBxT9nUyAa+2 ZKjgpfHxCFYkwG8b9R36FotPRBvft+Q= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O4UGiPgi; spf=pass (imf12.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748881428; a=rsa-sha256; cv=none; b=S5SQie1j0PED6coQspw7Uf4jp2fnHskJYAHT20w6k7dsLkItXLMX7MTzCgVj4NwIbl5AXs YInuWQZbdBldPeyERKOV/btODapJZYNjYkTB7I+CadjMRBnnnuGZZvvSojnc29iC8KY2Hb JHspyMHfRJLfINDOiFO1HA1l+jQk3UA= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-70e2b601a6bso42295597b3.0 for ; Mon, 02 Jun 2025 09:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748881427; x=1749486227; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Fx/1udL/q8PlGAipoyIKl9RK0k/YkkPXl+dR5dADJ4o=; b=O4UGiPgia6EOEPP3n+rxnjSCRqxjDx4Nle6fJqSz7bw/YcCs3KyxH0419g0Atyop+m L+ZrEJEXPJc6bVKkJZ8p9m6Xe4UqwHnLWtkRY2ID7uE83G5TAAlZJnymF2MMH7alROa0 YKmpsUXoyC7jfGSACDyvj+NK9IIASG8Zzv34/vYq70TV+c/gsc+nvOeYnyJnJmzfovwK usagWr+Anxx2pB3sSEbl9XN+PPttT+VdJuHMzxvFQuP7VxoL4l+8aEx2OMnJRCAJWTyH zhDhml4mXjep9WIfYY+rlGKwAo3G5LPzI5/ZZnLXO06rYST6ht9kA2IXdzSyb3l3M5+M Kuzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748881427; x=1749486227; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fx/1udL/q8PlGAipoyIKl9RK0k/YkkPXl+dR5dADJ4o=; b=CHB9MgxJDEDn9eNptlWkC8KFWEbaN6iejwyPOhyGuwnVJ1cWZaQeTNGSos7EEc1fql Aaj9wkfrH9MYxbMjY66SaNWqE4seG6Cq3Srw7IL7kZBrHQMZvyXIseP1ugW0YNNdkBSN Jikx9W2PdUELmzy3V849dty4YU4IQFviTchM1LfgVJEwgQc/dZrZ43FbiFCCka40RAxw /cfQH7IzsyaHqBcKxhGZmEBfvb6Wz2UWqM2PJ8Zu9zLQfWPuBRbjxSVBkZOKg4ifp9KW IEe7nGHZz3dcfiF5R2fG7u3Aw67q/uds4T7X1y2CBNdSteyOMq+BNsUnm4BznDDf4KDt Ix3Q== X-Forwarded-Encrypted: i=1; AJvYcCVE92004S81Md8gxzDjojMrG1ADFrzQJxmVF/2ON+CNr1+PDgpGjgPxc4+nC/Tt7sy66gWE2pDGnw==@kvack.org X-Gm-Message-State: AOJu0Ywf898RFJhZL8W/DccoX+COzlZ4gFAR7SfSOZr2BHBYRfT78PNo xv7YMsH49WvilWvzHmq6WzFwBtGxO8CriZYFrh+bMNuVhGHs/oUToc2a X-Gm-Gg: ASbGncsl7PM+S5bdRdcGNYiQGd3pZ9CWa1BU/X1QkpjNCCc1OsRgXPGQum7ZEFUGg3+ oxdgirMfTupD9C6WBXrtPbGu30hveah69q+PgtBHEFRzeHLHrAXWmo7crzdnSdnxo4/w9fLMQsW +x6Mp3HCC6mH9ATZepHiYPUkIs5EoflIP+1GPdW7rDJuwyxXEiRLAetxlE0nqWSg/Outq/cmk31 NX4SF2TcRU/beVrVhriO7syjuhzJnLTjDkvXBY4naVUQPmSGg+48KHv+0JlYLaIEdZyTanUZaMB ApLjfW+LTAj1qlKhHiJwcim0oKE2XIIcNrmQs9LfNcZcP11HAJilqBvutyNo X-Google-Smtp-Source: AGHT+IE/ggDxXwpcIAkuwoI4AgFW3YcPyj+8gShcZ/7Xs4A4hhvlYvqwuWUj0zwSIhiAAIa5EVD7mw== X-Received: by 2002:a05:690c:7488:b0:70e:5eda:4810 with SMTP id 00721157ae682-70f97e784dcmr214870587b3.13.1748881427134; Mon, 02 Jun 2025 09:23:47 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:8::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-70f8ad2440fsm21389277b3.123.2025.06.02.09.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 09:23:45 -0700 (PDT) From: Joshua Hahn To: Andrew Morton , Gregory Price Cc: David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, kernel test robot Subject: [PATCH 1/2] mm/mempolicy: Fix incorrect freeing of wi_kobj Date: Mon, 2 Jun 2025 09:23:39 -0700 Message-ID: <20250602162345.2595696-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 83C9C40013 X-Stat-Signature: kghx4f6kznmbezbj59tud9icse4fww8c X-Rspam-User: X-HE-Tag: 1748881428-436999 X-HE-Meta: U2FsdGVkX19LqTIa6NNTzNaaWNy/sUV5yfXwmOq1M2sBfWqOCkUa3VFcMa/wPKUqzZnqhPT36YEGPYkXfZLZe62z1kNtVMxikBT0rZBgafFESM8M61hVDsZynl7G8RPNz/jgwtx4NRo7ZQNUZJ+j2d5ZUoyfF2WvVkJA4xQGzJJsEdjJofITkigLJXvgFG+XSoz0uAKc2+omZ+FgR7aBvME3Y1CiPsYcta1FcJzHq+hvI/cyqutoyOfH3lW1G4rTazJW2qbNUrpGpHki4KMQ5GQP4kHSJO63qX5IDdvnGizhjNLAjmOrJSq/ELsvLmHD/Egyi5E4py9D2/dvk0VykZuUzoS/eabbqCl9Qu/+25xR8RyrGR+A86ceWRHyIXy9QenjQRrvQsOYmwdNtJGVjv0dz0OXZSNSaPNoEiUIRUoyfSk4433nIOMnp09RtbKqCFMrlJCJEDNiIx9PAGVMvoePlPWtUThGxy+PH3M61xdxxAOcLu+AsJRP1ECqHUVDZMyHeYfzBmEl6T9djJjoHWOROaUbDsCh7wsrXl92GxCs3XorZe3mMqHKpfk6HqnbkS7kfSVuQRq6b2F5KmU/EhV96rBMUjMUlA4O9OtbwIW3++M859yed+gYVShwmx+pmGj0WUYQowSlmfpLtz4KQjpMHf1zlgMQTXLsqxQNdyK3vVReOUXMXUIrVIjWaegaEkuFlm6vLDAUdU/Sjl+dp7y8Sl3Ehts+YZcsiTTTL2Ge9KtwVRJcrBJBNkCI7A/zc8Hey7jV+/disNHT/Q2gZ3CkVp6S0GwkCY4YLu85tutZTTiQ/5sX62RQ6nnpQ3hNvtiQitpkZZehRTHLjrFFBOWlwoEVoCErldKNpKnjVr+Eb56O+0sOCqsbTc4KeHZZ+Zw0n8p9yrhFjND58S5L7BBlqv4NzZwEGvvZ34Cj9GT62u+5I5/aHqeVJRNz3l7BupzzM05qYbqtN+b5/EN xTsyfM0c WZfYQfzrbWh9kSudfx/fVuVCBOrGDQz5nOIUmnY+0abugvss1WyBjyV2D9vFW72mqgO0F5DDuidQqE/Pl72FNaorPAUJC1Hzk84mYmqY49Vs4Y4+bPgRX8ieSxShHqPmhCyOsE+G/FLP5aswtYgHapeEVcoZFYOTkw3ymkFQTCBg9TpzdGpn4WT1lGHqg6xwgULEHld9B+OxdyayTud63dQZeqPZGE6v2Doa6WgedhoyYIA+ts2U8eiEJsaWpzvoSzlKJiJYO/DS3xT3DZwAxoqKVsVgYhcL8o4Mj/Ahows08/h5hPr9gga8xKcKQQF1Fl77pMf2mBFynPmDcgSL9jT9N7KJYIKLmd+4PDK491DgO7cuc3lzNw9SeQ8HaMb/GqEeU3cJj92ZKzfJ0RqwbqNnKkHWqR/ZDwe/SOzDSmYK77QRjrgLkDEY/H0i0/LJXbzjwdjaWLz+Mcd8E3Fo8vqCNq2DZ4B8s1ER6caOa1lHqxGlSZ5jVjGTFU2YmG/tNkSATJRfdlcHDqVEtHI106bajEiYa2+K48LiMAzni2wlKMAgv5/EzJoj0og== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We should not free wi_group->wi_kobj here. In the error path of add_weighted_interleave_group() where this snippet is called from, kobj_{del, put} is immediately called right after this section. Thus, it is not only unnecessary but also incorrect to free it here. Signed-off-by: Joshua Hahn Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202506011545.Fduxqxqj-lkp@intel.com/ --- mm/mempolicy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 72fd72e156b1..3b1dfd08338b 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3708,15 +3708,13 @@ static void wi_state_free(void) lockdep_is_held(&wi_state_lock)); if (!old_wi_state) { mutex_unlock(&wi_state_lock); - goto out; + return; } rcu_assign_pointer(wi_state, NULL); mutex_unlock(&wi_state_lock); synchronize_rcu(); kfree(old_wi_state); -out: - kfree(&wi_group->wi_kobj); } static struct kobj_attribute wi_auto_attr = -- 2.47.1