From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9BA6C5AD49 for ; Mon, 2 Jun 2025 14:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B53D6B0083; Mon, 2 Jun 2025 10:24:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 665D76B0171; Mon, 2 Jun 2025 10:24:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A2CB6B0280; Mon, 2 Jun 2025 10:24:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3414B6B0083 for ; Mon, 2 Jun 2025 10:24:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CFEE580995 for ; Mon, 2 Jun 2025 14:24:10 +0000 (UTC) X-FDA: 83510680260.25.1C1AE8D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf19.hostedemail.com (Postfix) with ESMTP id 1B1A21A000E for ; Mon, 2 Jun 2025 14:24:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=pass (policy=none) header.from=lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748874249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bvmk3nvgj/43LFsf0Vsu+jLmucsaq9sRlp6VUYMcnx8=; b=A0PfVGFCZy86FCYdprvGWRaxvhvRtJiB0nWy0RKN3ulNUKt7H/iSLxQ0n9FYdWWO6Tu2iP +kRAc+53J8+4ulc5YjUsWSMYXGNxaKsv09Pv+4/XcqIMeOOxU0rbJf4v/3qD4w5mXcLwIX 0j9Wl5RFVubhRw8Q5De9eSFSYqX0tmo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=pass (policy=none) header.from=lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748874249; a=rsa-sha256; cv=none; b=rlJSZ5a4n7a3yoeXsqOfwTQvzlyy3tqB7Jut3xntMzWguUBNyfnAIdsO0GQeDKI6ueBbuO aUuDh67pPd0iIDOAYiN0/UOLsIMiwyeKMjUC4pKopibVvkiIBDIaYHviB4OoSpviM8gDu6 zLW+xGKHcYmXS2Kn5cxGb1jf8yDZ3eY= Received: by verein.lst.de (Postfix, from userid 2407) id A052D68C7B; Mon, 2 Jun 2025 16:24:05 +0200 (CEST) Date: Mon, 2 Jun 2025 16:24:05 +0200 From: Christoph Hellwig To: Kundan Kumar Cc: jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, hch@lst.de, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, Anuj Gupta Subject: Re: [PATCH 04/13] writeback: affine inode to a writeback ctx within a bdi Message-ID: <20250602142405.GA22563@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250529111504.89912-5-kundan.kumar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529111504.89912-5-kundan.kumar@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1B1A21A000E X-Stat-Signature: fmwzkqtjx4e6r7trjrz5cdtfpquasifx X-Rspam-User: X-HE-Tag: 1748874248-185899 X-HE-Meta: U2FsdGVkX1+oTi78X/uq9Fx0mp+0quAYu1gjUEdXOzBa85yl9mtrSBhRfRzWNrumQOv6t3dgXUClYLxhEaMjvHZnS7tceekHBzOyd3JMWQUwE8QxtCupSJsLPQNe2Nnz4lBtoJZlkMOMNbfFTcgVnDC+sUR53hYYhRWIpWbiwmD3mNCGmnE02d6DtK7KC1Bq2IGOw3EkhgYge8wVTuJbrBIeHTzKQ+LxJrAYIWPVt5yH64zIzyAaopdc9/q8qRszQvd7ZCdosZijRMv6sBELE1uCH9TayzchZE785E+naLX8uVA4Pc7eyXE0HE6AffP2Z3WLdHnjBy92rqM7ijtWs2hnZHxnWwDV1q5CavYTuFrhT983G6/RNUtwiOfgwK+hdf/hpsIQYDMpIpgosdDCi3uQGFajA5VqWyWrF1nEL0HWHQ8Rv5flAKQVNwaekVhqeey2TsM5x3ws+QcInf/5kvS/DIwC7s5E1N7MBWpM6hwrRjqYw3Csi6HQmKlIRVUoxBo2L5w31D9tVpseotchjHe+MtGyNc6UC4NO7lLBwHlLeFgyfj9rT5z+3PhEO55O8ivvmmdh6AAYKuO+KZi8OJUEVyGrrikH3F4BvDoN132NJOGRea9IdM9+YUTvL0rhm3Eit4cYJgZwN5cljmR42jTuSYyDcXTdbSUPuE7lv0zpepG89RTNy0/9gfuVy9tPODvxtYP1mOxiyErCvokrOAHq2xSAM9gBdhkWVl6JiJkEpALObrhRFEqBroczWb3LH2M1pp6D0YAVRzWYakA63Dv1oUXUxkqcwfhSm5SGGhnjU606A3s0a+fML/b7tkWm4Ji4f3rxIdxBvzEOw7O7dGWzo0kMcLmdrgUsdiM6NxAsU9+rgcv2CrGA7Byg2L1+9f6isgO28JQlgOkE5dybrU4TQK6816h+KNE1dIDL2bMFQ6si3cf8ywPezf9g+glV/1Fq9vf+/Tc10DiEe8d VLH8jTCQ aQT00Ke0OsUiiaF0W/x0S631DbTR/LAygJSzZJZVG8s96vjQsqNT0W0lwHPsfimOHyetT9pjeCRBJ3OMCwS+MeE/Ikdyri/QvYUdoEAJYEXbhw1o2O0aQinpD9+KBurtSLIpqzym5f36EYbsGn6Si5PxiG0yohA33EeSMTZH5+XRM0cI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 04:44:55PM +0530, Kundan Kumar wrote: > @@ -157,7 +157,7 @@ fetch_bdi_writeback_ctx(struct inode *inode) > { > struct backing_dev_info *bdi = inode_to_bdi(inode); > > - return bdi->wb_ctx_arr[0]; > + return bdi->wb_ctx_arr[inode->i_ino % bdi->nr_wb_ctx]; Most modern file systems use 64-bit inode numbers, while i_ino sadly still is only an ino_t that can be 32-bits wide. So we'll either need an ugly fs hook here, or maybe convince Linus that it finally is time for a 64-bit i_ino (which would also clean up a lot of mess in the file systems and this constant source of confusion).