From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACB2C54FB3 for ; Mon, 2 Jun 2025 14:22:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CF396B02B6; Mon, 2 Jun 2025 10:22:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 180C06B02B7; Mon, 2 Jun 2025 10:22:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 096246B02B8; Mon, 2 Jun 2025 10:22:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DFE7F6B02B6 for ; Mon, 2 Jun 2025 10:22:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C2171A0930 for ; Mon, 2 Jun 2025 14:22:02 +0000 (UTC) X-FDA: 83510674884.15.427EFD3 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP id E63B1180003 for ; Mon, 2 Jun 2025 14:22:00 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf24.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748874121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uto16itjkDMpk4PmjcYSRtJ3jKBOXUUHzJUvEAv10r4=; b=BDxl4kAPp1VUX1bFQrq+wA6YMyfrpJ+n+gDHM45DJNXms/wfsiQZmALBwYM5rE0ePzZRPu UTGzRupJH3vxW8ngfHiHkscd9z2SdTvB8iADo1GAv7FoBQB1y3K935136Dw2lUfOSWVf8i qyTei2VFS6vOsqQT2f36xztciJ2ikUw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf24.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748874121; a=rsa-sha256; cv=none; b=0kPoqpjXC/AkTS5XKIg2OMkvawqqHaYiXC1+Sdpxp7gr8lNFF24dtMRIRrznakQ9zn5mjG 3CUEvLZaln5Di9gtSCPbLTOteFUYZBwzx7kEqc44yxvmRhdUB45pkEA4StOOqfzlX5QL29 v7CTzafO2qc8kxcmqB7G47mNVJRJJHg= Received: by verein.lst.de (Postfix, from userid 2407) id 448D468C7B; Mon, 2 Jun 2025 16:21:57 +0200 (CEST) Date: Mon, 2 Jun 2025 16:21:57 +0200 From: Christoph Hellwig To: Kundan Kumar Cc: jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, hch@lst.de, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, Anuj Gupta Subject: Re: [PATCH 10/13] fuse: add support for multiple writeback contexts in fuse Message-ID: <20250602142157.GC21996@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250529111504.89912-11-kundan.kumar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529111504.89912-11-kundan.kumar@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: 5ryh43ergu9wro3pka89e8choi69ibup X-Rspamd-Queue-Id: E63B1180003 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748874120-661341 X-HE-Meta: U2FsdGVkX184mArzxoak2RAPRs86B40xaBOtRydDqmXw6ulNmJOle//iId/QxPf3ZyGAIotrY2M+5RWhnGnFIQD/of5fJ3kGcm1JkFAXI/JzdU2G4wryvjrLGmPZwF5b3PEfdvBKWeYHdWJ00dQvalN9rajPrh8K8AN3qaNa2lvq65RoAtTL3ksIOBu5/ktsMhp1ycGDRJ1EXGEjEei1NXCdIcPNR4Fqj46oi7R3jGbT0UkVfMtDrQzX8MuUYgZwYhxhwAMkCPNU16YKxGisBlVDEBeGTtC5UZqn7rKGqNHslZyYHTQDW9UwWw+0ZSxEaOuPXDTON7iJjqIZR96WnLaMgJJ57EOpLUKytXRkB4MvB0VpJb9Z6BfTV8mbIxBQivsOyIxejIc6sFccsRlvmuwpvecktuUZoCrxEo2u04NOFl9NwHO3teBpBEkTihjtWDqSsAnjAdEORxQDhgkTLQ7RgQlpRQdqrAcGJaHu4tu7fb3DRCIxGmFsspVSnHWP8xofcoEyowr6tpKi3w5iBjOQy1eYRDnu0595KVHWUQyo8xn8i9IlUoiqgGJI5emnzPgblVPBUpVXxt6gxpklO5JxaZIlJCbc4N5+5yQLJyjOpgaxmMhrwL+QeOSf3xBGUweWDXUbZM3vZn0s0vXgN90P0wZrZ5MibiP+ndei/tI59l2pCtFsZ53QvHGIGjCsv6MXgU5H+vDEecXcIMFCvSok088nW6sBWnT+rPdEQQXGpeiU1aGaobgt/XADnKRyQ5OxUfXrk0Ybu259HkhIEYfAAaW4/sIcj8DlgsSk4auLp3PtGufY793lQW1cpFo7kdXF0twPVepZjeEECQrwIsccpDkzXO2umCmIIbz0fYkZGJThhczicN8wszF3dBxGHDOV2Wm5pytV3h9HrZbUcjkzZABx9IZObDtTVp0MquAY97/vKxy42EuShYi0nyLUG2/K5Ym+iRn9Ubg/WOf 1Rhj/jJB LIb43ZBVjDmD9nQ4K7+1U/8b+KzgQm4LsFcJbKomoxkRNl0xNIQXs4vKqDBVcjCaezyVxJ2pueLxMybvGlwgPbxiNov4zuQCcRPxWWzUYGvzyHf1+xbiCKdcsLNapkbtxUDGwugSkzq7JeBbjP/TA+NTkNYeLQjEInC3uLkHL8Xa2eAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > static void fuse_writepage_finish_stat(struct inode *inode, struct folio *folio) > { > - struct backing_dev_info *bdi = inode_to_bdi(inode); > + struct bdi_writeback_ctx *bdi_wb_ctx = fetch_bdi_writeback_ctx(inode); > > - dec_wb_stat(&bdi->wb_ctx_arr[0]->wb, WB_WRITEBACK); > + dec_wb_stat(&bdi_wb_ctx->wb, WB_WRITEBACK); > node_stat_sub_folio(folio, NR_WRITEBACK_TEMP); > - wb_writeout_inc(&bdi->wb_ctx_arr[0]->wb); > + wb_writeout_inc(&bdi_wb_ctx->wb); > } There's nothing fuse-specific here except that nothing but fuse uses NR_WRITEBACK_TEMP. Can we try to move this into the core first so that the patches don't have to touch file system code? > - inc_wb_stat(&inode_to_bdi(inode)->wb_ctx_arr[0]->wb, WB_WRITEBACK); > + inc_wb_stat(&bdi_wb_ctx->wb, WB_WRITEBACK); > node_stat_add_folio(tmp_folio, NR_WRITEBACK_TEMP); Same here. On pattern is that fuse and nfs both touch the node stat and the web stat, and having a common helper doing both would probably also be very helpful.