From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62850C5AD49 for ; Mon, 2 Jun 2025 14:20:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 045476B0261; Mon, 2 Jun 2025 10:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01D1D6B0281; Mon, 2 Jun 2025 10:20:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9D0F6B02A7; Mon, 2 Jun 2025 10:20:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB5936B0261 for ; Mon, 2 Jun 2025 10:20:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 818C9140951 for ; Mon, 2 Jun 2025 14:20:26 +0000 (UTC) X-FDA: 83510670852.27.9489D97 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id CC34A1C0010 for ; Mon, 2 Jun 2025 14:20:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf21.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748874025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xJOjThPpfHirzKie02ezE2oEzwyAswWABcYWhG/QSO4=; b=q7L9rDGVLo2LL91t3xU6oKbb/JdxVUUIv5Stj7ustWJUKLJ9pj6luycZk1+uoBwMMIZHuk eDXZW8uW7WErNjXHHQVEAyzbWOTPRBatp/2bBz39nm0Hws77SbDUufSO8QOGI9CiBFKk2v sPk/b8A9danRFYWmK8batuCoG3k9Sx8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf21.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748874025; a=rsa-sha256; cv=none; b=YXjNWfYO3uL4mmWdb3BntMhS+pRM/Sb49fBf6MPi9QxP7OaZYt2XYUBsA7/8bFILcMt2Fy 5U0vAPYWxAnQ3llEVluCAHIhuJXhgrSyQCh2yzrj13e38As/pHuZBOZB5GRIPFpn7kBu1R hJHEOubiNdG+tbwbQvmLdQ6wVSU88EI= Received: by verein.lst.de (Postfix, from userid 2407) id E5B2B68C7B; Mon, 2 Jun 2025 16:20:19 +0200 (CEST) Date: Mon, 2 Jun 2025 16:20:19 +0200 From: Christoph Hellwig To: Kundan Kumar Cc: jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, hch@lst.de, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, Anuj Gupta Subject: Re: [PATCH 09/13] f2fs: add support in f2fs to handle multiple writeback contexts Message-ID: <20250602142019.GB21996@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250529111504.89912-10-kundan.kumar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529111504.89912-10-kundan.kumar@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: CC34A1C0010 X-Stat-Signature: 73u45ms8osqwg4u1m9erjd189de79kko X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748874024-434768 X-HE-Meta: U2FsdGVkX18WteGmtY4rfk5F/KCj08Zim5P5fTzNFCa+RstIl4mgWXAIO17q6bM2SOr+w189uId7Wwh+SOV+uYyJ7l9DtttjGfUWynLM5Yjlb6q99roFcqYxcHxVY9QIr4xwSCJ0Qo4OoLalYUbD8+PrUYrj9EvjuOvD10Gd1+dtxPqXEVwir2JQmkAHniIM+OvTh7E22bYDWLWM0TmCAbmXby+zDuNjuuIvjDU5AcTsWhdE4UBOsRScHa2EPmDk59fbotpTm1TsfG1jzljfAnsIH/aJ/bVarnVInTtvjMsjL9QKcJhmwSlJrnOk3L+fRhxiKdeMeBfGAs9rKBwVrGu0HGRj0AgoZ0alC5SsonxIOpCNkfVTqJJQn/ElI/iXKfgmx7AkMy6VLQm/gXYFtNQSWzCTmxexEOxmdzfUUQgWVaiNm1FE+HrXKLYHFJ78dNiNnlLlGCT+sUnuYQY95tO8xCthn1nf1fywJcnaNlWob8nBqOG2glj940HfsEqTJpql+lwPAX0v4Xpdg9hSMs1e+pnWAtRtBbvVRLEbz+StAYwSb2xYG5rHP8ir5kPPL2X9HfFBP/3JWy8Ah7w/fEOMtx45xohwNQHHlyoom+0oho5hx++lEiCG5b5p9ExUO5pDzRSvIxXSqEzGbaTKOvTsTqBVRCN1WTeQip2nMukHAmvww5dncEoM1I/DmHrP1fzYRf5lhgj6seaAEMKxueiKzvoS7HMcodIs1kgSVAN9qcIQXt6jkPDDgysun/h1sFtydfBsfpUjgKnNGRZ9GMFXBymzwlRihYrXgB95Cctn2/wgZ44hzyVFK9wg9qSn3vY0xwEQs7SBxUDSXSUKn2HG/gTQwSk6KYlHewcgPLwojtLz5jgnLsztfGbaJxB0kM71xoAwRRLD6RsdJmWVoHfFRhfrE6qU6QoTCMmTcOb1QnQb7+K/UDfMrRMeKw+oPcN/dKQClrp3mKX0PMo dUlMFy0J FkH7B5SlIUX/JxWT0HVn1zU27Z753JAKEpW849CjmD7GGXX3EpuSfKJF3ZsMA+KdhqgfOpSRsTna2RTM/isgrjzL4hE5zHKphPkhVZuDHt+yu8HUQIj4+9YItYcyQOhWnD4qIcxZZwclWGyFdpXo7Ev2Mgm71B1FNacfj5vDmov4BQcM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > } else if (type == DIRTY_DENTS) { > - if (sbi->sb->s_bdi->wb_ctx_arr[0]->wb.dirty_exceeded) > - return false; > + for_each_bdi_wb_ctx(sbi->sb->s_bdi, bdi_wb_ctx) > + if (bdi_wb_ctx->wb.dirty_exceeded) > + return false; I think we need to figure out what the dirty_exceeded here and in the other places in f2fs and gfs2 is trying to do and factor that into well-documented core helpers instead of adding these loops in places that should not really poke into writeback internals.