From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B4FC54FB3 for ; Mon, 2 Jun 2025 05:05:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8F9E6B0259; Mon, 2 Jun 2025 01:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C404F6B025A; Mon, 2 Jun 2025 01:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2F0F6B025B; Mon, 2 Jun 2025 01:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 940956B0259 for ; Mon, 2 Jun 2025 01:05:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3D79E1A02ED for ; Mon, 2 Jun 2025 05:05:22 +0000 (UTC) X-FDA: 83509272084.06.A4FBFB8 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id 7B1CFC0009 for ; Mon, 2 Jun 2025 05:05:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf10.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748840720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fhdpPxWUNpQPF8RWGYJ0JnSI+SiFFNLqE3b9Sv5l9XQ=; b=yqSqkGIAs7S+s47sLUYC2Ao7ghuUZ1L6JTN9g8ahuzYWMfmworiy8VKBrp3LZ4dGckzk7y OjLzDrRXWdG2UjCrQvIWsFai4XHcae0pmXnpWXFSNUzGUwO7lQ/OD/v07bX7jeE6tvkrJv wHFtQUzfCd6QoTQfZbGS8MczplGG/JQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748840720; a=rsa-sha256; cv=none; b=hY9z+Oi8+95ympdTSdRJtGOEl5go6E9iKRgrJd1Zh6cf3Wk0WBRH1ul4dEM/G/RRdHl5lk ml3gG+RSxfPdj8f2C7gODviqDduTGRo0WHrI4CRgJfVwWvswQ7kb7LaMKFa2ueIXnnZ7X9 igWNUG2yRxytZwBTjeHqGIjWKuGXBrg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf10.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 1C15F68CFE; Mon, 2 Jun 2025 07:05:14 +0200 (CEST) Date: Mon, 2 Jun 2025 07:05:14 +0200 From: Christoph Hellwig To: Pankaj Raghav Cc: Suren Baghdasaryan , Ryan Roberts , Vlastimil Babka , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, willy@infradead.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, kernel@pankajraghav.com, hch@lst.de Subject: Re: [RFC 3/3] block: use mm_huge_zero_folio in __blkdev_issue_zero_pages() Message-ID: <20250602050514.GD21716@lst.de> References: <20250527050452.817674-1-p.raghav@samsung.com> <20250527050452.817674-4-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250527050452.817674-4-p.raghav@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7B1CFC0009 X-Stat-Signature: mg15emgg5gfz75ffetceqtyndozb13we X-Rspam-User: X-HE-Tag: 1748840720-768976 X-HE-Meta: U2FsdGVkX1/lZfxwm3k+pZyhkyf3E1CIeQEGVWrQRHri1DlRjibOSmrTIGqzirWDgpOsXTdBR90NAlbmqNa6Kwhy2FRz3N1MRWvgjJGoCXvTvuhuIslE7Jsd5MMWGfaKt07SRKAFk83EEjKm4q9bIK2uOM9M07fKeuXhEnLYa3qUgbY0lwV6qo0j1uPm7wumrTN8VAlLNMJEsD+upVXQI6wggjsRtaaMu7tCabb+FZdqj7s4VzqFlZ0oFyq00HnPqXtcy0i/ANjJUOB1LNQBpwvs9rVwAASBnfsaaU8xGAFDYAXDfg7Y0Sz4K8PnKDw1Tkw7XTO3Tvj5+5CKwx30LJzSzr+2F29HaCVp4DYPyQBFSRNpGWesNLyLi2U0SviAGmgzI4eOPaSa/Tdd1155eZHmrlKBMlHNUZjRxQYU1Ho4+8zypO1BuG6jDf4NroH9eEGb2cS9ttK7+ZQsrxrMKHULnQ2oh7VMPXykWr69vdmLWZTLo0e2RvLqkEdnWczBP4JS5CkFFnvtYv3Z1nOdS6ohpzrvAOX6Ldly/g74YNzlVLIWCEVk8eOdBEgIN15C/GR9RWe0hL87VESs+1SOFEb0z5bi7kWI5Dztpa1Xh4n0DEQzLuaqKGHkDzYO0t+XeRdNIuto1i6ewcceBaAfy1XfbS+ORE8je49NRTllLZG/VFPYGkYQ72NuGzludvhN3EXcUsAeGNNabrL7VjKG2JafKOvZNS9SFi0ClHK4cNPuqOezwA84cMSeYYkEJIw4+ICDSjHEeKzVTrKt68eRqcBid/eYuo8uIxShUJ8t/IxQ1XZiO2zhz63NNyXo8fMBLQyLlIa1UbK8TbTxSjma0YjfL/n9BovmY2FkCDYNQpS08o08y5xq1aRXJ0dxYvxJcKdfaIfc/mx20a/iKn46eTfyC6iKJylmXgdxfjDwZbrbN6f9RmDxLnwLnArfEiR36KefQYIdlOj1chxfKuQ ozjbqyls YyjkQHxeXDB4DTrLJREOjGQjkB7urnYzPOk9DmleuRPNDgmEZIMRUH6DAPb5QLraCKXVfOwToXz/X+MYPLLqnEFdh/5guXUGV6qvM3htKGFyZfVgcC1LrqODFmDa7E6ZIs92cASlEOgGxmac= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 27, 2025 at 07:04:52AM +0200, Pankaj Raghav wrote: > Noticed a 4% increase in performance on a commercial NVMe SSD which does > not support OP_WRITE_ZEROES. The device's MDTS was 128K. The performance > gains might be bigger if the device supports bigger MDTS. Impressive gain on the one hand - on the other hand what is the macro workload that does a lot of zeroing on an SSD, because avoiding that should yield even better result while reducing wear.. > + unsigned int len, added = 0; > > + len = min_t(sector_t, folio_size(zero_folio), > + nr_sects << SECTOR_SHIFT); > + if (bio_add_folio(bio, zero_folio, len, 0)) > + added = len; > if (added < len) > break; > nr_sects -= added >> SECTOR_SHIFT; Unless I'm missing something the added variable can go away now, and the code using it can simply use len.