From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E04F6C5AE59 for ; Sat, 31 May 2025 16:49:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 096026B0193; Sat, 31 May 2025 12:49:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020056B0196; Sat, 31 May 2025 12:49:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E519A6B0197; Sat, 31 May 2025 12:49:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA5BC6B0193 for ; Sat, 31 May 2025 12:49:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5438080C83 for ; Sat, 31 May 2025 16:49:04 +0000 (UTC) X-FDA: 83503787808.12.B7CD0C9 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id A173F8000C for ; Sat, 31 May 2025 16:49:02 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nv+xXj5J; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748710142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zwmzoPcfvNdKmVKaIXnvEW2YNQN/xTbR57LM/ieYMnM=; b=XF9mIPYcreYWiQSxTTVw2ZOqdGUm9+djPgfzls0XlM92k7szwZe5ZswgjavJOH0idotO9I RCyh5+wxt6HCM3pxVaAlaFmR4ef82JH4hjtqGqIliImK0IagGvBqg17RQDxnBQsyTSKVHZ ORdTGkrSGN9Z7Ye8W/IzyEaMbokpK54= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748710142; a=rsa-sha256; cv=none; b=Fy+l5xNracFExbAXnibPe5fDnJ+Z8vDikq35BrHBef9wQSPfQ4fq7EQmgjDdtplT1xhmR6 zuCTKOIuk3LwPgQfGVUBKdXbtnTn0dt2xWR3BVzpu3+TOFG4fzfISdF67kKPCwUWyylmxH NEJV/6cfsKyOA2hFjT0ShQQPG+nTV8Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nv+xXj5J; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 588944A033; Sat, 31 May 2025 16:49:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A65C4CEE3; Sat, 31 May 2025 16:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748710141; bh=EImyog8mJ2d1KSn2d/5M4MrBuuXlY9j+Aeou6GlnT00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nv+xXj5J8KG2TlcMwQGBuGyhk9nm/OSHlZ9z2opOK3e8fosTVpW3qO9UaZSELc0rO +RDF3xkAVIV1rDOA6yHwtCgtG2IA0bj2qtClKebAktbej1aEaE3M7LxrCItZ4y1Hso BScG7pvqMmMcsuzY+ELc9TSbSzrk41lo9NlAzzMvD+KRbFhr52vEKtTHPmzAEgcglD knnPYj5lvhf2P0kWrpLjWUiXSmnuCBoSQH+HGCCZsCVLO2B3/8Wx99h1W4c+KUGZKF xdidb/ALcs6tD5AXWfOZy0NS7w/7CY97p8ZwUPBvXc4yGHx92pA630emoXCeqSAZKm VcwS8T0QIf5yQ== From: SeongJae Park To: Enze Li Cc: SeongJae Park , shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, enze.li@gmx.com, Andrew Morton Subject: Re: [PATCH] selftests/damon/_damon_sysfs: skip testcases if CONFIG_DAMON_SYSFS is disabled Date: Sat, 31 May 2025 09:48:58 -0700 Message-Id: <20250531164858.37308-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250531093937.1555159-1-lienze@kylinos.cn> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A173F8000C X-Stat-Signature: 57zcdh8s9ww8s3wacs1sboxiqmwwp374 X-Rspam-User: X-HE-Tag: 1748710142-424229 X-HE-Meta: U2FsdGVkX19Jv08mV8alJbt+w+lCnPvzl5NxlCHAWRy0wDLotLCneHiZEOLy354Z/TzpZ+jFXKSA1W7BPQCbm0mKd4hNc0Gu1ZRq/PiRcZ6PYfbZGldlv62gKj/vBDmOxE66tZu0iBjNTztAgbwuPb8gs8JwXKsGG+5kfL0go/yzBOYa0GwT7Ez18uy24jBY4mb49pPyusPamGiq0OPYliAvEDjxxZO8BLighJXaBH8CJUcRUShm+3lf88ONjTotB9TpM492gPFLdUXkX7ULqMSW5jhLBtwN9Qdju31yEXDDUitSAPZK+Z5wpmrfPDWFEbawhzx6bOSJk0zWaawArB/ueIqnERo5fb2A80Ll15XMtK2ez2gcUSWdCN73BgFyMVekVQcsSskQW8ZuCnEJOHUyLZD7Ym0dGpvGYb4DOEALjrWHLnRV8tU3ORV2GYB0sUXtM71qy3ObYu6IKzvINBOAyR4rKG8Z0cNxDEZcag0WZ/fq1zuNSQQezu0b5S481B+Mfal1GQ02hjQC2U7Ynx5Uo4AYkhRulfeF6jPgW1QgXS2fHyKZWzfOjzJ1Ky+t4s4AJccW53u60j5z3SZDfk7+zX+o1J8YIWlbLfKKymfZl49YHt1cIwbJwk3E+v5CXdYlzpf2sm/wh9ZB/4ik24Few1FttWLPQdwJUxrqAY8lCNrfgCjxtL/75BUYume/hcSJn2cpBN3yDQszcckvnal1nkNhstkAwsfMQZAtdZTfhvHlKKmz3TgWBZIY0Ik1SQqhDyykHpfKdXH6hYWF5MCcKCqq3WEjQgk4mXVwvxXKb8K/zXCyl9ZeKoZt2/LybONfIzzJwdJ7wQJUeh2waMkusCep7rAlXg/pG7+lNRjqOnCVWGdmGXsmJCb0m65h6BEqkJjeAqLtqC/+ED3MihXR3O6Ao/fWwRhe9C0nc0vEdnK+N0+eYOQx46cr/iVwifn4bYdqe7HvHglH+2y poTTtPHS ROF86W65MfHXy5tYdWu4xGkAYOTRPM06ejb2IMiltXmlpu3GjlcXVcMHXqR23T3Hodg/nEFbsweDF86fZdOLumDG8y5EbpV3i+JMSvLR6csAYyd/QYcNQmz3XuDb8xig/kknvwlUaMck7BzW/tAFOAEQS5OBltwDr7SDJeDTXr1hO2RbkBm4b8ARmo9/xRKFMJeFJXRtcilshiy0yPgsdeiWQKlE7aJzd/T5FxtIBL6aoC6UBH+24b+8BuB178Sp3tUrepoDDxLY7koryd0snaIrEKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 31 May 2025 17:39:37 +0800 Enze Li wrote: > When CONFIG_DAMON_SYSFS is disabled, the selftests fail with the > following outputs, > > not ok 2 selftests: damon: sysfs_update_schemes_tried_regions_wss_estimation.py # exit=1 > not ok 3 selftests: damon: damos_quota.py # exit=1 > not ok 4 selftests: damon: damos_quota_goal.py # exit=1 > not ok 5 selftests: damon: damos_apply_interval.py # exit=1 > not ok 6 selftests: damon: damos_tried_regions.py # exit=1 > not ok 7 selftests: damon: damon_nr_regions.py # exit=1 > not ok 11 selftests: damon: sysfs_update_schemes_tried_regions_hang.py # exit=1 > > The root cause of this issue is that all the testcases above do not > check the sysfs interface of DAMON whether it exists or not. With this > patch applied, all the testcases above now pass successfully. Thank you for finding and fixing this! > > Signed-off-by: Enze Li Reviewed-by: SeongJae Park > --- > tools/testing/selftests/damon/_damon_sysfs.py | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py > index 6e136dc3df19..cab67addfb00 100644 > --- a/tools/testing/selftests/damon/_damon_sysfs.py > +++ b/tools/testing/selftests/damon/_damon_sysfs.py > @@ -15,6 +15,10 @@ if sysfs_root is None: > print('Seems sysfs not mounted?') > exit(ksft_skip) > > +if not os.path.exists(sysfs_root): > + print('Seems DAMON disabled?') > + exit(ksft_skip) > + > def write_file(path, string): > "Returns error string if failed, or None otherwise" > string = '%s' % string > > base-commit: 0f70f5b08a47a3bc1a252e5f451a137cde7c98ce > -- > 2.43.0 Thanks, SJ