From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041E7C5AD49 for ; Fri, 30 May 2025 23:00:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8256A6B0156; Fri, 30 May 2025 19:00:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FD4D6B0157; Fri, 30 May 2025 19:00:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73A576B0179; Fri, 30 May 2025 19:00:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 425076B0156 for ; Fri, 30 May 2025 19:00:39 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D6B6A1CEDF0 for ; Fri, 30 May 2025 23:00:38 +0000 (UTC) X-FDA: 83501095356.01.22B120E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id 1FE2940011 for ; Fri, 30 May 2025 23:00:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="gsD/5gpP"; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748646037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4no4hlCWyogk/d5faSZuN7o3Es4xzSNfLh+KWOhwQTg=; b=g3LEe6/y2yKMcMICe98Sy54F2btD+gS4YLkyn8phBEE4s3MYfdQU4e0/zUMpOPX6w3HIwf sqndFSi3+BJSsnB/iuH6UNHTbO5duwiro31mosP3fi4J3jrdNycxHBX0X+2sjjKI64dqo2 9xJjfzHyqCykEDTp9UyWmVJJMtcc0UY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="gsD/5gpP"; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748646037; a=rsa-sha256; cv=none; b=m3SeBClqu599ATpdNJmtvmGI66bRKTvWpwvMVYRsovtwKiyuGlLkgmmA96oU/+pSZX7b8t By2PoITrMGU43EX60aj94tWI+OSO3S5isRXQ0ZC5/U2C7Wx9+N2hAKZe2PBCADDDg+FdFw ia+f2JyUhoW/DPuG+zUfRPCnqaaNjiw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C5CD04444C; Fri, 30 May 2025 23:00:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19CE8C4CEEF; Fri, 30 May 2025 23:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748646035; bh=ABuVgwbuFCM6uuCeVrqEI3bOQFqSk/ajBEIr7MnpHKw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gsD/5gpPPJA7kNbAGwVznyjd5QCqyBQmeIODvPYxNx/51ADx8GZ5xPFYfOfua4CWP x7RzCADGmbh9lU3oXeO8m9OckSXLv2icFbgOWViJ9zRv+D6b/fRAabmv0uMItYPrPj McW0M2l+SXzAHspHnZiqrXfHagDiLtHjPKzXIfi8= Date: Fri, 30 May 2025 16:00:34 -0700 From: Andrew Morton To: Michal Hocko Cc: Baolin Wang , david@redhat.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, donettom@linux.ibm.com, aboorvad@linux.ibm.com, sj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix the inaccurate memory statistics issue for users Message-Id: <20250530160034.94c8aee421266afe6a0b8f9a@linux-foundation.org> In-Reply-To: References: <4f0fd51eb4f48c1a34226456b7a8b4ebff11bf72.1748051851.git.baolin.wang@linux.alibaba.com> <20250529205313.a1285b431bbec2c54d80266d@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1FE2940011 X-Stat-Signature: d7rizjr3ubeqcotj3p1ky1hhisqijt3c X-Rspam-User: X-HE-Tag: 1748646036-438362 X-HE-Meta: U2FsdGVkX19pVM3iYxNqSGOqufd9IWT+rdeMGkTFwe04L4T2Zig8TbOt9KGFI8PZYSBdHX/YpW7Il6GvOe4ciI3wLEagHdUDMcgevstQMYSJG9RYab3nukaMZn/NQvhaNolW5abV7jSYmpFHiB5mBl+hmLsA1fhkC9QnOtpHFuCV1KX+TSjJpZMKnQdLKv+IfSGXWqJwwxtF9zMyGwn5G0qkmE0g+RqsApozLKwYrhnaOwfyhzHa6nn1k5e7a5ISSQWvCTScF8OmgQ99SelTxO84VOUbmJXy208pRl5EFk+RqlCfCsPvYM2zwUeenSJuCdo5G9BCIeSPFn/OmJ7MDgJCwACPxQ0ejYgyfBIW8mJT484x5LHEq7Qn6d3lyMl+RPbeolVbnT/cmJ7YbE/LlUBCiQ5d8i4xJuA/hmMi3ORvcpjS4hd+LtRWEWMYHLZQviC/gZhhaP3IVNNNN4xRxEinSWyQKR2okGCm3m8Dt9Jt6ljxy2QyWpJXIFO0YnoVaAGa8BjyJrbX8P9j9/+Sz2gjddx8ThgAqF57JyOVp57dW+zZdkQCWc7xlzGh0bjAyon6qhOq2xyt/Wu7EOIzfze3ieWNwxl/zc+gFJDwNLoBVPpyDCeKzVRKFvOe/TB2e8VqKGqTGPSwBrv18X1zaJULg6tSJ2Z2LT30Ki2cNXUDelG7VtxSJNjXgWb5+jRSudlzfUwhy5aMlyqSGHiu30oTuP3HrpOYyniFDH0ITD9wItYPt5iOv9AMoy4s76Ikpd8qj2vHR76OmFAjBjBHUItFCojXSU6QHV70iGo1TMDrdP/vbEI4rVEdN7cDfGZhLiJ1gavbKDLhPI78jSwrILZZcADYjV21cR1WFRNpmXIGMD7oljQS1NV+fggN8lZ4zhQas/DKgBj+JOvZEnsTJDhqwBpVsICa/th2c1aFL+6NBNV++2ZAGatRqjOyvuKUvMqcOoJ2oaiATGx4YOI he7JfG5a ZNcuyqIOi8axszposoUn3QZ3DOqmOdudYPq13GNEdbpNznXp5aMHZwPqzMVqydaQALIazzyb6QmzQ9555tdSjO9Tipto85WGFsaU/IARok7ndATdMj5EMYNg6nrPFDlXCAZpfBh2cvLEtTihWdcEMMnwbULuV+Y/YvfUq4Q5Z+4ab+XymVssaEoKPacw/tdeBrz4vkEcU79OzRSsQU+Av03yKvtBg/7Pc+3ycpkiUYpYrZhZ6bL9OpQUHt3bPX8zRrJoIrNRbkg9YkC13aMrM0ST4DWzs7vWxIvGZbU39MpSK7BiwO0EKpPgL9ZVG/ps7H4IhquCkrwAU7ask164WK7I76QUNxrCDgrGFi0Fxd4BbiT2e9R7Qwcors1VXDxIFyy3I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 30 May 2025 15:39:36 +0200 Michal Hocko wrote: > > > Fixes: f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter") > > > > Three years ago. > > > > > Tested-by Donet Tom > > > Reviewed-by: Aboorva Devarajan > > > Tested-by: Aboorva Devarajan > > > Acked-by: Shakeel Butt > > > Acked-by: SeongJae Park > > > Signed-off-by: Baolin Wang > > > > Thanks, I added cc:stable to this. > > I have only noticed this new posting now. I do not think this is a > stable material. I am also not convinced that the impact of the pcp lock > exposure to the userspace has been properly analyzed and documented in > the changelog. I am not nacking the patch (yet) but I would like to see > a serious analyses that this has been properly thought through. Thanks. I'll move this into the mm-new branch while we work through these things.