From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8096FC54F30 for ; Fri, 30 May 2025 03:47:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED43C6B0085; Thu, 29 May 2025 23:47:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85536B0088; Thu, 29 May 2025 23:47:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9A9B6B0089; Thu, 29 May 2025 23:47:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C07FC6B0085 for ; Thu, 29 May 2025 23:47:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 311C416206B for ; Fri, 30 May 2025 03:47:58 +0000 (UTC) X-FDA: 83498190636.18.174025D Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id 8ACAD120009 for ; Fri, 30 May 2025 03:47:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ipOCa0lu; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748576876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qpTQOxXTd03k2tfRdJAq7B39qp+ExnDldCqsD7rR5m8=; b=Ldy94MOShzhi1zJbKsI0mp/hSDfhaNY+/mW3MnWL6G/bMSJwvVFbckxXnMmLjLrG3M611b Zl6CT+yTOnR93ojJWOZ80aakQVM2E8BbzXKrleVjpWJ6p0uMfrFwu0sl2WdgbkkjzEIsqt FTJLavBu6u3Qobmx4+rzqvtQwOVV1zE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ipOCa0lu; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748576876; a=rsa-sha256; cv=none; b=aNkj8vBRW+gEUxwqbLrn5y04aQcOjOwuUuQN/FPzOyZqPRjBF8sMuPjlZ1gIJ5bcXFPpPf 6Z5rCVXis8J293eK55zUdatRTaQ5MFc1fVQRikOu74TbbcH84rAMcNm+fOB498FVGB+y0n jVzo5SVQL71EIrC3VAElzG7Y+XGaMbM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id BFBCF60010; Fri, 30 May 2025 03:47:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 074CBC4CEF0; Fri, 30 May 2025 03:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748576875; bh=Hb97F5GkYpcc48N6f3tWzBC3BkuaZ0i7TfPlpBexI/g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ipOCa0luwWgZ5Jq3z4iLedmlMD4HEMnw9X/sWU8k81ZBz9iizBTsblXMuUBy+19aX LcQgSctHDRRNjrpNxZBVmW3UEKN8CsLXmB1MsOEbNiThlNsIK9PEue/rj4oT4h9ypC A0SeNcpnLTDoSOuXCg3ECYX6AXy0Y4fuAXlGNV3s= Date: Thu, 29 May 2025 20:47:54 -0700 From: Andrew Morton To: Pu Lehui Cc: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, pulehui@huawei.com Subject: Re: [PATCH v1 2/4] mm: Expose abnormal new_pte during move_ptes Message-Id: <20250529204754.f3cd5d72cd68755e6753d378@linux-foundation.org> In-Reply-To: <263929f5-bde6-48fb-a162-298a9f83bf5b@huaweicloud.com> References: <20250529155650.4017699-1-pulehui@huaweicloud.com> <20250529155650.4017699-3-pulehui@huaweicloud.com> <20250529121944.3612511aa540b9711657e05a@linux-foundation.org> <263929f5-bde6-48fb-a162-298a9f83bf5b@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8ACAD120009 X-Stat-Signature: 485bekfpqeyndtneix9d7kox98np7jp3 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748576876-244426 X-HE-Meta: U2FsdGVkX19UM3U7qjEvYfaU7qG6iQKTGbVElc6g2fWC3XyOC1y+/Y9jKuNMoqCbNYgwC39iq280PDd+Er6JaSI2CDoyXeQFABkOJcBhHZfvH4dJiDpTOu6ESBdp2k/8QTCDJ/x30B0hnpyNBTw652zy/BfyJofxScho+SP4/C8ZUKXL8J3cCwul00nY+LzYX82k/D0PdchpKoU8PGhyZ9CbIaRGxP5PbWQGvpkUML+/sIxM1RxTfy9D5WEqB6rLk0yAzmNTTpGQd+qZAnhQ5QH54QO8v9h716KGZtOKLxwbNO+T/6/0kCvtEVlihQzF93t5FQE04/wajEETG8dHgOU8Gb/7rqKcoTUAeFPrnjupkwGAzWtiVMgXjZzk09IP6keu3vE5ASOducye9UfQTcOeJc1MgoyPtztrJ7HUFqC/HLqaJVj2aC5W9SRDIY3+MeW1OSY43gUE4QYj2rz75wa+Ti99Zi6j7nfivTfcbrECT4a8tCX0YTEK0IDTTZVNKoMPTpl9Eev0+lHhKn9cHJRHqpiNDSfw/0GlJdG/V3u+kW8O80hv26MgB4WxP565DZTbYxdKGfmbqLj4vw1KNWjGXD7EwJa9q4UjQw77X+2sFKUMVbukmf1o2Gi5u4Vu2DRB8KMqssAbCm+PlOiNfFMg1RtiBu+p1Bixyp9vWGl+Ev5IoJiAoYIMt4u/3gMXeOBbcHxWdxBoLrObgcRoKbVq5CNbcpd66fHECRzdmbTTzZ3PnLGYyVUYrtNOQmIcSdwmjBA534KC+6W4EW+KUmIl83jTs/Jf2PGDdcuTiZcth8gvGG+aXeB3ByPlHCjG+nZ6VU79bCvaubuylGwCvqNCECxG6FuxCJGbq0uwlb46S/p3/U5tNFiofs+eq4vVTwBWN7KrPGGLMNzO8MQJOsPt4vJLcTo5uHkYGVcx1HBoKQM992l1yQkCUs+KMcq3LoOyXht2iONaAtKdHaj +IKUfdLj fUcsqgMkFHLGI+7vg7FfUyf9ofjcWPez5VvLDtgBPx8Sl6+0MaBmg+Hzc4d7Xr4yJ4x8xxnN7oIGCyPNDNOSquB9H+AnWHCIetNF/FTw760eJAzkqpGz4FL+UCkQuVUyMWiPWtfP9G+6p72yG48p9J94Z0A6XZOO3xhRxP/+P3uddxyBVn8eLnVu562mhsIeW/HbW2aB0MKu2EU4U9ZvRz3p4oyJK8d/Gl/25SYVLajruDuCWgrw0rS1ha5+VntsNSSenvCsExfKfhF2JvueGM0/uTOXYxRAQYNLvSOLkVsYt2sXjpKuszXTwd8hA0Mc4bNBG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 30 May 2025 09:24:54 +0800 Pu Lehui wrote: > > check that patch [1/4] is working? Perhaps VM_WARN_ON_ONCE() would be > > Agree, should I respin one more? That's OK, I added this: --- a/mm/mremap.c~mm-expose-abnormal-new_pte-during-move_ptes-fix +++ a/mm/mremap.c @@ -237,7 +237,7 @@ static int move_ptes(struct pagetable_mo for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE, new_pte++, new_addr += PAGE_SIZE) { - WARN_ON_ONCE(!pte_none(*new_pte)); + VM_WARN_ON_ONCE(!pte_none(*new_pte)); if (pte_none(ptep_get(old_pte))) continue; _