From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA706C54FB3 for ; Thu, 29 May 2025 20:16:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78E476B0085; Thu, 29 May 2025 16:16:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 765A16B0088; Thu, 29 May 2025 16:16:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67C596B0089; Thu, 29 May 2025 16:16:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 492536B0085 for ; Thu, 29 May 2025 16:16:17 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F323E1CDE6D for ; Thu, 29 May 2025 20:16:16 +0000 (UTC) X-FDA: 83497052352.15.1D430D3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 4BFD180006 for ; Thu, 29 May 2025 20:16:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of "SRS0=SoWH=YN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=SoWH=YN=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748549775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cZssOCUgOIuFDc7zFWaOANJEU93Txpa3GDUl2u2PL5A=; b=rLD4yxnvTk6WPKwPfYM6YifRQ1/dG85J/FiLIVqiSKmfwFaR1Nox8I6h8yARrE9G5PBtnb oTHas0O8VUUZ0ZitG7Ii0GgVoxM0YhwXrKAk96ADBHdmBit6B13DHwMow/YlVbbojgwHDT VKTCkXnT9bfIuxaBoW+fWZroCq3MmPA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748549775; a=rsa-sha256; cv=none; b=7083eDtTLJPCX4MaNhl/urvNbgTb4RU+UaPZH+EYrK7IbL306faPPWxCpiSKaJ+pikZ0nn 1V5cHfIDE6ycbTh/yz2uIa+bSK0gcrCqcpSh6wf3iJD7TB61QvhsKEEiOXQVigHDEoN8IO EpTx9WB68yWNIsNIfzoYobvRjltuqoQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of "SRS0=SoWH=YN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=SoWH=YN=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5C6495C6923; Thu, 29 May 2025 20:13:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47A9CC4CEE7; Thu, 29 May 2025 20:16:12 +0000 (UTC) Date: Thu, 29 May 2025 16:17:14 -0400 From: Steven Rostedt To: Lorenzo Stoakes Cc: Caleb Sander Mateos , Andrew Morton , "Liam R . Howlett" , Masami Hiramatsu , Mathieu Desnoyers , Eric Mueller , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Jann Horn , Pedro Falcato Subject: Re: [PATCH] mm: remove unused mmap tracepoints Message-ID: <20250529161714.1d172189@gandalf.local.home> In-Reply-To: <20250529144327.1633825e@gandalf.local.home> References: <20250411161746.1043239-1-csander@purestorage.com> <3ucksa6coiwco3wpmcjtfwezqjigzm2zwvdvkt2ryvefzojtqy@4lda47c236uz> <20250528114549.4d8a5e03@gandalf.local.home> <20250528122411.16a551b1@gandalf.local.home> <20250529144327.1633825e@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4BFD180006 X-Stat-Signature: gn7gf1ozwoiha7iwqpkkfgrorhphmwa8 X-Rspam-User: X-HE-Tag: 1748549775-364307 X-HE-Meta: U2FsdGVkX19IPKNPXReVSGvpGDedlH3O4SY3gNHaDYhtd+4BVEbysXvoGwllskhGqkErmLtengTWtfEhJFOvD9T0jxmdGQfFbdeAThOUENM2OeyFi++x15DdpFKpkht/GHjqV4nRqO55szCTt9xV6YFDiswfsg7lhxjTpBFONw28ZzEIykWAsW0j23MzzDr6RIsza+49Aqc+qtywKVExpH/JvNmwRxiy7ZwhzKFVBdVG6XYS5u+fqYQAYwni3FeZI8gUQE0R8GmDpU+3Fx4qVlWleA6uXqFmso6pVwaYnSSSA+Pq6fh3c+oQ+56DE9D36wKOUQ/QeIH8n/IRXswn4uc2WRn2GJP6YW38t7V+mZpkFDSgOP36z5J5VqqncJ0LYl5AjRuJxP3EXZNrSfz/GinGSxJ63wJ7E3jwSkssYbM7mOdYOsV4jXD22tJagAiOuGwhH0/EBtTR8N/lVg15hSIYoCKIQVZDOqPf+oCQxJk/srGaIMFQ/eX5oBH8C6CyqmbLN8fe4bLUqnMUJSvhEKKJ22DBZ+pOlpUtofKf68W+H/mZO7P5gUB+23AEBZFdeqX3xcgs21crBF5gnxsQxfzQiSZe4exOXbXr9/3vsGWlO61/GlhjBpvJlhlyg3PlpVbI06BzuwkgQMgdj8+nLnsDoORIOJa+k5lCyXa4ta/QXonrZmWLMLSgDGXhYrWRJbxY7wL57vapT0IsSjqF1EP1UuDWZlu6J6rr8Tk0ZiYEbaEPtD37j7U0VzMG7AIweHiulM2rcUSDJbjw4I+vxTEqlJ++eJRp59e6yk8SWx+nwmOe7IXjg6oCY2h7mt2kmFvQr9v0dMbXYh8WCIqLa7Cb+uyYP1CzjPyvzKbndbq7Lo5VEDHmEY3PF+XaM41tsJckfyCfHi9ER5XMtt5clY4ihFVCqJSdLz3D0yrPEbss5KzBL/xMB2nG6RimevN4H7GDkBpErtqG4Y05o6c 2i/IO5gC y3EP4wQ9a6+SFvTuGRyTa3K/1gao8KeKq6k7gavoVkxuUUF8tIzJSITSQK0onoAARzyCdK+MTBTyan0vE8EeYr5EQuKyC+s4j40YzXCpe7yj3PpTTCN4r4+Q5rrkMq4qQeH2vwQ0hWBLqP+U8i6AxCCTBj+DRv2I0IJ72PGdXX3k+ULN98rFs0YQBHaXEBpM3ySevwQoIAwSr69HUlOrCMrETWbcsjeVuC4JilkGgp/nER/Itjy/XoyKS5zTQC0cuewSh8Or9bWk1/T/rAwE29TA+SuplOXiuH8Qr/9i0jfyQGFBh+PHlVUdAhwxB41aulOaHrfLuD4bbWkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 May 2025 14:43:27 -0400 Steven Rostedt wrote: > On Wed, 28 May 2025 12:24:11 -0400 > Steven Rostedt wrote: > > > Yeah, I have a patch that shows how many static key instances exist and I > > test that. But I probably could also add an option to the macro that > > creates the trace function to also add something to a section when used, > > and report when it isn't. Shouldn't be too hard. > > Done: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/ > And going through the list, I almost sent a patch that removed the two events that this patch removes! Luckily, when I ran "get_maintainers.pl" on the patch, I noticed you were one of the maintainers and then I thought "Hmm, is this the events that are removed that started all this?" And sure enough, it was! This was going to be my change log: Subject: [PATCH] mmap: Remove unused events vma_mas_szero and vma_store When the __vma_adjust() was converted to use the vma iterator it removed the functions vma_mas_store() and vma_mas_remove(). These functions called the tracepoints trace_vma_mas_store() and trace_vma_mas_szero() respectively. The calls to these tracepoints were removed but the trace events that created the tracepoints were not removed. Each trace event can take up to 5K of memory, and it is allocated regardless of if they are called or not. Remove the unused trace events. Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/ Fixes: fbcc3104b843 ("mmap: convert __vma_adjust() to use vma iterator") Signed-off-by: Steven Rostedt (Google) -- Steve