From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A15C54FB3 for ; Thu, 29 May 2025 15:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17C1B6B0082; Thu, 29 May 2025 11:54:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 152DF6B0085; Thu, 29 May 2025 11:54:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 041FF6B0089; Thu, 29 May 2025 11:54:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DB4226B0082 for ; Thu, 29 May 2025 11:54:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7ACB75C599 for ; Thu, 29 May 2025 15:54:41 +0000 (UTC) X-FDA: 83496393162.22.442E12C Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 474DF1C0012 for ; Thu, 29 May 2025 15:54:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748534079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4wkf0VpK7n9H96mDEk5qKJ5imsTiB0La29STIZXAT/Y=; b=5I2YKYmJ4iCaEPOHuS985lJ8LjSWfAbplmg+pU+tLVoK1Oce2TUXDif9JLj/aMahIb1D/9 ip7J0FOXkpQGEHPmbetEyuyYJUTVCUTr7cvBNc9zog53O5kwJwV4UWpOT08CflE0hAG3cQ evMckYaWIK2jhB4fYFFp3FrFU8XU1/w= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748534079; a=rsa-sha256; cv=none; b=PU7dwD+uQBzO6Fi/j02I5Xv3RtCPdmXZ72PdLAEVp/XykIFwpYPzfntmc41Vc8y1nh/eYV +lQLe/KDlHPun9kNYD16FL2FKLfejeyjDiyz0lnLrmmNVxYEyC13k/CKhwNcrCcMRpNMJ1 K9m9ZM9YJQMTeKrxuyS5H8abFyuXiRM= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4b7WCD3MZhzYQv7c for ; Thu, 29 May 2025 23:54:32 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 9285B1A13B7 for ; Thu, 29 May 2025 23:54:31 +0800 (CST) Received: from ultra.huawei.com (unknown [10.90.53.71]) by APP3 (Coremail) with SMTP id _Ch0CgBX98EzgzhooMK5Ng--.57784S4; Thu, 29 May 2025 23:54:31 +0800 (CST) From: Pu Lehui To: mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, pulehui@huawei.com Subject: [PATCH v1 2/4] mm: Expose abnormal new_pte during move_ptes Date: Thu, 29 May 2025 15:56:48 +0000 Message-Id: <20250529155650.4017699-3-pulehui@huaweicloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250529155650.4017699-1-pulehui@huaweicloud.com> References: <20250529155650.4017699-1-pulehui@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_Ch0CgBX98EzgzhooMK5Ng--.57784S4 X-Coremail-Antispam: 1UD129KBjvdXoW7Wr43Kry8tF13uF47ZFy5Arb_yoWfJrXE9r 4Fqryrtr4DAF1vyw15Cwn8urZIkw1q9r10qFnxtr92kw4kJan3ur929rWkZ39ruryq9rW5 XrWktrWSgr1UKjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l82xGYIkIc2x26280x7IE14v26r15M2 8IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK 021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r 4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx 0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWU JVW8JwACjcxG0xvY0x0EwIxGrwACI402YVCY1x02628vn2kIc2xKxwCY1x0262kKe7AKxV WUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UCZXrU UUUU= X-CM-SenderInfo: psxovxtxl6x35dzhxuhorxvhhfrp/ X-Rspamd-Queue-Id: 474DF1C0012 X-Stat-Signature: fie9j7h9bj94fbdqi83fmtpf6ka8699p X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748534076-8632 X-HE-Meta: U2FsdGVkX18ZfCrnikV8S7JasCQ5tj8z8mIxMh2f58A0bapljG5DvpHn2UbPrztByMbrjMq+rOXcagija5ODksqEUc7plrisU1Wax3pu+8JNJ67s34ZmAi/umiBsxZAFaI8PJPhjwrI1wTNj07HO8ZBKrlFUwcnWWlVdyUAqvk7DHljuiBteZEK9QvzTbDWAmgKHDc1ug+x1/yWG59SYpCxz7LTkQ6ihZwtoDIChQelkVXxwAFtrB0+VhTTeaPFwBkfHvKzjhjEeu+cWLlDwA6DixO3CVwJizmUxag0ONJse4+4cLyCzHEJONDkgpq6G2qj6z6E7jQK9OX7/KMaUk27NmCL2fukJzKYB5sxR+qnFGc8OaLfVDpef/rr2Iwc+gvGfKI8mGmQdL+abn45AFq2QTp7mW3iGTIVmg/mDO8fJpXL/z94bcKJOQf52aDUuJdiFi+IGzinGmV1ltzsrYDu2ePpowW2m4Qvqy/rSGbG+iiCCoKDOeVsNoABQ13VbV0Yvc6y8QVvXpk2UMtgzZESajgJxzwo2Fch6/Xd2kyKCN6S9BpdjDEQ2V1qiTBv9pGOm64ZJRyZSLmoksUqLLsOWRCgQqWCzLRKKWqaIcM7moFaaJ1JagsnNBRm/OBOQ2i1d60XZNsPRP12/XHRrex2B3Q1tww0T9T4+IkYjx4lm+8t/89Tkjf1AcfOuh57yJunVRQF7aghY7pZnNp45ndLjOJM09e5hDrp7hKbJRHw96XdF4m+7qUO6OPssxRq9XDuK4Z67k+paDFG4l9jgJ5ujELA3mUlQ+LTwC3PuOxLfF0Bo2nlsMLsxHjfGuDV9qn7cZZM9IWR79B1wU7tNvizXTHmzQAeAlzlM8qH636DOnD7BeujKZEJ18Dq9coLvzMMChr9FJBrB6P53CkwbMjyZ7Wk6Hs+3DCBlxaUehgkWXkyVCRs/hepTSquoyzwBwVssXotGgK2YYetizNH 1AjTAb/9 SAWO+krFc38VreBBhgEGdcoh+3mY0PXP/sBQrbJm+OgYgOedr14nySC5HUZEctgT9yBg6/x149r7663pjvXOW0bwIPxtqyj57x0ktZ6GGHdlbwGbVAJr405vosbXJKoueHwVGt6G1JSr5/KdAnWlYLoIL38qYMVgC4Sy1nEu9FMvwp1/QHvbJ4Dk1OKAiYbwnNFVKIGGeUvqZcYE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Pu Lehui When executing move_ptes, the new_pte must be NULL, otherwise it will be overwritten by the old_pte, and cause the abnormal new_pte to be leaked. In order to make this problem to be more explicit, let's add WARN_ON_ONCE when new_pte is not NULL. Suggested-by: Oleg Nesterov Signed-off-by: Pu Lehui --- mm/mremap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/mremap.c b/mm/mremap.c index 83e359754961..4e2491f8c2ce 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -237,6 +237,8 @@ static int move_ptes(struct pagetable_move_control *pmc, for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE, new_pte++, new_addr += PAGE_SIZE) { + WARN_ON_ONCE(!pte_none(*new_pte)); + if (pte_none(ptep_get(old_pte))) continue; -- 2.34.1