From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1D1C54FB3 for ; Thu, 29 May 2025 11:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 993176B014D; Thu, 29 May 2025 07:46:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9435E6B014E; Thu, 29 May 2025 07:46:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 859186B014F; Thu, 29 May 2025 07:46:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 646D86B014D for ; Thu, 29 May 2025 07:46:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DE25140197 for ; Thu, 29 May 2025 11:46:28 +0000 (UTC) X-FDA: 83495767656.17.B18A6F5 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf23.hostedemail.com (Postfix) with ESMTP id CEBF514000F for ; Thu, 29 May 2025 11:46:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748519186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+6/BHV2eTmabDcVQTVev0tLsBBKy+Q7dgFYJufr1v0=; b=3tKw7hyHCLaKsyWrt6lP7jzoB6SJHMMQXWaeSKXSB2BLM3VBpv79zl90ZKmUc3w835apia bWFKOeiLrf6r6hAitq/f6eDlvUu8nX+BfcmIu6fC/IMK7VkBW05lDCWKR5dNBbxSLwN/j0 uLB6bJS2x4jFKlhYWP+IiwcsBFA9z/s= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748519186; a=rsa-sha256; cv=none; b=FCMZIVOli7uB2eq3EiVoyRUPDkg26KgEN4COFXoPM355RXa8f8BB+3WQiV7tHwDF76r1Bk aX5Hg01AIdC0TIPJ9fBqciS0EwlKRqwYClEtXlEAKcf2hfnRHpLXM2e0cZJ9K6wBw/Fo5l GNsoABJspsCsern4AlXy15jo7cCZvuY= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b7PgR28wGz6L4tL; Thu, 29 May 2025 19:45:07 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id AF2D9140519; Thu, 29 May 2025 19:46:22 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 29 May 2025 13:46:21 +0200 Date: Thu, 29 May 2025 12:46:20 +0100 From: Jonathan Cameron To: Alistair Popple CC: , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 01/12] mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST Message-ID: <20250529124620.00006ac7@huawei.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To frapeml500008.china.huawei.com (7.182.85.71) X-Stat-Signature: 1brn3dpqac3jt5f3d9gceos4q46fhqzt X-Rspamd-Queue-Id: CEBF514000F X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748519185-726629 X-HE-Meta: U2FsdGVkX18WY3KifYX9QwgKGbnqHKPlA5P0CffwJdUEAvWgBf4Fb17zvD8eK9st0xPnGK94UQm3F6O57GIQUVPHTsKK1DcVSlgC6ZkJtV/pyWK4LBI2SFqEifN7LvqvoLOQqbne38+/I/wOJoa2AnuMSeMigqZhUTFRhuSMLG8jr8bKJmygxhQxnYeJOShHRZ1Gn7hohiHFb88Ew23QTQfa2pAyGnUhgBZMB+0SnosRLQ7THzyF8FnXWwKY6m+1J6Rt+hcvdVatOKTEtu1DZ+f5hvbxIvOY4cxBhnkZr2qbBfuF/fblgjrnB4mYjxbs98Gp6S4Tyg7jF273jVxmTXlD0uH9jJNU0g4oLuYqJiMll7yeMnzCAKbtQfD3wWuGyXsbpydIubD4r3oKAQx70+ddi95F+F3P+gcG/QX2Prk9hcZkPtZEHwuk66yQMn7Idfv3KyyNbg+9ekg5E7ryHJQx6w295HeE3ph052I8ZQc4j++psc0EW8Juj3dzVIY53y9J+7TZ3E2hudbkY2WWDuJcg6YN9zbakfEjJaG+fUBcw7bvYUVRQNrjzbNX3hk/ydRtwJuDomRBmcredWOTjZVyPweZ1fMevvQf56YV7MYM7dQAAT60GJJIcuXKS9XyuLKYBTfjg2LhCGqLmbrdj5033HTdl62n564F55SOgz0ZDZui6EryO8qX+faK9nsSNjhnJV+xMpMT5BeVbrkpwBP+8hg6jNGkKVxUY+Z47Kgh4AxRQbd4SmnNj4zNaCJ4fRmzgL+wGlGdEmA7NSfikelvntduwPX2EFomIZAFCmd8FVuSz2XWLOX3jjIpTM4Cevd4smGwbOhDW3KOVFHHZ34pXUX26JrrA8zrbhH/qHESQkpGaJs3DZ/M8nI7F5yukbq+PvMN2o1+BGcz4VRC/2n+5KwIf98f+ddtsAu9UfENYZKYpr3sMyxb8/f8zqdK0ac1tzgAUpMDUfdatmL /Debe9HG ZldjC8w0wnMYH/wPKlq2vk0Qu1RqCqGnaw4ya5Dimiy09feH/Vz+E0eUYTL6Lw4qo0dOGkJYpDghHVCcP4e5jeZSyBmry0b4wtCga12qXQFXZLNu7BcGCTM1I5mdOPZHyP/p0ECOf73SuChLwDCbkkKDn0txCMDBRnLNkoPYLQOpaWMhaeA1Tw8LkPB2irVUAZyqNCpQ4kR5+TJf94jsDboVX7EfYcd5rkLqzH8bt0fHd3z0LCQbCl3S6zmtnhhhWgP7oUIBusYe4YVjkiDGQT1ze2mUDzZszGZx3bquInNvRxfZFkSbz5Ql5lVzVIJ7QUykdfGRqA9RYmpRnnBZzJy63kw1CMD3nhUxrlJ0wBmZWJ4A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 29 May 2025 16:32:02 +1000 Alistair Popple wrote: > The PFN_MAP flag is no longer used for anything, so remove it. The > PFN_SG_CHAIN and PFN_SG_LAST flags never appear to have been used so > also remove them. Superficial thing but you seem to be be removing PFN_SPECIAL as well and this description and patche description don't mention that. > > Signed-off-by: Alistair Popple > Reviewed-by: Christoph Hellwig On superficial comment inline. > --- > include/linux/pfn_t.h | 31 +++---------------------------- > mm/memory.c | 2 -- > tools/testing/nvdimm/test/iomap.c | 4 ---- > 3 files changed, 3 insertions(+), 34 deletions(-) > > diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h > index 2d91482..46afa12 100644 > --- a/include/linux/pfn_t.h > +++ b/include/linux/pfn_t.h > @@ -5,26 +5,13 @@ > diff --git a/tools/testing/nvdimm/test/iomap.c b/tools/testing/nvdimm/test/iomap.c > index e431372..ddceb04 100644 > --- a/tools/testing/nvdimm/test/iomap.c > +++ b/tools/testing/nvdimm/test/iomap.c > @@ -137,10 +137,6 @@ EXPORT_SYMBOL_GPL(__wrap_devm_memremap_pages); > > pfn_t __wrap_phys_to_pfn_t(phys_addr_t addr, unsigned long flags) > { > - struct nfit_test_resource *nfit_res = get_nfit_res(addr); > - > - if (nfit_res) > - flags &= ~PFN_MAP; > return phys_to_pfn_t(addr, flags); Maybe not the time to point it out, but what is going on with indent here? Looks like some spaces snuck in for that last line. > } > EXPORT_SYMBOL(__wrap_phys_to_pfn_t);