From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD52C5AD49 for ; Wed, 28 May 2025 22:39:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E48C6B0099; Wed, 28 May 2025 18:39:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 695AA6B009A; Wed, 28 May 2025 18:39:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ABBD6B009B; Wed, 28 May 2025 18:39:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3DE026B0099 for ; Wed, 28 May 2025 18:39:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C9BB25FF92 for ; Wed, 28 May 2025 22:39:20 +0000 (UTC) X-FDA: 83493784080.24.11ED2FF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 20368160002 for ; Wed, 28 May 2025 22:39:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mmQ3+q7C; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748471959; a=rsa-sha256; cv=none; b=VCvC3Baw0a5HM1+Sj4uetX3yLEl+u86q9iYbQ7JMJ/D1i6u8p7HH5LOYZOcnPEtJRjpu6W SpMV17C2dZvUFGhm9iMerwP6r/hid3v36c7GQ2G55msee2AWRwcd9v5WzgeYPiSSzdMmxo rGOq5ZH9hywK2FC3IAfImBxqzKB9VVg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mmQ3+q7C; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748471959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PsUgCML5/oSNM2+Neg5csuVjUsBjKv+VqwgxQ3s9it0=; b=wWrYVXSyCIrrlVu0oYirWFBI2XkZdBquhmIkcP2CiTr5RcF5X+Km+UbydfLG3Qh4L66GFF jRLmS14RlqOsFUmuHTnt4bqOlQzKAFtpqflo9kEu2ynKEg87WFZhgFU37MUkV6g/IlG8ua c/enWZLb/Fhi8dj8Ah4viERxAIXlozo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 263B65C5D03; Wed, 28 May 2025 22:37:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9661DC4CEE3; Wed, 28 May 2025 22:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748471957; bh=H6sNMIHXeTr/9xzRzueBp5o1yGTA9o+s7DYHLjD3t1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mmQ3+q7CpSp7N2CadSmUinswYYLasIFN0UUEyKWKcltxv1tqZ3aXksmAJU1YOjQup wBJoGc4xNws/q4MosvdovkeTO7WwyImMLymtpuwMFfhwSK0DrPQWsfBUhQ0d/200MM oliBdvRjad8eAN34ov3xikN/vxiTMNy2FLXKoO/h7cBdcVKRUgqnI+XMH2A3CdZVt0 Oj1SQcaFI7wyD02s2ZM8x49EeoCl3MgQ8QrL2zf+7hUFawjBv6ZQ4vrGpALFZpxTSk Ju4Au41D5f/jaNwnA8+7fDSnP1qPtq0QuXoqM28bt1zpqilY4bam2MwRLqDyIh50Et usOOBYY+uzKDw== From: SeongJae Park To: wangchuanguo Cc: SeongJae Park , akpm@linux-foundation.org, hannes@cmpxchg.org, david@redhat.com, mhocko@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 0/2] add a knob to control whether to use other nodes at the same tier of the target node in DAMON Date: Wed, 28 May 2025 15:39:15 -0700 Message-Id: <20250528223915.55694-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250528111038.18378-1-wangchuanguo@inspur.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 20368160002 X-Stat-Signature: rzs51zp7jg6mrxxwd3xyz7fcuwmopn99 X-Rspam-User: X-HE-Tag: 1748471958-568064 X-HE-Meta: U2FsdGVkX1/9Ie4kBT10czBv4fuv6wMHpITQ/idJWQPupkqIZElfNBudL3HtqgdnKg3pPcpFb25uIjl4p15WOHbEE9d5whFXDADbq03qJBhMjP98g4TpdfqD5ZPtta0VuoainfQ1kdPQSiFHKRloh37VcddWbKzs9xKUH/5WrH8sTkS29pgedEK+Q5gV/4aKC8vDecS3qfKJjtqoj0E6pY/T5Qmc4WIDKs2+vSj3GUJ2XcumH8Tj5CJl4AGcrXjuoH5froMm5iU0FB+a/FcAz+WYh2hOb46upl1IX7FvICz4ke10RAbx1PzFzgSM/qfcVS9woBKvu0ScNs248k6X81gJVG5pFib16f2f2QgubTLZLzwzwHqp+fabPKUS35pgmE4hDPN6UK/32zoV0JU58hpmGfzRdLR3eH4EsIg9RG39Qm8FVUZUPgHPpACzzLVml6cvWRrHWFUhwxgOo/fL78Oh7ORV6kHxo9Q+nDvQX6qRB6TUcuJjFy9cFLATFEVQsIGnugkolxGj4o6JyL4pzuKW8gjIWxp/TrIt+3S810r4qMHRonAPySpmpSLqxBA9U07vvsOvPNbDNTOEB296dyGk7zrRbPs0vpqI+9wJdcWM0ZAa10SbBaTU7GEN7s4SVSxJc4umdNLBdbBj4JYWjWOYYRrGDdzgTgiEkmVElYI4RNZimW0oDVNzTB7dlNRvWA799bxh8pBbzcyQUU4r2DJcF0nlS/nporqWbFxrpBZt8T1c41nc8KKvbcYfVCWU35qfxJ4jGRKh9RPFxQES5xhKu5G938hKA5GO0G0IlRHEWJj+gbq1V+BRHTWPAtLB2R4uZuJlt8ffobocfzJ4bpeegIwg93miE5rptjCGaxOYgfcH+7IY29PIVrM0C8uvkSmYHd5qpYwAbdXp2AuDUMGmNCkLiA2el78fiocCJKAspew6lfsDyaxdi2nNPIL+IglDXtkB+kauNOkKmTA t0+gxybo +Db+fkl4a/koPz1inQoCZr57/+VHF8QH7nEt5INyNRO8P5B/Nup/TwjDuBp6s2K1CstGiMp8nDSPXzeiQp9aDT36guBLFM5d+oduL8NpkCYsi3bA7ztM4Q0+9aonr3Mp3SogKZuTj+jEMYWthXpy7haGcyfC3f9vr4vP1aq6I99iLSUBBFg1ZpQZZ6pfHaWsTQ32nUFMnUkpdFkpPhvo5m50+3KHKtCpGhe2RCDj12xyOS/Gx6SNrFV45pg0umCVRiQLo0vHUFCdxrQF+CBGAC8WLvtDnAwTJNh7UFfhW9JXmCYmBuMzK8NIdST3LGeDHWAINBvpD/bZkYo6FJt+um2ceJeL3w1xmpyyVGuBUP9hlwhKMDNrvCfU/0uyPvp8/3Dbs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi wangchuanguo, Thank you for sending this patch series! On Wed, 28 May 2025 19:10:36 +0800 wangchuanguo wrote: > In DAMON's migrate_hot and migrate_cold features, the code was > intended to migrate pages ​​only to the node specified by target_nid​​. > However, during testing, it was observed that memory allocation > and migration could occur on ​​any nodes​​, which is a BUG. > The first patch in this PR fix this issue. > > A use_nodes_of_tier file has been added under the directory /sys/kernel/mm/damon/admin/kdamonds//contexts//schemes// > to control whether to ​​use other nodes in the same tier as > the target node​​ for migration. I left a few comments on the patches. Looking forward to discussions on each sub-thread :) > > wangchuanguo (2): I believe your name is Wang Chuanguo? Sorry if I read/wrote it wrongly. But we disallow[1] anonymous contributions, and prefer more formal Signed-off-by: if possible. Could you please use such formal Signed-off-by: identity, say, "Wang Chuanguo " from next time? [1] https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 Thanks, SJ [...]