From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE78C5AD49 for ; Wed, 28 May 2025 22:31:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3F506B0096; Wed, 28 May 2025 18:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF0C36B0098; Wed, 28 May 2025 18:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06C96B0099; Wed, 28 May 2025 18:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D05B6B0096 for ; Wed, 28 May 2025 18:31:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE63B5FEF4 for ; Wed, 28 May 2025 22:31:47 +0000 (UTC) X-FDA: 83493765054.29.467973C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf14.hostedemail.com (Postfix) with ESMTP id 4431D100009 for ; Wed, 28 May 2025 22:31:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LocCYfUK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748471506; a=rsa-sha256; cv=none; b=E70evARceXc3X/DAQguay6JCg0hGSpLp6bCZNY3rqiN+sCm9dBO3ebHfnoxDsOKbpvUKBS znfyupwekyZZkNNBmzWkGOGH+7M37/E66pluMlihQsSbi9lfnfttW7iPqwtCJdrR6EiRKr gId+wsBzJiceebKWECYNZ6EdegCY2Ks= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LocCYfUK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748471506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EY2H3j0Sz1wTUw/btni6c4tYldt7o2VezvjBqjZgeIU=; b=zEyl2vt5mPBJgQRMC7429YjzLHqNONXFZsRVRjoFz4Cwq9vjrw6r9TkpRadI1O9+xUU4O3 rA8CYeM36tA6RBGXycXUCbdwkUJhPCIH6mBEZ87P5NBm8cp+uLCICSXSafZkel1yX+Lz15 cLmcfGhTasZofq+2xJ5ISOVZZ8tlp6w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0107A4A130; Wed, 28 May 2025 22:31:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A871AC4CEE3; Wed, 28 May 2025 22:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748471504; bh=u9Xa/zfU1fFl2g0M8v5nS3bKTcpyA4POdBWP6Um/jAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LocCYfUKlhRDVZxUHf5yelBF32WP42iwT1/6sULUTpmHCbt3bCmZtMmhh2tlCUgID 22r6lC2L7oSUQqYOHrO17uxiO9LoROMM6YIhIFYtQK8nvpOeYirhhGvAracx98xBPw REQO6fXYIHy2AbuHewsapfDDLs/v1a3apdgFhvljcWGDvTlL+kvHuMsIuWHruU0wKM vgZXONEbBqgNrACADGcrYW7lNMtHf5bRBkdF3EjwmTGniNLiwnmD+hHOnJzbOW0Nlk diTgeMIJxnFZTilQWRmjjjSoDYDJTE3XSh9+15+RwdAAhVnGj/S7RsusjoZmAJ/9Sl udLk7eFx/GiSQ== From: SeongJae Park To: wangchuanguo Cc: SeongJae Park , akpm@linux-foundation.org, hannes@cmpxchg.org, david@redhat.com, mhocko@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 2/2] mm/damon/sysfs-schemes: add use_nodes_of_tier on sysfs-schemes Date: Wed, 28 May 2025 15:31:42 -0700 Message-Id: <20250528223142.55568-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250528111038.18378-3-wangchuanguo@inspur.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4431D100009 X-Stat-Signature: 1n6x98hjujp1y5t5arxs3zjtepbo1edy X-Rspam-User: X-HE-Tag: 1748471506-670334 X-HE-Meta: U2FsdGVkX1+75StzT/V6kdOV6bcIWvbPi5kqjjtRSFzlP8II93HYf73CcgK+2wcqiv5QvCkJuipX7Z+GpHScc6pDKCyx9pPcPkpr8STDlxHmjLdTUxhR2YGtwNTpNPlbYA2+J43FF521B1QoDugIt1iNKqoNmEzgNaSZ+BW9lSB3JKzhUQ04x+1yNMqKmSzzpb/BiyhJlOKbq/KNb4G224DY4IzB83zUKw7g7KazHAsKa8tmqr/UpOmEZZwMDzm4kGhpqLJvyHSdLMRabhijz8eAMRTgrATx97TG5mAxp88OtQ1BW6tlTLYo2uyLpb2zRAqLhdSDINTU/dbmJM71uZlf051oVT8ZmV4mSaii+R0Noh8SJQl6mGKinUxV/gg6flsatNgNuTLmxpxoEX50rHo2UCLg6TAybOcNoJ1tOTilL9DrI/aPmmEAMwfmnRX/dEVA29pSNV4RHbsL8olTzunsozyamEdURLJQp3uvuboXhtm9ZoqPsRufh750CDJ7WmTBpi+mA1kCKYoOC0WKUV6Tk+l74343YNldV7kbBiWxQHp5SY5VVNFTJCQooqc86WtuCZycgdv4Hqb8elj9JpsOgGMn1TpGwwlu+R4LXoF3qnwJKX0UtVSORn2ItPtB2yTkJ4vRWWJKNSQa0JguN/1aOvNPJtnRT5Pw4HLwOWLSnzKvJBrknwdUD9b8PzWy5I6nZnuWOzHgmpR2QZVTk9o9fnBo1WHvzTIfQ/35boejgJUVlXWbMJwxWC6i+pgOaopWEiSLqjWBM6op647svKaISka0p7XiN5BwtrfGmLdGkCM3EMbKYEkN0BPfeapAZyZ7KgsmPnmy9USRkcxmRRvDMINBOmWzKE8vxEpmETs4h9vtPo4DUfVwZ9fXdcpZBs+EZrBYKy8PsuLhwPsMUbFFiomcF5NrJEhlLbBT/2o0QEjT76R0sbPRExHPEAoRJwJMzQzuOfyFCFpBMQU WqOU16Wz hvi9vB9nfg1vi0KhUkPQt6+2j2h48weLVTPD8NnOwPS/kVXO1l5kRNFs76QPuu1Ba8TnFazYEssdrpeaGXScdaJzsEgS4vHAocn6C79me2Skw4S4A0JW3P108fl7q4QHhxjcJYc+GJ8YhldzZnq5mddXAvOD3xRPB4n62e4NgMxry1XveqmlRSx18Ocbp/CL2dFMU04i8BNJZXjG5ZsD1oNu//ClxaSmzhFO66B5ufQDjYxrr+3cOSdhfFRtzHQMoZyzAeKI5JSmHpFfrbj6UsqYeL3k85uf9SczlOlVTyEb2Cy8UWxREqyZd/HkqqzMAM39Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi wangchuanguo, On Wed, 28 May 2025 19:10:38 +0800 wangchuanguo wrote: > This patch adds use_nodes_of_tier under > /sys/kernel/mm/damon/admin/kdamonds//contexts//schemes// > > The 'use_nodes_of_tier' can be used to select nodes within the same memory > tier of target_nid for DAMOS actions such as DAMOS_MIGRATE_{HOT,COLD}. Could you please elaborate in what setup you think this option is useful, and measurement of the usefulness if you have? I'm asking the above question because of below reasons. My anticiapted usage of DAMOS_MIGRATE_{HOT,COLD} is for not only memory tiering but generic NUMA node management. And my proposed usage of these for memory tiering is making per-node promotion/demotion for gradually promoting and demoting pages step by step between node. It could be slow but I anticipate such slow but continued promotion/demotion is more important for reliable performance on production systems of large time scale. And I believe the approach can be applied to general NUMA nodes management, once DAMON is extended for per-CPU access monitoring. I'm not saying this change is not useful, but asking you to give me a chance to learn your changes, better. > > Signed-off-by: wangchuanguo > --- > include/linux/damon.h | 9 ++++++++- > include/linux/memory-tiers.h | 5 +++++ > mm/damon/core.c | 6 ++++-- > mm/damon/lru_sort.c | 3 ++- > mm/damon/paddr.c | 19 ++++++++++++------- > mm/damon/reclaim.c | 3 ++- > mm/damon/sysfs-schemes.c | 31 ++++++++++++++++++++++++++++++- > mm/memory-tiers.c | 13 +++++++++++++ > samples/damon/mtier.c | 3 ++- > samples/damon/prcl.c | 3 ++- > 10 files changed, 80 insertions(+), 15 deletions(-) Can we please make this change more separated? Maybe we can split the change for memory-tiers.c, DAMON core layer, and DAMON sysfs interface. That will make review much easier. I'll add more comments for details after above high level discussion is done. Thanks, SJ [...]