From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F73BC5AD49 for ; Wed, 28 May 2025 22:52:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A146B009D; Wed, 28 May 2025 18:52:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1B136B009E; Wed, 28 May 2025 18:52:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A31076B009F; Wed, 28 May 2025 18:52:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84B276B009D for ; Wed, 28 May 2025 18:52:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E2C25121B88 for ; Wed, 28 May 2025 22:52:21 +0000 (UTC) X-FDA: 83493816882.02.622EF0D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 2EB6618000D for ; Wed, 28 May 2025 22:52:20 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rhH8kLT8; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748472740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sxDSGvlKjRWdzZRMKGOi2dg5m/4Zi9fBwmuq+W5qOfI=; b=mjrkDNP9coyFjnoZsuyHH/wKnwjhrhGyqkDVT0T678GEkotmAgVQWMMlZQPg8hvBvOfbjd MRFfKy+UC5A6LUhnDZw4/LIvbt2oD6wj6/jLt3urGTe8qZIVdjWR9WyZhoDDAAv8iPadqI tC0KCdG1PcIc1Xv3YOXtvqePBkkq9TM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748472740; a=rsa-sha256; cv=none; b=TDfXNoRHd352FJk6BKgwwVtAx8VjpmlBoAR0qEK7rSyzZstbAV1H7AcIv0uLXp1mdoqRYY vJCh1g2ot1mshC+v1hh/+joIiAOpG6fYXlfxrOdMyXJAqiUqFJumbCGCJJRQ3GaVVOrDeM PowqMnpPa7m9DYacQRb8zJGga5zrOXw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rhH8kLT8; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 49CB95C5B73; Wed, 28 May 2025 22:50:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1B46C4CEE3; Wed, 28 May 2025 22:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748472738; bh=2IoOHI2xO3MVBr6bPNdHZD6BmmLkb+UZ0OkJxJKjhDs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rhH8kLT8wPRClBVdF/6l6jjzMi/xf1D6eXsZJ58EE1hmU3Yn8quY+G+I0EH122e9j Bagm6I3vH1bZAo87FLxMbc9s7PB/TNlHb0V3pUKapx70nEWSN/JCSI2xa9jaOk3rTM NvCg6VPIVaEAyOHNVSQilhaxsW+KGOx0IrK+7t4o= Date: Wed, 28 May 2025 15:52:18 -0700 From: Andrew Morton To: lorenzo.stoakes@oracle.com Cc: Lorenzo Stoakes via B4 Relay , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/testing/vma: add missing function stub Message-Id: <20250528155218.a8b755912d1eed25148c59b4@linux-foundation.org> In-Reply-To: <20250528-fix-vma-test-v1-1-c8a5f533b38f@oracle.com> References: <20250528-fix-vma-test-v1-1-c8a5f533b38f@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2EB6618000D X-Stat-Signature: iz4mndjx5b1t5x6gzfmzhx7ierubsg4i X-Rspam-User: X-HE-Tag: 1748472740-7082 X-HE-Meta: U2FsdGVkX1+SCLXtfheLz/H4veIPrYVUj/eNg5DjTQuchKznngishv03+AGhSfOSy9saUKfw+hzlXCZlxSEgqGngdeRCdzikeM9cCveA6d9xsYSAaYv3/fF2ObYxNOdDkJE5hR2GtXXUe24MJFuSJcuKQyM0qZf5m+uqqBhnk9nCzC0Pt3GzWCxIR+/zAytoyZgTfXK/eyzsvMHCgrfmF2lJXcoekLf9tMmQIYkk8H4kR64zuzencP0nVHt3RxetR+d+KfKgb+Ik7JjU6GYcTjIzf4/2xMeqjzWs+y0HqSxpSE7vqncGNWS0wlfKugqe8xKTQmkyAGirZcoHKnubqHBVg6Z2nc0HIiVVXQ1FSS9VBagrfsGOwAFPr6Kl3T/JPfvKNxxCK3IdY6/+lBIFnaSNdIlwId8REzdrXW1PyQdEEu+y8Zz0U805Itv9JRaTBoaSDLmjCd+jEhOzK6qkTTtiLIeXZhLKoCFTLDm7E0/fNvCxCbCQaJ7BZECcOZGwXbifGe3D1Aa5BqZYpso20C6Bu9O9QfiabT2LI8ywARuUpDA1FHzImjroYywX9ccnOp03T1qrlnndPAz0ttR0xAtXF4UPmTfQcvP3rr6bYQEnY6VBsbqwseh2iKqE/9QUbyB40PII0n3Nasc0TTUATHboA9v6q4Z1fi5+dpb7aZWv74W2tHEkVvNZhEi8twrOQsNC4MvF2uoDgZO13dWHoXw94PutPFsP8Z3kphkHFfcPmq/Hi4Ugw1SwaiuERL8EvcQYrj/aTlZWkGbNZGQG1B9WX6wly2DTRFoDnQsZuuxqwmdHs78ESEew6hy/Qso1it5y13Vfo6xMiR2NVoAS7mdT+fG1o8zXcBn3oOwALADRcAlTmLfg7rAp5L6gQiF60I2QZ3+m3r4rhonGZHogRC0bqVpR1yVO3hJCZq5q5nIqG1LOvU1ganHeucIDSvyFMIFPFVnvhCvsV7VFadt OqLQH0w2 8HHhoURgmVWzDrTphBvB0J3QFNGFQMlsVIGz2E5PdJnEUWBmkd/zIRsMEk+pxVWKGQRyCUVpr1/Jc+53+Z3Ev1PGPkZHb5emoMZwv1hvcXS+nkRGfS+g4YOjVdyZWeqpxZ8cnwYbfS3acjDoi89bXiguMRCZ0gfn+a8FsaAB8xYGnC1UYLE7U0qWUtY5+6vrPbHsDVqHMpNlb+NaDmW9Lf9HkO3D5ZGuER44hh6dFEQnvDFaNXBPul451DkR56O/33cdvCJ+4acYep/Ic0aKEcwzGxXkvtqCH3PJ/rTC5vJ470w7BeDRj3a4Rubb+HQuro0I5820GDbV7YkgvFxVQIOHqML6XIVa9Go9/1bUF1lpVm3Gzp4e1bYwZeGImc6L09gorZUlR1AfJeCDIYJ7AGn3CnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 May 2025 15:15:39 +0100 Lorenzo Stoakes via B4 Relay wrote: > From: Lorenzo Stoakes > > The hugetlb fix introduced in commit ee40c9920ac2 ("mm: fix copy_vma() > error handling for hugetlb mappings") mistakenly did not provide a stub for > the VMA userland testing, which results in a compile error when trying to > build this. Thanks, I'll add the Fixes: and the cc:stable (because ee40c9920ac2 had cc:stable). > Provide this stub to resolve the issue. > > --- > Signed-off-by: Lorenzo Stoakes SOB goes above the "^---$", please ;) > --- a/tools/testing/vma/vma_internal.h > +++ b/tools/testing/vma/vma_internal.h > @@ -1461,4 +1461,9 @@ static inline int __call_mmap_prepare(struct file *file, > return file->f_op->mmap_prepare(desc); > } > > +static inline void fixup_hugetlb_reservations(struct vm_area_struct *vma) > +{ > + (void)vma; Was this statement found to be needed? Normally we just use an empty function body in such cases. > +} > + > #endif /* __MM_VMA_INTERNAL_H */