From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB54C3ABB2 for ; Wed, 28 May 2025 16:23:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003316B0082; Wed, 28 May 2025 12:23:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF6896B0088; Wed, 28 May 2025 12:23:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBE826B0089; Wed, 28 May 2025 12:23:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA72F6B0082 for ; Wed, 28 May 2025 12:23:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6CA74160E0E for ; Wed, 28 May 2025 16:23:16 +0000 (UTC) X-FDA: 83492836392.29.6F6D364 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf05.hostedemail.com (Postfix) with ESMTP id AD822100005 for ; Wed, 28 May 2025 16:23:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=ORhH=YM=goodmis.org=rostedt@kernel.org" designates 172.234.252.31 as permitted sender) smtp.mailfrom="SRS0=ORhH=YM=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748449394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cFBg5f1OETJk+l/jd+jTXJ9zYVwwRzT76XQf/nerao0=; b=kUEJGWFPcRoTbfpePCY2PfqttlzmclnDGJTvEHfNFAkp5V4nnWU9Fi8RTHHTD2UUGBEICN XugzTr3FBP+5SKSpskp1aFoXol64DvPlKUT17VTWsytIdrN8n04pLtkq4aT4X/0Ev20XLd PO2dn20yMevQ1mfmGRb137fYjqJNrA4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748449394; a=rsa-sha256; cv=none; b=nErAy22SlwLRsVe+qXJPV9BYjYn4YxnWtXf9tfJAmfmQLqetNxuZpFSZ4lnuA4XLFNu6VA oozCSxzGv7YosKHLzJxv6Nb4RjYczx/5gIboJgSUN6PJHqsrJZpEyhborUkUAzr+T82qAk BJ3ZI2pN/tdXtbHGnHTOJB1eOYYj+WI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=ORhH=YM=goodmis.org=rostedt@kernel.org" designates 172.234.252.31 as permitted sender) smtp.mailfrom="SRS0=ORhH=YM=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 557F04A03B; Wed, 28 May 2025 16:23:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9547C4CEE3; Wed, 28 May 2025 16:23:11 +0000 (UTC) Date: Wed, 28 May 2025 12:24:11 -0400 From: Steven Rostedt To: Lorenzo Stoakes Cc: Caleb Sander Mateos , Andrew Morton , "Liam R . Howlett" , Masami Hiramatsu , Mathieu Desnoyers , Eric Mueller , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Jann Horn , Pedro Falcato Subject: Re: [PATCH] mm: remove unused mmap tracepoints Message-ID: <20250528122411.16a551b1@gandalf.local.home> In-Reply-To: References: <20250411161746.1043239-1-csander@purestorage.com> <3ucksa6coiwco3wpmcjtfwezqjigzm2zwvdvkt2ryvefzojtqy@4lda47c236uz> <20250528114549.4d8a5e03@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AD822100005 X-Stat-Signature: qp7xuadnhy15up3eigrhcuodcx8h4yyk X-Rspam-User: X-HE-Tag: 1748449394-495818 X-HE-Meta: U2FsdGVkX1/9IAhn0R1dR3/Ri1rb42+fOG43YaQz/P/T+zZQECOgmIfVOvyogfHKCD/nzGfdKq/c+u1uI5eTXHr8iJPd2qUkgmZ8coTLD+lJnBKqZQKRFc/qFmCxU+uF6XaMmAJtdBDR3ufNC2CIPFM0gOtfMUTmez0urrDRw8uoZSYLdwe0LLeZll7esJr488avG8HD3vTjUoULtcVhWUGzKsF7UJoJwi35VH0VfoxgKZPn4zatr85CJinBKigTn/cnOsRZ470XCxsd6SDvgycku9VBA1D6bazhAw7puu9KpCyFIp21Dkqld6y5MgkW7JZFU67wDmxATrdGzcjA+E8LPD9sQNyj7C+UtISLiNZWqMKWnC6kxkTIUO9xATU5r0I4ZyMQqs9dIHVuZxzgU7b3F57BLX0axbcpPKxvPxvrK8BpC78H/Gqyry/gl+WGMP2DlKnMkG6c3R1XDtoSi+DG2WMRax1uA2VGw3btF9k5KNWVG+Hoqg0V0sgk5NsMTNiAj29sAExsIUTYeNlHgVFd5VI78IWaTou4gTe/NVQb6o8pmgwbgyHKu1CS+YS32whc3xqpnIwg5aM07HTX+r3tnF1xyYnQcP0Dn1gq7cS0gMAwAQDbLOQL8nt6ndQ5dFXJzOn/V0xSn2becXsYTPl2Y1zK8CJht5GBVZVI560vVLGgyOGjEvyxTUa/jiI05ypZ7z8oxLlG01v6MQWw3XyfGLrB7NgeehxVFXJMHSPx+7XVJ24lBWLLN8henxuRlvblAlnO/PULZ27tOLDgOwc9ZMQN7ya6XLxCZ2SQat/HiV/wu04TvxonlhXgm+jUwcwYdtCLi2hN1tpR2mGcyVwESVYfpknAeQAvZKn7wCAEMFQWX0jfYqBtyEYSxWCZnugbAs5WRGsh2cWc5jOCOhh9MQjhio+TW05ocEEcDknOEqW7sfYvQdRnZJs7gAovU2PMCwtGn+ARiqf4Dcn uZ2xv+Q3 UFOHRHYeA2Hh0XApeOhr16bijKGpjVw55nNEZ0sGug5KzjBiriVU86GQ30xZiKlK7oA11YRPDxqTYM/sRrEF/ICVRiRL5VYelfq1Km9GV7T7Ue2zpXA37yBB6wOJ84JAxFrNVRl0o2BYXKVZ7t/UDqYRAKCNpTay585qVLRUoyUWwmgsDei0QZkZY9dfWN3bw+f7xHr94tr6IjZv93c/AHgbgcx8/jxZ3VM5tjjxUkpZYBbEfX9IGyw9XZiOOBFwq2yKlRazop18bk3tiNI6xU/79NQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 May 2025 16:48:10 +0100 Lorenzo Stoakes wrote: > Maybe reasonably straightforward with a clangd/ctags/etc. backend or > something to track usage? > > In fact could do a quick-an'-dirty script to grep invocations and have a > person run down the results to double-check or sth? Yeah, I have a patch that shows how many static key instances exist and I test that. But I probably could also add an option to the macro that creates the trace function to also add something to a section when used, and report when it isn't. Shouldn't be too hard. -- Steve