From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A3DC5AE59 for ; Wed, 28 May 2025 18:44:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 135866B007B; Wed, 28 May 2025 14:44:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10DAE6B0082; Wed, 28 May 2025 14:44:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04B8F6B0083; Wed, 28 May 2025 14:44:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DBF736B007B for ; Wed, 28 May 2025 14:44:45 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 90489EAB92 for ; Wed, 28 May 2025 18:44:45 +0000 (UTC) X-FDA: 83493192930.28.D83A794 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id CE1A6A0017 for ; Wed, 28 May 2025 18:44:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MQbTTlUz; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748457884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+eY7Mk/hp8dR56+ukFMNh6zrhD4Px0pXn7CgXGjFZZg=; b=p7EYEGaQEqCxc0C4P9tvv7JMWmhbSNZfpWNNvT7pHGek3YafsaIAZLe11k6iLPaPKJxJmo 1xr0J9kaLeGM8TVoUc6o/uV+D0XyW4excElDmtkgdVgvN68EBqLZmK58JT+RXrOnGCcl6g FwKvXktuucXNmRB48HlsLCQdCaxqNMQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MQbTTlUz; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748457884; a=rsa-sha256; cv=none; b=fbFcRCMeBphRsHcC9z/ZO+5NLQhYOqZ1YHStGcq+/trfP3xmy7aAcxw1ycuc1ZCe8iu1pH Ukh5Lccrc+aqCxVIXS8YIc5ENMAj7qrVbs4fyQ+S86XUgx8FPJdZAsoddxx2VwlzKHcpO0 4jntCDn8vfHhgbmOwESeOeSkh0L68jo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 00DC25C4C94; Wed, 28 May 2025 18:42:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71CA1C4CEEB; Wed, 28 May 2025 18:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748457882; bh=sP3VDy6sbZ9C6gDj7ZTR2vY4rl83eflQ2u95ORq5hoA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MQbTTlUzSEgQnwV7ZSVem+51bi6cTtdUn6wNbP/uGsOMC5L0nV6tKC36cUjVlc9Hu 58snRK4YnZEIykFhfAwjK0JXO9GaS+pT2B0RWmUSVuInuNCIt6+kxi4LAB98PkqA00 ml0N9T5tp7vk4jOOw4RDiyhY2Re+fdLgZNlf0F/k= Date: Wed, 28 May 2025 11:44:41 -0700 From: Andrew Morton To: Shivank Garg Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Baolin Wang Subject: Re: [akpm-mm:mm-unstable 36/67] mm/khugepaged.c:2337:7: error: implicit declaration of function 'folio_expected_ref_count'; did you mean 'folio_ref_count'? Message-Id: <20250528114441.abd8980f1d66fcb3e1eaecc2@linux-foundation.org> In-Reply-To: References: <202505282015.F0fVmLmH-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CE1A6A0017 X-Stat-Signature: 1q598guehi13fttp157y8g43ynxq3pf3 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748457883-818678 X-HE-Meta: U2FsdGVkX18BggOqxS7oweBMJY8LmxjquVqtHa82wMIw1URat9PQ2g1iA05QbDP7WwuHewaGuRQCh00fP0ODqupLR1LpOJAO9DWGTHXocYpQGjilopPz4/PmC7Cg08LFalrltbn9cZk8nnE2y9ykO25daJsaVjzhvr3ONJM58gTjGXWMFmNoSyTuEVWOvHDYY51gipawKS3lZS9QOaJhKSa19ciNv9oBpjwPjGf0ceWGRreve7HUbx4gMsNVDCmzVxDXDBcXcCa8cVdz/b6hB6YmXnqN+E90/G75w6Tov8MocZXiPuUqmMYOXKaxtk7Nt07l93WsgJRLcFMyfxyQ7njULQBrtO/4wkEnp1MLaICw0WNAOahzsvKL1DHigg/b5k2zzEUGsIR6gs41fMPRARDand/Jl0+jR2LzvIgy9vpo7cA0MbVDEtcCZaZ0EwHuN5X9zijyEIhZIQ2kXW/2G2E14tZwWoRAT/xYg9QPq4Y5eYh1irF+XdE2J/rJmvTFh2iP3eIgmf/A7ztmZNQWG6T61mvb35ATzYrybuI5k8m/RzuGnsW3APFnHbWpjoJdtXYmY1p2mtqoZmDBY2Rcf62YRvKQm0U8haXyoJWjL5chUp56DruqPljEp5yP1Fbmz7oUoDF0BdzN9zmnVHCpExTP9t/zdRCXd5Aek5iBzkorpguA3XR+TFSwPTSQ/zB3uSp5LzZGRrGmNd8tnhvlit1Hz1QO7b6RzERkTWDvgRidVWOBxLQhD1Amn2DCEAGl47lckUAjrZNQM0Dl/SfOiEVJcU/XrK8dwx14dYzN84SARzUZu+Jgf3WHngihYKWtDHtH0yWepuwVbL2SfQIRqYe1DdE3TLTpqTzvFF6AC6R6mbBvBi4lFrxLDy3Mnd7H8pcq6oDiDg1ZfCDXbE+lW7OxlcrFFHEBJC3nfYeJoKiQVwtbetTKw7JS75P33zeYzLEEof7DTGcXBQp3bML 0UMQdHVg HYNvM5c7PR9rgOOY0L2BGDi2qUgTs88a+He8gMrJLqepYUxcChgvqoxyKtDQl7vSHQHH/xMJGLuOx2IkA0yNJb2xADiO5lHwovmS2Cejob7ReaiMorJS2GO+ULekxvKGWfN4qI/PEx2OxjbSA9o9IhRwPykLFjsYxUXnRGtn6IRZN0A2gsXcA0Ppm52vvBF+t0Fr1+c4WcNik9oEo7ekzhKHXVtTZypK/g0pUzjBRmuOGWF/a95xAFsiu9wlVNxzpXeSEwViqXE2Q1ATMREDL9R/MuQGgKScR/cjUzctlwXpGZiTDP8F+R4B238JIzVJoAgflm9lWR53q2SxQYolcsUQ88u5EdNiaC7ToBwGpm6FVRjIQKwrNEp8wvT3ClzD70mTxmMIcvKocHe1LChmUpofv1YmSK8pkdyX7rvXkPVDENGoYjyQAoBrsTk1wTceiwNbruXyZf5i77Qtil1dmPUow2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 May 2025 18:04:02 +0530 Shivank Garg wrote: > On 5/28/2025 5:46 PM, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > > head: 52ce652e7ab0f015b51fee11b2862507b2c0c25d > > commit: 3bdddbba5f02f6d97283acb18e2a6e079324fe4b [36/67] mm/khugepaged: fix race with folio split/free using temporary reference > > config: arm64-randconfig-002-20250528 (https://download.01.org/0day-ci/archive/20250528/202505282015.F0fVmLmH-lkp@intel.com/config) > > compiler: aarch64-linux-gcc (GCC) 7.5.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250528/202505282015.F0fVmLmH-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202505282015.F0fVmLmH-lkp@intel.com/ > > > > Note: the akpm-mm/mm-unstable HEAD 52ce652e7ab0f015b51fee11b2862507b2c0c25d builds fine. > > It only hurts bisectability. > > > > All errors (new ones prefixed by >>): > > > > mm/khugepaged.c: In function 'hpage_collapse_scan_file': > >>> mm/khugepaged.c:2337:7: error: implicit declaration of function 'folio_expected_ref_count'; did you mean 'folio_ref_count'? [-Werror=implicit-function-declaration] > > if (folio_expected_ref_count(folio) + 1 != folio_ref_count(folio)) { > > ^~~~~~~~~~~~~~~~~~~~~~~~ > > folio_ref_count > > cc1: some warnings being treated as errors > > > > > > vim +2337 mm/khugepaged.c > > folio_expected_ref_count() is introduced with this commit[1] and merged into mm-* tree. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-unstable&id=86ebd50224c0734d965843260d0dc057a9431c61 > Well darn. We have a patch in mm-hotfixes-unstable which is cc:stable (mm-khugepaged-fix-race-with-folio-split-free-using-temporary-reference.patch) which is dependent upon a patch (mm-add-folio_expected_ref_count-for-reference-count-calculation.patch) which is scheduled for 6.16-rc1. I'll move mm-khugepaged-fix-race-with-folio-split-free-using-temporary-reference.patch into mm-stable, after mm-add-folio_expected_ref_count-for-reference-count-calculation.patch to remove the bisection hole. This means that when the -stable maintainers try to backport mm-khugepaged-fix-race-with-folio-split-free-using-temporary-reference.patch into earlier kernels, the build will fail. When this happens, please work with them to come up with a version of mm-khugepaged-fix-race-with-folio-split-free-using-temporary-reference.patch which is suitable for 6.15 and earlier.