From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B8EC54F30 for ; Wed, 28 May 2025 02:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B22F6B0098; Tue, 27 May 2025 22:29:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1641E6B009E; Tue, 27 May 2025 22:29:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAA356B0098; Tue, 27 May 2025 22:29:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 94DA36B009F for ; Tue, 27 May 2025 22:29:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49DED141D83 for ; Wed, 28 May 2025 02:29:32 +0000 (UTC) X-FDA: 83490735384.27.B133F5A Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf03.hostedemail.com (Postfix) with ESMTP id 69EC220008 for ; Wed, 28 May 2025 02:29:30 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748399370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=h/VmdDP7Sj/IDHQMM5aQkhuZ+VxQq1DdNoS1nXlKBUg=; b=8W/oDYhGeXH5nqck883hdDSWj48iQ884wR2ei84K99OpB3vSg41cm7CqzBx8Wf62krlM4a Lf8A5HBCNSSuAkVhGwtJosG2C+wiKNd0XEnZll5rlgWag4RZr3QVsyxOsIg5rAbsjReYtU jgxdPkBtP9XXGPOvrWlROzOqZKKUB7w= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748399370; a=rsa-sha256; cv=none; b=4i8x89aINB4qiHiudj0TMRG211W8kFrS5J4jt7z/K3O/dwvrcoMaD27QF3oFMxPmKB69xF 8nHQm5AP7X/ei2PZSrKXGLMuEa99DKHKLr04RZiYHinh0s7CmxWCbdrhv7luuV+uCisQZI /ToWHTwW/9/LihK4bt2PTda8cO3R2sQ= X-AuditID: a67dfc5b-669ff7000002311f-a7-6836750207ab From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Subject: [PATCH v2 14/16] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Wed, 28 May 2025 11:29:09 +0900 Message-Id: <20250528022911.73453-15-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250528022911.73453-1-byungchul@sk.com> References: <20250528022911.73453-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWRa0hTYRjHe3fO3h1Ho9OSPClYDUyorCyzB4qSwno/FBRiH+qDDj201bZk U1NBMhUq75egsFmzyMu0ZsvLDMlay+5p3lhmLWazD5WSy02dXZzltx+/5//8eeBhKKmNDmaU mlReq5GrZFhMi78vrYkQpEUrtngHwkFvasLQOJ0BdZ8sQtAb2xD8nHkvArftKYabNR4K9D35 NEyZZilwdTtF4Kgdo6HzfDsFztJnGIrzfRTkWuoF0NtWIoRLs7coaM/5JIL++3oMH5v+CGHM WkzD86oGGhwlMdBtWAmel98Q2EztAvAUVWOo7DNgGM13IOh77KTh6rkSBKYHdiH4pvU4Zi1p aXgnIB1VH0TEYE4j9+rXkwJ7H0XMxouYmCcrRGRkqBOTZ1d8NOmwuAWkOG8ckx+uYZpMPBjE xNQySJNXBpuIuM2hh9lj4l3JvEqZzms3704UK3pcX1DK9YCMct85KgdNiwpQAMOxUVy38Re1 yM57FoGfMRvO2e0zCz6QjeTczqd0ARIzFDsu5Fx630JoBaviWsvvCv1Ms2HcW0//woKEjeYe v8kT/itdzTU2P5z3DBMw75+MJPm1lN3OTRSakL+TY6dE3NTEwP8jVnGP6u10GZIY0BIjkio1 6Wq5UhW1SZGpUWZsSjqtNqP539Zmzx23oMneOCtiGSRbKiHN2xVSoTxdl6m2Io6hZIGS3D3R CqkkWZ6ZxWtPJ2jTVLzOikIYWhYk2eo5kyxlT8hT+VM8n8JrF6cCJiA4B2m+dpXffp61oin2 9XdDCBN4x4aKwsyXj4yWueInhsoCN8Y2Dvc51tnIvsSIzy8mO0IS1K6Ty0MLD8TgV2nnR+Kz 92un8jbg8eGjdYcuZJTHJVTuPLum9tGy8ZqukIPKEa8paJtkx2jOjYoxd9Pea7HeVm4ODzqq f/8ojfd5Q3VfZbROIY9cT2l18r+KbOjt1wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWRW0iTcRjG/e877HM5+lxSX3aCYQWCmuDkjaysCP8dkKgLo5sc+tWGc8o2 RQPBI6GmZXoRNnOhea7pNJ2lJmoeSvKEMnM5XWgWoZY2phNMje5+/N7neW5ehpBUkt6MUq3j NWq5SkqLSFH4qQw/QUKw4sTLLG/QG+toqHUmQeWMmQJ9TTOC1bUpIaz09NFQ9txBgH4ok4Q/ xnUC5nrtQrBVzJPQdr+FAPvDfhryMl0EpJurBNBdMkDBcHM+BUXrLwhoSZ0RwtgbPQ3TdZsU zHflkTBQXE2CLT8Ueg17wfHxJ4IeY4sAHA9KaCgcNdDwNdOGYLTbTsLTtHwExg4LBS6nng6V 4qbqSQFuLf4ixAZTAm6s8sU5llECm2qyaWz6/ViIrRNtNO5/4iJxq3lFgPMyFmn8a+4ziZc6 xmlctrAswMamcRIPGnqE1zxviUKieZUykdcEnIkUKYbmvqH4UvekAlcakYqcwhzkznBsEGdv NAu2mWaPcxbLGrHNXmwgt2LvI3OQiCHYRYqb07t2QntYFfe6oIHaZpI9yo04xnYKYjaY6/6U Qf0bPcLV1ndueYZx3/LvrVHbWsLKuKVcI3qERAbkVoO8lOrEWLlSJfPXxiiS1cok/6i4WBPa el9FykaBGa2OhXUhlkFSDzGulykklDxRmxzbhTiGkHqJ088GKyTiaHnyPV4Td1uToOK1XegA Q0r3iS9H8JES9q5cx8fwfDyv+X8VMO7eqYiLijjmuXDuSt3Nzqu6yWmf4vMpmzq7KCh7vaNw t7qz9kPWsHUyaJdjSjcSNtDewhYtWp0rpbbOweByQnajfS3kYFws8Wpa2SqUz1+yXJ8IFEfH WN45w4jW2fLcixv1P2yz/v1WtzvLHsXPLpz0kR3e79Pg13govGz0bf/ppYDvUlKrkAf6Ehqt /C+bozxnugIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 69EC220008 X-Stat-Signature: fwwgi4ep1hsm4buqqj4r4smkd8wpxcug X-Rspam-User: X-HE-Tag: 1748399370-586787 X-HE-Meta: U2FsdGVkX1/7VLpNf7a298QVqbSXdbVZ+bVUzYme0X1vr/QqeiJHJq+bOm6bt7pruptVRLdNlmrLtdHhlZn+hBz1unXCSrsucmjoLuRa3wgph+o4Svx159Bnj/qD+gnuICyjXmIiW2yesHzHMdNQTZ5ALXAoARSKF2GBKgAhbOTo69MsPN4vXeUDm4vuF+s68Lh2ANhVN92UV27B79GaN160i3Ndsy+Gxkj+QN+5u3xeUQH43ttIGg4Bb9hjlTIuw8xVP9u4a6A0GT7DKkpRtPK0YteGcmhoB5l5g46yXwGr9/oX43YZdZnsWvNj6YY31AOvihr3hA5WX4oTvZmWDiluOGrzYm6jSBtJldNcEGDE1WXMkrZIwjt8klhXx9CmEplSyCIt7gLHXiXUGX85jwI4JVAgqdmGTJkukygnUY4hryAoOaHPhak42pDfrtGiABWw8Ls35COVkXVIBk++AOPeFGdBhiN0VcXfINfzNKrwgjVf6FVBuljMfZbdx1Fz9BSaE47w/3S3mf4Jm6jb4Q5RJNHxBHZn7aEV3Av0e00/A10bu/7NLaOVqSm1oUKLyOyY67LPdAO1U9EyaXMCYXjm1EEAYP727ihXccVFTuiNDww7Pmlh3qhSgYpUTsQNlwCPfc0xQfbReBbGOpOssV6EFMCuEhBKUDZZMhTjyRSZfj0kdJRci9DQl0JViLW1Ll4mtMwmuu3uMdTee66s04gXJJgkLu/LDG8e4Kvm0057bv/gDbWjif+q8lGftIo9zFghmzodEX321BxST0ijGjU/DUgrJHl/6Afbp16AgqvtpmaF4o39DEJoFWK6fUBEuxwWe2wMG7sGmH751yZmU3ez4eRI1tFtKNiaLdohghkR+wyjTbjM9s24vNPNfwVz76F8qcGfdhdI150MYVn6ZRcrurqIfll2pnplAFNW1h59zcK44fNMBSQat5ZsVVv2VrWdtP2hQX1MucDOMVE AehzomwN Ng3ZnspN62T7MLLtYCmyl/7SalFhHzNoziQ7UsWKywr9ptRRiDzdsVCDwMC7b+QzoVqS9QadPPXvmJME8sBwTEswCYouiQ845NkMWbNIWOysRQVBPtQW1XS1kte80nvdnWUzE3JDelKysdqE02mzXiMF9DhzHWHTxR5ELgRFsGxyc+5lrXGqOX5ZObf4+DIU5KnIxMCqvoLvEUUM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry Reviewed-by: Ilias Apalodimas --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 93f2c31baf9b..387913b6c8bf 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -437,12 +437,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1