From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C07C54ED1 for ; Wed, 28 May 2025 02:19:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 681676B007B; Tue, 27 May 2025 22:19:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60A636B0082; Tue, 27 May 2025 22:19:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC076B0083; Tue, 27 May 2025 22:19:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2B7CB6B007B for ; Tue, 27 May 2025 22:19:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C7E58141D8B for ; Wed, 28 May 2025 02:19:51 +0000 (UTC) X-FDA: 83490710982.17.21E7D1A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 249F2C0002 for ; Wed, 28 May 2025 02:19:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="h1Vn3/Ja"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748398790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3n6c3Pa1B/1iOEKwLR6sTO7AQGDH7SpZ3zteBKqbHHM=; b=fl2M+GSE04S79Yh2QiZZwXmXCH+gr2WwB72jRAW7R66DAyGfaWUYIR+JcdGHSsRlN5gTDT bXcL96+QkoWx4n+iiEjUg5wywM98hsmRFUgEuBI/qiyWk49OxuTUpcviXqWHVzORMss4HU ueYVP2NLn8A6fyirID8z1VeW0DPtkZA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="h1Vn3/Ja"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748398790; a=rsa-sha256; cv=none; b=1rahBvxMzVIXXghyWzscXghn6dpz2uFYC9Sri9MKm2qiXoJtt8K97FutSSh/s6Nnx3VKMH GdvVEUH4ec7WFX/wjll6T/JeITS+R4dEi1Si39oOo137zpxfVWIal8W/BHvCvLnSi+z2Cl Xl/j1OH9IfP9icKAnx7TYAoFv/mUxPw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 71103A40395; Wed, 28 May 2025 02:19:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D80BEC4CEE9; Wed, 28 May 2025 02:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748398789; bh=wnd6Rrnm5aeOoUpYHWzLgfC1qbw5hFZzHSb6vnzyLwM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h1Vn3/JaHSDIum15zPYqmphsscb2RRCjFWeoKCMIO6qunFfFQkoNknLs//HpDBcRm PTqV791R1AK40pjejZLlK+Xe1iG0ZMzRxGqLqF6Y1XVL4XhV5Zp9o5OT76FLyifB1s e+lwBvf+q8UGngto0tr9NDLCRml6E9jcLgRIv0VE= Date: Tue, 27 May 2025 19:19:48 -0700 From: Andrew Morton To: Jinjiang Tu Cc: David Hildenbrand , Zi Yan , , , Subject: Re: [PATCH v2] mm/contig_alloc: fix alloc_contig_range when __GFP_COMP and order < MAX_ORDER Message-Id: <20250527191948.2ffdc5d432dbacedeb473965@linux-foundation.org> In-Reply-To: <4023fc44-aafb-1895-e6db-b27f11ddc7cc@huawei.com> References: <20250421013620.459740-1-tujinjiang@huawei.com> <0a6fa00f-0e48-4101-b2ad-23c9a964b740@redhat.com> <5CD028AA-64B7-4A93-8679-AAC5869B8C15@nvidia.com> <0b4308e5-97ed-4a82-ac8c-a9061cb4d5f0@redhat.com> <4023fc44-aafb-1895-e6db-b27f11ddc7cc@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 249F2C0002 X-Stat-Signature: du4h1t5h4yjmeqqiph7ti4smqxmcod7f X-Rspam-User: X-HE-Tag: 1748398789-366196 X-HE-Meta: U2FsdGVkX19nCdH0fye7sRoTD6EmAahu5VdY3pyVip1TjYmtxXawg6HOSoQ+bXTgyMVsYbYCDa/oX12Hh1a6n3kar0vIqIX+k8VyYn2SlCk3iByVHEGg10//a7KXjwB8YoNvcl/mj94+bDK98RMzFbJi5YBVaotKEOSySYRvz8/qNjsgJStD6en65BNw+Xy0J+kQlhcR+79JO2IYWOYmLpNBekkiV7K4KyrZiZEY3XqTmK/XRJ9BN0jPB/yvieVx+svwuB6SJOIAzvtuvZjznrBhnOernIrzgskUor/nSpz0obOj2wibEH7WE5IalleVqmoGAu2srSA6kiijqB9F2eUads1RgV/THmsq7DNEBQ+cffyFRKcQKDMeh4dcFvNKFGL9egIispq+SbZTHF9hXJcoB63hCPGcdp3BlaPf3nNCqWZj376Bus3KV/01oYBQWVm5Qccv9qoq6DV/ZHsbhn1hwdTyZjJt4IQJ5nGNx0/sFMIweITRYc7c8/3q8MO1rNKUbFNCKnfTrgeqDnCQLEAPGeU8LsKaR5/R3qMsSSJmNKXC9yleTg5FO467eGCL1EoB8F2anERFrbfu0uu64LOxPcSqHP3ff3SSFqgcoWSR1SIA/okWjXciHJFQ3UotwOzE2bZDcaff/DAS1clCTYTf3JVlmSqsMl2LnoDUZFhwCnccqEJfOcnjXrQFU+ps3njmMrDkZ2a7CAo9A3fDiZ0dZ58ynzne7qiHX07zGyvgmLVf9vCXnEOFMZTqFEM/8Q09FvGCxHXRYvgeI11Q0rCpkPX1+GNj+PPI6YEefmO+jLMus3sfs1CIaO6V7YvwLnwdfAyZpY6ewe7ca+1QC8EPiDrI2TccxYx0cBQR5WgSwapRLW5DnnKl4gpk2Kaj15CheIo+uAfUnfHzrytXoMv4lJvRufubMoOQ+zxgBvQPqrL3yluo4q703HCN5StyGD3xofDt5rGPpQj8uhz HhRzrUN+ LBljPntHB+Z5YYA2RGVk7KK4r0wAOJ9c18utgMr5Hu3O0J0o9t3hF1FHDstleOSf5uZcIaLCKTFCppFLYykKvvoTVMYKJ0l6lU+qWyxHV+adkeRW6Kn6Egp8HhMh1u3+B4BCspXsf88Hy5Y2qH3WkeotSfshzkOQhtWLYsNmVR//0xu9u5Byep8ShWQnAlpaCAO7oi7kId1qIODLXfgsisyWKFVNRBrZ8jVKgXNT5JiMY9WCO57jah3FuNJZT7qa6wl6DtQUVkmA6+GvrDmOyT4jSw2VSK4DvCNZxU8iqUFhU7YPeZ5uE38qkC3mDrPN8B7aCVUSR8TBIRSFricdMhsRFgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 May 2025 09:13:31 +0800 Jinjiang Tu wrote: > > >> > >> The change below makes the code cleaner. Acked-by: Zi Yan > >> > > > > Jinjiang, can you integrate that into your patch and resend? > > Sorry for late reply. I will do it today. > As far as I know, this is still pending. The patch does address a WARN() and it's cc:stable, so it's rather important. I'll move the v2 patch back into mm-new and shall keep it there to remind me to bug people about it ;) David (and everyone!), please don't be afraid to grab someone else's patch, apply changes and send it in. Stuff happens, and doing this is well within accepted processes.