From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60633C5AD49 for ; Wed, 28 May 2025 02:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D97176B0083; Tue, 27 May 2025 22:08:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D48886B0088; Tue, 27 May 2025 22:08:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5E2D6B0089; Tue, 27 May 2025 22:08:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A7CD16B0083 for ; Tue, 27 May 2025 22:08:15 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 461ACBF957 for ; Wed, 28 May 2025 02:08:15 +0000 (UTC) X-FDA: 83490681750.13.E62FCB3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 91EFF4000C for ; Wed, 28 May 2025 02:08:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=h2uilgXu; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748398093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XWTmjQdWvh1Nx6Rpe5XwcR2P01sarCktSez9QYQ6ZMI=; b=b0p80oQPPi7EaE/V4cWk99FgOwHEB66EBvp8LWstzks8DWFDaxC6UioDvEeJIlAUwfW7zS o8wnrtB57oX2C3kV4GQFxiTuG5iGHdDalE5Vru5gVmNL2tWCZxigorezijh6UpPck2vjMH AhXb/1oYCesfKrZ+sbkEw/Byi9V9Fp4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748398093; a=rsa-sha256; cv=none; b=xyvug+aqCtLTCCZ6szTwiIRIXdOLJl5byx14lHYTIrmvEAMCUO2wLx282EmLNvX05bwClJ tuFKjHo0Q3785mxyrWBfmYjJvsU1RGMVU2PHLQjq+jT3b8VKsMhVyWQvrvQC1JCfCgcV9m 6DqeDpxxRyo/MyL237/ypGvlf+JOgEY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=h2uilgXu; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 817F25C41E7; Wed, 28 May 2025 02:05:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC6D5C4CEE9; Wed, 28 May 2025 02:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748398092; bh=QToKGrlvFUYinwPi5NW51sedo2o3ko9Iy1rwyPVIWos=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h2uilgXu7mAlYkZJqMoAFSxXeLzcpbOHHnEgdHyFhhn/0Tss3I0KeD7B0wD7pHm8D wUGX3hdEOTtvUUR8GWnw4ojq6l+gm9nEkEFM1d64XoHvcRlWSz2aWZSVBDFu7yQQKz busFYqMMtqupeErVIcql88N4cMQWlJ0mZEw9tk0Y= Date: Tue, 27 May 2025 19:08:11 -0700 From: Andrew Morton To: "Vishal Moola (Oracle)" Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org, osalvador@suse.de, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni , Sidhartha Kumar Subject: Re: [PATCH v4 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page Message-Id: <20250527190811.08e3c035f30187ba852f1914@linux-foundation.org> In-Reply-To: References: <20250505182345.506888-2-nifan.cxl@gmail.com> <20250505182345.506888-4-nifan.cxl@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 91EFF4000C X-Stat-Signature: d8hcaz5hnbrhkyzm3thms6u6o3wsokzb X-Rspam-User: X-HE-Tag: 1748398093-632182 X-HE-Meta: U2FsdGVkX1+w/znIxmpd9YVtkfdIQD38O45rLTU6aSr1NEeb+CHBxUvcU+HLLgvf2Dnkq0lmX8bfpc42jfsYvLzImIxz4vpiwG//LjqPzjo8vOuYIGxnryi5KQTK5uadTilL39KeQ89zWmjPcmc8+ybfSn4LI3b6MwAmLMA3FHG+rsw4uEvOEHXfZkD3g3VHPlHBWXfhduAzUIFA+Smb7mfdQUXn3sgqVHcqwvjquYeStGeftm7C60Paf9yqWSoTGeUT7Np2v5UKcg1Tu1wy5zbc/ZigxUwxtwA8ex9k4HJ+v4jIBxU8jbLVr0dtVK4rhlyBQrNkNUG6Obe7s98g18kd6qinSjaWaGcff1h0WyZq1cx4h+9lSwN1z+dXu0dY+CrdS5GujAfsF5zbHXtEAgV16WHQhn/QGbKjZa+OIMR/VuEEQi45KjXlXS7fUf3yXwsB/dhSiAyMbvn2YFMdbZGRYkdNl2nCpQz5Kb4mUOkt2gozIGBe2HmhfwyjZARsA1KcUrvAXqsPq58QF5O2fZDq4sw/tTtNtzTv7MZII7exThLS8Lh5T2dLzZoFr27ZhsFqpJmySSieEqhN1BX9gPC0SC/B+707Nw5FmnzNvfIuAcplvjh3qPbi/6nA+KofJRLMLVfzZ2LVBoQHIsx2pKzQ7ZMqK/1H8j7vmUKCiwPbfR3oCsxAZ9EJ/H8zMpV9+Ah8ZYlqT1M08/N4vORsrRqIBPGWZpkKkpSueVbWXudSxyKPB98WOrixpF+J+fGUXRRkZNpXoijwA8b21jzgvqujPpY/P8HjEO7k2sxTDKssL/BiBAiItpFh7+DIXgF9/zAdGSAxeuG0kYghBwWGTtOgzLmAZISi4vU0u8KsXAz4+h/BCW4kqiRIp5oxBbO6ws7AfDt1FwnacwdNJDo6TZbIOW/0mVA/Lz/Kk8KJ4IWmTgH1nxomnCTHffz2ji1CwadOw4cHpiFWx4kLkMv G4vSPYHu 7/Yef7m0E94uIBO775I4/5dVYZU1IRF+malkHG7uVObZ9aUWhN+Biujw7E/7FmXoiHfQPPxEBA26MIIB+xoAV4rRwlPnWG41dEbnNBdIwp+RCy5h/rNkadiz7O8h5ZTa3OC85EufKcc+/On3AsURbZrv9ibjIO2jfsOMJ+ydLMZR4bug4kLVcKORb6AhSBXvn+fxEkzLj2QR2rm2dCFev1VAxSe+JX78ycxOdDzKA34K5HpU762YeQGWGorxftdv/zGSPMhEWT4HROG/RXvNxwzY7n6xKT792RM0y+wqVq/JTiweKGk8pR/NUZn7p6ZoWL0Ex8yl4nQxpZMUlGBlI5RfywjBtqmy0VeZrfQaKPdt2Q2yl5hMKDjXWapMyF+DdmcjRajlgMbA95OSFxoGsd90kpT+8wtIRxZ7j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 May 2025 12:59:20 -0700 "Vishal Moola (Oracle)" wrote: > On Mon, May 05, 2025 at 11:22:42AM -0700, nifan.cxl@gmail.com wrote: > > From: Fan Ni > > > > The function unmap_hugepage_range() has two kinds of users: > > 1) unmap_ref_private(), which passes in the head page of a folio. Since > > unmap_ref_private() already takes folio and there are no other uses > > of the folio struct in the function, it is natural for > > unmap_hugepage_range() to take folio also. > > 2) All other uses, which pass in NULL pointer. > > > > In both cases, we can pass in folio. Refactor unmap_hugepage_range() to > > take folio. > > It looks like unmap_ref_private() is the only caller that cares about > passing a particular folio to unmap_hugepage_range(). Is there any > reason we shouldn't drop the folio argument and call > __unmap_hugepage_range() directly? afaict there was no response to this review comment. I'll proceed with the patchset, but please let's not lose sight of this.