From: Andrew Morton <akpm@linux-foundation.org>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org,
osalvador@suse.de, mcgrof@kernel.org, a.manzanares@samsung.com,
dave@stgolabs.net, david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Fan Ni <fan.ni@samsung.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH v4 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page
Date: Tue, 27 May 2025 19:08:11 -0700 [thread overview]
Message-ID: <20250527190811.08e3c035f30187ba852f1914@linux-foundation.org> (raw)
In-Reply-To: <aBkYmLOiTZt1sLr_@fedora>
On Mon, 5 May 2025 12:59:20 -0700 "Vishal Moola (Oracle)" <vishal.moola@gmail.com> wrote:
> On Mon, May 05, 2025 at 11:22:42AM -0700, nifan.cxl@gmail.com wrote:
> > From: Fan Ni <fan.ni@samsung.com>
> >
> > The function unmap_hugepage_range() has two kinds of users:
> > 1) unmap_ref_private(), which passes in the head page of a folio. Since
> > unmap_ref_private() already takes folio and there are no other uses
> > of the folio struct in the function, it is natural for
> > unmap_hugepage_range() to take folio also.
> > 2) All other uses, which pass in NULL pointer.
> >
> > In both cases, we can pass in folio. Refactor unmap_hugepage_range() to
> > take folio.
>
> It looks like unmap_ref_private() is the only caller that cares about
> passing a particular folio to unmap_hugepage_range(). Is there any
> reason we shouldn't drop the folio argument and call
> __unmap_hugepage_range() directly?
afaict there was no response to this review comment.
I'll proceed with the patchset, but please let's not lose sight of this.
next prev parent reply other threads:[~2025-05-28 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 18:22 [PATCH v4 0/4] Let unmap_hugepage_range() and several related functions " nifan.cxl
2025-05-05 18:22 ` [PATCH v4 1/4] mm/hugetlb: Pass folio instead of page to unmap_ref_private() nifan.cxl
2025-05-05 18:22 ` [PATCH v4 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page nifan.cxl
2025-05-05 19:59 ` Vishal Moola (Oracle)
2025-05-28 2:08 ` Andrew Morton [this message]
2025-05-05 18:22 ` [PATCH v4 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() " nifan.cxl
2025-05-05 18:22 ` [PATCH v4 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() nifan.cxl
2025-05-05 22:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527190811.08e3c035f30187ba852f1914@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.manzanares@samsung.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=fan.ni@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nifan.cxl@gmail.com \
--cc=osalvador@suse.de \
--cc=sidhartha.kumar@oracle.com \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox