From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203A0C54ED1 for ; Tue, 27 May 2025 17:21:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 665CF6B00A0; Tue, 27 May 2025 13:21:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 616826B00A4; Tue, 27 May 2025 13:21:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52D076B00E5; Tue, 27 May 2025 13:21:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2AC4F6B00A0 for ; Tue, 27 May 2025 13:21:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 624261A1196 for ; Tue, 27 May 2025 17:21:15 +0000 (UTC) X-FDA: 83489353710.28.66227B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 5615720002 for ; Tue, 27 May 2025 17:21:13 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YK1TZjy8; spf=pass (imf13.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748366473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wNmQxhzq/FF3MG71l3pLSG1OCC7OzHf2ouNx32BNQ6Y=; b=Gls9pQQL+e0UNMFWF4igIJ4EXEbczE0welGngHLaZqw7GUDPznhteRS49muHo7hIToAalG HzyAtHSNKhpeWYr17rKDzaHkPh9zM740L/LJZFIzjJGVCy/pTrn7gXim441m893EqJ61Lv UspQ+PrF/vYTzEIHH89KQp6qgKtf4DU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748366473; a=rsa-sha256; cv=none; b=UM/89xsgOagwy3XTURZcNsQGDOuJp7yrFW3Ltzdo2p7CfxZQUX5rQUQIIDmMdhfpnsxNZS jsXyUGASDVnE6IlKGDdNK/ohqqNoAvR3i/K5Ykehj/xf8HGpvwhfr+gA9zEde8ucASrVg9 6xLHTYqG+a0VB/Kk/06btbGtqiZOQ8g= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YK1TZjy8; spf=pass (imf13.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748366472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wNmQxhzq/FF3MG71l3pLSG1OCC7OzHf2ouNx32BNQ6Y=; b=YK1TZjy8bwtkMUaJzROwluOjgIQ46BA4rF97wfcEooeJlcZVqsd/LeB4ZiYPsWBgs6GWSF wXBwUpGXCMLQoIsxk2ITBk0bVX7idsTfh272uHRS6loDASkn1WxCe2z4JmWBuAk3JI888D IojO+1yMSgDwyCcM9DwMNqR5QIgA9QY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-qxPJ_SE-NSeBdhZYWjxwsQ-1; Tue, 27 May 2025 13:21:08 -0400 X-MC-Unique: qxPJ_SE-NSeBdhZYWjxwsQ-1 X-Mimecast-MFC-AGG-ID: qxPJ_SE-NSeBdhZYWjxwsQ_1748366466 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BED1119560BC; Tue, 27 May 2025 17:21:05 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 6BE851944A89; Tue, 27 May 2025 17:20:59 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 27 May 2025 19:20:25 +0200 (CEST) Date: Tue, 27 May 2025 19:20:18 +0200 From: Oleg Nesterov To: Pu Lehui Cc: mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Message-ID: <20250527172018.GF8333@redhat.com> References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> <20250527142314.GA8333@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5615720002 X-Stat-Signature: upjhy1ci7hs1sai4jiw7tp9wo6rqnrq6 X-Rspam-User: X-HE-Tag: 1748366473-754894 X-HE-Meta: U2FsdGVkX1/G3vXpmKvEOpJ4xh1RVCRzctKLguLcMfv+t9NfDFBUVgzDPTUs/l17h1ubpWC8hC+SpKyhDGoAVtM6x/8TDqMXMGm2gj8D1F0adki4Vgg/cGglr4tPwObqvHo20na8y8GrxkXMnjZH7depSm8ezNqYhVvQJGwjMD9IWBGvsggAwpzTBuspo3z6HgxYGkRWwc+F2skCLoxTRdT1yoje8aD1smJcI+DtmtCooxlN0HtRxQdduI8A8U9HRb/xbWncJx7KX59K3AYYnlhpmoMgcIOmWoRDu7ZaSxX0COcwzkEX1WV55A9jVRPcsZpgbWnQiQvu4JKCP9pMz6gw7SPM11JPT6xFZDyEbGQ7l7Ndl6QGp4Za5V3FKE9AKd3H7/CRm2m1Y5CM2vjaK0IeTYE4kmVYyRw/hGvvMIAAJDW8OwIb56UgTOsTURE2mIeWtHPDpO0eW6HniwyVrvu6YoYAmQp3r8ZN+HVhvWsZaNnS6U+2V8JyQy7CsrqovcaVXhXrCiTlTvxrPAXsUU7ANrLtGbVbZxNbPmoxS6Qumw9fCPKGe6ScN+0yLJeU/of3UBVWTu9UtX6Euqx5nr4jV1cxCm7/EGv64iX0QbrLiW8ArRErw/rTyjU64l5+uYvFEsRPLUZna+QvGq4oVrWFgOGF3nskJP9+KLiU28gi4PQ6mIqQ6YuTJ53Py1vGXwugxQr+lo1qMczTCa3Aa6w0T13yR/5Mcx/yoRLa/gI4/z09+DQKkpA5HQ2m8VEyeMmHxmHyc4KsQViK8nFYDJNg3SfMLGCGvHVcsg7MOVkvFGjMbPSKh84bg2jfL0l8G1o4c+JLkuFk9mQLlETFyz0E0MwL6G/epNJald23YYnDXi59duqgtPzGQ3ca2FO5UvqCyAusH/3Sow2V8XWk1vjrawYW3xm78PiIK5sJo8QH54yqHezVoUtfMXAMRtisqdZ1Z2oRMsJhhmgd5rg 6fAEH+EQ HaeYK3WxS1e4HcdlZCjBKQ4PGvzJiWIgoXqrhEOmOXrMdpz1DJ/ITKnhRJDuKWBRsHHucvKo5jg67lw3E6kvwZkYqTWC2/l1nsoPWSosj+g7iptOOZOF3SFgVJR6ahy+DX1HPi7a7RutySm2hcxbRRpuRPH41n4PO9rlZQ4erugoMo28D0FWGDn0f0O1q9Shbg43aaXLIFea3jx0c2TmybN75ERZxbb/eKwV102y15xZnF5gRGcROh1XLoD2m9RvatjJBz5oNBrgr4X6dWDUbQPUeLC+V8KWXti53WnO/0ShRzweFTFeGcnDFJrVpsJWeYkvd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lehui, On 05/28, Pu Lehui wrote: > > On 2025/5/27 22:23, Oleg Nesterov wrote: > >Well, I leave this to you / Lorenzo / David, but... > > > >On 05/27, Pu Lehui wrote: > >> > >>Fixes: 78a320542e6c ("uprobes: Change valid_vma() to demand VM_MAYEXEC rather than VM_EXEC") > > > >I don't think that commit could cause this problem. > > Hi Oleg, > > Me too! I was test that before and after commit 78a320542e6c, so call it the > `directly related commit`. I feel I am totally confused... but _may be_ you have used the initial reproducer which used PROT_NONE in void *addr2 = mmap(NULL, 2 * 4096, PROT_NONE, MAP_PRIVATE, fd, 0); ? If yes. I _think_ we should have the same problem with or without 78a320542e6c, just you need to s/PROT_NONE/PROT_EXEC/. > In fact, I think the issue was introduced in the > original commit 2b1444983508 ("uprobes, mm, x86: Add the ability to install > and remove uprobes breakpoints") # v3.5-rc1. probably yes... Damn I don't know ;) Oleg.