From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E58C54ED1 for ; Tue, 27 May 2025 15:18:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D4526B009C; Tue, 27 May 2025 11:18:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ABFB6B009D; Tue, 27 May 2025 11:18:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C18B6B009E; Tue, 27 May 2025 11:18:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5DDBD6B009C for ; Tue, 27 May 2025 11:18:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D65431D408C for ; Tue, 27 May 2025 15:18:14 +0000 (UTC) X-FDA: 83489043708.04.C5983C4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id B8F671A0002 for ; Tue, 27 May 2025 15:18:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKWqNBYq; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748359093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zAs1l5N8QR4S+KMnC/1DQqVjrRQ0/Ijhuvh531ty540=; b=JDMtwAvCPAqRKIuWYFlLbkubfm9R/sQ0n5BLfNkcT21jjKPQJbk2WoCdRe77yk7VcDeCFn m4S+sQlFs4BfhZNEJb6NoqHsVd8RFem5NLFpnk+EL7BhYOTkvFLLTdFmUYhipmWWROGKjw oOPZxPgf/epuGB4Sa0kwWI1qyczrUtg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKWqNBYq; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748359093; a=rsa-sha256; cv=none; b=3e3UkCZmFcraDnnqAy8hYS9wcb8KH4RaKc9OK8S/H/1jSyQxrQHqvpzcbGdAN7X48Lqzwq N/QFOfzvqNMrylFiRmXtmq5KNovCkCGWXqMRHlp3w37MpHikpc4RBt88v78KhkKskp49eF eazt6xomyRbS3lYSpw0ICVBDO4ppnDw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748359092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zAs1l5N8QR4S+KMnC/1DQqVjrRQ0/Ijhuvh531ty540=; b=OKWqNBYqylF8WVGoXor+FM5J1hv8XbV7eyZqRF3C2J0oM273CVng//2vXGTomrhdE2BKol n0rkIU9u2OiPjYwZBmJVzJyHaL7OwzsL2ujQnSaK/FBW6x8WKBMfwcwLeRz3bq7TPxnp0z Tk6sH9a6TEftZBdYIGHBIq1mTdbN8SU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-S7n_sbMJP0eY7lrl2XUyJA-1; Tue, 27 May 2025 11:18:05 -0400 X-MC-Unique: S7n_sbMJP0eY7lrl2XUyJA-1 X-Mimecast-MFC-AGG-ID: S7n_sbMJP0eY7lrl2XUyJA_1748359084 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E9FA19560B0; Tue, 27 May 2025 15:18:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.4]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 2637519560A3; Tue, 27 May 2025 15:17:56 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 27 May 2025 17:17:21 +0200 (CEST) Date: Tue, 27 May 2025 17:17:15 +0200 From: Oleg Nesterov To: Lorenzo Stoakes Cc: Pu Lehui , mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Message-ID: <20250527151715.GC8333@redhat.com> References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B8F671A0002 X-Stat-Signature: uis9wkogz95xjffus31d7rdpc9gufakf X-Rspam-User: X-HE-Tag: 1748359092-142242 X-HE-Meta: U2FsdGVkX1/kzhT17K7zpY7yLQhRUDgEFTypADg9fCMttdlU8g5t+zrzL6vlaCjFdxV5+WTsSU2D7eqn9ymNjB5i82WzSjzgwCzirPEdciA2txPx7u7eZJZ+cZ0j5FBxu8Y9Lj2T39RwbA7lVV5AlNCaI8e29aAH7J50CVatZ90VqGOp/cY8CuihS7uh2mXLgj8PLc25RAQYwqR8DQdc2onN57xULLTxedvhWWoCAMzCNv36IX+lGDsUcr/NR7qrUgeGIMzPIwPe7cNnqfkG7ZhMyLL8W7vgN3TDb1xVLPkTJfNxVnZSg7MEW2Y6Clxa/9E3v+l+zeINqnZ3ylTWxz4CM2k9GBAr9jTX8TK1fLT7xauoHI6IFUYH1SDBU35bBNi+QuT4CCEPESkIG0lbogoFfTYLBC05F8QcbY9QIDWSkcxCmcqo+RKVJ2fntU3BcI2b54ju3/1YnLgD+Zd1nne3cvWQF3M+flThP1dPLWE/O607gtsBOwHPo/1JvcS6QkmtIRE8zMfVyqqIl+aBMS0W5+G6wyF2tT4nnmYkluRDx0z8XBPJSaDOs0vuNPXVaacsuNutGW7AWZkClxqZEUfpP4TIpfK1vXaKEEJh0VvLWkJfGsKpMOy68I8DVrVCK7O2Bgu+epClfaexWnQX6Mg/w4qjXw3axVaXtD8lY14qpz86bCGitzMdlGyuF6giD5rjpg/7zp9D6r6t4R4rj8hJu53bGzH6/glPkFXFv3ehJYLPmhXrZgSXxIdqrd4VxbDF9HEC1KAxwc5haunaOD8GNpdPUNa0heWrrLJeeAMRHz6QT8d9DglzUteVJPkwlCIW73FuJ9zyY174TdT0XH6aBRQtXk7H9VKdVimtPHs4q81tn+sb0IWGxD15yJASa6z84XOBzdwgs1SH37ckp96cd1nt54kZfnuOONKviy3iuOV9l06zyi73CbQWCUs0CtLb/IzckGtv4/whRyL ElCdC8vn l8fGI/hgDKULBXeZuahdCcPnZmeUyyl7M8KA2QNoh5nXRhRTgxxJuJ8el6YMz7FFiCEGguWx/wCORJ44J6CslpQ4cFQAY6LSLnecGBIIDIzaczb7/AiHhe50rFQMzPa0g+uZN3+OCwY6y76RMAkMlhNll1YkV4RAXwLMdFGNNZMRlI1ppqtts4szzvJZawxk0SfGtKIFTOFyrYy+ZRGF0fFE3nQ/xenKQhgfyLkBLcIKvRw2bGPsK9HErER45VGlPGkwLnn5A0aUetA9tJECQZ6Z2SlgTE8IQAfh4Lrcsv4Yq5tQlB/DO84Q72PzMTh8M25jj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/27, Lorenzo Stoakes wrote: > > I am by the way assuming that uprobes work by installing a special PTE at > page offset 0 and only in the case where there is something installed here > do we need to worry. perhaps I misunderstood you but no... Basically, we have uprobe_register(struct inode *inode, loff_t offset, ...). If / when a process mmaps this inode/file and the (new) VMA includes this offset, we need to call uprobe_mmap() to install the breakpoint at the virtual address which corresponds to this offset. Oleg.