From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACEFC54F30 for ; Tue, 27 May 2025 14:25:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEEFC6B0098; Tue, 27 May 2025 10:25:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC6976B009A; Tue, 27 May 2025 10:25:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDCFA6B009B; Tue, 27 May 2025 10:25:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AD2136B0098 for ; Tue, 27 May 2025 10:25:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 37982140DC1 for ; Tue, 27 May 2025 14:25:44 +0000 (UTC) X-FDA: 83488911408.14.81905BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 4F0321C0012 for ; Tue, 27 May 2025 14:25:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cohcASTe; spf=pass (imf20.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748355942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6m6fUwYqNmUe829wAUeva9RRwS1btD4mQ76FCpQtbQ8=; b=WcgpaIw0yYkLIBVekCsa8E5+ci4DpDza7Pr1VNXlopAI4z+2g3Gd8EDHZV7ypQbcSJJHus r+zz1xnu6gScIxsDUtcwUmo85/IcujjhDxK6FaBIQZe+tTNJGdAD6eYW5Hhm7JhvDu4wu/ RCZVTeeiPfQjguREOeuiFFvqOOdn0S8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cohcASTe; spf=pass (imf20.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748355942; a=rsa-sha256; cv=none; b=1fbHdaZOX0zjzt1uPdDnx5evuoLc2bgUHvqKdOO+BjFzbVIdkPX7MB/E6+/KWdkK2nM7nK jj6NSMsH1lX53FaA7iSlxH3XpS0xCvrdE0WpO/U0FADIEpPfAifET+ihGXXlhh1ka1UpXG Ag1ajMCjnlSKZV4ejvjBScRnrL3EBTw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748355941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6m6fUwYqNmUe829wAUeva9RRwS1btD4mQ76FCpQtbQ8=; b=cohcASTepKkZbkCR+Ll+3SvYO+63wzkJkKNYNyJ1BeXvTFXjrNU7ZuwaCxJWmMQcqnLlj5 DzndzbIzYT3Ui72dr6QBKHR5G83dUFrOcsYOYGYBFLktAnVS/4jLUf1+D18Ty+IUP63bE4 /P3b0XNLP6cvb8sxXDY9bud3J5bDVyo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-5B1KHdJfMTOPo6wkkgDXBA-1; Tue, 27 May 2025 10:25:37 -0400 X-MC-Unique: 5B1KHdJfMTOPo6wkkgDXBA-1 X-Mimecast-MFC-AGG-ID: 5B1KHdJfMTOPo6wkkgDXBA_1748355936 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B425F18004AD; Tue, 27 May 2025 14:25:35 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 91C1F18001D8; Tue, 27 May 2025 14:25:30 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 27 May 2025 16:24:54 +0200 (CEST) Date: Tue, 27 May 2025 16:24:48 +0200 From: Oleg Nesterov To: Pu Lehui Cc: mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com Subject: Re: [RFC PATCH v2 2/2] mm/mremap: Expose abnormal new_pte during move_ptes Message-ID: <20250527142448.GB8333@redhat.com> References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-3-pulehui@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250527132351.2050820-3-pulehui@huaweicloud.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Queue-Id: 4F0321C0012 X-Stat-Signature: 569ei45tc4rs619nqiqc1jbsiebc18qo X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748355942-699202 X-HE-Meta: U2FsdGVkX1/r0n0HQnzTUNXDssT8lGmhw1l7HH10cOa3D2i9jb/zHtVG96XoyUy/IruloRj8qc8kX9LbGNSprC1gLWhtEeNOjHBM4QT1h8BT6YXl6AKlnhXOVhow+g6+FeKfkSUgdJbWegUfsj4I60VfWoykxU2G3cnZ9ZlLbluIDgYNDgS4StvImMhab7Cv2OgXfrzYR/htFHxM/Ym2xHvXroYQ/hhyrx75Llrip0fucvlraGhkbSjkpn/WF8Me0ymB4S71QAlAYcOJQhBpAJ80YGjse9Sg/nhbLVtjSKUs4T9Ci1aZKPV0gekLsE3LTKOyb5bIrRBSl5NiNTj+EI08J4/tgToX0oYVtOVvKJSiKu01P/AcnhF1d3ET2kN3cjdK6VoKWATRMyV7PXqdcRLsrS9ytIabciFyupA02rsngAXANchnUnA7wSFg5PGprItW9WAsET08vw1v1Mfp5JhVp2tBaCEaG7FU78lgHc79Vh9UcWnyy9TetV9qvSTiNwYKxDPeiezHqWdhy8p2JImJgpJ21DiqHCIzIXWM4mqTuwOpiMzYYDQmKgkE7lQeJT6yhKLN933GvmV6qBjj14YrlmU1GfYJKbly/0usm5E0bL/URyO7CTKOxSga9dtAYdNldpj8fDJ2IB98J86LTeRd9mwO9+TRxxOjaYbB/0QS2A5GrafE0R//Iv/kNX/ds9AgwLfR+MOsHRsrQ7Rz772EzmVsWm7kCdswbbk4eSR6gQvigp+yt1KjiH/+U6HOZvGDWEV924lq4N1rgdelqDreb9kfuUo+isx/aKwKs+z0d1sUZ5J85TGAEAg404Z0KF3hIciUqmOXlznvN7m90fL2jsVf8hSQ4pIzof3a57wTuOG3esWUGKi0KRwh5JOhlV2bcS/4LDQFmw61f1YsCMxhXwKwS5WIYeRayKeg9ImdJButVwjmHU+UCZQzEmISuPYG4jiHg/z+Gdtc3Ir QLpae0di ZYfp9sv6N2nI3NmfFdqIJQxEEfuVw+X9Byf6dpQxmJAzftW3X3iE7wOIfXsSdKhiG6wpK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/27, Pu Lehui wrote: > > @@ -237,6 +237,8 @@ static int move_ptes(struct pagetable_move_control *pmc, > > for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE, > new_pte++, new_addr += PAGE_SIZE) { > + WARN_ON_ONCE(!pte_none(*new_pte)) it seems you forgot to add ";" after WARN_ON_ONCE ;) Oleg.