From: Oleg Nesterov <oleg@redhat.com>
To: Pu Lehui <pulehui@huaweicloud.com>
Cc: mhiramat@kernel.org, peterz@infradead.org,
akpm@linux-foundation.org, Liam.Howlett@oracle.com,
lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com,
pfalcato@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, pulehui@huawei.com
Subject: Re: [RFC PATCH v2 2/2] mm/mremap: Expose abnormal new_pte during move_ptes
Date: Tue, 27 May 2025 16:24:48 +0200 [thread overview]
Message-ID: <20250527142448.GB8333@redhat.com> (raw)
In-Reply-To: <20250527132351.2050820-3-pulehui@huaweicloud.com>
On 05/27, Pu Lehui wrote:
>
> @@ -237,6 +237,8 @@ static int move_ptes(struct pagetable_move_control *pmc,
>
> for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE,
> new_pte++, new_addr += PAGE_SIZE) {
> + WARN_ON_ONCE(!pte_none(*new_pte))
it seems you forgot to add ";" after WARN_ON_ONCE ;)
Oleg.
prev parent reply other threads:[~2025-05-27 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 13:23 [RFC PATCH v2 0/2] Fix uprobe anon page be overwritten during mremap Pu Lehui
2025-05-27 13:23 ` [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma " Pu Lehui
2025-05-27 13:34 ` Lorenzo Stoakes
2025-05-27 15:17 ` Oleg Nesterov
2025-05-27 15:27 ` Lorenzo Stoakes
2025-05-27 15:29 ` Lorenzo Stoakes
2025-05-27 16:29 ` Pu Lehui
2025-05-27 14:23 ` Oleg Nesterov
2025-05-27 16:32 ` Pu Lehui
2025-05-27 16:37 ` Lorenzo Stoakes
2025-05-27 16:52 ` Pu Lehui
2025-05-27 17:20 ` Oleg Nesterov
2025-05-29 15:09 ` Pu Lehui
2025-05-29 15:12 ` Lorenzo Stoakes
2025-05-27 15:30 ` Oleg Nesterov
2025-05-27 15:33 ` Lorenzo Stoakes
2025-05-27 15:52 ` Oleg Nesterov
2025-05-27 16:41 ` Pu Lehui
2025-05-27 16:35 ` Pu Lehui
2025-05-27 13:23 ` [RFC PATCH v2 2/2] mm/mremap: Expose abnormal new_pte during move_ptes Pu Lehui
2025-05-27 14:24 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527142448.GB8333@redhat.com \
--to=oleg@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=pfalcato@suse.de \
--cc=pulehui@huawei.com \
--cc=pulehui@huaweicloud.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox