From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7634CC54ED1 for ; Tue, 27 May 2025 07:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F026D6B008A; Tue, 27 May 2025 03:51:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED9D96B008C; Tue, 27 May 2025 03:51:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16A86B0092; Tue, 27 May 2025 03:51:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C3F306B008A for ; Tue, 27 May 2025 03:51:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 34D461401DC for ; Tue, 27 May 2025 07:51:13 +0000 (UTC) X-FDA: 83487917226.29.D9B9063 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 881CD8000A for ; Tue, 27 May 2025 07:51:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748332271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0obdcAoyQ8MVnWLzLyNalumo394dRVHhZQsgo3Wjzms=; b=MfEsEwElYoHvqaqKjtBf71f3UYNp6BcUTokarHi9rjkPtGSxNsJNrMO6vlN4mXy/ZeHpAJ 4Cpc15V0kRm00N9XCEW0AopqrFJGgpr2JPGyRU8HZEOpEorNksqywspPSlOjWFihiujOcD WuDogbdlHI2h945CVCRQiDlgEsRsZQQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748332271; a=rsa-sha256; cv=none; b=OyRmFRd4kQP7mZ/aE3Uqcjm1Hysr4XQiX6rOv8LZ2LbgMGgV8by7VeeWLLkdJz0bC5iERx ZrzSChBd5uQHTJJxl8nGBfnzttGdqCRprFoZMLcO6+oltsWxZyLEEogCT3Q6RWvmwTOOU5 LAmT+z3xi7ZdTysCdTuaRmdB42Z+zIs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2AA4150C; Tue, 27 May 2025 00:50:54 -0700 (PDT) Received: from localhost.localdomain (unknown [10.163.85.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8829E3F694; Tue, 27 May 2025 00:51:03 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hughd@google.com, Dev Jain Subject: [PATCH v3 1/2] mm: Call pointers to ptes as ptep Date: Tue, 27 May 2025 13:20:48 +0530 Message-Id: <20250527075049.60215-2-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20250527075049.60215-1-dev.jain@arm.com> References: <20250527075049.60215-1-dev.jain@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 881CD8000A X-Stat-Signature: rm4w37ptjks1f9i338yqpwmnzkysfums X-Rspam-User: X-HE-Tag: 1748332271-293922 X-HE-Meta: U2FsdGVkX19DwLMiC2gM3SvQD00hjH9qDDOAzsRkNLV32v+RJKjxT6zSav7RioQhs645jgK7VCIo9N4keTvSh7jtbtKC99MXBDjSj7TnuCEThlWvW/ytMrRbrob6FBO/S9jkzvAGYVQgkATrtiQ7QmpLarPOXPIAUxeyz53OZEws9Qkjj8KZb4cMYzdzW24vMmPD/TEhIu8z1CLkP8f/4xHRLc3IBrIOMO04tF/LX+uJrf7eennHI5lUJ7+vBZdSgIBSsNcY8EEEVFAJlW8aVCStzaEWrSL6eKDfRhcjPu+Z5mzOYb+LMBh6TV/ixrI+295Pf4dx9fyjVIyL7w+zXdLRnoszZvrfcVyYf2lqCNMb7z1aWy+re1DZnK7ZxnTF0uqmoTazelaY+hskrseRAYfVvIAqYnVX+03PTJsmPtHm0aXYMi/5S9Aj2ugjGXmacNA7wzZk67Z3e1XXs6g9bE6Hszpm7LlQ2d+M4sPXQvj2HSJ4ysZQuzLtyCH01y27zfC909vPz9HHUeyiYNzXwB4XnKnMt8cSGFTawlpMtHo1/bXxB2gjcj9gZkoOrI3ECRiSYzTt4jEe+SkZgytbCkGr8n8yGSZ6pZKIdHqrMbLP5jRGd2frvrRQwNVX9FUXOoE+/of0MEzAeR64rGXbY+3kmceL8lwtI5fCTpWKcI0JvrmBC9NH+EFYkRPnJq/ZkFyHzgo/sT2UbkxheW1/8QxX9YEg8blnBHoz7PJvoW+pbW4ZVAy/XFcvdhalMF/bA29DLFyNVskBOETeSv+QavW5wJY89t4X5lfUFKX4InRrR+nBuc/73kuWdM+qMtdtr4IijnkogxxzrRtc0TrholtXepQmIuj4dYWYb+TRFJZfBSzJ8Xqmene9HY4QEpVjwFmAgNRRzGs3YykbB2zaMiujaqHcVIsyN0VbvfH67FLdgfL4W4KVqgD0dhOeUHsNdmpmM+s6cTtL6m09rbh BlTKVubi nTjYe4dn6LA5F1X+GvVVAAtSgAAW2+PxNy7D7T90PvtLF++d+jo+EshcWPfdQN0udPvTmWgpI21qrpeJRoeUC7R3/9W47lmh6NKiIfJagjMiiRWLlXBw0C9l40SHp+QOUAqQ6HDlYMk/WeBZIhXSPfhcYRg0Nbd7tb18xRhccTIg+0aKxIZig3hGP6gNfHahCFzWaPhQI9AblBjY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Avoid confusion between pte_t* and pte_t data types by suffixing pointer type variables with p. No functional change. Reviewed-by: Barry Song Reviewed-by: Anshuman Khandual Reviewed-by: Lorenzo Stoakes Signed-off-by: Dev Jain --- mm/mremap.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index 7db9da609c84..0163e02e5aa8 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -176,7 +176,8 @@ static int move_ptes(struct pagetable_move_control *pmc, struct vm_area_struct *vma = pmc->old; bool need_clear_uffd_wp = vma_has_uffd_without_event_remap(vma); struct mm_struct *mm = vma->vm_mm; - pte_t *old_pte, *new_pte, pte; + pte_t *old_ptep, *new_ptep; + pte_t pte; pmd_t dummy_pmdval; spinlock_t *old_ptl, *new_ptl; bool force_flush = false; @@ -211,8 +212,8 @@ static int move_ptes(struct pagetable_move_control *pmc, * We don't have to worry about the ordering of src and dst * pte locks because exclusive mmap_lock prevents deadlock. */ - old_pte = pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl); - if (!old_pte) { + old_ptep = pte_offset_map_lock(mm, old_pmd, old_addr, &old_ptl); + if (!old_ptep) { err = -EAGAIN; goto out; } @@ -223,10 +224,10 @@ static int move_ptes(struct pagetable_move_control *pmc, * mmap_lock, so this new_pte page is stable, so there is no need to get * pmdval and do pmd_same() check. */ - new_pte = pte_offset_map_rw_nolock(mm, new_pmd, new_addr, &dummy_pmdval, + new_ptep = pte_offset_map_rw_nolock(mm, new_pmd, new_addr, &dummy_pmdval, &new_ptl); - if (!new_pte) { - pte_unmap_unlock(old_pte, old_ptl); + if (!new_ptep) { + pte_unmap_unlock(old_ptep, old_ptl); err = -EAGAIN; goto out; } @@ -235,12 +236,12 @@ static int move_ptes(struct pagetable_move_control *pmc, flush_tlb_batched_pending(vma->vm_mm); arch_enter_lazy_mmu_mode(); - for (; old_addr < old_end; old_pte++, old_addr += PAGE_SIZE, - new_pte++, new_addr += PAGE_SIZE) { - if (pte_none(ptep_get(old_pte))) + for (; old_addr < old_end; old_ptep++, old_addr += PAGE_SIZE, + new_ptep++, new_addr += PAGE_SIZE) { + if (pte_none(ptep_get(old_ptep))) continue; - pte = ptep_get_and_clear(mm, old_addr, old_pte); + pte = ptep_get_and_clear(mm, old_addr, old_ptep); /* * If we are remapping a valid PTE, make sure * to flush TLB before we drop the PTL for the @@ -258,7 +259,7 @@ static int move_ptes(struct pagetable_move_control *pmc, pte = move_soft_dirty_pte(pte); if (need_clear_uffd_wp && pte_marker_uffd_wp(pte)) - pte_clear(mm, new_addr, new_pte); + pte_clear(mm, new_addr, new_ptep); else { if (need_clear_uffd_wp) { if (pte_present(pte)) @@ -266,7 +267,7 @@ static int move_ptes(struct pagetable_move_control *pmc, else if (is_swap_pte(pte)) pte = pte_swp_clear_uffd_wp(pte); } - set_pte_at(mm, new_addr, new_pte, pte); + set_pte_at(mm, new_addr, new_ptep, pte); } } @@ -275,8 +276,8 @@ static int move_ptes(struct pagetable_move_control *pmc, flush_tlb_range(vma, old_end - len, old_end); if (new_ptl != old_ptl) spin_unlock(new_ptl); - pte_unmap(new_pte - 1); - pte_unmap_unlock(old_pte - 1, old_ptl); + pte_unmap(new_ptep - 1); + pte_unmap_unlock(old_ptep - 1, old_ptl); out: if (pmc->need_rmap_locks) drop_rmap_locks(vma); -- 2.30.2