From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91106C54ED0 for ; Fri, 23 May 2025 16:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF6036B00BF; Fri, 23 May 2025 12:52:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAE116B00C1; Fri, 23 May 2025 12:52:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997106B00C3; Fri, 23 May 2025 12:52:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7A1B46B00BF for ; Fri, 23 May 2025 12:52:48 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E9B3AE72D9 for ; Fri, 23 May 2025 16:52:47 +0000 (UTC) X-FDA: 83474766774.15.B3183F7 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 2B6F9120002 for ; Fri, 23 May 2025 16:52:45 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N2s009HC; spf=pass (imf29.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748019166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=lnOScSnE/yXdZeUwx1aaQHUueDdq5UuSPkXF2iQZTL8=; b=e0bIyeDxv/jljJJ0z28ULTa/aSNWeQyvZDDsEf5fwmOY9Dnsq6LpDBPAFTXb7trDSsYMn6 YXdNHv10aQQ3tPh84JLjr5uZekHzaJJyeh4eDSYf2wPWh7TrUb3gUPiwidfzgKg04hfMaY x5EH19HvIjR+Q5R9VgsVD/jYNJNw1WQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N2s009HC; spf=pass (imf29.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748019166; a=rsa-sha256; cv=none; b=tF9FRPTYXXd+qxmr44uZ5JBXKvQ44As1Fs9ztZfwpzGA9xgrttxBHSkwVVRKN/PqyYwmWf 2Cfs6QthKvo6qU5gKCoGxlWWXGyFh4W0jMFz0ZNZ/H1zTyUvtUKCYQ1r2yTJn9rNxPGDl7 lgRnExRSX00Kk9fH//2lBN/YfEr1P5w= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6ecf99dd567so678316d6.0 for ; Fri, 23 May 2025 09:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748019165; x=1748623965; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lnOScSnE/yXdZeUwx1aaQHUueDdq5UuSPkXF2iQZTL8=; b=N2s009HCr1i0Y5vjI2lxhQFKUNPUfFZeeb12WRbB87zJiodj5SJjbwDbb/3v/v/Bll fNJMGei9gRJBOB5yh6mlk8k3YRpJO9QK4mBCbJJVNOsnG9bNDG5vkS+wpGK/3UsvYZrK +SggSdgHbPd7Q4B/EorMCebvHv8VfYYutKTOgtu6V1AO2qFSC7375AmoJqQpK4PkAIfc mIClkaW+mzluJaLReJBvrOHcRZVdI3m2Oi/AysplgfdHHjnBEy6CkPtveRdXW9h8zFHO bYkNO/mpIdxFBpL1RP2wQva7VWHSXE8k1fhh42bVdhzUfLm2h8ptj8nCfArzi8p0/5Ud fSpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748019165; x=1748623965; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lnOScSnE/yXdZeUwx1aaQHUueDdq5UuSPkXF2iQZTL8=; b=oeiuFDyQMSbVZTROs6uLE41yOjoGSFkb9bp678XZN399RD0+cWxCJUdeLfdqOarn8O StQl+FTsBtrKgcMgSjYpk7vHG4Yx6bJ8Ov7EBSFxJ6Tygura84cKp9UefdXb7buGkRxC 80ch6AnlNjQo4q6PAl4trj4ov4FpGyc6WrZZSYm3EAj8KNFola1FQ6ATf6TprKlHBME1 niQSUXN6G6FywqX38Mv9do1fE0DtcBdwoV8dWZVWLOJ3IFrsbHAQCC6OCaQBf6AudPBr mmQV7PhCWLL+UmF2uvVro735ymaWZObYVbCZQvaAYIDB9P0BGE545S2Ulr5KKVuo1YWC PAVw== X-Forwarded-Encrypted: i=1; AJvYcCVPt5VP1HxvEb1JDRZ4CfXfbfwr5MzpaIaLafT6B4wmqy4MEiWoHDizSfE38hKVaslzZj9zuivavA==@kvack.org X-Gm-Message-State: AOJu0YxlAbZLTS8MqdRq+NeA67INDzoRWPDcqJdHerGs0zvC/Elz0HPZ ynEYxa5ZoztiZ6gEmwNZFxR/9Yp+LmSjg+57L9M383GSnJOe5gJY5sRw X-Gm-Gg: ASbGncv69oJeLFNitWQBcB7Tfa7ljHW4xY+Kt8+cWJL8CkdPNLbzFqWhX8h0E9DU9W5 AZpH5Tl6HCvN9x/wS9ip/m6sliXN4aSDBFGNGcM23Jd4qoXXkG8jtIitqCb61P4IgQtup61oaIa GLzSZqYprQjfaoF6btn/V8yS1ADvntbtcjo9z+4nNXtbLCebps6c56Skijv8OCzPrCK8dYIDvBv S2ge83CYxraGP/N8m+/NDF3Xm5/jRdks8BmADeTj4KqHUXFRaOsquB8+Lt4L5DgPFp69RRHTWS2 dRrY/e8uQPIsjmGSuJxE/ofL0Ya2YwBnbq8dozeKCqt6gLGX X-Google-Smtp-Source: AGHT+IHWry3SN2Ct3SZFespp1702g6E+CCGpeSKQhfGWaRCN/eduukpNy6BuDU6Mhmu8IL0WGc98+g== X-Received: by 2002:a05:6214:5196:b0:6f4:f621:bc with SMTP id 6a1803df08f44-6fa9d2a28c8mr3253006d6.33.1748019165146; Fri, 23 May 2025 09:52:45 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:8::]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b0965823sm116908236d6.88.2025.05.23.09.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 09:52:44 -0700 (PDT) From: Usama Arif To: Andrew Morton , surenb@google.com Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, cl@gentwo.org, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, kernel-team@meta.com, Usama Arif Subject: [PATCH v3] mm: slub: only warn once when allocating slab obj extensions fails Date: Fri, 23 May 2025 17:52:40 +0100 Message-ID: <20250523165240.1477006-1-usamaarif642@gmail.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2B6F9120002 X-Stat-Signature: jmmkcmkm7jxg1brq7ouo1zwobf6skxc8 X-Rspam-User: X-HE-Tag: 1748019165-702181 X-HE-Meta: U2FsdGVkX1/J+M8G4cSjs5NPdC6OesniPCxfV12BxMOf+xxCkT8nelJYHXG8gWGsU4xbM3+/mvDRPnMZWDfxAzW0kjQsgnDntwDzoTZ0iL+aAkqNwpuJtfkdLD+E4V8tgVb+Ak3Kl6tWplA7X/coz78VRfU68YjgvLiJY7wfKKKqX88DRYt/oTyUaYPw88qCFEzsugUc42IFbGAFRUZ5KbqwUZ2TrrrqDW3SOyoDM1QMVULdyphFoMXVyA+jLFFuR+HbK46SNMdt5KRDWhbY3VFi5ViAj1ez21wYgOdaeRjYGaBP2sCpqGKFPYpoEx4u3QdRfNXIcgiX52t0SnP/jd1KKLsmWdaeXY7JByjkY5sVRUK5Mp0EE6UnySIsIYHB5/lzhTXRP/3POArRgvoy+aVnt612wpvKTMzFZ8Se4Zipofzfn54xqKI6/Lj7+e/M5VTCNKG7qXKYw3RED1WhtU0mMtBvklg3Bu28Vvcey/D9v4QEpK6Bv5WOAT3aFIzP0phEHjoYhhKP5Ridy8hfcku7CKvw6i61OI76OVwIEB5xyixKpEjT5vVMBLQ0gAV621L4w8SbLdIsOy510HciQsSHJwZYkryALH0njOe47rK217XVBfE9PAxAirJg8R5l45ctzyxw/WLSHy3Sz+BHbUJFi2WMYmU0rP/Ljo4I6JB2s5fjRJ3eoKarOkBE2g8snZka7HmakKpO3fLWIVuM5MzysUWVTeTcjcJc4gh0c7f7H5juq0KGuKUByAiee/iLf5RPWygG8CMz8xCxD1sqR6pjRejnsjb/vDe0Zm+sxTqgZi+lU0IgN/a+pzFArqR/gRyry0Qd98nzrpXCBxp4MQY45FQ3q7TZZ2O8YFO89FB00EIilSykzOpEy/Bxibb0pepX00jTzqHYbSe3SsULVSFQVBDJX/b4ypYd8W7jnC2AcDZ/KSZcdN6hIqhGWgO7SClzg58Ilj8qaALnh3D aSjpTaC0 yhv7x6LPZfhNrJLRrJj3v0BzjINTo0BqVAirudG2xlRO5SKGPUJ5LxfifX6eWwxj4gTvS94XIds2WFt4NZ7ChtMSY751ExmnzWJ5V6Bl42oXspshCmTxKpgvZWrGXhGvoIRNLK99txg/eY7Gi5NgYfQt4zU9yTxOHWRaMUWitmhoBw5x9E/4W82p2KWAZ9nCQ76hCjTuNABSM5inhZAdqbCCyMIsIqF2DHOeU8weeGhrMz/Ap55SVOsrAhP1HFX5fN/IJSWsu0nKw7gLvUGN6UGpcZ9vX4g8RfxSSLobtFgk/lLrmEZ9tg1uso/NFPWSIy6jibMZIGpd016xzCEUf61uvjyDrDaZQviz8dGQF95MMQ3AnUrCjHkyxpzWvSstIZhf8qvQsdvG1FOgUWGyeBbW4ah0ns4acHOCCHc9q4uFyKwbGZBASqqLPd9v71xcGI2YDf0XpxBdvWH646RBSY2iDxD9PhQviNliT+TvhkXWimHfCcqnU+Dv3g25cMFGTPj/6+UasZ89dtk4yB+DBY6CTvaXwfe/3nqIksxZOhUpP3so= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In memory bound systems, a large number of warnings for failing this allocation repeatedly may mask any real issues in the system during memory pressure being reported in dmesg. Change this to warning only once. Signed-off-by: Usama Arif Reported-by: Vlad Poenaru Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ --- v2 -> v3: - Put warning back, but only warn once with pr_warn_once. v1 -> v2: - remove the warning completely. We will have a way in the future to indicate that the mem alloc profile is inaccurate. --- mm/slub.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index dc9e729e1d26..36d7c43a6f2a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2102,10 +2102,12 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) slab = virt_to_slab(p); if (!slab_obj_exts(slab) && - WARN(alloc_slab_obj_exts(slab, s, flags, false), - "%s, %s: Failed to create slab extension vector!\n", - __func__, s->name)) + alloc_slab_obj_exts(slab, s, flags, false)) { + pr_warn_once("%s, %s: Failed to create slab extension vector!\n", + __func__, s->name); return NULL; + } + return slab_obj_exts(slab) + obj_to_index(s, slab, p); } -- 2.47.1