From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49A3C54ED0 for ; Fri, 23 May 2025 22:27:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55A416B007B; Fri, 23 May 2025 18:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 531E86B0082; Fri, 23 May 2025 18:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 420C86B0085; Fri, 23 May 2025 18:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 268476B007B for ; Fri, 23 May 2025 18:27:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C9F80BCF54 for ; Fri, 23 May 2025 22:27:08 +0000 (UTC) X-FDA: 83475609336.01.FA7A866 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf02.hostedemail.com (Postfix) with ESMTP id 23B2080005 for ; Fri, 23 May 2025 22:27:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MAUxf4uN; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748039227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2xqMbf8qIxRTZRLZ1hd8yjSC+vjQ5gHARaDDfUrsm9E=; b=g54VO7hyHGv/nQo1iJGuntOHwSkCnn5QQXHi5GyI36u+oD51jXPSPrTIYNMFNn34SSu1yI VDBE/r+r9+YBiAvfs5OudyZ2tOp/ujqheJ5DyqKWkqVykV/adeON0PTMbWyQbZ+1nd+Ptv hw16XlZPUyg+G+9le27lXZ7FtB36Qqw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MAUxf4uN; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748039227; a=rsa-sha256; cv=none; b=pC4IX188q0LH/d2iB0rTOrpUgBbzSwyhjdbJxZNumwO1fmKZQtPPzB1BJf1/TSzS0g3hZn fzrCWrb/edqHAGfrbudDOJ12BTreV5UNSYa+ScXa+3HnNdzXvaUAOlXuYHf77gIJqi2FtB rVUts7/n1pjy/lhQ2ZuKqO+OTC+0g3o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 388AF61154; Fri, 23 May 2025 22:27:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A37D7C4CEE9; Fri, 23 May 2025 22:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748039225; bh=JrmjUcUuCdLrFyFZQZQSWsHwlooK3iF/M77Hw8oBD4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MAUxf4uN9muK+1RNCrui7Voj6noNO5+7v6fvwjsEVHyC7IHeZTMJXQqYkB4ZTxW7t rnrLj/H1ds7sl8o36C6RcGUOkVsxcecPnZxQAf+t6TTQoEt5z+CnCieabJYVyh1vFO Yw2uH9qwxW7uD+RpHuXhK/NJd3rZooMbIWmkyMqA= Date: Fri, 23 May 2025 15:27:05 -0700 From: Andrew Morton To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, Yu Zhao , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: mm/vmscan.c:3504 walk_pte_range() error: uninitialized symbol 'dirty'. Message-Id: <20250523152705.2ecae09e834c66e1327d6748@linux-foundation.org> In-Reply-To: <202505152339.fBOfDPsi-lkp@intel.com> References: <202505152339.fBOfDPsi-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 23B2080005 X-Stat-Signature: qxq5qh1ixgzatyadjr3e1yow8xnf4761 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748039226-159444 X-HE-Meta: U2FsdGVkX18oqs48jU9q2vTjIDga0tgAsDZJy3uowGOhuHM5QnjFBskwC+9KVVQYtfBjCqmyBNn+XEp1aJ9u557wKQBzdbjTJQ7NpI1kuGuvNacKX9wezeITI5nQ0h0n4p50IC19y0JAjxcm4qYuhugKKerOz2pHXM5u93rvVWZ9VeppHVPMj3PcuudRDCIFM1Gr9nA2QUxwzUpRSqr1GKORitX3xMAlNM0ojvC5DA7hAwPw/y63yGzZN0fe7TP1yApiH0+CmKIyyz8VQ7CEfiF+QLl03+vRuhka3zMw1oOo4jlsTcBDyzqJh4C9tyZPZV8yIckDZfjtppevyoEHdJ61bbc+tWQM4mO34AbQhQrsxPXOYbudhTFmzxaSxRDDIkAqO/4Jof5b8hcOoscJWLXxYRfRSIcauLJ7Mbq84iK2Te63OJKFgi3PQzjZ1oBhBY7PJ935E2aFeJCkSZGcGkQFeYCb212E0VL4CbUduiA0g25aWL7Xvw0mpM1Gw7NNv0H8cY7CN3664PRCidIxTV4BK1wvlh+8ozmVEu8WSIwrS5pd2npaT5DqlH9VAqRfeGif7EtjB0maoDtSTn48Yxs5P3EMC/BBa9Jp1cPfBe7UNlz11/flgmbDa1wbQhIgb+z2CKYjxxxoQGct6VuqmagOeD2NosmFhT1eQzJhbdo5e2dX3MCvq5dCN073wh5lXV9MTRy19quYbA5OqcVUE9enZ35IXW+trJkcrKTOrROtxxa3XjCUbS/DjX51C+gzLKqY3+L3dGbvOzsJTCv2CRVPzBMZljE8ollLCklw1eBrNcY/pJiCmikYPvZjA70iYCvQmAyVwmoHJBJZY3J8FXhJ7UUosl/3on6j9T3SYLm9eIYopNA8nKMoTXCC+CzBqYvTxlJNr0c+M9/OE2CPhQXKF0B75iAMR3uCmTHBsBj6zEOUA5D0WgxXfC+aIhfUc0SReZskGPSWvD8F2lL APf2S9Nh IM6x3d7NRhFELJ0CS03Xpj5E2vCLRsHBTaiehA/rrxqV/xX81fPzDejqzFAGsYOnTkrOsCYxeXy+gRN40eCQgrvzqc63vxyTOcYaMbQgOi+U6nL0B4IctD+V25zIb1D4Ywjf0WpR2xLSj8dTFWohiiLtrWRfaOM55Qee9BC16sEZE0AUxPkABt18+DuRy6MIduiH2h134uccjSwZ/BdFr5ORDvO2jh1mvmb34p0vvvY780AX+MdLMFACy1wCzgS6/kaYsVajIyRQFdRI659D3gXtKSl6Cz2P0hCt2PiRcVdHjvWRiuCiD8JdY5ej9bD2Xn9R0xT6aowuG29sYTPGkRgieO41Ia6UaSZIzKxKV8nv1dIwdnLaXi1LwwQolC58b3xuG+F491QkeK2Wl5oWVQMSF/DMAtV4wSYON X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 23 May 2025 13:47:54 +0300 Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 088d13246a4672bc03aec664675138e3f5bff68c > commit: a52dcec56c5b96250f15efbd7de3d3ea6ce863d9 mm/mglru: fix PTE-mapped large folios > config: sparc-randconfig-r073-20250515 (https://download.01.org/0day-ci/archive/20250515/202505152339.fBOfDPsi-lkp@intel.com/config) > compiler: sparc64-linux-gcc (GCC) 8.5.0 > > smatch warnings: > mm/vmscan.c:3504 walk_pte_range() error: uninitialized symbol 'dirty'. > mm/vmscan.c:3595 walk_pmd_range_locked() error: uninitialized symbol 'dirty'. > mm/vmscan.c:4215 lru_gen_look_around() error: uninitialized symbol 'dirty'. > > ... > > bd74fdaea14602 Yu Zhao 2022-09-18 3484 for (i = pte_index(start), addr = start; addr != end; i++, addr += PAGE_SIZE) { > bd74fdaea14602 Yu Zhao 2022-09-18 3485 unsigned long pfn; > bd74fdaea14602 Yu Zhao 2022-09-18 3486 struct folio *folio; > c33c794828f212 Ryan Roberts 2023-06-12 3487 pte_t ptent = ptep_get(pte + i); > bd74fdaea14602 Yu Zhao 2022-09-18 3488 > bd74fdaea14602 Yu Zhao 2022-09-18 3489 total++; > bd74fdaea14602 Yu Zhao 2022-09-18 3490 walk->mm_stats[MM_LEAF_TOTAL]++; > bd74fdaea14602 Yu Zhao 2022-09-18 3491 > 1d4832becdc2cd Yu Zhao 2024-10-19 3492 pfn = get_pte_pfn(ptent, args->vma, addr, pgdat); > bd74fdaea14602 Yu Zhao 2022-09-18 3493 if (pfn == -1) > bd74fdaea14602 Yu Zhao 2022-09-18 3494 continue; > bd74fdaea14602 Yu Zhao 2022-09-18 3495 > 798c0330c2ca07 Yu Zhao 2024-12-30 3496 folio = get_pfn_folio(pfn, memcg, pgdat); > bd74fdaea14602 Yu Zhao 2022-09-18 3497 if (!folio) > bd74fdaea14602 Yu Zhao 2022-09-18 3498 continue; > bd74fdaea14602 Yu Zhao 2022-09-18 3499 > 1d4832becdc2cd Yu Zhao 2024-10-19 3500 if (!ptep_clear_young_notify(args->vma, addr, pte + i)) > 1d4832becdc2cd Yu Zhao 2024-10-19 3501 continue; > bd74fdaea14602 Yu Zhao 2022-09-18 3502 > a52dcec56c5b96 Yu Zhao 2024-12-30 3503 if (last != folio) { > a52dcec56c5b96 Yu Zhao 2024-12-30 @3504 walk_update_folio(walk, last, gen, dirty); Seems to be notabug because last==NULL on the first loop and in this case walk_update_folio() will immediately return without touching `dirty'. But gee, I can't blame smatch from getting fooled by this. (oh look, mm/ has two walk_pte_range()s)