From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3453BC54ED0 for ; Fri, 23 May 2025 14:36:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8EE96B007B; Fri, 23 May 2025 10:36:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C66F56B0092; Fri, 23 May 2025 10:36:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3926B009F; Fri, 23 May 2025 10:36:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D9366B007B for ; Fri, 23 May 2025 10:36:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41D6514051C for ; Fri, 23 May 2025 14:36:20 +0000 (UTC) X-FDA: 83474422920.07.82680F3 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf07.hostedemail.com (Postfix) with ESMTP id 6223F4000C for ; Fri, 23 May 2025 14:36:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aS+h8Waz; spf=pass (imf07.hostedemail.com: domain of dskmtsd@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=dskmtsd@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748010978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=sZS6KKAxkfiJ47UQ2g7848YiBd6r9R46LhHeN/beZvg=; b=qp0J8iOWpfqRe4ZMTvnX/UXN9yzxEXbOE8YnMj7qJ6cQuB+ExeKTeYKnc3sdjcPWnoUJhT HZvymBTZCeSkdyicV/JrPYI4w3VYuN4+wyFjiqgECsAfumWfK5VmfTvfNNSt1Pcny7+2v7 dcdeZx8UrXeLby8w8eXThxD7eMLRigA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aS+h8Waz; spf=pass (imf07.hostedemail.com: domain of dskmtsd@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=dskmtsd@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748010978; a=rsa-sha256; cv=none; b=spzlpwJ8mTMdKBFn4TGEamq64xBRtVhueIUk1U4/X71/TllA/oJGE9wmHKINzbfaK7qCZx 5TXUfDFMOzQhKxv6eN1RT5seB67Df/RH9AcNBAHwJGmdLgfQgLgq8atavlhx88bkdc+87W vIbiEvxIt8QQxvVWX3BPlMkkzKz3s70= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-742c27df0daso40613b3a.1 for ; Fri, 23 May 2025 07:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748010977; x=1748615777; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sZS6KKAxkfiJ47UQ2g7848YiBd6r9R46LhHeN/beZvg=; b=aS+h8WazxSXsvFnzxAjs6E0nf2mLaFz6CJcv4+/a3yvHEcD7z6id0mhtJMoPRO4uIt eVSpPCX3LV+hFBwUfKEOToRmxW5I9kXobTKVUWrE4j/VCL5uqypS/KJSEtZCwbzbX6zl fhpA8e7RxAWC3yoImDu8pysCNGow52+s4LMjHA6AoJems6z72d3NQaEBHbzZfipaM/Wb rJzrUnBWXsjWkTHiZhxsV/k8+kvTs88ubu/mL/nh2pfP1IjH2JyDvmTIa0W+hKFFF1VZ m7vkxC6rgQCBrgVSJov5Eb5Trc15ip7o0zxp46uaARGKNeLPjsym8JcQiX6JUgr3qWpo AS8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748010977; x=1748615777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sZS6KKAxkfiJ47UQ2g7848YiBd6r9R46LhHeN/beZvg=; b=dA/ssloB5pc6lS7AxsyjeD9ybL6CQG27SvrYCESoeGvAZ9Bpcse5wM2avTm1cCI9m4 94+KJ2ZOuGHh1CxG6S6KOtCcdyRKg8u6gmJNKmP0f2MjOIf+5zwXEaALxAMP2TR1Ll0o 6cNKrrlEO44+f7BOo/pKZadS74ZmCv33ow50jnhOALjA1wZrSMRjpjc8DCm4uEkBCTOd IBYdgUOrjYlvFUvnjTPc7d9GNAZU/pGCgSzHXcd1snLyD1i+FgUa+1Rp+qwhTp5IjSsQ wKTvwmXLqM+lzHpYZAd7Jq9UxLcIh3Z0hCGESYn2S84KNM9mZeYC7MJHVMv3MWRcl5mQ H+ZA== X-Forwarded-Encrypted: i=1; AJvYcCVzkGfxFGUzkEfin4/cabRX7rlnnemJPzhsoRa4u9qs84n2v9YCEMaRup+ZhxBykpdT+WSjqhiJnA==@kvack.org X-Gm-Message-State: AOJu0Yw2SdRzqqgXVQPQW6D5ZA25BHJ+fcunNAhCR1wSSkeYGABlkekD sMvA6QjARe/j677nYOP7ZybjA64mS1qqu6pJUKoyuHrYaKEE828Ic3AP X-Gm-Gg: ASbGncsYFM9t6gZO70ZesylShOUA0FwomJG35qon+RSw+6LGw0/pThAIA+QY41iDq4X xDQN4f9I6pdRzRE0KCdkErdQCBLkrJHyQ6id92yUHjk0lAzp3FRO2v6ta+M9rBqWaSemwlS9lFJ 1/zMQ5SFpaNDdH9SBIciro3B8UOnNCuCHQiMrBbHkRMwCMXmLuHYfQyRHvqpnwFxXMwqhl1NJMN UuFgUY1XjVBrFoO5l3+n7akg0l1si9v6aPAuUjmcs4pz78Ge+cScu+DPp9RCqaGk8IevrvIObzQ FhW0okYT5igHzeN1lH9s2CdqC9nNc7u4Jb7ATcy7zFgX+Cpfr+zW8l1KImlGjYQihf0CPJgcV7B YwaAgtg== X-Google-Smtp-Source: AGHT+IGBJ66/Pp0yFSs6RBfnlTgO0ld5hemSj0mUVbSrfLUVYezMJRqXOgHPvfEZXDDQere6Gt/CIQ== X-Received: by 2002:a05:6a20:9d91:b0:1f5:619a:7f4c with SMTP id adf61e73a8af0-216219b250fmr45645240637.29.1748010977056; Fri, 23 May 2025 07:36:17 -0700 (PDT) Received: from trigkey.. (FL1-119-244-79-106.tky.mesh.ad.jp. [119.244.79.106]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b26eaf5a2cesm12884264a12.9.2025.05.23.07.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 07:36:16 -0700 (PDT) From: Daisuke Matsuda To: linux-rdma@vger.kernel.org, linux-mm@kvack.org, leon@kernel.org, jgg@ziepe.ca, akpm@linux-foundation.org, jglisse@redhat.com Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, zyjzyj2000@gmail.com, Daisuke Matsuda Subject: [PATCH] mm/hmm: Allow hmm_dma_map_alloc() to tolerate NULL device Date: Fri, 23 May 2025 14:35:37 +0000 Message-ID: <20250523143537.10362-1-dskmtsd@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6223F4000C X-Stat-Signature: bqjupdqxaj9obt9gje3wm3n9e5syom81 X-Rspam-User: X-HE-Tag: 1748010978-821591 X-HE-Meta: U2FsdGVkX1+TFyINZZwnYlYGfHB45CuyRrLcWbrLahVT35YiFr8Z7PWuuyuot7Ph0KV5xlt1CuOMD0Ru+Y5QrmjisqMili1Aj//Wmmv23yFnKw6RA0i+wmSmCb/ux7QHaL8U3jRphtprXryvB/f3lfV5okJQFnq4kqvoXs/YUk7btdmZAfkkrn0iZ+4ZgWqVoE9JO4bzS3WXXjKn4MHVV2WwnuRj/Ka9BOImjMO+0cQNU8+eWA1poT0L80fFjFl3py1hbTT8O8H90Orxo/q4gX/AwAycQQHRH+gE8AT8Sb3dqd4Z/RQjIjjZ2EclBWkia+muT/rhQSaoE89Sy0xnANRuLSdlVSASoQ3Ktv25KENjOvoxwSvLLL7TfY0fNFzeJ5oF6O8wW7AXG/hnF/fJrTk25CM+MfSNYJt4Pu5pmkV3pL6VSJ4LCShfnghJGGYQ2qER+UjqkdMjtcg7NmQW+Z7IwyLpAa54hgAZYW3zrHlFFMOakor5u4wVUxdYH1nepJvAYKDYbCZgWIoZLy6Nvw5ygi4Uu2OBq2AryIOx9ocUny0UAAUsweI89mdWJE0kOGuJ7+Lw5BvLZ2EUMB8S/RStORt8K7hb6rshmjUyyLqSghAXi9CpOSzRGz4enFC7AcXtSHAgrSNIuVC0tHJkusUziM/KAqv8xfQcvvELjmHL4gZWsabuBwVCYBrBm1bcXfTzOSQEc7KL6j+jvU/HzkjKofF9NJL9iG70y73RJSXOLxPv3Lc54Ud6bajLaWubgm4BifhOcScUQSIj021FPOgEwfbvDkeqUngxKFA1AW0IRjmM+I+a3WrFNr2uy5ZR0U/iNy0CtbQDCEeTt99ui6Zp5hFPCzdJR4M6oWAsG8svpQK5DbZSxASv8A8hSEeyc8unw8cFDh6F4dkX96lzXvga7/ugtlwJJ+tS6XR5HjWLo+eM/jALOIG4uAd8Ou6OpYpM/k0/8wlX3zHYGeP wpXmenDs bTS6aFyz8TwqOTdInGiLD7I9MVeJb6wsKj5tJMbi5+2p9jozRPLA/SG+SEVtqGELKf64vuILleJxKarNBoOk10Y/bQF/9xi86jmMqfpj7F6TV/kRQQESdUaysvN6enax41IPXOiyi926UgNdm9797kDE2EQ6R9LtUyO1wGuVoe/DOrk8ZAhaHg46HDbBRp7c9UZRT7UU3ZvEPnHrQOaoSmAvoN76Rm3v7uoScRqituQHHlmilRMvG1ae7NAYjxzsse5qnIMWdcNDHaKCmDKYVax16LVPFbvJ3PJtODqBV+GPWrjmhSITzFfUd+ZU+H5RHHRYc8tJlyUEwKtumTaEITBgXtZh+DbEAwQWuDeJneI8DTl+/HyIPPFekHaCRxWfQPe3inGJ4y4uNqZkieKMcTBT9Jlg85PF9Wu8nGpvSuN/EincBfh1Gmf0BVruU0TH+ldYk3jhB/bwxA4upXZkyTkueJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Some drivers (such as rxe) may legitimately call hmm_dma_map_alloc() with a NULL device pointer, which leads to a NULL pointer dereference. This patch adds NULL checks to safely bypass device-specific DMA features when no device is provided. This fixes the following kernel oops: BUG: kernel NULL pointer dereference, address: 00000000000002fc #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 1028eb067 P4D 1028eb067 PUD 105da0067 PMD 0 Oops: Oops: 0000 [#1] SMP NOPTI CPU: 3 UID: 1000 PID: 1854 Comm: python3 Tainted: G W 6.15.0-rc1+ #11 PREEMPT(voluntary) Tainted: [W]=WARN Hardware name: Trigkey Key N/Key N, BIOS KEYN101 09/02/2024 RIP: 0010:hmm_dma_map_alloc+0x25/0x100 Code: 90 90 90 90 90 0f 1f 44 00 00 55 48 89 e5 41 57 41 56 49 89 d6 49 c1 e6 0c 41 55 41 54 53 49 39 ce 0f 82 c6 00 00 00 49 89 fc 87 fc 02 00 00 20 0f 84 af 00 00 00 49 89 f5 48 89 d3 49 89 cf RSP: 0018:ffffd3d3420eb830 EFLAGS: 00010246 RAX: 0000000000001000 RBX: ffff8b727c7f7400 RCX: 0000000000001000 RDX: 0000000000000001 RSI: ffff8b727c7f74b0 RDI: 0000000000000000 RBP: ffffd3d3420eb858 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: 00007262a622a000 R14: 0000000000001000 R15: ffff8b727c7f74b0 FS: 00007262a62a1080(0000) GS:ffff8b762ac3e000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000002fc CR3: 000000010a1f0004 CR4: 0000000000f72ef0 PKRU: 55555554 Call Trace: ib_init_umem_odp+0xb6/0x110 [ib_uverbs] ib_umem_odp_get+0xf0/0x150 [ib_uverbs] rxe_odp_mr_init_user+0x71/0x170 [rdma_rxe] rxe_reg_user_mr+0x217/0x2e0 [rdma_rxe] ib_uverbs_reg_mr+0x19e/0x2e0 [ib_uverbs] ib_uverbs_handler_UVERBS_METHOD_INVOKE_WRITE+0xd9/0x150 [ib_uverbs] ib_uverbs_cmd_verbs+0xd19/0xee0 [ib_uverbs] ? mmap_region+0x63/0xd0 ? __pfx_ib_uverbs_handler_UVERBS_METHOD_INVOKE_WRITE+0x10/0x10 [ib_uverbs] ib_uverbs_ioctl+0xba/0x130 [ib_uverbs] __x64_sys_ioctl+0xa4/0xe0 x64_sys_call+0x1178/0x2660 do_syscall_64+0x7e/0x170 ? syscall_exit_to_user_mode+0x4e/0x250 ? do_syscall_64+0x8a/0x170 ? do_syscall_64+0x8a/0x170 ? syscall_exit_to_user_mode+0x4e/0x250 ? do_syscall_64+0x8a/0x170 ? syscall_exit_to_user_mode+0x4e/0x250 ? do_syscall_64+0x8a/0x170 ? do_user_addr_fault+0x1d2/0x8d0 ? irqentry_exit_to_user_mode+0x43/0x250 ? irqentry_exit+0x43/0x50 ? exc_page_fault+0x93/0x1d0 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x7262a6124ded Code: 04 25 28 00 00 00 48 89 45 c8 31 c0 48 8d 45 10 c7 45 b0 10 00 00 00 48 89 45 b8 48 8d 45 d0 48 89 45 c0 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 1a 48 8b 45 c8 64 48 2b 04 25 28 00 00 00 RSP: 002b:00007fffd08c3960 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fffd08c39f0 RCX: 00007262a6124ded RDX: 00007fffd08c3a10 RSI: 00000000c0181b01 RDI: 0000000000000007 RBP: 00007fffd08c39b0 R08: 0000000014107820 R09: 00007fffd08c3b44 R10: 000000000000000c R11: 0000000000000246 R12: 00007fffd08c3b44 R13: 000000000000000c R14: 00007fffd08c3b58 R15: 0000000014107960 Fixes: 1efe8c0670d6 ("RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page linkage") Closes: https://lore.kernel.org/all/3e8f343f-7d66-4f7a-9f08-3910623e322f@gmail.com/ Signed-off-by: Daisuke Matsuda --- mm/hmm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index a8bf097677f3..311141124e67 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -638,7 +638,7 @@ int hmm_dma_map_alloc(struct device *dev, struct hmm_dma_map *map, size_t nr_entries, size_t dma_entry_size) { bool dma_need_sync = false; - bool use_iova; + bool use_iova = false; if (!(nr_entries * PAGE_SIZE / dma_entry_size)) return -EINVAL; @@ -649,9 +649,9 @@ int hmm_dma_map_alloc(struct device *dev, struct hmm_dma_map *map, * best approximation to ensure no swiotlb buffering happens. */ #ifdef CONFIG_DMA_NEED_SYNC - dma_need_sync = !dev->dma_skip_sync; + dma_need_sync = dev ? !dev->dma_skip_sync : false; #endif /* CONFIG_DMA_NEED_SYNC */ - if (dma_need_sync || dma_addressing_limited(dev)) + if (dev && (dma_need_sync || dma_addressing_limited(dev))) return -EOPNOTSUPP; map->dma_entry_size = dma_entry_size; @@ -660,9 +660,11 @@ int hmm_dma_map_alloc(struct device *dev, struct hmm_dma_map *map, if (!map->pfn_list) return -ENOMEM; - use_iova = dma_iova_try_alloc(dev, &map->state, 0, - nr_entries * PAGE_SIZE); - if (!use_iova && dma_need_unmap(dev)) { + if (dev) + use_iova = dma_iova_try_alloc(dev, &map->state, 0, + nr_entries * PAGE_SIZE); + + if (!dev || (!use_iova && dma_need_unmap(dev))) { map->dma_list = kvcalloc(nr_entries, sizeof(*map->dma_list), GFP_KERNEL | __GFP_NOWARN); if (!map->dma_list) -- 2.43.0