From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC48C54ED1 for ; Fri, 23 May 2025 20:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E617A6B009F; Fri, 23 May 2025 16:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E39A26B00A2; Fri, 23 May 2025 16:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27E96B00A3; Fri, 23 May 2025 16:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B0DA06B009F for ; Fri, 23 May 2025 16:28:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2BE39BE7C5 for ; Fri, 23 May 2025 20:28:35 +0000 (UTC) X-FDA: 83475310590.19.6ADA1CA Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf01.hostedemail.com (Postfix) with ESMTP id 4BF8A4000A for ; Fri, 23 May 2025 20:28:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cKCTWrMO; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748032113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6aeXDyZRCKQtQf+44JC7dc6tXRgMsqq93+WCOHWY+ak=; b=nRph5ZohbhuY447djMDM6mU9Bic7ihrlx1eEeBhUS750oaT0mi5a8zlhTVfW/EHPmSXhHS uWwPulEXpX5hrSbDz+YHb4lLE16f2gcAzQkG3repPzimwI4lfZgEwvixQiy0DjnVdkjOXz sOjr5eRkvZ9PwiUPriCh/ZE575afSkM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cKCTWrMO; spf=pass (imf01.hostedemail.com: domain of kees@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748032113; a=rsa-sha256; cv=none; b=DajHSVOa0yUfoSFnievHFfwy19KwcaFRxdc/eT8jQwPJ4Q8u3F8WKJTNrSj3feQvtoAOH4 d1lIbfw5/kXunCHXoj1oF+s4f11lWArzck5RRPicjaSWbU2ef5O04KpCPEo8JBui77rRQF HeAAtOMcKPQ7sKlRwB4H/reHLt1dE0c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A175F45078; Fri, 23 May 2025 20:28:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74E60C4CEEF; Fri, 23 May 2025 20:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748032111; bh=mCqS/Kijb63hfjRogkIoo1V9a7plAKd5pBatsPb3zS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cKCTWrMOz8QGFkwtap37uEMcxPQVostPEoFPh+liJpGoIZm7yUbph01VSxYIZ9Mnu Xp2SFx8fCFcAMCn/ELInspiWG36xJF3J7d0jPlVxo6aeh9oNz5+dzf8Kq3g/Xe/so1 mYCrUnXAuBAVZPsZr7ruImlYVc+gipnIRXGuB54FA2ds4IMAQQ3eh1QLM/4b0qJj2M gTr/IjcVsa0wubmGcNRixgHZajZrPNsHowCdWXY/LC03W+Pu6hAChB6eWCEPXnK99u 2vaA5rFoq3M2ELAJVxf64ufJ8UJLD7jY5t0UU+6I6+n7SgWhzCzujvRIpD5lc47LG4 +IQz87qYLaslQ== Date: Fri, 23 May 2025 13:28:28 -0700 From: Kees Cook To: Sean Christopherson Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Mike Rapoport , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, "Gustavo A. R. Silva" , Christoph Hellwig , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches Message-ID: <202505231327.3FA45E4B@keescook> References: <20250523043251.it.550-kees@kernel.org> <20250523043935.2009972-4-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4BF8A4000A X-Stat-Signature: nw4kzfomak3iaop4eh5tnj5zgzit17ya X-Rspam-User: X-HE-Tag: 1748032113-687336 X-HE-Meta: U2FsdGVkX1/8DovC/cUl3mBDVJxZkfarAJgteSBat1ZCZ7aKMmeR2TfxXinFAf2/4ovdq41/Re9f/qmZFvSpdI7xC6xnLlkcFFb8IKIp3gzJ10Uqy7o6yo/qJofQDj7KNE58QdKRgbaMArRtUcb8TS3XQr55iEI+7JWZyzuATTQ79gquXTMN50JPJHfqvyiDio/uSAX1rs3LOHRNvgxzHIK+GfUpQWsmlmufm8QDUN97fiAUtfwUkXHIpmqF5s5xf+nwryCj/CMdHCYqgk9BPfgF2O4qjeqHMGwcCqBNLLJL+mPUfkkCAqlHky54fwMWt5WfjlNbX6DnS7NQ/lBfAfZUDZONdq5aC9j7cYljqLOjsTNBq7QhtGuIlU6MxJNKvsluBYRkD0Z1hWNKcUO+XeKTIiAUkWoqDJX4MDeE0Xh+fJRtToYpY+IVrlmZuZH9tjz7Z3aF/eU6BSym/00zsUPgUgMTWwnpzcAXTFxE6rjLYTp58lYTSHf/rC81jpz21ke/Cz634XGeHaxQem67umbb2UEbGctkZi1fQ1fUWrZMxIKzjmizLO/XNlcJX2qO1ZJawPc+1ls2oceLfW6gsDAPYgm0B/fbQ6/v9b+FBNq6wT0Auc/+D0TFautFVDsxJ47fx+0fyxJ/0gYGdIL8MiqDtXkzPhT/umhoCcX2LTkaGjRRHSfsklFqIdSh3AhPm4GD4Jz6oR4rChPBCRyxQiEPal1orI229fkF488t2ZGAJ25IDyBJgQUh1PvHkd38IWz3jDfflMxbZ8O8FKttBSTgiASVqygj9yDAnppLBlq8gsayxjGfdtxGHz+Y2ifks5AM9ECd5uwyuo6rLFWk2RaTx8j8ACo9hFruL6gK7ugBPrnGAFYCJHbDICYNNbDB1hdlYZc4tHDVNm3Eg/8MtepPMbH43u31PNI3pPxiphMUuYKQWVF2IFJCw3qGF6MlzC9lfl7ce/xU2ybf7Rr gU1D7MJu SAy3zgw6keP4CfwuuQa8tZtf5p7iLvmDm38iinQPPO0JfWyKFFPzM4lSZKXNpK2wMUjHhTfq/QPIeaPzuSHesYr+Td+pNJLWcqPsCexicjH0goK63ySlCOODtitH/DvkOL2FA8oNpMVBKUZOuDPx16rBZUS7xJDR4b935dpgB9yDFE/OY0VGKQhjlcOp/3AXQLyuKuYu/QIRzJcvhsQ3xjtf+uIsH1ONsJCJH0Z1N+NxtU9vJpXVpMg5TtIt4ZEd8gW6Td4N5m2RQvtqW8LbZ0OyGh9H4i8o+nPj2hptL2k4KkIJdpDWtbJJBSRNikn3W96bjUgA03RgBB3vE64uX+bPdXCxDq6I2JPxDydcPZ7GEUx1hBWDjKkY3gA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 23, 2025 at 07:35:03AM -0700, Sean Christopherson wrote: > On Thu, May 22, 2025, Kees Cook wrote: > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > > index 921c1c783bc1..72f13d643fca 100644 > > --- a/arch/x86/kernel/kvm.c > > +++ b/arch/x86/kernel/kvm.c > > @@ -420,7 +420,7 @@ static u64 kvm_steal_clock(int cpu) > > return steal; > > } > > > > -static inline void __set_percpu_decrypted(void *ptr, unsigned long size) > > +static __always_inline void __set_percpu_decrypted(void *ptr, unsigned long size) > > I'd rather drop the "inline" and explicitly mark this "__init". There's value > in documenting and enforcing that memory is marked decrypted/shared only during > boot. Sure! I will swap this around. Thanks! -Kees -- Kees Cook