From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E44C54ED0 for ; Fri, 23 May 2025 08:25:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 148896B008C; Fri, 23 May 2025 04:25:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D27B6B00C3; Fri, 23 May 2025 04:25:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB4F26B00CA; Fri, 23 May 2025 04:25:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C90426B00BF for ; Fri, 23 May 2025 04:25:32 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4C925141C9D for ; Fri, 23 May 2025 08:25:32 +0000 (UTC) X-FDA: 83473488504.23.DB9BC4E Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf05.hostedemail.com (Postfix) with ESMTP id 5E3B6100004 for ; Fri, 23 May 2025 08:25:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CiiQdINw; spf=pass (imf05.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747988730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YIt+tQvqN/b+WOLsIlbdB6d57Op4QEcknN1TYeFItpA=; b=gyepuG8l40yn/0CnHSZJTonOGdpsWoVCBYffj9/L4OE8M27/DBOrOXIF3PdLKVnPjxJsmy WB+sgdylON08M55b7Sd5/Dz/z01X6OpZVHzCWygkfE8M9YBRJzctnR6/kSbPmO4QFwdPZA LWy4iB2xIxCFQhW/SxSvrtEdymLZ1vU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CiiQdINw; spf=pass (imf05.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747988730; a=rsa-sha256; cv=none; b=iGOyzGSPbcPf4j0lbB3aqU9Ou2oJZ3TEU7O3iT4Eo5WAHCyvb9hORY0Na9PpszHhZ4ZKoy WlK8jK6Cvo1UevJDy+xV97TCpJ34VwxUhEbStsaGBvdmbuPQMyd3mcr/+VtliEkhQ667kK ZPoho2biqxog+uscHfkp3EsmJ3HWfb4= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-742caef5896so4992116b3a.3 for ; Fri, 23 May 2025 01:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747988729; x=1748593529; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YIt+tQvqN/b+WOLsIlbdB6d57Op4QEcknN1TYeFItpA=; b=CiiQdINw5wC6ELGhPdbyu8pD3yvgMwkhAfwiRFcbSGo1abHr0jVDd3MM7BNnFsHojG hLL/k/rL5+t+EmXTXFJCRfnQi6TuDRhXrQVymv0+ChX/oLVxEFgawvEXQmVxZP4BDDLi /7JsBAcOgjVRnu4VaBgDELxP+pAXOKBfNfbVslWqOYRmqXV4+fOsBdhXoWQEJW68ysyb xxUbxbfjdjafMg8MIqwW9ZJaufpd1EvvcmtxQ5E8i7wE+h/0ijAsIvyFKTlkTi+cU2Xa P+1iLAZDpE4Vf/sot8J4yUQh4sDjhFwEyZ6YJU0A32X11ESuk7NW7ZllUSxuCnv5fOYo 1/OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747988729; x=1748593529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YIt+tQvqN/b+WOLsIlbdB6d57Op4QEcknN1TYeFItpA=; b=Rjh1WKcKmomOmMVrhjFzYQFKp6Zf3ANpXQqfP0qgUzIGL0+Z1jEJb2xhYipf4wabqj +LOq9Sk6Xgeiv6qmRbEzqjFT/y7u5hRJGipWWbI7AXjqXCsWRbeGIJMdfqw7+Xr/zuf0 6NnAaGH5s4E2o15uWTDJ4DoyJphH10jSgheCyIlkgjqG/gxksEXUKReOAWGs7n0Zglsy iGkEdW1XuY3GiLF++jzRorz0KdM/0ok+UbNCEw3KwWmsCQsjzxDAQ+qTlGG+9XmqLT2O D43N2ipWwnpFWqUF+/PvXs0TDUWARPQVNLyjzSMGn0A1NOdWNsG5e3JqM+JqadmjHUmm aI8Q== X-Forwarded-Encrypted: i=1; AJvYcCULtFhqDridrVB00roW9OtzdgQFQ6vavXvLLwTGcFYsOrw2epLfxApp9mKIRTq8bfRsVPTeJrQngA==@kvack.org X-Gm-Message-State: AOJu0YxMRdhRNtSs9z8yvUXxNqfdruObiQGMttcpgzOphATv48LHhJEm lNKmIkEDMs5vSVPyOca4yLhpCWKsXKKgxsxLEX2ONXNf7pUa8olyEMjR X-Gm-Gg: ASbGncvf3C2QOJy+g6WlnpC1XsZRh9tYRed7CH5UNM8QECV1ZQGqSUzhyrGjKkqdk92 cdNLkZ3+W+yscDpSKk5yN/ELc/oJvFYXxOEJ2AYoNCaY8NBxwnTQIcCJL5yPZOjRTBLTA1LC7hG Spm3+YTCQ61rVgjVqIFcqZO3R8qoaSOJjQ121Ojjg6h3fEjnLSwpz7gl5PwTg8Y0ZmWhLJ84Tgo OgdCv8o+heKtrdLIMcdvQta5A6/7R3QgPw64hCJTRHQa3ccwpz/kyxbJzfYsHaCl3LtuxW43byd ReXl5vjZJ6mHiCfaEe60DDdU26nwVl26lR0FhqlO4LvoWZoaloCui7FuKvZ4aZH5/E/O X-Google-Smtp-Source: AGHT+IExkp2mLsDMFw66X43a+5MBxL+Wj6GFFM5Mc2D21q6j82/DMbt7bLVlk5NMNu3vKnXP05HHjg== X-Received: by 2002:aa7:88c8:0:b0:73e:2dc5:a93c with SMTP id d2e1a72fcca58-742a97c4fd9mr35894458b3a.11.1747988729060; Fri, 23 May 2025 01:25:29 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.145.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-742a98a33c3sm12799448b3a.176.2025.05.23.01.25.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 23 May 2025 01:25:28 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: 21cnbao@gmail.com, david@redhat.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, bhe@redhat.com, chrisl@kernel.org, fan.ni@samsung.com, harry.yoo@oracle.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, riel@surriel.com, rppt@kernel.org, ryan.roberts@arm.com, schatzberg.dan@gmail.com, surenb@google.com, v-songbaohua@oppo.com, vbabka@suse.cz, yukaixiong@huawei.com, zhengtangquan@oppo.com Subject: Re: [PATCH RFC] mm: make try_to_unmap_one support batched unmap for anon large folios Date: Fri, 23 May 2025 20:25:17 +1200 Message-Id: <20250523082517.3144-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20250513084620.58231-1-21cnbao@gmail.com> References: <20250513084620.58231-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: ytpued6tfggmbu4fdthaf53okk5wak3o X-Rspamd-Queue-Id: 5E3B6100004 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747988730-730922 X-HE-Meta: U2FsdGVkX18GDSwjBLxA2IFEwwRwWF9B3O+pF2W5mC27LO5AWG7lPInqfku7VNgiUgrnbK4bfiaUELijS/s9XsyYShHRfZN+za97aeNCFO4Y7PAImKWZoyDhcJ1mmTQgvRdJA9P66MoCTxbjc5Xd2NB9LMquorXSg3eD8LIaWtPLp/35cK6kbnZxBLOZkKpPs86qRzKwsMUmKgZxKGKA6f3WdCTP0p7Gx22VzDC2qp6vHyKqlMN3b4BkRHC4eXrrCvSdlJ79VaxI9GWHWPSkBf78xhptuG5JYH68c2ky5A1YCl8Bq3ZfaYK/dZr3mD/U0bXk5oQwTaBzEJSEf0GRK2kapazXVJjnDsCZHhYDGQHBdbYOAZ14/zL6bzDodCQ5UjCUWMGPtBwFvFx8ZPFFEH1ohxaxCqfQEXDN0akrR9dFgaIDlQBzDjC5pIXFwvphMf86nWaqqdDr/Snj758ZW4gI7p742HS5KUpsxQ4EApgQ89sKFBbsVUbnm+7RaV0Wu5OI2qkJljj9NCYiki//3w78pNxP38pTmx0sxUEJOwDRU9J5uPXavx2S3Kw/DtxBj+f/QhVPxGY4IuWoOsu/zR3qzdWJC+Y1cjeLXYBt8aX3hkbApeDZansrOaf60EwVaVCi6eNlhnqJavs3a26QeZ8qdeQPfSHcQIhIE9lRA8vhAbor5sD0LYNwaoc8V+LJCfXzMmsMCkvuuFeyL0TzxLYVoA8RzE54H6Xf+bfXBzCSumxzShCebU+GZpEBi+DIheslKREICp2yISZUTATI/d5zWMmZiFoPWveMFht63xOAujoOqY8R+jmsuCUPZjqGEUyzJzZQwYwt127dNeMf+kyjawvnIq5QLkGbtulUiqUrZys47SB7qC54cMHifn7CD+2mcO1e8o+wSQ8vM5HYv1kYsVB1xjQbi5dS9bHWho5cscfAl/yydDSMbfsq8sixwdd99UXJQ29AKl0cszJ UOCpQCCG qbyAU3EYwayjlWEYqPe79c8qFTAzDOMNuWP2TwCTD5144nzUCLOnazScNhJJhJ3zzvuF5NlH+2fr39FO341fex8gbAhAnOOaWgaXckUbinqJcFTmGlzgn81mU6ehl2gWqInEj8tGVOQDoksxwHr6En1bBpRrdrC0FHfd0eD38TN245uVd5RWAxiC9E4PHmuUOYcuXRhbnXRc5X4V2ciSlDVxmNdz0bruvovbd9N0ggufDihWHzj4FjLorBSSlJ/OU+zOlLLCKEcvqGgvguBjDTOq5ba5HKekOOnWfu1nugx0wLcWnK8Ro810m3hinbfzwfXq6nVJEulFSjnYlv87Ax+0R7yIoe7zbriGp4HkNQf+62lOdF3g04sM0uJaF599fDNg4x7QN5jQ9j2f8234pBY0YRpPrn6OxZ/q8OPPfK6SMrbhHVrEat9cYL0WiIT2wp3Z8hV2RXMEFgE4Ia5dPGgueYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > @@ -2159,9 +2179,10 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > > /* See folio_try_share_anon_rmap(): clear PTE first. */ > if (anon_exclusive && > - folio_try_share_anon_rmap_pte(folio, subpage)) { > - swap_free(entry); > - set_pte_at(mm, address, pvmw.pte, pteval); > + __folio_try_share_anon_rmap(folio, subpage, nr_pages, > + RMAP_LEVEL_PTE)) { I have a question for David regarding the __folio_try_share_anon_rmap() function. I noticed that it only clears the Exclusive flag for the first subpage, even when nr_pages > 1. Shouldn't we be clearing the Exclusive flag for all subpages in this case? Could this be a potential bug? Thanks Barry