From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF10C54E90 for ; Thu, 22 May 2025 14:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BA0A6B007B; Thu, 22 May 2025 10:58:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16AFA6B0082; Thu, 22 May 2025 10:58:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 081766B0089; Thu, 22 May 2025 10:58:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD34A6B007B for ; Thu, 22 May 2025 10:58:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8AD8A1A17EA for ; Thu, 22 May 2025 14:58:13 +0000 (UTC) X-FDA: 83470849266.12.083D947 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf11.hostedemail.com (Postfix) with ESMTP id 67AAF40002 for ; Thu, 22 May 2025 14:58:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747925891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4bqNngK4uY9Vx6n0/HtWVT7BD6CNMvgIVtCvOi9JA6U=; b=tdEYV3A1fb1hwYMGiFweBlzns6O12j9oxXWtMZmYhxFUxE60p2424fsJTx+x2PT6t+Ma3W gJcHEEXjAzOEXpVtNVuCBCDCnPAQERBisqRIHAG3qn7vWVZd5VjU679816WBOkPEQWLUWg hKvZ1Ml4Qim8TC+7gyj87nidxixiTQU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747925891; a=rsa-sha256; cv=none; b=qSxkawV8rELnKHuEEqM89HZbY/J4UTDYWghOF1VvOUh6nzIfxxt/2KTJaOx9qLFbdaUiRk q33hW+buMOVTgc3kE9+B0U/hWDZ8MpoF5HVOCOKFMHNDPD6CRjvPBTzY25R41lEH3wWFsO dTtWZu5u+8Ul/7Di4Mia0TEg5GaUJlk= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b3BCZ4Lk5z6L5Bh; Thu, 22 May 2025 22:54:50 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 70E2D140390; Thu, 22 May 2025 22:58:05 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 May 2025 16:58:04 +0200 Date: Thu, 22 May 2025 15:58:02 +0100 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v7 0/2] ACPI: Add support for ACPI RAS2 feature table Message-ID: <20250522155802.0000648b@huawei.com> In-Reply-To: <20250519151116.803-1-shiju.jose@huawei.com> References: <20250519151116.803-1-shiju.jose@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Queue-Id: 67AAF40002 X-Stat-Signature: 58her3ezz8spmpirngxqad8kts4an9hn X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1747925890-232657 X-HE-Meta: U2FsdGVkX1+fArJvq7ZiJsz82t/RXpAAjA9NkHfjALJuYOqpfjxK1IOlwYua+2jW6G8/KKNz6/1fAZE88m8ed4BSjMuRLzCkXgAznpnQVDP4rMDpaUma0bqIPFAPVrkbYq0lqZVmDPOegcjTXvvNBeIbRva3NFphv07hiM+qm0ByC8GWposxRNEl5/slWS3n9dd9CMEROBSjH0/0M9JBZTueTPaAKd/8W1/nkCTAonWweTkPQwP4xEGKIEIkA2RRpV5J+CKQEWXnQfYUAn1FPXcnRkwVUFlq/wO2JTqg0uHXqFFcWuIIlxKZxK+li/L4q5gyCJ+xbBlEvkANCQUlfafI7+BYD7lABxXN1H0iO/JAkzFWutxfh+Aa7T/Zbqu0KW+DvpxHMDgik7M8XMk0xxRgCdxZBn9FqoT2y/KSbqwAX3qnpcAwFNjCdQeha0yyvI6wJaW1VGHwEzu/FnU0/anVkQjUp6HYwJ9dKiHHxBHEL1d/KBz9mWQvkAk24LqTU6Qb4dM1gQpPz1XkQEm2AZDWR0+7oBX3xQvotyt5K7qzSjlyuvrGPxZaLKIBg1ppuUVGdBeA3MkUWbUL2P7EqLxXqUiUg1pCHubNy79tO3bQlTrp2kMByARRTlF2ySAgpkJOde0dmbfc/1tSRH475pe/UsgWhWJYVdomyq2gArN87GNlfLpVXCKEjui+ptC/M5h6JnR1qgxbpcWC9GAQXOwV2lX7JcHpJIfTYyCwFA+KuvTxKsJcv3fOQpoVpJACioc3EIcQgJ7397HHL1I6CMTLelK/XqW+MSKe6J+uqI11ONvN22ymUqRhYU20poMNV+MmcxOnSebKT0XUUuHclZjCOXYd58g7fVfHktIJ0QID9zJZKPAW2uxiwjWU5SGx45rWgWZS+EjDKWIGuVLEoa7E791AuKg1z8DzrHuTkodIFqy8K5qHOjEmoDC4mdGcYZmA/5HaqoNZLG2TCm5 4+TSH+XC PB1oCW3bj3ovdZnkXH2YOhwxvxauyO6vCpr2J7zF2+WFTwkplrB4rjv6Bw9wRP7wqnkjMdcATuezHQJTelnFAHIbsdmt/G8vq+ryAHjDrf8KvWzOkIeEEVMvWwnYjPn9KnEj9jzvryT8C1MbdxrxVyBZebBcAKFH3bjyinIrzKi7OXfzO5JoQAfDyFlC5UrJxYI4e4sMzMaE87Wbz5AT5ubLavMZRKLuWVLGApjnG5By7UAIlCDULOMQ3lHqdVQvZmLj3QtzyaIG1CXQ1AZ3QJH7VEEUYHvHL8gt4CTzTSaebPy/rE/eH/fknSMuPOlYpM2kBajIfWhh2Nl7TAfKpyAghc780WHu3kdPoVVdD/RA50LU4+S7xGi2Q29QG57YotPrjwA4yAe7PHO+jnSWMQVIYdsTJLUs07UwS59OjIEP356A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 May 2025 16:11:13 +0100 wrote: > From: Shiju Jose > Hi Rafael, Are you looking for anything else for this series? (reviews from others etc?) The core EDAC support when upstream last cycle (this was in that series as well so is kind of version 27). I believe the expectation is this will go through your tree. Tweaks have been pretty minor for last few versions. Thanks, Jonathan > Add support for ACPI RAS2 feature table (RAS2) defined in the > ACPI 6.5 specification, section 5.2.21 and RAS2 HW based memory > scrubbing feature. > > ACPI RAS2 patches were part of the EDAC series [1]. > > The code is based on ras.git: edac-for-next branch [2] > merged with linux-pm.git [3] : linux-next branch. > > 1. https://lore.kernel.org/linux-cxl/20250212143654.1893-1-shiju.jose@huawei.com/ > 2. https://web.git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-for-next > 3. https://web.git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/ > > Changes > ======= > v6 -> v7: > 1. Fix for the issue reported by Daniel, > In ras2_check_pcc_chan(), add read, clear and check RAS2 set_cap_status outside > if (status & PCC_STATUS_ERROR) check. > https://lore.kernel.org/all/51bcb52c-4132-4daf-8903-29b121c485a1@os.amperecomputing.com/ > > v5 -> v6: > 1. Fix for the issue reported by Daniel, in start scrubbing with correct addr and size > after firmware return INVALID DATA error for scrub request with invalid addr or size. > https://lore.kernel.org/all/8cdf7885-31b3-4308-8a7c-f4e427486429@os.amperecomputing.com/ > > v4 -> v5: > 1. Fix for the build warnings reported by kernel test robot. > https://patchwork.kernel.org/project/linux-edac/patch/20250423163511.1412-3-shiju.jose@huawei.com/ > 2. Removed patch "ACPI: ACPI 6.5: RAS2: Rename RAS2 table structure and field names" > from the series as the patch was merged to linux-pm.git : branch linux-next > 3. Rebased to ras.git: edac-for-next branch merged with linux-pm.git : linux-next branch. > > v3 -> v4: > 1. Changes for feedbacks from Yazen on v3. > https://lore.kernel.org/all/20250415210504.GA854098@yaz-khff2.amd.com/ > > v2 -> v3: > 1. Rename RAS2 table structure and field names in > include/acpi/actbl2.h limited to only necessary > for RAS2 scrub feature. > 2. Changes for feedbacks from Jonathan on v2. > 3. Daniel reported a known behaviour: when readback 'size' attribute after > setting in, returns 0 before starting scrubbing via 'addr' attribute. > Changes added to fix this. > 4. Daniel reported that firmware cannot update status of demand scrubbing > via the 'Actual Address Range (OUTPUT)', thus add workaround in the > kernel to update sysfs 'addr' attribute with the status of demand > scrubbing. > 5. Optimized logic in ras2_check_pcc_chan() function > (patch - ACPI:RAS2: Add ACPI RAS2 driver). > 6. Add PCC channel lock to struct ras2_pcc_subspace and change > lock in ras2_mem_ctx as a pointer to pcc channel lock to make sure > writing to PCC subspace shared memory is protected from race conditions. > > v1 -> v2: > 1. Changes for feedbacks from Borislav. > - Shorten ACPI RAS2 structures and variables names. > - Shorten some of the other variables in the RAS2 drivers. > - Fixed few CamelCases. > > 2. Changes for feedbacks from Yazen. > - Added newline after number of '}' and return statements. > - Changed return type for "ras2_add_aux_device() to 'int'. > - Deleted a duplication of acpi_get_table("RAS2",...) in the ras2_acpi_parse_table(). > - Add "FW_WARN" to few error logs in the ras2_acpi_parse_table(). > - Rename ras2_acpi_init() to acpi_ras2_init() and modified to call acpi_ras2_init() > function from the acpi_init(). > - Moved scrub related variables from the struct ras2_mem_ctx from patch > "ACPI:RAS2: Add ACPI RAS2 driver" to "ras: mem: Add memory ACPI RAS2 driver". > > Shiju Jose (2): > ACPI:RAS2: Add ACPI RAS2 driver > ras: mem: Add memory ACPI RAS2 driver > > Documentation/edac/scrub.rst | 78 ++++++ > drivers/acpi/Kconfig | 11 + > drivers/acpi/Makefile | 1 + > drivers/acpi/bus.c | 3 + > drivers/acpi/ras2.c | 450 +++++++++++++++++++++++++++++++++++ > drivers/ras/Kconfig | 11 + > drivers/ras/Makefile | 1 + > drivers/ras/acpi_ras2.c | 424 +++++++++++++++++++++++++++++++++ > include/acpi/ras2.h | 70 ++++++ > 9 files changed, 1049 insertions(+) > create mode 100644 drivers/acpi/ras2.c > create mode 100644 drivers/ras/acpi_ras2.c > create mode 100644 include/acpi/ras2.h >