From: kernel test robot <lkp@intel.com>
To: Bhupesh <bhupesh@igalia.com>, akpm@linux-foundation.org
Cc: oe-kbuild-all@lists.linux.dev, bhupesh@igalia.com,
kernel-dev@igalia.com, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com,
pmladek@suse.com, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com,
alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com,
mirq-linux@rere.qmqm.pl, peterz@infradead.org,
willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk,
keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org,
jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com,
bsegall@google.com, mgorman@suse.de
Subject: Re: [PATCH v4 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation
Date: Thu, 22 May 2025 04:02:41 +0800 [thread overview]
Message-ID: <202505220326.5yDQHjnt-lkp@intel.com> (raw)
In-Reply-To: <20250521062337.53262-3-bhupesh@igalia.com>
Hi Bhupesh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on trace/for-next]
[also build test WARNING on tip/sched/core akpm-mm/mm-everything linus/master v6.15-rc7 next-20250521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bhupesh/exec-Remove-obsolete-comments/20250521-142443
base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link: https://lore.kernel.org/r/20250521062337.53262-3-bhupesh%40igalia.com
patch subject: [PATCH v4 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation
config: arc-randconfig-002-20250522 (https://download.01.org/0day-ci/archive/20250522/202505220326.5yDQHjnt-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505220326.5yDQHjnt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505220326.5yDQHjnt-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from fs/coredump.c:20:
fs/coredump.c: In function 'do_coredump':
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:655:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure(
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:730:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("Core dump to %s aborted: "
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:725:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("Core dump to %s aborted: "
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:618:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("over core_pipe_limit, skipping core dump");
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:642:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("|%s pipe failed", cn.corename);
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:625:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("%s failed to allocate memory", __func__);
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:611:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("RLIMIT_CORE is set to 1, aborting core");
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:591:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("format_corename failed, aborting core");
^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:752:4: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("Core dump to |%s disabled", cn.corename);
^~~~~~~~~~~~~~~~~~~~~~~
fs/coredump.c: In function 'validate_coredump_safety':
>> include/linux/coredump.h:57:7: warning: array subscript 16 is above array bounds of 'char[16]' [-Warray-bounds]
comm[TASK_COMM_LEN] = '\0'; \
~~~~^~~~~~~~~~~~~~~
include/linux/coredump.h:63:43: note: in expansion of macro '__COREDUMP_PRINTK'
#define coredump_report_failure(fmt, ...) __COREDUMP_PRINTK(KERN_WARNING, fmt, ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~
fs/coredump.c:1006:3: note: in expansion of macro 'coredump_report_failure'
coredump_report_failure("Unsafe core_pattern used with fs.suid_dumpable=2: "
^~~~~~~~~~~~~~~~~~~~~~~
vim +57 include/linux/coredump.h
46
47 /*
48 * Logging for the coredump code, ratelimited.
49 * The TGID and comm fields are added to the message.
50 */
51
52 #define __COREDUMP_PRINTK(Level, Format, ...) \
53 do { \
54 char comm[TASK_COMM_LEN]; \
55 /* This will always be NUL terminated. */ \
56 memcpy(comm, current->comm, TASK_COMM_LEN); \
> 57 comm[TASK_COMM_LEN] = '\0'; \
58 printk_ratelimited(Level "coredump: %d(%*pE): " Format "\n", \
59 task_tgid_vnr(current), (int)strlen(comm), comm, ##__VA_ARGS__); \
60 } while (0) \
61
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-05-21 20:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 6:23 [PATCH v4 0/3] Add support for long task name Bhupesh
2025-05-21 6:23 ` [PATCH v4 1/3] exec: Remove obsolete comments Bhupesh
2025-05-22 6:18 ` Yafang Shao
2025-05-21 6:23 ` [PATCH v4 2/3] treewide: Switch memcpy() users of 'task->comm' to a more safer implementation Bhupesh
2025-05-21 20:02 ` kernel test robot [this message]
2025-05-22 19:46 ` Bhupesh Sharma
2025-05-22 6:15 ` Yafang Shao
2025-05-22 6:27 ` Yafang Shao
2025-05-22 19:44 ` Bhupesh Sharma
2025-05-23 9:40 ` Dan Carpenter
2025-05-21 6:23 ` [PATCH v4 3/3] exec: Add support for 64 byte 'tsk->comm_ext' Bhupesh
2025-05-23 3:48 ` Kees Cook
2025-05-23 12:31 ` Bhupesh Sharma
2025-05-23 20:55 ` Kees Cook
2025-05-26 11:13 ` Bhupesh Sharma
2025-06-30 7:58 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505220326.5yDQHjnt-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bhupesh@igalia.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox