From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1800DC54E71 for ; Wed, 21 May 2025 14:25:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 857596B00B3; Wed, 21 May 2025 10:25:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82F0D6B00B4; Wed, 21 May 2025 10:25:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 747B76B00B5; Wed, 21 May 2025 10:25:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 52A6D6B00B3 for ; Wed, 21 May 2025 10:25:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DFDAE5B63E for ; Wed, 21 May 2025 14:25:33 +0000 (UTC) X-FDA: 83467138146.26.9B6DFA5 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf15.hostedemail.com (Postfix) with ESMTP id 148DCA0007 for ; Wed, 21 May 2025 14:25:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=a0RN9N9q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747837532; a=rsa-sha256; cv=none; b=CCW6UTiFhYngyNGHnIcW67CxQMpQdUBPqVFp++3FXylOAyl8K+z1KY3FYLXhJq6Vn06mHu DMNO9GIK33Ohh461g9zM0D289/tg+fugMmv86c2RNpOjodT/Vq3R7gg0hO7fGiUQ9F4h+4 zI/kPhpTpCOk+5vyfMkUinJxwdbVXDg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=a0RN9N9q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747837532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=bTV+0yNwT2AirgQziM0cVofsthdmprW68m/JVhQEzJw=; b=A9iG+VloXtE0MfUVSfHPZxHg9uhoAS3dcz5IeCn8KEW8PAYYhqe2CPRGPbGK3EifLhNd6J Po9arLcc9L58/wmKedN1/4iSzkAMEE/E6WSAgM3ubGvfSEzwT21dFfp4Al2yIOOI/PbPrH LCiLF/DTAP1p3oE8Rm2fo1S5+4UH810= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4774d68c670so100544541cf.0 for ; Wed, 21 May 2025 07:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747837531; x=1748442331; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bTV+0yNwT2AirgQziM0cVofsthdmprW68m/JVhQEzJw=; b=a0RN9N9qbvOWr0aHw4xGlkU76a7czw31vfnBMXRqKjXQrcfnLPEbc/RxbVEefackXS LWDhBWhdhmqrIhWEJO02oNcIr+FB/Ys6O6Kz+aa668IJwukDj54ZUtlHdXojM5TG05q6 B5xSfp25cVCFoIh5GZLItmT4dGmpRgXaOAOGZ9qVwqzY3dGU7GD2x6qBoiNiuqpGllWv vGzGbxX3At38DkAjOeZ+VWZbHahyzLN3z9RyKl2XAAK6HQSqdMI8qrYM5KYaczOo1Woc DbikaXNpG1vOCFS8mSUpGzi6UYz2Obx06mI5wNaojU0LclnzzxneBzEf9cr5MJIQVxZM Dotw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747837531; x=1748442331; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bTV+0yNwT2AirgQziM0cVofsthdmprW68m/JVhQEzJw=; b=ZuY+d3Rdcit4cMbxjMxkXs/+CKKwA+AJsb8lDehezdk0LD80Tig9h4fkx/mcWyPOPH 9BtwayvhLD5zBeISP2E4dOXSstkGVLPtMVAj/tU4DU9SB/Jib8ZHklPU4YWqriU3z4kG Ey8O4T6WBfZk4IaSXTizvYSRVo7p4ZogkqPy3DbcIn3aZHRQgVY8F/f1sQJx0zFszsIE CGrplCttTRrtVjbetsYBAOG2PM0qdba+kZQrOo1I94tt11P+Gzw6RbAUObmgmJWPj3aw W6LXWnCGFqgRBg/VHbSaZH1v8TD2uGJCdLNXAxLVFX6brnCRYzbRJMSRbkfbSd2IYeGt vhlg== X-Forwarded-Encrypted: i=1; AJvYcCVUcahgTmibQsCo2bZRj5g06/hSQzg1pYbCdGbKwmYk3U9igRV2SPaun9WbRdxUzaiuwOmZFytmdw==@kvack.org X-Gm-Message-State: AOJu0YwoqQesHewiGwF5Zpx4GxL991ghilBF1YkAAItk9i5jBx3UUzoP dEYS9OWwfqdwmz+S9aZdZBnERJUDQu3glpmk+6se/O1Ed8Mu654tXYOo X-Gm-Gg: ASbGncvoDcs3YhbNCmQHch2RsOfoYW5hSUdjfX15LLJjO0N3SLi6cOq/6EU1T3joysT b2WSJ92/GcXk6FEl3uodjNlGMbRAGtmc4IJcNhOYZMB0Yx6sV26R1zbCQ/z4NidHjPbvmyViPnX 5wdzpsxmiSCro4QzjZnDXeRoAa+PFDsVYdu0+ldOpNO563KqAIiG4ae8mGRqvsG1S3X7Y+GzIW1 nuDA3fCSIuc3KBRlAdauMmcsnEl89W5VkqbgSeLPdHgsc3gRSyIxthV5cIwzwYnwrp0LVmS1dqn QTjp2YoruvDwMz7YNmvqH+bFPEgO1KYUJyRkXtvQY9LMBLjwnaMwXs0VKtLa X-Google-Smtp-Source: AGHT+IGJ0ff2P8PVMyFv7jR8lBEHrrx/8AzvYD2AyqGTlxL78Q+9oY84GVU7SAYIqbomBI8CnqDdLQ== X-Received: by 2002:ac8:5ccd:0:b0:476:739a:5cf3 with SMTP id d75a77b69052e-494b074d0c6mr371222921cf.1.1747837531149; Wed, 21 May 2025 07:25:31 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:43::]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-494ae528f08sm84171971cf.72.2025.05.21.07.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 07:25:30 -0700 (PDT) From: Usama Arif To: Andrew Morton , surenb@google.com Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, cl@gentwo.org, rientjes@google.com, vbabka@suse.cz, roman.gushchin@linux.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, kernel-team@meta.com, Usama Arif Subject: [PATCH] mm: slub: do not warn when allocating slab obj extensions fails Date: Wed, 21 May 2025 15:25:21 +0100 Message-ID: <20250521142521.3033264-1-usamaarif642@gmail.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 148DCA0007 X-Rspam-User: X-Stat-Signature: 8yjhanxsotpz487mj6a1a6gpo5ngqxk6 X-HE-Tag: 1747837531-981960 X-HE-Meta: U2FsdGVkX1/5YlsoxWqtHzSIF0i6KRuhul4ISgsfmZXZQByAr7uRGHDhelxIUoZvhOsHActSVwrct8FvlU/hYIMVyAIvD5sn4utH5qY2JXgCk2YDCtxER2T+IkIkmDXwNmaU3hh6Q+klLA7MZYVKIg6iqU1iFNPJjOOFTDcLTYh9vTqeOgupHzhLFV2xnik94w0fcay+T6VHwyH+6aTshzYcuq/0Em5z4C+matXWJGJZ162nDrR2w+rgLN7b0MklUUMUIh3x/g2DWmHKpVZHlGOXF9mDtn889MSuD3RF80D8DccuK97etxDXkGkP+lCyBW2yyMSGihjDVEwBXvJultOxiAGx47LV1surTkstMbNENw68qwd+jo9UftyIYtRVXZSh5QU7keD62mSp8NQ2FQdt/AkYAnytKnOmUJIMU7WtgSWR0CXJ37gjYf/+XPhCGAXPSVhZLG8/WTrd3jJbA5Yk3OfZoB0Mv9RQfJibtIj7Se+uKmie09+PR0hGxT8pxjT4zoKEe43zwKyhUrTr5PkIVE0jc5nBkjlX1tfbWpUUvValkJLpAtEvyFXee7D4MB17JYl5Xzg1aC9GsUq/yctt55IbfuhbMAbT78DZ0wVnRCPX1Sc8rwXXjw+zLp5QyTjPiFH98pC7/ab31FzNckd8jUCFPaUYo0MeHoFvrI283FE6nKv29FdYbnIpT7eFyrJSDhmj1Age2g5bKI/E74jzrgMNBJm4btMn/xZwto1HBxpuY2xuQpClZYzWgyrLnldW0/UMPoGsqbWDLjdf99XSZsQ0RZmrvGPv3r+tWyvULoohTtFSMRq7LiRahO51LnroG0qoKBEbgLc148wliKRAPsiVGNnKRjiBM2+Ospa8RL6cNsQKpdNCR08wKNTrQWQ7NCt2F8+CBYKJEmoo5To0NWPsnSvUIUUf6AU60RaClpaVZYno1wYdGCeLwfN1YQIb0ZZjX41sGBIhH4V Q61N0haV VRfkCZvQOaAyzwY3qPcmjMOI3h7TLWiEaMuGg5jCOJ94Er3A9/efJwE9WaFFvZn+RzIOFxj00uifYnWGw/Kr7255wxYc1v5vXxY/FL6ca+UZthsLpxe2FzmiDn6dxT+b8em5RxLXqna1CavXUqCauPU4KNRLQmAVWg393o1FDko8N/3d7qjVMt0oqGvbvxw4WHIRbhjnaqfjyr4PL7O6QRLgHQPbSrIS4JMC852BYR5rxV1bOVU45X6sx+loER/6Ts2l+UESszQDES2+SUE0yMKs0SCwoPcP4QA6KcIJ0BGkMM3ErcM6ik6l+TdvZfLhm9XJrm+Mhn5+Mg2PRimV/P7R4WztFsZbENS9Ic6yFvVoOkdsNposX+cMeLutxEp6fDOBC9nBtzCN/bSJ+oQC/mB/cPw3M8MRieK6CicRUgIoEERuxZ8esiIv16rPhfXgvsoR7RAm45wpcRg494MA0G1zGNV+H5ZMjPJapAFg3OxBQr7bjQFZqRGJILQaAisLKZxsQGzmgonfRcvW1vjd3/qWXAHupBS/h+epPU3VAQAWqAF4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In memory bound systems, a large number of warnings for failing this allocation repeatedly may mask any real issues in the system during memory pressure being reported in dmesg. Failing this allocation is not indicative of a bug, so remove the warning. Signed-off-by: Usama Arif Reported-by: Vlad Poenaru Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ --- v1 -> v2: - remove the warning completely. We will have a way in the future to indicate that the mem alloc profile is inaccurate. --- mm/slub.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index dc9e729e1d26..06ab9a558b73 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2102,9 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) slab = virt_to_slab(p); if (!slab_obj_exts(slab) && - WARN(alloc_slab_obj_exts(slab, s, flags, false), - "%s, %s: Failed to create slab extension vector!\n", - __func__, s->name)) + alloc_slab_obj_exts(slab, s, flags, false)) return NULL; return slab_obj_exts(slab) + obj_to_index(s, slab, p); -- 2.47.1