From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600EFC54E92 for ; Wed, 21 May 2025 11:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0132A6B00B9; Wed, 21 May 2025 07:55:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F05FE6B00BA; Wed, 21 May 2025 07:55:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E43416B00BB; Wed, 21 May 2025 07:55:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C5E3E6B00B9 for ; Wed, 21 May 2025 07:55:22 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 55654120152 for ; Wed, 21 May 2025 11:55:22 +0000 (UTC) X-FDA: 83466759684.22.6AE982B Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf28.hostedemail.com (Postfix) with ESMTP id 78E5FC0007 for ; Wed, 21 May 2025 11:55:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=HO9BZ9PU; spf=pass (imf28.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747828520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tL9eCLX5QiCVgv4ctfN0wj5bckq6gkGyr3yq1p7b9sA=; b=1x+scnEomg6HszIXE4Snzgsiv9/nq4r/YwVBoBcR6YNk3ezIDw/Sf4raJ23fJwD6CfrOwS RJBsYBrwCY71wvWohUjLdZ9pSh/GbajtgGreTQA4qXymjAHubuYEM+DRUxFDP40m7QhnjP IKwhuttjmTHUAVO8kxauGcR8jH8BNd4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747828520; a=rsa-sha256; cv=none; b=3kz8uOfOCfLyyhSN++UOpFZ+PL4cx4ssCiBDzZ0KnbgvFCtraf7ISm/opORNeaTMy6iWgy 0GIfNArQRWKuWtknuknpkHEVJAxVmQAGuv0Pd3aLo/NS4XBpHFZB2f6kIIhxMdWaarKxmT 5C5CbURLLWkfOWhPA3sMyUT0ZuzssFk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=HO9BZ9PU; spf=pass (imf28.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 0731840E0238; Wed, 21 May 2025 11:55:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id H7jslWYdBfFQ; Wed, 21 May 2025 11:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1747828514; bh=tL9eCLX5QiCVgv4ctfN0wj5bckq6gkGyr3yq1p7b9sA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HO9BZ9PU88TxKTn3832zMPLGeb174cware7gqc8aEYEwlFTS3JLZHXeIE21kDzqCz rxt5D3MW5Dtxu73Jt/i/jHn1oOXHN/CAC6zYiZFxJJHXlSInUZmIIdqZSenKMykZlT qLoSWwyTwnnU5IqgQQCrcCURyBjKamqGKKLUbGk+8PrtqxgSFwEfVKa1r3hEsdNAhZ F4XPI/hwAvUwbdvRZj2ZB4xIMp/exegZjzAkQssQ+rNZHmqU8QH8Zol3OhczjZHwx7 9DKCQKovWsQBxN68S50mauoXzvvxCN/ogkpWADIeM4pHpZ/QCORm9D1MBXCfQwcDY5 kea4nSxJsme7yk9BwBnamkHmjDidr9ZpV0jfw7pdk+e1qe4RRbg61q8QRqCtTuKmMH 1GXia4kH5I7OyDYM7IQHI0LrA43c6i6l/8wq4w9SPshkJAkfJlm2UVwNPIgwKfxhEv EEo6utg3WHV5LV8N31gzcqfHvmcSWIcFTbAqmRa1Z67rUwXIiF7jajOH23+8J30YXi QaJy3m36l75i4RIcShUqcdiJy8+qniRwAxK6zB7pBQ0hJTjtzAQvOFWmV6lNCUUuha JZzqX6P2UepwqAmLAOXRYbnvyQU5a5wQi+0fySD08WCysuIhT7TvanXW4f3e9dsWV9 mrpqbY9ACGdi5MozubSsAyW8= Received: from zn.tnic (p579690ee.dip0.t-ipconnect.de [87.150.144.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DD33740E0163; Wed, 21 May 2025 11:54:59 +0000 (UTC) Date: Wed, 21 May 2025 13:54:58 +0200 From: Borislav Petkov To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu Subject: Re: [RFC v2 5/9] x86/mm: Change cpa_flush() to call flush_kernel_range() directly Message-ID: <20250521115458.GDaC2_EqaXGa8ZsImM@fat_crate.local> References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-6-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250520010350.1740223-6-riel@surriel.com> X-Stat-Signature: 48n6bdunmso4mxsmfunf8xaet4ifiz7h X-Rspamd-Queue-Id: 78E5FC0007 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747828520-985657 X-HE-Meta: U2FsdGVkX1+AdO4kw3zJ2DgVDLJPfiG0jouPgiNhg1gQWCiyrLThyUA8zccCuXC0xQc+OZTme2S6V4Uae36VPgpUYcn/K8wAVoSQ7vQkNUVlx5C5nn6iAEM7wFeukcHbjg7bdr6L2UDIQbEF/Y7K0K5wtaKS6X9Z571XLClPgjM1C6IcKkoQPkdUaai4alEDU8rQjxiG7kdiMI+GGXaTpe4WGCc6KAmRNOOZ/DViVU56HGZA/XCiWaA7OvAkkjc6RfbE44HBQ2OTheS1P4jtAZVSB81FbcEWFGglJjpSynqdoblyVACZFfIv61rkueqrZ8ses53y3NeYymx0dqRAyEZauerSvu4/sJBD8swk8v0p9+ohFIfdvagauOv06XHDDiQrsGTgIeRAPLYomC4oZY+NMTC7N0+WYdb4UJpY4CB0LqT++tMAo/lzE3PFr9oisCdiSQPmLoHnOa+b9Nbr3rXxj6bRpnPN4rpuGnnIPDv+YoIxfaOToD2LCnvfCaqt/tvylNdlHi8tfzUp/dLoEJKyQ0A0i5fTVM2S+nIvtFgAtm6oPFPTOZ6wO81JNkLc46ISvdcvzcx6CeMQUJTkTakVKfT9LTf2X++1ODhhX/CXwUZjCW1xWL8FWzer4A78HcrbMjhHXR2gwJRKFgeMV6dnaAJoRTC3U8ounatJfPnNHxGE+sKHCITN0ghwBngyqgI10CvMObR32hmmK5ySWTAB0wHEEIIBP1xZaQX6ZcCk1BzFncPZxKu/gln1ASyYuMWpAzJ0IOnshu1zM8YUQk/+I7DF9hReiow00/NYWa0ETuLDIrpw0e5poNuK223FJwK1lyxLsT8EQQpgIsafFiEK1bvAiohdIzIdbm6y+VvRN+s7+QqrAXzi7oi6yaX2cwpqfyxJyWaV9j0Rlgcj8Fb3LCBYABjo2lsr0iVPQynpQ5TaNfDzdqXdGF2vmjLspDvnv6AcwqWlFZajFbk quTos/+e xRwEG3aNFfVctoJHhzoV0VgySA/ctdnA/Oc5fydSRtf+B68E09t6cQWLV5zRC1f+9dv+XmbJ2BJ5qooM3/VxlDm+A8dXL9bcMsmSx8lud/Eg3iHV9P1k23H3N66lYdnrDmMcrR1hUnjR9YZe16zGmHEoUWtSgsA00P9a9w7/xmn4BokE+xTMznHuwXxfdOGoVn0rYoFurdHZ6LwLkW729eB0LHBdtNK3K3e3PBstI7ksxv6L7yl0GEtX4m7sPi9q6kE488yPn8a2yV9DHaNJmvVb3qH+Bod5Uv6ixmes/52UrWKpPJIA6p5PZnfzUYxCPhcmJwq5fzY1GpV/b95PnjnF+adVEkZUNgraDPPS+PfjX9t2wk6u6DjfUM1nsUhlKLoCXE3wZXZbhpmq2x8WmUePX71AlniQZrScaAAqmfzJf1OwOLhAHoLpbEm/MLk6K35GzolEJ+JgLnPN/WOA3ILOvuHO7MRem6cz8VGy93HRuhGy//eRixaROZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 09:02:30PM -0400, Rik van Riel wrote: > From: Rik van Riel > > The function cpa_flush() calls __flush_tlb_one_kernel() and > flush_tlb_all(). > > Replacing that with a call to flush_tlb_kernel_range() allows > cpa_flush() to make use of INVLPGB or RAR without any additional > changes. > > Initialize invlpgb_count_max to 1, since flush_tlb_kernel_range() > can now be called before invlpgb_count_max has been initialized > to the value read from CPUID. > > [riel: remove now unused __cpa_flush_tlb] > > Signed-off-by: Yu-cheng Yu > Signed-off-by: Rik van Riel Please audit all your SOB chains. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette