From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F94AC2D0CD for ; Wed, 21 May 2025 11:54:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B829A6B00B7; Wed, 21 May 2025 07:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5A136B00B8; Wed, 21 May 2025 07:54:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A97B46B00B9; Wed, 21 May 2025 07:54:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8B3736B00B7 for ; Wed, 21 May 2025 07:54:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 415B7B60D2 for ; Wed, 21 May 2025 11:54:07 +0000 (UTC) X-FDA: 83466756534.24.EFEFB97 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf30.hostedemail.com (Postfix) with ESMTP id 395C680006 for ; Wed, 21 May 2025 11:54:05 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=JyeqJ1r0; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747828445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oxFFjYIAl6Gx0mrK2huomLlzlORJsSkgG/Z8fhvD5LM=; b=1wSCYOiy5v7PnvzuGqbCC7szxJ1FdOyrnnvHC610B4FhvWKdUz2TPckb0at8J/QtBuJbew FV82JBvaizYfKZZSqCw6WnxWGzzbToMVRUwvWovCmy96sZWAhl4aawYKWZc03HVpMiMWho qnhEcQ6nSlJz51lBklXr/g5s0skpArg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=JyeqJ1r0; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747828445; a=rsa-sha256; cv=none; b=i+SI1Is0JB324QljAgUdhifiwI62dE3Box75H2uMXh/KHkm8ZWwvVKs2ky4ZQHiBvGfVdG k8aj/2QtA4LzvrdmBYXXRs0SspCoRJOT4dfGEJZ0gmHl6KC+i1f2kfnxL40HD2nc092Pjf fjgmLVF6pnQ+Ja4ST7r0Cxcod/IWP0g= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id E426440E0238; Wed, 21 May 2025 11:54:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZUy4qgCg7Jo9; Wed, 21 May 2025 11:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1747828438; bh=oxFFjYIAl6Gx0mrK2huomLlzlORJsSkgG/Z8fhvD5LM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JyeqJ1r0zEfWOiwV6aDnvMZZimNTNuDHtBBzznXTdNqEJrjFjkktAH5Cp7fLtet5d AHjjWvALvtW7FrVblOJjgr6uN5Pnt5De0CLz8steQQu5qsw8RDRk2cJOn7cIEBJnZI ls482K5mgyMAIBeELHk+ZNoNQnUNyNvzvTOVVJIe19IPNEa8LPgDqQheHCJqovOiTQ ikKj2YmhI96JYtCdYuwdvBTbvhgsPD7DZ8MjDzHQMdNAo/cjb80q/n6ilETI3lUW5K wHKqNEEima7yOL4d/F6DPEKvRKPTDzl0962F9V44vIVqD3MSF8vjrqQzOuijw71Qdu ZJriLyRosC5+VjI/M7Y185+6RY+qKurxHvOqb26bJdWTwgUrda4YMZVJerSk6QhNNT MYgcDZW+CBltDrBKY0dYwXN1gwhGeMGMSucBgj8TFPmeUDfls6i2WQbLddXmvy23MB TwTvNKHjVzzHybGaKR0Q/Ur8kWpi43eFa7Gr1Yt2pL8C2BZxZwo3dPQQVKxTB31MMr /wJfRrwxPr3mOgp2NHZrJ7qhL5pNXMfUYCVT9kBYxsUKwxYqEGEkSFJaf9+aMWiFuu RkRl39bVrDqksDo6glluQ6dQfh20KCNBbO5r+18Syq9duBHHbCt1EvM3pOnlxYUNLt Wl8OQXQGU96MgJJLb4ncttzM= Received: from zn.tnic (p579690ee.dip0.t-ipconnect.de [87.150.144.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 654D040E0192; Wed, 21 May 2025 11:53:44 +0000 (UTC) Date: Wed, 21 May 2025 13:53:43 +0200 From: Borislav Petkov To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu Subject: Re: [RFC v2 4/9] x86/mm: Introduce X86_FEATURE_RAR Message-ID: <20250521115343.GCaC2-x8LsmMApUkjQ@fat_crate.local> References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-5-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250520010350.1740223-5-riel@surriel.com> X-Stat-Signature: ey4wzyzawfndtpqjzskrpxepdzrdanp7 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 395C680006 X-HE-Tag: 1747828444-863191 X-HE-Meta: U2FsdGVkX18sOSrAYhAYvpvXKKpaRExtpijWszx1g2JF4AlxT4FZns1g9tmsPlVunuH1gJyLHXBdZVUxCgz6N3RjRziCHUkA5e2InbsVRFD4ZgNmpYyfGBXzPJJno5Mex1mvpZLBvdq3wRkzHasGqmS6rEyaJYx5xBgf1ADmPbxzfOt+cktKCMjYb7XyoFRUNd6YbFD9WOeaJATHSw2EFkqIDJrzSOUX8u9FfVQ9504xHLxTONNMmunjphnzaAP2dD7vvxCN85Ax+qMs5ERmRH1VF2dfo02HsO/EDOFv5vHaH5Cp+3noW5HBtY0nLVjk+SZMqnaxrCZUHNwCGByYsjfg1oi1HMIXbcxKIOe/T0RgLIzsH23JoWkYB3iSihUUhfh+EPy6ChRxB5l0gUzJ6Lfj81PoKomyBdNCqeqYxvS5vzm+X+27+tKGnqqoE379SvOgFfnfXBKzwtecB5qlO6Wmb7O5z9wpKHfozItGTwl0o98xTmoYHaxLAsGuZboY+2ZRm2Pmh8Zkr/G8Sunb49sbUSo5mVfYBpZ3oplvMBEHcvqoIU3Jh+OBacMqsShsyEwSwOfWYcLuLfK5ynax09CrCeV5KNfaXWmZIEeFRi8D/F4ZA+PjgcMa8CsrcA/vte8FQZ6FB9Zp+uup6YRXLI7N5KkDRIDXvJ8SOPIOeK0UOWovayUvxRc83HU5L8+DQA34qsGR5nPHE8n8/DrZ/jiwrQjxQUlZa9HS8DbhadL4zTsmVNqUvwz9OcScqr/zB8BFMaJlcNzPsELR/dX1NHKQzzaRqR+C5x/I5JvASCAHhIM6B7t4Ko/wlIlZFG2z9P4mNOFvkEJcFM+o0r6CPb7NfXfxnfSv7ISNNAM7rYAlzIXFFasY09pnEGjsekrREblPMcht6lHOihaNphcdmZpSGOmAft3OSAfX9SNzBWQgcPF4s3Xe6AZ+C/mmR7lYrAxQYTZHIv5WcEWdG20 bo+2j0jS LcY8pg3hQhbHtbdJpFNw5VS2bUx/ACYZGkMWyMdgtKojjTzLyHp1JyVhTTEv5mro9JPoQltbFXTf5nrkbGnn3CpAHZWmPftq/+W3SD9rnxUWQRJfrig40QcRSi8Hg14h2DMnu1YroRO1wGPqAJhorvZ+QNN3CNjSOit2lyvIcbscepTyi+OWn/TnEC0c2kr1RUUZ+76hLFexNDE0F7O3WKZ/kOksaYl5cpQh6b27Fxt7BG6v9c9zEwR/nCABNRPmWIQmP3FYJra/M/PqkE37IxcnjpP+K84cYPy7lZHdfjvasl6R/WqImTWzMLBRtwb6NEDBadXdM6lt1JWPvBprDZlavoaB4b9BKhRVqGo1qQ2k556nOZW6iSQUi2Ru7B4oMoEc99u7PHpD5iLwh+gHIhU3roPPLngZ5OID1YxpmYiOa0QYbA2Nkj48gl/WvjOzdvyMUUK868iFoCYXFo6qFv/i0W8T9T4/iFcbQ/GCyPahLzf1Uw6n/2NSMkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 19, 2025 at 09:02:29PM -0400, Rik van Riel wrote: > From: Rik van Riel > > Introduce X86_FEATURE_RAR and enumeration of the feature. > > [riel: moved initialization to intel.c and disabling to Kconfig.cpufeatures] > > Signed-off-by: Yu-cheng Yu I'm guessing Yu-cheng is the original author - that's expressed differently. > Signed-off-by: Rik van Riel > --- > arch/x86/Kconfig.cpufeatures | 4 ++++ > arch/x86/include/asm/cpufeatures.h | 2 +- > arch/x86/kernel/cpu/common.c | 13 +++++++++++++ > 3 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig.cpufeatures b/arch/x86/Kconfig.cpufeatures > index 250c10627ab3..7d459b5f47f7 100644 > --- a/arch/x86/Kconfig.cpufeatures > +++ b/arch/x86/Kconfig.cpufeatures > @@ -195,3 +195,7 @@ config X86_DISABLED_FEATURE_SEV_SNP > config X86_DISABLED_FEATURE_INVLPGB > def_bool y > depends on !BROADCAST_TLB_FLUSH > + > +config X86_DISABLED_FEATURE_RAR > + def_bool y > + depends on !BROADCAST_TLB_FLUSH > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 5b50e0e35129..0729c2d54109 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -76,7 +76,7 @@ > #define X86_FEATURE_K8 ( 3*32+ 4) /* Opteron, Athlon64 */ > #define X86_FEATURE_ZEN5 ( 3*32+ 5) /* CPU based on Zen5 microarchitecture */ > #define X86_FEATURE_ZEN6 ( 3*32+ 6) /* CPU based on Zen6 microarchitecture */ > -/* Free ( 3*32+ 7) */ > +#define X86_FEATURE_RAR ( 3*32+ 7) /* Intel Remote Action Request */ > #define X86_FEATURE_CONSTANT_TSC ( 3*32+ 8) /* "constant_tsc" TSC ticks at a constant rate */ > #define X86_FEATURE_UP ( 3*32+ 9) /* "up" SMP kernel running on UP */ > #define X86_FEATURE_ART ( 3*32+10) /* "art" Always running timer (ART) */ > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 8feb8fd2957a..dd662c42f510 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -1545,6 +1545,18 @@ static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c) > setup_force_cpu_bug(X86_BUG_L1TF); > } > > +static void __init detect_rar(struct cpuinfo_x86 *c) > +{ > + u64 msr; > + > + if (cpu_has(c, X86_FEATURE_CORE_CAPABILITIES)) { > + rdmsrl(MSR_IA32_CORE_CAPABILITIES, msr); > + > + if (msr & CORE_CAP_RAR) > + setup_force_cpu_cap(X86_FEATURE_RAR); > + } > +} > + > /* > * The NOPL instruction is supposed to exist on all CPUs of family >= 6; > * unfortunately, that's not true in practice because of early VIA > @@ -1771,6 +1783,7 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c) > setup_clear_cpu_cap(X86_FEATURE_LA57); > > detect_nopl(); > + detect_rar(c); > } Move all this gunk into early_init_intel(). -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette