From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2AEC54E71 for ; Wed, 21 May 2025 06:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9C2E6B0085; Wed, 21 May 2025 02:24:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C745C6B0088; Wed, 21 May 2025 02:24:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8A036B0089; Wed, 21 May 2025 02:24:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A068D6B0085 for ; Wed, 21 May 2025 02:24:05 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9F8531A0517 for ; Wed, 21 May 2025 06:24:04 +0000 (UTC) X-FDA: 83465924808.20.329CDFD Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by imf10.hostedemail.com (Postfix) with ESMTP id C5590C0007 for ; Wed, 21 May 2025 06:24:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=lPzMBE1P; spf=pass (imf10.hostedemail.com: domain of bhupesh@igalia.com designates 213.97.179.56 as permitted sender) smtp.mailfrom=bhupesh@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747808643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mj1L8UT5keBFToIFmCVn4vf03lSCBcagktZ7oeGryzY=; b=G+gpKd+waifeCw9Je9mqZcWRnPGmF5zXXzZ8TPhCcvQn8u/7Qq4qoyVj7Q97dW9bPPS7Rr jWFM61ulxrCvlV0sU+VAXM2kFTG07LGyGi1r9/R/VCX/Xj+wmaBJAJIMNnntspALHffQkJ wOD22KFkOMtDBJN4GAFNGvkQq+zIx9c= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=lPzMBE1P; spf=pass (imf10.hostedemail.com: domain of bhupesh@igalia.com designates 213.97.179.56 as permitted sender) smtp.mailfrom=bhupesh@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747808643; a=rsa-sha256; cv=none; b=xyE+jLed0Fjm1kC9PcxaRd3am1fy2N75FTIE2wvcPcOwgrSQ5xpUEZSnlHgDoEGugFTvgH 4nB/9jFxfk29gbKXg8E7LV5aHU8pjRqoP7emrvFu2ic8mfCT8/CCv+D5sdTYhAJyCti3NJ OOFedpPwWyf85eJDDkO/rGKWGx6Oqdc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Mj1L8UT5keBFToIFmCVn4vf03lSCBcagktZ7oeGryzY=; b=lPzMBE1PrVethON7w5jSglZ0xH doMttCtEHa3eE5f+fCV168lQsBT2/z+SSX6WM6u1qcTFFAQZbVT4KEKYq3P/aZcfSvHFoFAGM2tE7 luHTWLJ1z3bG/Q0B4+YnNDNufb24FcogBUnxL1gTq6DggcJOuoQZT35uA61x8TkmUrU1i42nIC43N eLDbKGfDDQQIVEhr4Dnk3EtISFTwWezSPLTCZ59CvgIzNp9b6cQny6eTNcsQ82ixKM9jeguTVvcBg TmIaHE19jBMUvyhf6ezdOBl8N1czNhiqPIDMErkVMbNDquDobWCOfzAb2TfR7cMJMX4qzES5jePmV STdRxYgw==; Received: from [223.233.70.209] (helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uHcrs-00B3oN-DJ; Wed, 21 May 2025 08:23:56 +0200 From: Bhupesh To: akpm@linux-foundation.org Cc: bhupesh@igalia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-trace-kernel@vger.kernel.org Subject: [PATCH v4 1/3] exec: Remove obsolete comments Date: Wed, 21 May 2025 11:53:35 +0530 Message-Id: <20250521062337.53262-2-bhupesh@igalia.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250521062337.53262-1-bhupesh@igalia.com> References: <20250521062337.53262-1-bhupesh@igalia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: u84ha7xcunmhwna61w9t65dccqi6fons X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C5590C0007 X-HE-Tag: 1747808642-148629 X-HE-Meta: U2FsdGVkX1/f02EEFhLC/ZIz3JNjq6fk+2oMkUK+HOxdcjQELYmfrrHS1rLDjtkkjxo8kpXiFKvOc6uyk93gJsehtVx/NkxFjo8fcWA6SMF6DJDDC5Wh5fddd/aVC7atdEU4+dkV3aH2PcG259ZphJOBKCMtOeIi05so2KujAXm1EIElOlhCAPu48N92ogsK87IoesDhA+X6Aq0/dWmuEMluNpNhNk0HndzYRGenGHHMcx9XPL5rODVi2kEDvLtYSopFVYdTGWsZjyk3YBpLZ1X5jjDSslL9ijsQMVYfwmSGIJaLCUX3yYgbrCOL7HjeqPU8PayEulzUWNU8UT9Ssz668qZcUGUyYuzB0IeIzYhKaoZwdCHu4SZUSQ/ckS284p+f7vcV1gK5JUQ/YftvgmSa1IxGlerLtjRCoWM5y5c1VW9Jmg9JfUTNmoZCrMjVlJvFc0evO8IBSWePgZ2xErAfeEtSNzfBabT/9kgyV2nWt+UCEvn2Y26ILgrpC/Ebn7nJgz+fmTkWtn4IGszHQbBIiZ9cAdK0Tu0ViAwje1FQK6ByFPU7DjKkOLm4nqwLPQe0snNdveDqSVh0ZRE8niB8SQhvVCAOM2uNINp+X9lF8qz/WUyC+Ccak/cw+GGvaTw2sh4XaU7nDxBNQjOl8Ddw0xm1VaQx1GbiLsUixBLlBwmEeveCic2UsTydlPqMDwfTitpAN5S7ilup1w1YozN0VD69OU9tG9vO4zZO23FCpNCmJLVOLPShLOOv7H8EbejEDZE7EW7rNW539RwPYfApDEFuVixls8js9kRgqKwcCp77g2UaoEVsc2Be06q3uCZcBRgqgE+LnH/d3e7V8jyrgae4NHBkRkG+ojtcFS1kHlZxHqCDXgCVpSfZaSBQuXz7PlwIge50MDPwtoIQbAYarWSYlD32fJJaROL6Plp+QvUO+0ndSXrEp0MvmCk3FNoyxcU5/sg1EGe0N4o 9s5BWldy 0Qvk/X0Ac+v5H+nC+qelv1h3A7Zoa5R9yDDFvrYryhucFV3+S51GdfW4QNIgUAyzmZLuuxBePplDjjEvMG6xAji1lub/4OpTSZa0L6J5lwBCQ/P/IbgLJFb7ZSHIpWIr57PRseb3vC5sdx/YB62ixy+wK4uygcygiOv4pYJXCLRDGPlq00uZhdevQIvmHmEOVOhJ/Wyu7BGXlM/jk0pgMrjesZWQSQtihDbpW0ZOoqEKWYfdhyBvPVXN2yAv8QMU0wfUN4I3kW5v5CRgV1QzMDGDzgCPPU74n104f5aJhAii8ouLQdvMuSkpzvmlu20X90IkVtjUgGgFRzk3b1q6kXQUdOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Patch 3a3f61ce5e0b ("exec: Make sure task->comm is always NUL-terminated"), replaced 'strscpy_pad()' with 'memcpy()' implementations inside '__set_task_comm()'. However a few left-over comments are still there, which mention the usage of 'strscpy_pad()' inside '__set_task_comm()'. Remove those obsolete comments. While at it, also remove an obsolete comment regarding 'task_lock()' usage while handing 'task->comm'. Signed-off-by: Bhupesh --- include/linux/sched.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 8c60a42f9d00..704222114dcc 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1162,10 +1162,8 @@ struct task_struct { * * - normally initialized begin_new_exec() * - set it with set_task_comm() - * - strscpy_pad() to ensure it is always NUL-terminated and + * - logic inside set_task_comm() will ensure it is always NUL-terminated and * zero-padded - * - task_lock() to ensure the operation is atomic and the name is - * fully updated. */ char comm[TASK_COMM_LEN]; @@ -1997,7 +1995,7 @@ extern void __set_task_comm(struct task_struct *tsk, const char *from, bool exec * User space can randomly change their names anyway, so locking for readers * doesn't make sense. For writers, locking is probably necessary, as a race * condition could lead to long-term mixed results. - * The strscpy_pad() in __set_task_comm() can ensure that the task comm is + * The logic inside __set_task_comm() should ensure that the task comm is * always NUL-terminated and zero-padded. Therefore the race condition between * reader and writer is not an issue. * -- 2.38.1