linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Casey Chen <cachen@purestorage.com>
To: surenb@google.com
Cc: 00107082@163.com, akpm@linux-foundation.org, cl@gentwo.org,
	dennis@kernel.org, kent.overstreet@linux.dev,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	pasha.tatashin@soleen.com, tj@kernel.org, yzhong@purestorage.com
Subject: comments on patch "alloc_tag: allocate percpu counters for module tags dynamically"
Date: Tue, 20 May 2025 17:16:20 -0600	[thread overview]
Message-ID: <20250520231620.15259-1-cachen@purestorage.com> (raw)
In-Reply-To: <20250517000739.5930-1-surenb@google.com>

Hi Suren,

I have two questions on this patch.
1. If load_module() fails to allocate memory for percpu counters, should we call codetag_free_module_sections() to clean up module tags memory ?
2. How about moving percpu counters allocation to move_module() where codetag_alloc_module_section() is called ? So they can be cleaned up together.

Thanks,
Casey


  parent reply	other threads:[~2025-05-20 23:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-17  0:07 [PATCH 1/1] alloc_tag: allocate percpu counters for module tags dynamically Suren Baghdasaryan
2025-05-17  6:09 ` David Wang
2025-05-19 22:51 ` [PATCH " Andrew Morton
2025-05-19 23:13   ` Suren Baghdasaryan
2025-05-20  0:21     ` Andrew Morton
2025-05-20  3:19       ` Suren Baghdasaryan
2025-05-20 23:16 ` Casey Chen [this message]
2025-05-20 23:26   ` comments on patch "alloc_tag: allocate percpu counters for module tags dynamically" Suren Baghdasaryan
2025-05-20 23:48     ` Casey Chen
2025-05-21  0:45       ` Suren Baghdasaryan
2025-05-21  1:22         ` Suren Baghdasaryan
2025-05-21 16:16           ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520231620.15259-1-cachen@purestorage.com \
    --to=cachen@purestorage.com \
    --cc=00107082@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=dennis@kernel.org \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=yzhong@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox