From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C47C3ABDD for ; Tue, 20 May 2025 15:54:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA8F66B009B; Tue, 20 May 2025 11:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C59256B009C; Tue, 20 May 2025 11:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B48FD6B009E; Tue, 20 May 2025 11:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94B7B6B009B for ; Tue, 20 May 2025 11:54:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C610E5B8FE for ; Tue, 20 May 2025 15:54:46 +0000 (UTC) X-FDA: 83463734172.05.9E5CFC3 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf10.hostedemail.com (Postfix) with ESMTP id 4A820C0005 for ; Tue, 20 May 2025 15:54:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XiNVxsZl; spf=pass (imf10.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747756484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wdJ1jwLeaCaXnJQgO3tBJIQWMGl4H2EoSYzh9CBvdn0=; b=GagnHdCGGd14Z1kDY9ThsbrSbB9b2tKqIgR0qfKCw1DjW53SBUVr9qVoKtgh7ktrgJWlff kUDjluz/fsBT62Vmujr95BBpz69kxP+4cLJuvd8JTuRQ7Ohv1elQ75AAVjJGE62+uQxszP sjem/D1BA1xDgk7sPQgHL8OA2kq7Eac= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XiNVxsZl; spf=pass (imf10.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747756484; a=rsa-sha256; cv=none; b=WoWzUyk9zHGQev6KFnC3U2bSutQOjHBk6NAi6/pCJilU4d6cSbwsttKohzIiXfP7ytYAFq sxvLoF8M114og+XbVzPIyQGFFFnxYqUzBoWlgXyQeNrhs3Af6eCB3uefOVe+ed/GOhRajD vNobc6t7zb9KX9fYiR+h1eMC/sQc0lc= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54KDn9Rb014272; Tue, 20 May 2025 15:54:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=wdJ1jw LeaCaXnJQgO3tBJIQWMGl4H2EoSYzh9CBvdn0=; b=XiNVxsZlvaP6AUdLPjj/1Z pZwRwscvLPGeLDxhp3AXf/zq7zDOUSitKESagUOL/ol+eEC8esL91WN4LC/Ko6yg u3EDTpbb+Zg1v4XZV0Nm4EDLcFi3MsTsPVSdbq+UivqiuaP7EQazJEh2XhJxf7LV rQRD6p2wA+iyOBU8Yz7/+3am3XIPyjhIOQ1g1lh9Co7wfSQjwJhzQhP9NnxC86Ez +RLUR/u7g8qDHYEUQzNd4pROQ1KFQGda/sOginb8wNj/rwCReRG8Va44pd+D0dQg 9OPOGVz05fDXTP9vVRbZ3pzczrYAAmz6ZNBRedGFzioEDJFl9ZgUL+OO+ztnpjVw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46rty3gqvb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 May 2025 15:54:37 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54KFg5Ki019123; Tue, 20 May 2025 15:54:36 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46rty3gqv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 May 2025 15:54:36 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54KDCAuq014262; Tue, 20 May 2025 15:54:35 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 46q4stcy3q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 May 2025 15:54:35 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54KFsVPU50594076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 May 2025 15:54:31 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 54DEB2004B; Tue, 20 May 2025 15:54:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C967020043; Tue, 20 May 2025 15:54:30 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 20 May 2025 15:54:30 +0000 (GMT) Date: Tue, 20 May 2025 17:54:28 +0200 From: Claudio Imbrenda To: Lorenzo Stoakes Cc: Andrew Morton , James Houghton , Christian Borntraeger , Ignacio Moreno Gonzalez , Yang Shi , David Hildenbrand , "Liam R . Howlett" , Matthew Wilcox , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , pbonzini@redhat.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] KVM: s390: rename PROT_NONE to PROT_TYPE_DUMMY Message-ID: <20250520175428.24ec47b7@p-imbrenda> In-Reply-To: References: <20250519145657.178365-1-lorenzo.stoakes@oracle.com> <20250520171009.49b2bd1b@p-imbrenda> Organization: IBM X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIwMDEyOCBTYWx0ZWRfX+SmD9pxtFRWL Y1A5CvRO5j3pLbJXgfJ3tYZTv5xTJ2ADxBegmCEskjfRhabnYdPZwMZsYAzewILo2kFo8TrOUs1 rqQklZ9hOB2kjgti7XAoPtboPYftAQT7x+MpZ+fwDgmEsqQ3G2n2EbA7P69GK2+wWYp8Vh/uwu/ RJvfhG7lfNn/YGLB3Jibr9Lpc38LUjY8AIVRh9Vb41QK9g33sTJ90TAvd39dEie+lbImUQZYZW0 kleqa2qaU1QNXMeeGAgVShdYsJ2bQ6K1og+rvffMapKCP9P7W3RR1VPZdlAyN1DMRcqAMM08St4 hnAeBWDHcYuwv5yE9qGA/Htf+o4mb7hyfCy/WL0Jhe8LDwkUJhslstLenI0aORMJvpvvveGJqYq TBBK8tr+yv+pDpofjLYbs9z5QRhcb5GqZAnNVOnGmwV7+FqHIsM7J3QoLnnBTiScT4NuujDM X-Proofpoint-ORIG-GUID: NqSYhNXr9uJIwok2XATvZpjkj1adV_zo X-Authority-Analysis: v=2.4 cv=DKeP4zNb c=1 sm=1 tr=0 ts=682ca5bd cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=TAZUD9gdAAAA:8 a=VnNF1IyMAAAA:8 a=vzhER2c_AAAA:8 a=20KFwNOVAAAA:8 a=-dfg5vNDZjZ0OaYXpFQA:9 a=CjuIK1q_8ugA:10 a=f1lSKsbWiCfrRWj5-Iac:22 a=0YTRHmU2iG2pZC6F1fw2:22 X-Proofpoint-GUID: uIm7Ji6apohDdQkSspMSiXzoGwXD6Qz_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-20_06,2025-05-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 mlxscore=0 impostorscore=0 malwarescore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505200128 X-Rspamd-Queue-Id: 4A820C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jgxbzoyu191aejuipu96zxkh58jzhsyu X-HE-Tag: 1747756483-650042 X-HE-Meta: U2FsdGVkX19g35D8uUZIopT354GWPsz5LncRm8fFrjxvPAbs7w/YrWwehyaXMpdLOjZ/hT8X6Qn+no/Ls3bgb+9DAFMj7fIqKRGxmuE7SanoCNDx0ociDXMgna/Vo27qBvPqpiS3NP8kfd4mooiDT0JDmFb0mK5pNNlDQeCTTAIbFBQ+TBwVj4Qmpn7ZT2m1w754hHWA8SorWCnkVsHJBHche/oN3TVSQ5kcZF4M7lYQeta656TyeHJuRfvkpmgmHBx4lhoYQcsPGLp5QT+RyQanUL75YmhO1FDt+4+M7DZJcdmO3EgSA4d7jolSRC3+943tr/7ic/Ia8R5fyjdm0OeLIjeGtAOOjq0HpW19J2IRa/4sc89gHY3r/Whh8sRHt5WmFGTYSrzf7lWTXZGUUDF917IygQve1QYpLyrEj2VwcF5i0/tkXnbOCenS0LaU0bdNNawu4lfpHvPXRJnsGjOimL6SlpfkxYrUAIrQ8EktSmAZSP6ZYXjjqo8bRmTpHr2li/kXnib2gcyZElWPYHRAVpqBKiOQ+VaqPzqpRwu6M8lqtMKSBjjv9zoVWMhVVW+ccffP+nSveejQVm5KiZ8XQy/480YQ8dMKA2NFOpooGR3TkqRpl0+gis/ow62atFOICGRPQrnQjYr6Nt6ol/05ccG6MleNDVc08UrdwBtuN9j23yNIyrfOJPMwoO6XBqh+zgcnLk4kjjNcwX3nxY2v/sBf30DqhsMti1vgQfpz8zw/JQexl4TP3zZx4qew+bmnpbbhRIP2UJ1pcBO6y4p4B2kWBujMNt8AhcELDRW5gL4NB0RRy3zXtLS0WpHSbAocdtpWsmXniEw7z3RgmdmzbIqKDCHiia5beit2yusyaAqYaYZlzIAmGz/qAv1Q/BGgjbKluTMnf8aboDqqnXqjvXmOVYs3TtbGV4k+Ow4CfOYHQn1F3tzTqyHs8sL8i9AnGBkGUf/QeViBwPU NjjqgZmd zTh1OkRELQoP4XzZCr0dp8A3oHLeAXyZeIOxFTHho6dXromZ14LvDQjQnFC0w/fyDuWvdpAXjj6Pjy+mY2+MHWoHOSU6DhLSCxONRdDxwcccCjy/61hMuQ4DpGsm2zfX50ID/KBcB8eS4MeQ3207HLTP67qn1J3hgiXux9ldVkOTXPBtSfJf06vMRHQtqwCiTBg0A/IQB9h9v1PINX+xJOBJar3PQ76q1txd1eh+av9BP4N8h69gmqa/EjISLFMzDeF2TYe3BAHX0V9wk05jcB4tJJ/Es71oUvuATyWCGt+ZyAjJ1uuQKxAxBIGEofu/WVx3djIB9KxWWkmDs9jups3GOoOpRcIXeUNviG5heKdpRPyWpRZLB+ltlnPpQNztKF7otrqVboJuWLOEbV5KzjhPt0d/lXWLTg4mFAeQydfgy/5xMhPxmnYelQfaejfca3zALcFM4DfZ8YvHYp+3WFU56mwaoF9lUKP7HHgYS0mlRaT/50zYZEZLnGGYtzdsCmW7htdbd/LkEVhbRXFa9JIg+04Up1aFSboIKn6gxY+H2Zx9oEPXMRXCXmWVJ8oUJOv5Cm8BxQuiEJSJYRJ/MXx271mV88QJ9e9eXU7sp/jba4c05EUowEeycJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20 May 2025 16:24:10 +0100 Lorenzo Stoakes wrote: > On Tue, May 20, 2025 at 05:10:09PM +0200, Claudio Imbrenda wrote: > > On Mon, 19 May 2025 15:56:57 +0100 > > Lorenzo Stoakes wrote: > > > > > The enum type prot_type declared in arch/s390/kvm/gaccess.c declares an > > > unfortunate identifier within it - PROT_NONE. > > > > > > This clashes with the protection bit define from the uapi for mmap() > > > declared in include/uapi/asm-generic/mman-common.h, which is indeed what > > > those casually reading this code would assume this to refer to. > > > > > > This means that any changes which subsequently alter headers in any way > > > which results in the uapi header being imported here will cause build > > > errors. > > > > > > Resolve the issue by renaming PROT_NONE to PROT_TYPE_DUMMY. > > > > > > Signed-off-by: Lorenzo Stoakes > > > Suggested-by: Ignacio Moreno Gonzalez > > > Fixes: b3cefd6bf16e ("KVM: s390: Pass initialized arg even if unused") > > > Cc: stable@vger.kernel.org > > > Reported-by: kernel test robot > > > Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/ > > > Acked-by: Christian Borntraeger > > > Acked-by: Ignacio Moreno Gonzalez > > > Acked-by: Yang Shi > > > Reviewed-by: David Hildenbrand > > > Acked-by: Liam R. Howlett > > > > if you had put me in CC, you would have gotten this yesterday already: > > > > Reviewed-by: Claudio Imbrenda > > Thanks and apologies for not cc-ing you, clearly my mistake. > > Though I would suggest your level of grumpiness here is a little over the > top under the circumstances :) we maintainers must scale our grumpiness > accordingly... it was not meant to be grumpy, sorry if it came through that way! > > > > > > --- > > > Separated out from [0] as problem found in other patch in series. > > > > > > [0]: https://lore.kernel.org/all/cover.1747338438.git.lorenzo.stoakes@oracle.com/ > > > > > > arch/s390/kvm/gaccess.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c > > > index f6fded15633a..4e5654ad1604 100644 > > > --- a/arch/s390/kvm/gaccess.c > > > +++ b/arch/s390/kvm/gaccess.c > > > @@ -318,7 +318,7 @@ enum prot_type { > > > PROT_TYPE_DAT = 3, > > > PROT_TYPE_IEP = 4, > > > /* Dummy value for passing an initialized value when code != PGM_PROTECTION */ > > > - PROT_NONE, > > > + PROT_TYPE_DUMMY, > > > }; > > > > > > static int trans_exc_ending(struct kvm_vcpu *vcpu, int code, unsigned long gva, u8 ar, > > > @@ -334,7 +334,7 @@ static int trans_exc_ending(struct kvm_vcpu *vcpu, int code, unsigned long gva, > > > switch (code) { > > > case PGM_PROTECTION: > > > switch (prot) { > > > - case PROT_NONE: > > > + case PROT_TYPE_DUMMY: > > > /* We should never get here, acts like termination */ > > > WARN_ON_ONCE(1); > > > break; > > > @@ -804,7 +804,7 @@ static int guest_range_to_gpas(struct kvm_vcpu *vcpu, unsigned long ga, u8 ar, > > > gpa = kvm_s390_real_to_abs(vcpu, ga); > > > if (!kvm_is_gpa_in_memslot(vcpu->kvm, gpa)) { > > > rc = PGM_ADDRESSING; > > > - prot = PROT_NONE; > > > + prot = PROT_TYPE_DUMMY; > > > } > > > } > > > if (rc) > > > @@ -962,7 +962,7 @@ int access_guest_with_key(struct kvm_vcpu *vcpu, unsigned long ga, u8 ar, > > > if (rc == PGM_PROTECTION) > > > prot = PROT_TYPE_KEYC; > > > else > > > - prot = PROT_NONE; > > > + prot = PROT_TYPE_DUMMY; > > > rc = trans_exc_ending(vcpu, rc, ga, ar, mode, prot, terminate); > > > } > > > out_unlock: > > > -- > > > 2.49.0 > > > > >