From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC7BC3DA6D for ; Tue, 20 May 2025 15:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06B776B009A; Tue, 20 May 2025 11:10:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01C436B00A1; Tue, 20 May 2025 11:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFF726B00A0; Tue, 20 May 2025 11:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C017B6B009A for ; Tue, 20 May 2025 11:10:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 80F90120673 for ; Tue, 20 May 2025 15:10:27 +0000 (UTC) X-FDA: 83463622494.05.942D69E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf21.hostedemail.com (Postfix) with ESMTP id 032981C0013 for ; Tue, 20 May 2025 15:10:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=nyRxdM4G; spf=pass (imf21.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747753825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ImJYlZ5KVwozGboNulihlvH73RO/Xx8tW7cXQE7ByHk=; b=g1bzn2BxN7zMvw1U5kawUSF2I6DOqiU3oJahz1h49gUadZZNqR0O/FJoxfNyNAzdtY2Gr1 /QniLlowTyQAFVtxOG3DqyoYJIZFKzX2Nf7FX5z4eL3n1eb7PcQn+/phex7gvf1wY3k6PQ y+2nEPgFscmWft8iwPvO7UjQo2yOB6I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747753825; a=rsa-sha256; cv=none; b=Nj9j9wAR+Fnd6F2dH9qG7f1c5NHmBPnDDt6MoB8s2c/vLS2ImT9dd60NvakfJ4tmkn1upH N2WkoJjq2A/EXJMDZ8dVLCTIub/NqS7El++2iZ7SJSmV19RxxRS7IFs7LZIH4a9WjPfu23 0tyeFGtHksTWLu+p9W7k2Wg2SfK81Qk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=nyRxdM4G; spf=pass (imf21.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54K7iMUm013649; Tue, 20 May 2025 15:10:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=ImJYlZ 5KVwozGboNulihlvH73RO/Xx8tW7cXQE7ByHk=; b=nyRxdM4GeKJxhIMiaN8DDY OdePpXv6SKOB1Uq9zqBnSbPFXF2ab6uFheECxzGBYsoOQlUYtM89Bf4dl/LeACCt NvYJ8yd5UHC4cMy9plevG4+keuNKZ8GQV7UbLshbWnNQhgMhRD7sI8wUSRZW7X74 HD5OaTnu/dtKOEvsE13oT9yJgP93LEI9BsZ13p/V7ArHLAd6stJX8jl4DqC9D9kj qjTUislDibA0LaUi5KCYuP36JTsqNCTulkupGyioD17MEYli2iVMOa1vRhAosWwo 70uU9P52ev8XLdNC3JoaqLia6UMg2p2sLRm15FBt8mdQPyiAZHhPzDOWM1pzesCg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46ra99n25r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 May 2025 15:10:17 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54KF1luQ024544; Tue, 20 May 2025 15:10:17 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46ra99n25g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 May 2025 15:10:17 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54KBebPD007347; Tue, 20 May 2025 15:10:16 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 46q70kcb81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 May 2025 15:10:16 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54KFAC2v49545622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 May 2025 15:10:12 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53AFF2004F; Tue, 20 May 2025 15:10:12 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD4BE20040; Tue, 20 May 2025 15:10:11 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 20 May 2025 15:10:11 +0000 (GMT) Date: Tue, 20 May 2025 17:10:09 +0200 From: Claudio Imbrenda To: Lorenzo Stoakes Cc: Andrew Morton , James Houghton , Christian Borntraeger , Ignacio Moreno Gonzalez , Yang Shi , David Hildenbrand , "Liam R . Howlett" , Matthew Wilcox , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , pbonzini@redhat.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] KVM: s390: rename PROT_NONE to PROT_TYPE_DUMMY Message-ID: <20250520171009.49b2bd1b@p-imbrenda> In-Reply-To: <20250519145657.178365-1-lorenzo.stoakes@oracle.com> References: <20250519145657.178365-1-lorenzo.stoakes@oracle.com> Organization: IBM X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=J/mq7BnS c=1 sm=1 tr=0 ts=682c9b59 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=TAZUD9gdAAAA:8 a=VnNF1IyMAAAA:8 a=vzhER2c_AAAA:8 a=20KFwNOVAAAA:8 a=TdoRMgLQO9YfxZhadQYA:9 a=CjuIK1q_8ugA:10 a=f1lSKsbWiCfrRWj5-Iac:22 a=0YTRHmU2iG2pZC6F1fw2:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIwMDEyMyBTYWx0ZWRfX6ETF0aPitQjf tBavV1oG8+qlAYCVttmWmV9C699wqmr9mBJ7ugqpYea2/7AUQm4szrF3BjtoL9Vjiu89sIh4WEM v9gj4kS7rrh+nIrYIF8k8OJH8Lr1wLf+0DLLwOG5rXx+1dncZrB3gt1IBs//nmlzibf2W+p9ZXw dpsgbWgZSKCi8cXok6DHwjoPH6gr5uP5ucIhMEtCKCjL8ZMPO4eYkgbci5RXlnA/LhEK3JPbDHK lBKGmAQ5rqnEgDfbHNdlYNXkxeQfACqZhGZurgC7mVrOMISoBOy168Dgtn6HOZ6EDZp3TKfmNgG WYbnvlI2F4OYmZJFcWtso4J4bMuzK57obsynuXKlBAhs/NOlqaaZUrBTeQubwBgSxw7xwKqydv1 vF48ry92+MzxPcfLmH35nu0N/bNJp8Xcn0+1Y6nCR8QZjV1Gsk530291vFQoHDENPYHZxapw X-Proofpoint-ORIG-GUID: fJP2X6P0Z10eyLO_i1XNVfQ-lXAlgR7H X-Proofpoint-GUID: je_od0NDs4Y-fTVlpKSl16OI1JQ3pQxb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-20_06,2025-05-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 clxscore=1011 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505200123 X-Stat-Signature: 1ee5kcde6modoe7g3ptuafn8r6fbix11 X-Rspamd-Queue-Id: 032981C0013 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747753824-91748 X-HE-Meta: U2FsdGVkX1+hjgoyigdISULPjLFyJ9iTFrGzHgsU06rZOpNtk306QXIa2T1gnSC5VR+R8XA2qVQZV1OPT2Yqlpt8uJ1p7B1fgn0WdnJaxFQNkyX/mhwco5/wUAqW8Dgson4S9zTKmdPcut2hzmbaob88GfUA37yxv7rPV3SPhoFIWFK8jP9mv6e8Bq8voAhF1w8lAndFe5BkumetSuj6HsSS74ozPC6N6wFJ7GUijQqkhvdGsi0c+ijt74mAbCZ48/bFoVXG0UNsVngbOaoCggQBbrG67Mgggm+s4QkG40aJSuu07LjXQTQUVNd+LO8b7/wiOZ7pknGbOjs5ZPNDsppJvJ7qeSj7xyLjH95YIstFb83ciHAuSnJhTtKwPWiK6dsNpQ1HVz3ufeJOHGHsgwon8UKR/r8NF2q2BamGv4ynPS97PWiSG83hKxCyQf5JGK31QUEZxSzzUevw6uN99teafNx80g6k/pkC4uTXqvBVOOAvbzix8vmyTujnNAqC7mZE2CSimGT9q5UJFEr37UYYtkMfDT/SadWpGRHrMmhyUebVCeJ4E97saX4Kp1k9jOZtoGvkJ+lHmDQJvPpLxYT/gcf8CbKgExBIGAu5ak0d+DYMhvbSflSVtJz2UH7FS5WS8I6WrhxxPhs9jBys/uCqBNYk2WzTFCCHCO2S0lEphOdIjRu/5X18EOHCUQqmAjgWNwbuYgNoI+5q4s4JRCoMXnHwWzjO6zbdOzcgCVtI8jrdtFn8PRVtH3/dBs7CSiNp2yZPByYXDj46QYlJRDQaa9CrPTXrinGrY1mgx0U3/C6rK44IgVCWtBu1873wJBPSOfqSiRlW02T5w3MQgN8Tk0M+V7h/gTIkm1G+ZpxxXq5JTmw9yLzWYsrF0589uVuxcf+MmhpmuwpWmruybmyi32oSPWPWvbltpUusYw/5RrcjpwldssqviJb3wBUZGGVPq9SsPCo7ilVgRQB oEOZq+nb zU5qnHbe1fVDN57leBwZdTRd5YtFGwUZttMyAInSlbWPw3/Mdq8/ewf/JNot/+Ci+R0mopqoX61F5sBaOcFnFeQ4QgBp0nBBPNK0COM9mgZww8xDpI/RseadZvWV44EBT1PjtiyQp3PFhQ6H9TEnDAKfCRHZv6bQIshpfWkab3yeSZNWh5afNSrTFGTDwoKssFWQyz/2JhlMfVnQnjTvOfqCGK9gtTCcZNPCXeeOY1g/A4oUs/4UD19ZBaRsgIzw1ELFUtY9aQnre566tn6U19TgzWyKupAGkM+XZPW5qcx43gJ93ebwPSuNGoCIVTHIzbX5dO9ehOGkqNK9+LMnUy3JKKJl/3Rfu53xnZ8nnIA821FB2EkQlX4b4DMuoYkFjwta+7/Ou2ILdGIwFpMA6K/EcZinP8sbEdEkTZFaKYOhscT5syyU/G00O8ZmiLw+Fh6/tMlxFialx83mFY+U858p/8XryEvW1MXDSmwX1CcuZYnb7tcAokxr0t7ujCQxqQbpMPRFjNo3SrJ/ijIhQcUkydJ9x+6Y6i6yPaRgQmiggsNpBn5PRMsmnowJRL/GZ0/y44Y0l9oiMgzaVFGaGgeBZ7Nl3k0JiK+JZxkjoSphz2uU5QyFWC16h0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 19 May 2025 15:56:57 +0100 Lorenzo Stoakes wrote: > The enum type prot_type declared in arch/s390/kvm/gaccess.c declares an > unfortunate identifier within it - PROT_NONE. > > This clashes with the protection bit define from the uapi for mmap() > declared in include/uapi/asm-generic/mman-common.h, which is indeed what > those casually reading this code would assume this to refer to. > > This means that any changes which subsequently alter headers in any way > which results in the uapi header being imported here will cause build > errors. > > Resolve the issue by renaming PROT_NONE to PROT_TYPE_DUMMY. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Ignacio Moreno Gonzalez > Fixes: b3cefd6bf16e ("KVM: s390: Pass initialized arg even if unused") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/ > Acked-by: Christian Borntraeger > Acked-by: Ignacio Moreno Gonzalez > Acked-by: Yang Shi > Reviewed-by: David Hildenbrand > Acked-by: Liam R. Howlett if you had put me in CC, you would have gotten this yesterday already: Reviewed-by: Claudio Imbrenda > --- > Separated out from [0] as problem found in other patch in series. > > [0]: https://lore.kernel.org/all/cover.1747338438.git.lorenzo.stoakes@oracle.com/ > > arch/s390/kvm/gaccess.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c > index f6fded15633a..4e5654ad1604 100644 > --- a/arch/s390/kvm/gaccess.c > +++ b/arch/s390/kvm/gaccess.c > @@ -318,7 +318,7 @@ enum prot_type { > PROT_TYPE_DAT = 3, > PROT_TYPE_IEP = 4, > /* Dummy value for passing an initialized value when code != PGM_PROTECTION */ > - PROT_NONE, > + PROT_TYPE_DUMMY, > }; > > static int trans_exc_ending(struct kvm_vcpu *vcpu, int code, unsigned long gva, u8 ar, > @@ -334,7 +334,7 @@ static int trans_exc_ending(struct kvm_vcpu *vcpu, int code, unsigned long gva, > switch (code) { > case PGM_PROTECTION: > switch (prot) { > - case PROT_NONE: > + case PROT_TYPE_DUMMY: > /* We should never get here, acts like termination */ > WARN_ON_ONCE(1); > break; > @@ -804,7 +804,7 @@ static int guest_range_to_gpas(struct kvm_vcpu *vcpu, unsigned long ga, u8 ar, > gpa = kvm_s390_real_to_abs(vcpu, ga); > if (!kvm_is_gpa_in_memslot(vcpu->kvm, gpa)) { > rc = PGM_ADDRESSING; > - prot = PROT_NONE; > + prot = PROT_TYPE_DUMMY; > } > } > if (rc) > @@ -962,7 +962,7 @@ int access_guest_with_key(struct kvm_vcpu *vcpu, unsigned long ga, u8 ar, > if (rc == PGM_PROTECTION) > prot = PROT_TYPE_KEYC; > else > - prot = PROT_NONE; > + prot = PROT_TYPE_DUMMY; > rc = trans_exc_ending(vcpu, rc, ga, ar, mode, prot, terminate); > } > out_unlock: > -- > 2.49.0 >