From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A23F3C3DA6D for ; Tue, 20 May 2025 12:26:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 211256B0082; Tue, 20 May 2025 08:26:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C23E6B0085; Tue, 20 May 2025 08:26:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FFD66B0088; Tue, 20 May 2025 08:26:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E73106B0082 for ; Tue, 20 May 2025 08:26:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2F3D4C050E for ; Tue, 20 May 2025 12:26:07 +0000 (UTC) X-FDA: 83463208374.28.2F84F80 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 4794610000C for ; Tue, 20 May 2025 12:26:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LqeQ6uYi; spf=pass (imf05.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747743965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OR26QMf30kWt//XYhDELT/MMI/WjsN8uqjV/8nFgOk8=; b=bH25v/3R229aYE7EIOfgMImwKfZEvvpdfUr26x5dluethcXebcY8ScRizPCudkK3MwpIJR 2ajPGsW1k+ss+hFL4MFBd6gKKKDUD3Bh9fP93YuiY81+PTSIy6Rb2nsiH4q62vvLMqmGB2 qf2/jCVlR+3WTsDhCfLboMKKJDE8bRI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747743965; a=rsa-sha256; cv=none; b=Wejs7+thGzI4PzaPP0uPFNq68lOXoLKn2veIR1OHrAz+Juo28S1Zp5g9Ot6q2vU+j6C8n0 4RxLKQysVp3PYDHpK06Sr83Ria7IIkbq+oWIfMD6xDRU7qcpCfXNFqCiVbPHJUBScMWIKm ScHA02qmgTFEgBfSrVXQKZmgKU6SjbI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LqeQ6uYi; spf=pass (imf05.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6f8b27c2d7bso53540026d6.1 for ; Tue, 20 May 2025 05:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747743964; x=1748348764; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OR26QMf30kWt//XYhDELT/MMI/WjsN8uqjV/8nFgOk8=; b=LqeQ6uYiVDM0k/UIWR0SULZcocDMonlYHT0uInaG6wyzBLcbt5XOR7NVtCHrkFd64u peeKs68iZjPyA7EMldmCiBihgEZN5ROreW/GZVYbjsDcAGj7cjphUqh2A6i5HxGraVIH +ydRlmdPFffsY4HDzmtLFlikCVTNOK3v0hGrqD+imQh+hrTDf3hOYwSZt9zQmdHX3+1S 11ospocF+JDHilqstnq5+KkqNyaem/nnSUbRGis0ys7HMr4EAx16LMrc49OhpQD4ThDN 3SlGcQnYftajZfjVUibNDUh0lRr5OktO84ItIqB5OOKjemR2IT/53iaRaW8TdmRvcOdQ Qh3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747743964; x=1748348764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OR26QMf30kWt//XYhDELT/MMI/WjsN8uqjV/8nFgOk8=; b=jt72n/vZNNwLrjTs+FNl0eSFifa7OJ7RJhdih6eft3Ms6bw/Y490B5jFrql870a7NO pam/gNCbk97zBVvNMLx6MWDalsjTSZCb5hBpuY9Ve14HKqZEss3UZtL1CKaMtnmNo+OK 2IGcPnpYL7VBq0lU9kLLfH1gcPC6Wp1q/lsCW3R79Uyss1z2oVMxO3ncFO+KZDFP1pke nUGucv4iRe4kBV/VBxYFfR0IXT2kgiI+IJStom4N1nEHdOympUXg1weQGKwxJGjvvghv +vxw9pbw//yNedYLYtbXgw31x76a2DS+rtN7z/eK+H87+OpEAAvjZ9zVFKZozSaoCWYs q/ww== X-Forwarded-Encrypted: i=1; AJvYcCUlo7Z2mcaVs4OMQw+H9IZ9BQsD/gOWpFVL238tLQzPsOA5hpRBMiU0FK/ePw2zr5av5OsZ2TRtig==@kvack.org X-Gm-Message-State: AOJu0YyIdK9lEesu3KeXAXcBHSOhgZRBXCdJyRmTMkiL8QBgXSEXLFwc xoYiyV51Hlf1CdNTnZIFGKEhLqk4kLuSN4H6vycqlpcdJiKC+0jO4ram X-Gm-Gg: ASbGncvWMCcgcfFbChV3STu+QzAQdvsMdr09LAy4G/4qnC3PADFRP1IKr6ndym4kQOk bm1MiVwfiATMF4bK4ZETXWwUEFywXKPyCNkaMnoV0+L0F6ZpuqsWfGOWCuB8JX6N7wu15s2573w UtVc9CA37Qq4/wkpNidq6XZEwJiZRRv0lN9W20nShnxyUxeGWIZwILnAeyZZsev/MpGX/r1DB6M yDTZsVFnJXgXtypC1yqExoOCRnfwdweH9tXKgmGRqPwyHlOysa1iMlzmEpS7x8FHRxNbHf3Dslp 2F/CqgxiR7+Xx5m5grg454CrQPL0O+5/byCPXoZ4Zcz7iqOO X-Google-Smtp-Source: AGHT+IFmyKsIt0OHKvSQp2VtnsGzKp1f4GZ+CsWOw1isKJyxRNeVj125WrDIiRzRuXMREaoak7aWxA== X-Received: by 2002:ad4:5caa:0:b0:6e4:4194:df35 with SMTP id 6a1803df08f44-6f8b2cc77c4mr270991566d6.9.1747743964301; Tue, 20 May 2025 05:26:04 -0700 (PDT) Received: from localhost ([2a03:2880:20ff:8::]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b0883f45sm71384006d6.23.2025.05.20.05.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 May 2025 05:26:03 -0700 (PDT) From: Usama Arif To: Andrew Morton , surenb@google.com Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, Usama Arif Subject: [PATCH 2/2] mm: slub: only warn once when allocating slab obj extensions fails Date: Tue, 20 May 2025 13:25:47 +0100 Message-ID: <20250520122547.1317050-2-usamaarif642@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250520122547.1317050-1-usamaarif642@gmail.com> References: <20250520122547.1317050-1-usamaarif642@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: bykx78eobxa6u6y89bqabak3y4h9dxkf X-Rspamd-Queue-Id: 4794610000C X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747743965-890813 X-HE-Meta: U2FsdGVkX1/9FGQWGRffvjbQWa7qAcvyjDyM77Z0s/aqro9Q368ePwh5DCL63zyBqEdI3WZGLNW+xsirojiG5xQyFlfAbLWmr/yz25BiWDYqat62Yk4N+Yflb1rZDBV+Vq2OP4/YSu9wUWuh89W/pYdSsSjIvjViVuGKcTXIsfH0csEeQA7ot/ACrHUTJZ9h8AkwuvnM8bDYDyFXfcaCYB6LXZXtZJjWPmooqgUfzM7fYPOAvhWXQEjl7BonmVMonQn64G8DRix9nf/CKl/JwENnzhux2I33saePw5nZ0OxDpyNwbLs7sRomkBan3v+1D9nUTXi6k3yxRXwwqQIHFmz5QgBWr3vz0uNGwRc0kFO1VhjeclftDu/j0EueY/WQLP33QrjYeKB43D8FdKL0RyWIy8sZNLfUHLS5StdhJ3BYCjqe4AoUto1jQE+5w9yUbm2cX+mIO8ril41Cf3O2AegGpYvR9N3VqpBciUVfCCJ+lX26RYUNn1TWzjBr413UPIIG6qWZ+ms/aWmTmlb8hio3Cdtn2xuTamlCGVis/wBWG2ixOuPnkCWWuKyoLUOsOmTs8dGDrBiqAQVTy789wbeZUw9EoHPbLNtZl8aQhoE/c2T8xYW20+bC2CGMm2eJcBc2XMzW6ENbdY2HnGeLq3nXG/yDCtBCWecyqcu348hSBwr/2y4g0dTBIUuT1RlTwIf0qAsTevMTTGccwuikVP1em1s0ltcuGQVAXnnF6iFOCybA0rstcp9L3jlHHTp+VmGwKtmvXGcVx2xj484wPJ4LmHfsxaxuWZ9U3od7Duc/pc4hfiiUSP8vskV9Ecl7w4c11YYeUSP2FSpcht/qpIyhIYpJ3nLARmm8x1uGuq0kTYntHmsRb3at/hIZiTSA1uuO8r2dVd0DI3nsR1YGto/sUlGBOiqOzd0FGsMQwWVSA/ZFH0G/8HC66P3fpefLqfUM3dR+hUNTiAesU/Z pzEN2LiH riVW4nRv8M111n0+8YPAglD02I6r4BlYcygN7rHCyIuN7vZH1b51l4R+KvM9v3k/CwC6/DZjbggBLHzxpLdse2Nh7AQ+VLqSaIykFa/A/HkNkEFvLMbSP6QqwtKmV6/sHgNehMqop9XYWW0wTdsTM8QbKzvqvBjc3OFy3MlyXavqPuS3MFgjLkZu1eRuaZzGwZHs25tRLY6+aymGA6gFn+s5OGT/7R/2eS1UTy1Jzkqq9Aic0nmTXFQeHBOMcHT4eeH5+kVK1jVJgJZ8pI9+GM2fBAdOFJiUQppnW/8q2wILZsZb1KZWNiKzPsoIFYMg65pmboiqXqjppwlEXVeDCK3a2aZP19ZI5n3I7+ECxCHREcZx7vqFxbuQP8tadgkNIyItZJRIVUnNiPHCPMcDzDKjE4hFS4L9W7xsdOwLdEzXmlVa0qDNF2jqlVF8pB2bwFXtd+CYZVBvsYRWCz0ZtQoCHwPMZ45dUNH9NxTD4PTvryJJjEJHbjt21kxWFg8WbQ22c77tVqf52ir+PcnBubwaPlfX/IMdU7C7OaMXCdmso4as= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In memory bound systems, a large number of warnings for failing this allocation repeatedly may mask any real issues in the system during memory pressure being reported in dmesg. Change this to WARN_ONCE. Signed-off-by: Usama Arif Reported-by: Vlad Poenaru Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index bf43c403ead2..97cb3d9e8d00 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2102,7 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) slab = virt_to_slab(p); if (!slab_obj_exts(slab) && - WARN(alloc_slab_obj_exts(slab, s, flags, false), + WARN_ONCE(alloc_slab_obj_exts(slab, s, flags, false), "%s, %s: Failed to create slab extension vector!\n", __func__, s->name)) return NULL; -- 2.47.1