linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Usama Arif <usamaarif642@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>, surenb@google.com
Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com,
	linux-mm@kvack.org, kent.overstreet@linux.dev,
	linux-kernel@vger.kernel.org, kernel-team@meta.com,
	Usama Arif <usamaarif642@gmail.com>
Subject: [PATCH 2/2] mm: slub: only warn once when allocating slab obj extensions fails
Date: Tue, 20 May 2025 13:25:47 +0100	[thread overview]
Message-ID: <20250520122547.1317050-2-usamaarif642@gmail.com> (raw)
In-Reply-To: <20250520122547.1317050-1-usamaarif642@gmail.com>

In memory bound systems, a large number of warnings for failing this
allocation repeatedly may mask any real issues in the system
during memory pressure being reported in dmesg. Change this to
WARN_ONCE.

Signed-off-by: Usama Arif <usamaarif642@gmail.com>
Reported-by: Vlad Poenaru <vlad.wing@gmail.com>
Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index bf43c403ead2..97cb3d9e8d00 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2102,7 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p)
 
 	slab = virt_to_slab(p);
 	if (!slab_obj_exts(slab) &&
-	    WARN(alloc_slab_obj_exts(slab, s, flags, false),
+	    WARN_ONCE(alloc_slab_obj_exts(slab, s, flags, false),
 		 "%s, %s: Failed to create slab extension vector!\n",
 		 __func__, s->name))
 		return NULL;
-- 
2.47.1



  reply	other threads:[~2025-05-20 12:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 12:25 [PATCH 1/2] mm: slub: allocate slab object extensions non-contiguously Usama Arif
2025-05-20 12:25 ` Usama Arif [this message]
2025-05-20 13:34   ` [PATCH 2/2] mm: slub: only warn once when allocating slab obj extensions fails Harry Yoo
2025-05-20 13:42     ` Usama Arif
2025-05-20 14:18       ` Shakeel Butt
2025-05-20 15:14         ` Suren Baghdasaryan
2025-05-20 15:22         ` Usama Arif
2025-05-22  0:16           ` Harry Yoo
2025-05-22 12:42             ` Usama Arif
2025-05-20 13:44 ` [PATCH 1/2] mm: slub: allocate slab object extensions non-contiguously Kent Overstreet
2025-05-20 13:46   ` Usama Arif
2025-05-20 14:01     ` Kent Overstreet
2025-05-20 14:24       ` Shakeel Butt
2025-05-20 14:28         ` Kent Overstreet
2025-05-20 17:44           ` Uladzislau Rezki
2025-05-20 17:47             ` Kent Overstreet
2025-05-20 17:57               ` Uladzislau Rezki
2025-05-20 17:58                 ` Kent Overstreet
2025-05-20 18:59                   ` Uladzislau Rezki
2025-05-20 14:13     ` Usama Arif
2025-05-20 15:20       ` Suren Baghdasaryan
2025-05-20 16:41         ` Kent Overstreet
2025-05-20 17:20           ` Suren Baghdasaryan
2025-05-20 17:25             ` Kent Overstreet
2025-05-20 17:18         ` Johannes Weiner
2025-05-20 14:01 ` Usama Arif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520122547.1317050-2-usamaarif642@gmail.com \
    --to=usamaarif642@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kent.overstreet@linux.dev \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vlad.wing@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox