From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9AFC54754 for ; Tue, 20 May 2025 01:04:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E28616B0099; Mon, 19 May 2025 21:04:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDCD46B00A6; Mon, 19 May 2025 21:04:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDE786B00A7; Mon, 19 May 2025 21:04:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 999256B00A3 for ; Mon, 19 May 2025 21:04:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 41CB4C18DC for ; Tue, 20 May 2025 01:04:22 +0000 (UTC) X-FDA: 83461490364.25.93DFFCA Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf16.hostedemail.com (Postfix) with ESMTP id 96922180007 for ; Tue, 20 May 2025 01:04:20 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747703060; a=rsa-sha256; cv=none; b=sbLlfhrY18CMklFDPmdAIUP/HhH0ihAzbH7Az+QGCdo3ARRkW3/THsutiDHSlJRx9mtw6Q U4Pu7Lt1x8wh4kxV2YO3t2pAJ3IekBN6DD8aAbw3+jrNDqKjb+OO7OFYlLZe5HmcpMyMGf bb7t/v3YuRRVUpoAeo3x7FV1IwaZsBk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747703060; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXnJU06ulJsGzar7hOH+ZHpU7Vfog5DFN8FuVvNY5VE=; b=j8UIIOSNHp31S1FoNHPPYkNuj0g0HNWLuZ4KUUMK/XCaiNmoqWpcsvAv7RAigQdZd9qJpi Sxaex69r05l5zwRNELLB+0pl+1ASIuBOP3sbRm7kBcywLYXdQxE8qW4Mqi4U3Cue8qQg8w aHB/bUZutF+K3xp2L8J4yTgl5LYqlk4= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1uHBOd-000000000aB-0U7Z; Mon, 19 May 2025 21:03:55 -0400 From: Rik van Riel To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Rik van Riel Subject: [RFC v2 8/9] x86/mm: use RAR for kernel TLB flushes Date: Mon, 19 May 2025 21:02:33 -0400 Message-ID: <20250520010350.1740223-9-riel@surriel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520010350.1740223-1-riel@surriel.com> References: <20250520010350.1740223-1-riel@surriel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 96922180007 X-Stat-Signature: s6mby4n37qdqjnyiykiep44g41spxgdp X-HE-Tag: 1747703060-744188 X-HE-Meta: U2FsdGVkX1/35k2RTWQJvTgTv6xvW7Jz81hS6OasYJpkpQl1vaytIhwCN70sPkmQihVP+55DLD3t3Gk88foI1w9G8X6qqNdWP0ZCxV6SUAv3pNlpnM5wIiKKnL/K8eAhUze0tt771JJ6MOgbBT5d76XvLSuwU9S5Z6gxZvwftzHRTtqVjKkmNcYBOLDxcZMw5TIaNmHJXKRImkKYLeHWcoBpAQKaq6G8LXBPAHVnNGYp/IK8uZhjjhpsLd2iCeElU+an4zyhEKkpiJgivtEA+zsSvXHQPW3ML+puB39kD6tfB70oZ2seoNoUGNTYKmnrutXXuwoWAmCaIUnbqWpNthXd2T0N4pgDMe0TiEWrmkQNHurCGsd78BNqLAfqAjVDKM7ScrQCuO6OffV+YHOQqFa+oVKADG+KFXIATXVZFX5Fq7oDHrCdYzSugOMdmgIzSUfQS5sM7zvbcbpgW7xYSjB8WDsjG7asuGoY2ID7VBe4/svErHRqtjHHbr1mdcSYISSYGrzHKBVshgLqr749rWVO5AQ9rTwqBBgSuvepHJJ+ug5lqYC52jEsbNiQaWU+RFckTOhHxXHXhAJQybaQVnv0CCaBqnA8tlaYC9d8dfWxpuNXhNaQhJmc6wxkLUFtEb14qIkA8+2E6MlyM0onNoWQ7XclDb6G7BSUjP5ZWbQgdSaIz3UbQd0ydI8pcUOlHCdYmbjAyHCPa6pLsndcoiIoOjmDUO2HlMyOjSB5e+UhsF5Pwufpu1RLZ3/3Y8HUqwsyruk7aR6eYqNv2TMgMtfg2HIpeOBV7b8B5Pm4lq3z7v6KOISPtUHj2Al6TyylXvteSAfnRpKvfUoEqe5GIxjkuU+SZ403W6zG2izwdrwdN7g7C8lxzhjgI/OD8LYAxBSstDdnmJS2BHBCQGKmcbP/5f3Mub3iVjwBqno87s8AHl7iWoFBvvM7WCQ85R0KUbcP2F+tdvJFd/in2qT DJ6sWY6z ONR6TOdrr7nkC6/VYAMVLErx5TVjxHG+pdlgfMS/zEkndSB7ww8w+AJ1Lp9wceBLQFX92KZqRRAI/77PgTX9+ybZ9/uZZrPOjVgPLdf9zu+wWsQBFPUDCjObXNgPiw9aYc3vsvrvYjA7E7YVvHGUloICwitGaVRUtvsp2gwngGhhsUSFikymQ3Na48aFq15OCGx89C1D66Z5d7AmZPKSag2uaBT3PohhoGpuux3ZhIB0T9DmFXII6Ef5U/zhmykgCU7lOgKAKcwOMpBm1d75sbVI+Y7tOBm4N0iepCpnWKnV+BFH76LpZuFpGI5VSkjwBTNsT9OmN+6eBsWl/yDReQB4GFC88GTnnGYK7EKu7JkPaiq5XMLfXg64bwYg9a98v/xrNZ90n0i4aRhR07KgSGXc+y9OFRI3jnFzd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Rik van Riel Use Intel RAR for kernel TLB flushes, when enabled. Pass in PCID 0 to smp_call_rar_many() to flush the specified addresses, regardless of which PCID they might be cached under in any destination CPU. Signed-off-by: Rik van Riel --- arch/x86/mm/rar.c | 4 ++-- arch/x86/mm/tlb.c | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/rar.c b/arch/x86/mm/rar.c index 16dc9b889cbd..9a18c926ea7b 100644 --- a/arch/x86/mm/rar.c +++ b/arch/x86/mm/rar.c @@ -142,8 +142,8 @@ void smp_call_rar_many(const struct cpumask *mask, u16 pcid, * send smp call function interrupt to this cpu and as such deadlocks * can't happen. */ - WARN_ON_ONCE(cpu_online(this_cpu) && irqs_disabled() - && !oops_in_progress && !early_boot_irqs_disabled); + if (cpu_online(this_cpu) && !oops_in_progress && !early_boot_irqs_disabled) + lockdep_assert_irqs_enabled(); /* Try to fastpath. So, what's a CPU they want? Ignoring this one. */ cpu = cpumask_first_and(mask, cpu_online_mask); diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index f5761e8be77f..35489df811dc 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include "mm_internal.h" @@ -1446,6 +1447,18 @@ static void do_flush_tlb_all(void *info) __flush_tlb_all(); } +static void rar_full_flush(const cpumask_t *cpumask) +{ + guard(preempt)(); + smp_call_rar_many(cpumask, 0, 0, TLB_FLUSH_ALL); + invpcid_flush_all(); +} + +static void rar_flush_all(void) +{ + rar_full_flush(cpu_online_mask); +} + void flush_tlb_all(void) { count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); @@ -1453,6 +1466,8 @@ void flush_tlb_all(void) /* First try (faster) hardware-assisted TLB invalidation. */ if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) invlpgb_flush_all(); + else if (cpu_feature_enabled(X86_FEATURE_RAR)) + rar_flush_all(); else /* Fall back to the IPI-based invalidation. */ on_each_cpu(do_flush_tlb_all, NULL, 1); @@ -1482,15 +1497,36 @@ static void do_kernel_range_flush(void *info) struct flush_tlb_info *f = info; unsigned long addr; + /* + * With PTI kernel TLB entries in all PCIDs need to be flushed. + * With RAR the PCID space becomes so large, we might as well flush it all. + * + * Either of the two by itself works with targeted flushes. + */ + if (cpu_feature_enabled(X86_FEATURE_RAR) && + cpu_feature_enabled(X86_FEATURE_PTI)) { + invpcid_flush_all(); + return; + } + /* flush range by one by one 'invlpg' */ for (addr = f->start; addr < f->end; addr += PAGE_SIZE) flush_tlb_one_kernel(addr); } +static void rar_kernel_range_flush(struct flush_tlb_info *info) +{ + guard(preempt)(); + smp_call_rar_many(cpu_online_mask, 0, info->start, info->end); + do_kernel_range_flush(info); +} + static void kernel_tlb_flush_all(struct flush_tlb_info *info) { if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) invlpgb_flush_all(); + else if (cpu_feature_enabled(X86_FEATURE_RAR)) + rar_flush_all(); else on_each_cpu(do_flush_tlb_all, NULL, 1); } @@ -1499,6 +1535,8 @@ static void kernel_tlb_flush_range(struct flush_tlb_info *info) { if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) invlpgb_kernel_range_flush(info); + else if (cpu_feature_enabled(X86_FEATURE_RAR)) + rar_kernel_range_flush(info); else on_each_cpu(do_kernel_range_flush, info, 1); } -- 2.49.0