From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C49C54756 for ; Tue, 20 May 2025 01:04:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30DB86B00A2; Mon, 19 May 2025 21:04:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 135B06B0099; Mon, 19 May 2025 21:04:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E757D6B00A1; Mon, 19 May 2025 21:04:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8DF586B00A1 for ; Mon, 19 May 2025 21:04:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A2B3E6E34 for ; Tue, 20 May 2025 01:04:21 +0000 (UTC) X-FDA: 83461490322.22.87F4B24 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf12.hostedemail.com (Postfix) with ESMTP id A7F5940009 for ; Tue, 20 May 2025 01:04:19 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747703059; a=rsa-sha256; cv=none; b=FSKyk0JD40Vge9uWDMonT0Q05AxM2SSYsV4ZGBtr9BwqO6kZIewIoa/dHjW+YL+SUG9X2w Ltjse2khZlQOZHtYG+w02uJ47+aUVt1gJMX/UXu2cTKq8qis33MjhubHONXcY8yEq++1sv CsstypAK40gHrbPkY5leMt0XBHOV+Ws= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747703059; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rIrT894mYFPddGI75SeZC+Dr07QoIPjvN23IRr+cSTM=; b=5S8gZD6d3TZzxGtODZDiXTP9wmG27HsFcHyxeN0CIu3p85rF6pY1VGdgSqqycVWF4waQZi uKyKP92GXtgyTuzVbg3R9I7wV7OqBhAKgjzocpUaEWIlmbSOmkAx337g5rrSMYN2fJdwcM 67tO8DQYQFjoWHr+UTUuIU5jCC4UbMo= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1uHBOd-000000000aB-0G7W; Mon, 19 May 2025 21:03:55 -0400 From: Rik van Riel To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu , Rik van Riel Subject: [RFC v2 6/9] x86/apic: Introduce Remote Action Request Operations Date: Mon, 19 May 2025 21:02:31 -0400 Message-ID: <20250520010350.1740223-7-riel@surriel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250520010350.1740223-1-riel@surriel.com> References: <20250520010350.1740223-1-riel@surriel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A7F5940009 X-Rspam-User: X-Stat-Signature: qdz8e6u1owatzywskqujpi479bfy9xx9 X-HE-Tag: 1747703059-470644 X-HE-Meta: U2FsdGVkX193LRS5RXNPCsCCWNC+0OKCEHPfUt0g8AEW7lPlAzIkpjkKsHMqSdcyMofECHrwqn8lWL00KfdVHaOFq3zkULAQIu5GYU+Xrb5m6jTdzch80+uhXadcwLtUteFLLLYj7GjkeMHt1jNZgaUlEv6U/cPjHJEKYf62HrZr7LLQ/n0dnU2wpdG4IGlA6Hg/JK1eQIAU7kDCcePtmVO0dbTxpMXYfLE0LVs2MqjcoN2u4vr/nPx9XuPUa5FlTSMmgRR9T+Tw/Yk7+iEJPPrPWnk5HR94GcFi8WETbzCzVRDxwovxDQ527WCHrCBXckODA6MdruSueOMMrjAiR7MEOJKykrBPHAJWcMRByJmhqEDGrEh2Dr6yw+NPuw3NgbqBXZ4wuAxHyLH92RQukJKRG1tL5P6sR2NxBPfzFJeR9bxRMWywhL+keggFo+PL7Ys1rTAhPGKAJYw9Xcl6m3ijVzFnP9s5hAhAZeNyuEQOCDWFCU9r/zHUYjRTud+5eEOlpj9E/krl6X+sahUNSsPxMFAu5ta6W/1iIyFwfpuO65k6RG4GQ7o9eysN3MxVGABv1l/soAw/quqTbVw6HsQYSBkmQolH4KUMn8xvmzmYKOOYVoiXYoOWEr3MijeQy9dDBE6quiUMQIdsbq1QhPKIGe89BWAnnxNX3ABPQAAxpD5I1kYAntcRyK876jqN7o8n+oy5m99xhYiUWbeCeCNLvjRvcAu/5l74s9dgRm7SegPBcMKhw8FLlCxx0fD315gK23OhwwsMCNrbT6jbllF/kDgD66TMKxVrZ6GeK3AKk7jxYGp4aioSjXMM/ifiQc2uAbNR/+QVNTAPGVGRLCMnXDK2ELNhvPcXc370u1j3kzN48pZ98b3YIN87uHcVtMTsdbRNCc/3Fq+6Zo2RjN17GbHYx0E13cGy4Suc71gPEMqbiMvjkIfhmobnMqNOtGosQwrWRu6TIUBDzIa s0GDyRlq 4YgCgZgpRsq/RFbo2xKo5un4pQgaQzvih0tkJDBai22ovoEs65MRRlH7l2ugbixUkwrRwzU0gqwmdGrZGkTYIp5n2anv8ZcnIJkQS212Xe36c5OLB9YQ5OZrDtugWvbLQxINKjgQpAFJchF9iF3nTHx2m2fpupVQASBcSSPfrK79SSeMIt6ZAV9PRrQqKQv/GnvIC7JQStrTWMi0anY6GRB3MJW99hkEK/m9nef4o5fzBRFzV6mGDnHosF8UIai7PKjqvJgLjEro3bzZxOXcgTYqhm6t4nEMQmXV7XvJU51+LVCgzF6SBxf/mv7kgZ1hybntbw88+cDlUl5absuxtyQ9HePpbGmrvFIBlisgsZT8oasw+ONWe4MCeIqEdT1xVPxaImUhEJm7GwpQkhVOIFU4jNTVaZYYPHxvbrGUI6DFElyX6eErrxah/mQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Rik van Riel RAR TLB flushing is started by sending a command to the APIC. This patch adds Remote Action Request commands. [riel: move some things around to acount for 6 years of changes] Signed-off-by: Yu-cheng Yu Signed-off-by: Rik van Riel --- arch/x86/include/asm/apicdef.h | 1 + arch/x86/include/asm/irq_vectors.h | 5 +++++ arch/x86/include/asm/smp.h | 15 +++++++++++++++ arch/x86/kernel/apic/ipi.c | 23 +++++++++++++++++++---- arch/x86/kernel/apic/local.h | 3 +++ arch/x86/kernel/smp.c | 3 +++ 6 files changed, 46 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h index 094106b6a538..b152d45af91a 100644 --- a/arch/x86/include/asm/apicdef.h +++ b/arch/x86/include/asm/apicdef.h @@ -92,6 +92,7 @@ #define APIC_DM_LOWEST 0x00100 #define APIC_DM_SMI 0x00200 #define APIC_DM_REMRD 0x00300 +#define APIC_DM_RAR 0x00300 #define APIC_DM_NMI 0x00400 #define APIC_DM_INIT 0x00500 #define APIC_DM_STARTUP 0x00600 diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h index 47051871b436..c417b0015304 100644 --- a/arch/x86/include/asm/irq_vectors.h +++ b/arch/x86/include/asm/irq_vectors.h @@ -103,6 +103,11 @@ */ #define POSTED_MSI_NOTIFICATION_VECTOR 0xeb +/* + * RAR (remote action request) TLB flush + */ +#define RAR_VECTOR 0xe0 + #define NR_VECTORS 256 #ifdef CONFIG_X86_LOCAL_APIC diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index 0c1c68039d6f..1ab9f5fcac8a 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -40,6 +40,9 @@ struct smp_ops { void (*send_call_func_ipi)(const struct cpumask *mask); void (*send_call_func_single_ipi)(int cpu); + + void (*send_rar_ipi)(const struct cpumask *mask); + void (*send_rar_single_ipi)(int cpu); }; /* Globals due to paravirt */ @@ -100,6 +103,16 @@ static inline void arch_send_call_function_ipi_mask(const struct cpumask *mask) smp_ops.send_call_func_ipi(mask); } +static inline void arch_send_rar_single_ipi(int cpu) +{ + smp_ops.send_rar_single_ipi(cpu); +} + +static inline void arch_send_rar_ipi_mask(const struct cpumask *mask) +{ + smp_ops.send_rar_ipi(mask); +} + void cpu_disable_common(void); void native_smp_prepare_boot_cpu(void); void smp_prepare_cpus_common(void); @@ -120,6 +133,8 @@ void __noreturn mwait_play_dead(unsigned int eax_hint); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); void native_send_call_func_single_ipi(int cpu); +void native_send_rar_ipi(const struct cpumask *mask); +void native_send_rar_single_ipi(int cpu); asmlinkage __visible void smp_reboot_interrupt(void); __visible void smp_reschedule_interrupt(struct pt_regs *regs); diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c index 98a57cb4aa86..e5e9fc08f86c 100644 --- a/arch/x86/kernel/apic/ipi.c +++ b/arch/x86/kernel/apic/ipi.c @@ -79,7 +79,7 @@ void native_send_call_func_single_ipi(int cpu) __apic_send_IPI(cpu, CALL_FUNCTION_SINGLE_VECTOR); } -void native_send_call_func_ipi(const struct cpumask *mask) +static void do_native_send_ipi(const struct cpumask *mask, int vector) { if (static_branch_likely(&apic_use_ipi_shorthand)) { unsigned int cpu = smp_processor_id(); @@ -88,14 +88,19 @@ void native_send_call_func_ipi(const struct cpumask *mask) goto sendmask; if (cpumask_test_cpu(cpu, mask)) - __apic_send_IPI_all(CALL_FUNCTION_VECTOR); + __apic_send_IPI_all(vector); else if (num_online_cpus() > 1) - __apic_send_IPI_allbutself(CALL_FUNCTION_VECTOR); + __apic_send_IPI_allbutself(vector); return; } sendmask: - __apic_send_IPI_mask(mask, CALL_FUNCTION_VECTOR); + __apic_send_IPI_mask(mask, vector); +} + +void native_send_call_func_ipi(const struct cpumask *mask) +{ + do_native_send_ipi(mask, CALL_FUNCTION_VECTOR); } void apic_send_nmi_to_offline_cpu(unsigned int cpu) @@ -106,6 +111,16 @@ void apic_send_nmi_to_offline_cpu(unsigned int cpu) return; apic->send_IPI(cpu, NMI_VECTOR); } + +void native_send_rar_single_ipi(int cpu) +{ + apic->send_IPI_mask(cpumask_of(cpu), RAR_VECTOR); +} + +void native_send_rar_ipi(const struct cpumask *mask) +{ + do_native_send_ipi(mask, RAR_VECTOR); +} #endif /* CONFIG_SMP */ static inline int __prepare_ICR2(unsigned int mask) diff --git a/arch/x86/kernel/apic/local.h b/arch/x86/kernel/apic/local.h index bdcf609eb283..833669174267 100644 --- a/arch/x86/kernel/apic/local.h +++ b/arch/x86/kernel/apic/local.h @@ -38,6 +38,9 @@ static inline unsigned int __prepare_ICR(unsigned int shortcut, int vector, case NMI_VECTOR: icr |= APIC_DM_NMI; break; + case RAR_VECTOR: + icr |= APIC_DM_RAR; + break; } return icr; } diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c index 18266cc3d98c..2c51ed6aaf03 100644 --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -297,5 +297,8 @@ struct smp_ops smp_ops = { .send_call_func_ipi = native_send_call_func_ipi, .send_call_func_single_ipi = native_send_call_func_single_ipi, + + .send_rar_ipi = native_send_rar_ipi, + .send_rar_single_ipi = native_send_rar_single_ipi, }; EXPORT_SYMBOL_GPL(smp_ops); -- 2.49.0