From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DECFC2D0CD for ; Mon, 19 May 2025 23:54:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCCBA6B009C; Mon, 19 May 2025 19:54:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7CDC6B009D; Mon, 19 May 2025 19:54:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A93F66B009E; Mon, 19 May 2025 19:54:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8464B6B009C for ; Mon, 19 May 2025 19:54:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BC5C1BF31A for ; Mon, 19 May 2025 23:54:25 +0000 (UTC) X-FDA: 83461314090.26.0B96BE2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id EC804C0005 for ; Mon, 19 May 2025 23:54:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=INWcBy5A; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=INWcBy5A; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747698864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dM9pncmpihF8r7dBP2crpmDEBKDCLDl7qsU4siYmTMs=; b=YfVXK32wioLo3qVyWlCG7Xm2zRe3C98HAl3JsGTUa7YYfWsk1nHCs+v1+OSRFczghUFbSn pIEcvMWMh2pNptEeR+PuReHgwyl13rfREHnpM+D0XzEllwiVHKHA5chNteyIkMUo1njFIj NHVKOUplt3sdg1ltdtuH6KXpc8T8DJ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747698864; a=rsa-sha256; cv=none; b=ecGKEvC/LCvgbbLyYTbzo2M7eVsOARwdkTKmVsfDUpjx5m55A5qKp7QHwoA/1ja6QZhbvD A6KpHTl2gJwiyoTD4DYgmq9V3WNG+7k7DRHAoEPjBNwA4dAs+9xcObJgCQqGo6J2OB/FSH f2byDTECZT1gOrOKZ0tpK+2JQ50OLH0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id EDACA629DD; Mon, 19 May 2025 23:54:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 326D3C4CEE4; Mon, 19 May 2025 23:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1747698862; bh=XgwNLXvJBukljmVN2KRaxsMI83XLZNT7ePYa0+nIIbg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=INWcBy5APnEwJymZe+RxDtPBUBg374q+5MIqzebyecub6tsNDB8Z4ESaXgEm+M1aH Gy+JNeC2yKYrfTNYAfeH2krebXxUjmfva51S9RME426LfZMnJ/UTAyHuBp8SCVLC1x 5Xu+S1Tamrr7EBIhH1F23EHDfmJO0hJrCpsyyVhk= Date: Mon, 19 May 2025 16:54:21 -0700 From: Andrew Morton To: Christoph Hellwig Cc: Hugh Dickins , Johannes Weiner , Yosry Ahmed , Nhat Pham , Matthew Wilcox , Chengming Zhou , Baolin Wang , linux-mm@kvack.org Subject: Re: stop passing a writeback_control to swap/shmem writeout v2 Message-Id: <20250519165421.b883f3e762e8098ad162d816@linux-foundation.org> In-Reply-To: <20250516074146.178314-1-hch@lst.de> References: <20250516074146.178314-1-hch@lst.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EC804C0005 X-Stat-Signature: dpaua33mdget54773xw1rp6ocizkoxd6 X-Rspam-User: X-HE-Tag: 1747698863-61745 X-HE-Meta: U2FsdGVkX1/qgsbucEeidgog7g43z0PRLhbe6zf3JEm15hzJZ0qli5D9hk+Dqz/BTYIyZuEazwYnzmMBO4p3lYNVuMzkZUznWbNInhq8MVmuKEYIl1czzYjLyjJwFCSfidWgCs2055n9Byp61b9wZvmflpIfYOSWDZ3iXCNsHtxyZqJsszpSLi97ZokTgr062dkddqHWFVJUPLy3H2OoJcsQYx1/U2px1SdCQJzrIDDfIRdhLq4Gd0Z7XirRPRxDcbmXqPrBl1T0qQUxB43hIGgPsUFyN0rY5ozcR8B4LYdcDp3FazSjdHDUhNQFL9y6RPMz5Y8JmEfER9KcWopDNEnEjmOmrAuU4xGDZC2Lz4xPVzAaJjk9l1/nl/AZOuwe5o7eT5m1f2b04CxAZ0iwjESb6qDfJuHodubowsbRTl/3GnFI4kVn8HPg6GggjA3b9XFVnHKIi18vPii7/PaRTre8wmBwR0KOsj28l3wEqcx9Y+pX1H25RzyFMJ4Z0Sw9axoLuWB7K/5EE4p8gHUdR7Fdf+hH85eCc7jQsmHL6ENhLG0jthGPBlOSJpY6YnqC2Boi9go39hfQv4HWAYmMGV4D917icaF63jrV9hIcvoiTJZuSzUPABaXfhOastizyVcGZduMy+P6AkjWI1+fIqXj/cTaidSWGybnnlCt6yYeD4K7S+4DdvP1CtqvrruFrVFkPfE/D7d/7Wf4l+G20AcgaUVH6aoJJojeBjsNVH9vZhy2BIzSxBK3WPg39hWywQMZCi7lOazC1uLalVwuG2lNqPXIdp9WJe4jyFBtZ3nEHm9c72BDQQl0J38fk/xlg282aeU/80wx1rjZgX1b0NuLnUaMat3qyaF78jd8DrFjy5ko4rByMOQPUot3vISUApVXhJJ9x91HRLdvJr9mRkKGqol3TOaIGUBnYwBBmURU5e7p08vCgtQtUBfEuHfBUqKbdtnHogx8u586IL9O oBKAr1Xj kwTwRNy1O6CJ+NwLpTO4Pu//RaqI6z15qU3nQ29tkEOE4L+/VE6jADLz3igSNb1+yq1t2KhYbTFtrg4s8E+Bz24PlnDCl61M0WTUVeZjVl1lR5XD/7qKHCjKP6qaJg2GzHLhfzWCLCcyYdpAMATHQsodAdeC8+LOggnCyUyAOyweAFHyDYUtgWMazNkvvE9VSOGA2jkmLo+uwrsA3Vbf4W8fs+bKHttiUiHXGQu3p4xLjf2y+Ps/OnD71+NiWR0QMOZKz9J1lGA+uobdRHakpYQJmdlTVJEKqbN5ZXfjJmN6YDUg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 16 May 2025 09:40:34 +0200 Christoph Hellwig wrote: > this series was intended to remove the last remaining users of > AOP_WRITEPAGE_ACTIVATE after my other pending patches removed the > rest, but spectacularly failed at that. > > But instead it nicely improves the code, and removes two pointers > from struct writeback_control. > > Changes since v1: > - drop to patch to be merged through a different tree or later > - fix !CONFIG_SWAP compilation > > Diffstat: > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 > drivers/gpu/drm/ttm/ttm_backup.c | 9 --- > include/linux/shmem_fs.h | 5 + > include/linux/writeback.h | 10 --- > mm/page_io.c | 71 +++++++++++-------------- > mm/shmem.c | 17 ++---- > mm/swap.h | 9 ++- > mm/vmscan.c | 84 +++++++++++++----------------- > mm/zswap.c | 5 - > 9 files changed, 91 insertions(+), 121 deletions(-) I can't merge this without a lot of messing about because Matthew's series "Remove aops->writepage" is sitting over in the vfs tree. We're at -rc7 anyway, so I'll park this series for after -rc1, thanks.