From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34C0C3ABDD for ; Mon, 19 May 2025 16:44:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC9BB6B00D7; Mon, 19 May 2025 12:44:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7A2D6B00D6; Mon, 19 May 2025 12:44:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACB3A6B00D7; Mon, 19 May 2025 12:44:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9108E6B00D5 for ; Mon, 19 May 2025 12:44:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0919F1A0A03 for ; Mon, 19 May 2025 16:44:26 +0000 (UTC) X-FDA: 83460230532.27.38FE15B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 723F716000E for ; Mon, 19 May 2025 16:44:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=g46DMzW0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747673063; a=rsa-sha256; cv=none; b=eBi9LHO4ajSwNugVnfXlsVmtRxr6PRCYFZAOnEflJzThMWgKKBEeKwaqUkSpaTvzv9ccmi Mj7uonlHayzoL/HQ0bPLapqSIE5+6tGWzDv/LUDN6HhqxQuD8JblEB1wjTj9j9g7Bf11hY KAPGZAh1DUNSWHZugx99z2LZb2ttttc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=g46DMzW0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747673063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V62aoCICcE2IpBkZ7E+MGMKKhudkbA5nVnyjibrMzSM=; b=dMlte8ouV8NMFIJ8hD9UySahl3qjakLIiTE1PnyNb6XThdMFTlxzoyR9WBBY/YevanvRO2 sCiYjN4oDe+F/WbX8hJaiQod/8PcMjoWqorpWx6/bUdHL7uQKS4iQQ0L8zo3iT9hXpx7YQ uFtGmwEGMt2ffZF2HuS0FwGMHKUtIPo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D772EA4E521; Mon, 19 May 2025 16:44:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5174CC4CEE9; Mon, 19 May 2025 16:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747673062; bh=aEHaE8W06Fq5hALcrvZOQ2IWuHzzkcZJHOLo+mefNe8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g46DMzW0Ra+JSIykpWnDpHN1/7r2XsIY1kQ/mXixnOkME0IZGmBYlIqCPsGxKlzST GspthY0pYkZstR2betw+cfpgvYUBhMRJt0Oiuu3AUy5Qu5ZbLe4P7uqkCJPU3pW6cs 9M7dZ166PO4qDqsr49f1g5eu3egKwHzBGG9SdLdENvez9v3f0dnHFaE/zseY/ERREN AY6Cq8VytXLt9NZrs6JfLCT4LcdX3irWKgyPQfsRBBh3PAkDTuCsdYPRP80Zg+aq3J U7M5t03ANUf9JzHeksEUDG1JLSW/euot7o1RFgA5hu0H047Dc0CsH7thvnbxPcyJo3 WKDmz1d5UTU8Q== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 2/3] mm/damon/stat: calculate and expose estimated memory bandwidth Date: Mon, 19 May 2025 09:44:14 -0700 Message-Id: <20250519164415.43935-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250519164415.43935-1-sj@kernel.org> References: <20250519164415.43935-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 723F716000E X-Stat-Signature: o514gy8gka1ifrwebtjthismpbkqz771 X-HE-Tag: 1747673063-812272 X-HE-Meta: U2FsdGVkX19ePkkpOf7veEM4o8V0XDv7YHOE3PJ7ig1b+GdQn2o7MXuIqD1GHrvKpQq2NRZz3/2MnuSqtvVyqLadVx+NwD34xBKaLnfDiapPL355U61WEOQuK1ZHJIBEmaOuwa01hpdDxZ/Y1fKnChJrUyDBlcEaa93BfIw0Egd48dRNUDLWmasytxhPj1ycND7HynsMeOzjLxJ4amEMByj9qK1joDmTfSMlV/TwN3oRYHDOAVeE7rbqt2d7Yb02D3RhFPgNfYjK0JSNB7KZl002AWB1bseGWBtniBoYJKSMGFfsfIcUTPiJgh/ElJ+DEEgnDedITw3zyjmu5mqeCCr3R3InM57dk3jhP5/jo2nDef0v44HxxZfR0oJdUEvC5i+YjOlj+xUZ1LlRavi0GRrnei2wMvfGz/yOMXtAoGj6hUwLVqmaP5olrHwO+n0GemdEtZo6Xjndni5j2rjX5QLifTQ+MNxkNTusOFGWRJQKCPpiU2GLnbrxkxzh6hfeQkYU+YVR4rk1Ghqoq1yv0ej4zPB4bU+chWjrPy3RacZlBS2TtO+0/2adHjDnEMgSIzlalVr7IyVJYl4+MqNg2uXejB8aHvPOQ0XmIuyuzLnswQAnceWtZxBwqZS55oaW9VJzzdJv+6lapRYCNcOeNxb4+W3MPigQwIB8SpOxt50ZCutQdqI9roU6Q+muND3K9Jl+S3SlEGGhoLjFBd5R/hxGHOoSZutaxSy2hCxYVMLWSiQC3Q/8QkKDI9ibYkDkYjKewbkj5LcwwrRF526unfsdfnKNiJbxSmls9rbc4VwdIJ/+6wGNB+47X2tobBM9F3/AY7KlW5EUI2OQQrma3Nf8R3v0DG590crvSZcp8M0pMDm6Zh/621ZsKPVruG4WmkC0jzB3jMpiEmkkRBy+U+iNNx0sl2YiBIrRzUdLlBR9hf0QGUOTzcw/aBOPJOQwKW58IVslciXSeuO/QKn HKqa6LVa Atgd8gXYGml4fxBwPP2kQ13GoP3NIBJvnb6cni2xU1jaipexsAAceXPke8SR13lH0z3uKuOXkfTYsBHQgKfrWUqJJJIbiXO5rCfpU4v1v5MiaV6uUTVTqDp64IBdUA6CNoDkNO7spz5n/Knl2rdjfni7A1Iz1EZF5ZFyPVgWOgwy7U2pUbihOPm0A8yleV0p0R+KGa550e2DsMl1hE4pvJaogwL8LuPY/r1ob+z5Dpqzy3NE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The raw form of DAMON's monitoring results captures many details of the information. However, not every bit of the information is always required for understanding practical access pattern. Especially on real world production systems of high scale time and size, the raw form is difficult to be aggregated and compared. Convert the raw monitoring results into a single number metric, namely estimated memory bandwidth and expose it to users as a read-only DAMON_STAT parameter. The metric represents access intensiveness (hotness) of the system. It can easily be aggregated and compared for high level understanding of the access pattern on large systems. Signed-off-by: SeongJae Park --- mm/damon/stat.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/mm/damon/stat.c b/mm/damon/stat.c index 852848ce844e..f9ae44db265b 100644 --- a/mm/damon/stat.c +++ b/mm/damon/stat.c @@ -28,8 +28,42 @@ static bool enabled __read_mostly = CONFIG_DAMON_STAT_ENABLED_DEFAULT; module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); MODULE_PARM_DESC(enabled, "Enable of disable DAMON_STAT"); +static unsigned long estimated_memory_bandwidth __read_mostly; +module_param(estimated_memory_bandwidth, ulong, 0400); +MODULE_PARM_DESC(estimated_memory_bandwidth, + "Estimated memory bandwidth usage in bytes per second"); + static struct damon_ctx *damon_stat_context; +static void damon_stat_set_estimated_memory_bandwidth(struct damon_ctx *c) +{ + struct damon_target *t; + struct damon_region *r; + unsigned long access_bytes = 0; + + damon_for_each_target(t, c) { + damon_for_each_region(r, t) + access_bytes += (r->ar.end - r->ar.start) * + r->nr_accesses; + } + estimated_memory_bandwidth = access_bytes * USEC_PER_MSEC * + MSEC_PER_SEC / c->attrs.aggr_interval; +} + +static int damon_stat_after_aggregation(struct damon_ctx *c) +{ + static unsigned long last_refresh_jiffies; + + /* avoid unnecessarily frequent stat update */ + if (time_before_eq(jiffies, last_refresh_jiffies + + msecs_to_jiffies(5 * MSEC_PER_SEC))) + return 0; + last_refresh_jiffies = jiffies; + + damon_stat_set_estimated_memory_bandwidth(c); + return 0; +} + static struct damon_ctx *damon_stat_build_ctx(void) { struct damon_ctx *ctx; @@ -75,6 +109,7 @@ static struct damon_ctx *damon_stat_build_ctx(void) damon_add_target(ctx, target); if (damon_set_region_biggest_system_ram_default(target, &start, &end)) goto free_out; + ctx->callback.after_aggregation = damon_stat_after_aggregation; return ctx; free_out: damon_destroy_ctx(ctx); -- 2.39.5