From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9829C2D0CD for ; Mon, 19 May 2025 09:21:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5C166B00B9; Mon, 19 May 2025 05:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D13086B00BC; Mon, 19 May 2025 05:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B166A6B00BE; Mon, 19 May 2025 05:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8B2036B00B9 for ; Mon, 19 May 2025 05:19:15 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F0CAD1A18D8 for ; Mon, 19 May 2025 09:19:15 +0000 (UTC) X-FDA: 83459108670.24.6FBBBE9 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf13.hostedemail.com (Postfix) with ESMTP id 1C26420006 for ; Mon, 19 May 2025 09:19:13 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747646354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FtJWyIDE4KF+Wr115o/T3TPHF34Hh32spFLm92gu96o=; b=fay4ZENSbhUZOUxcwc0KU5BFkAyqZ33RHhxTcUwM2NdBnOS+O4R4SBdpbAKKsafmXlX/57 MM0JRn++FRTuBMMRQgj0eRH8onouVvqJ9APjtN308RW5XmLQNGpZwmjS68VFjH0b8f5PcX A+z93UAg5vdNJF7d1kz/zMn6u5dliSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747646354; a=rsa-sha256; cv=none; b=gBBV3YnAC8y+AIblIOMbErR+vlD7n2edHz4ygpgsaC7yasfzqjCipcnwMnFznU4fVEDaJ/ PJF9Gj+kGz6gVuMhWLop2U4xxTtX+xnybwhkOawrQBbM/V9apLmtRYLEhixu9K8FOMjjzq yUdBuQaMQvmgES3J0JKOk7EYYXdJk1Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-669ff7000002311f-63-682af77127a4 From: Byungchul Park To: linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, yskelg@gmail.com, yunseong.kim@ericsson.com, yeoreum.yun@arm.com, netdev@vger.kernel.org, matthew.brost@intel.com, her0gyugyu@gmail.com Subject: [PATCH v16 42/42] dept: call dept_hardirqs_off() in local_irq_*() regardless of irq state Date: Mon, 19 May 2025 18:18:26 +0900 Message-Id: <20250519091826.19752-43-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250519091826.19752-1-byungchul@sk.com> References: <20250519091826.19752-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSW0wTaRTH/b6Zzkwr1bG67iyQaEqIiiuK0fVEXWNi1HnxkgCJSoLWZbJt BNRWUVZNQJBFsIgYqIBgKVorFMWWB29VFgTFC1ZlEQhWwA3YcGmstNqCu9t6eTn55X/O+Z2X wxCyB6JQRpV6QFCnKpLllISUjIZULdr/MUq5xOdfAZ7xXBLOXzNTYL9ai8DckInB2bIRXnlH EEw8fUaArtiOoKr/NQENrQ4ENtNxCl7+Mw06PC4K2orzKciqvkbB8+FJDL0lRRhqLZvgjXGQ hMeFBgw6JwXluiwcKO8w+Iw1NBgzImHAVEbDZH8MtDk6RWDrWQillb0U3LG1kdB6YwDDy1vn KXCY/xPB49aHJHgLwsB+RiuCujEDBcNeIwFGj4uGF416DK362VCfHRDmfPhXBA+0jRhyLl7H 0NF9G8Hd3D4MFnMnBc2eEQxWSzEB/sstCAYKRmk4ccpHQ3lmAYL8EyUkZPcuh4lPgcsV4zGQ eaGehLrPnWjtr7y50oz45hEXwWdbD/F+z98Ub/PqSf6RgeNvlr2m+ey7PTSvtxzkraYovvqO E/NVbo+It9ScpHiLu4jm80Y7MD/W3k5vDd8hWZ0kJKvSBPXiNbskyhKTidyXOf3wk3N+IgON Ts1DYoZjl3E2w1vyO/eNnRYFmWLncV1dPiLIs9i5nFU7GMglDMF2TuVeVXSjPMQwM9nd3MjH kOAMyUZyxWeHcZCl7C9cnc6JvzrncLX1jV884kDek9+Mgixjl3MdtZVk0Mmx1WLu+FD7t4Wf uL9MXWQhkurRlBokU6WmpShUycuilempqsPRv+1NsaDAexmPTSbcQG57bBNiGSQPkdbbFihl IkWaJj2lCXEMIZ8lrbHOV8qkSYr0PwT13p3qg8mCpgmFMaT8R+lS76EkGfu74oCwRxD2Cerv XcyIQzMQCk0wZ5g+RazbEL8ozB1R5vJuW53f122vII64Lzkd85aEDzY44iY8fzpaok9eiU6c ErdfdyVn08Ltimloj2HleP9Qaaxjy9HNjUU+bXjDinjXQ5P+3tz1mzXhC3Z5435IvL9FW5gr fxt7Nt5/b+YbSdbQ+xmrLtE/f4bCCHF7ORMpJzVKRUwUodYo/geZXTjvWgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0yTZxSH977flUr1W0f0i8zgmhARohOyuuNlTJMlviPRuEgwMfFS9Iv9 YkFplcniBUZ1CMLQpSAorKKplRZlrZtaqSEQwKoTFKyKgEIWlbSURCkO7C6ty/45efL7nTzn n8NTqovMXF7O3SsZcrV6NaugFetWFC/Ke5usW/K07WMITZTQcOayg4WeS3YEjitFGEY71sCj yQCCd793U1Bt7kFwdniQgiudQwg8tu9Z6P1jJvSFxlnwmstYKD53mYX7/jCGgaqTGOzOtfDM +oKGO5UNGKpHWThdXYwj4xWGKWsjB9bCRBix1XIQHk4F75CPgfY6LwOe/hSoqR9gocXjpaHz 2giGXvcZFoYc/zBwp/MWDZMV8dBzopyBpmADC/5JKwXW0DgHD1otGDots6HZFLEeffM3A13l rRiOnv8FQ9+TGwhuljzH4HT4WGgPBTC4nGYKpi90IBipGOPgyPEpDk4XVSAoO1JFg2lAA+/+ jFyum0iFop+baWj6y4dWpRNHvQOR9sA4RUyub8l06CFLPJMWmtxuEMn12kGOmG72c8Ti3Edc tmRyrmUUk7OvQwxxNh5jifP1SY6UjvVhErx3j1s/b5Ni5Q5JL+dLhk/Ttyl0VTYbvado1v67 p6apQjQ2oxTF8KLwmfg8+CMTZVZYID5+PEVFOU6YL7rKX0RyBU8Jvhnio7onqBTx/EdCthh4 GxvdoYVE0fyTH0dZKSwVm6pH8X/OBNHe3PreExPJ+8vaUZRVgkbss9fTlUhhQR80ojg5Nz9H K+s1i427dAW58v7F23fnOFHkgawHwyeuoYneNW1I4JE6VtnsWahTMdp8Y0FOGxJ5Sh2nbHQl 6VTKHdqC7yTD7q2GfXrJ2IbieVo9R5mxUdqmEnZq90q7JGmPZPi/xXzM3ELkMGd0pSVmvjke JgFfxup4r7nQLidkqot/SNfZ85b7tZVfsocr3N1Z5o5u/EnivJSFL7eslE3fpCjkQ5qu0tjP Sw6Xx141rqvxa1Zl/5ow/Nug3j2z9sHBvGx3zX2rvCAtb8j2dVowM3wg6YvNWV+1XOpyBq3T hxwvD3y4gVnGuNW0UadNTaYMRu2/Yfj0JDwDAAA= X-CFilter-Loop: Reflected X-Stat-Signature: jb3k4wpxyzws9nh6bwmc1rdbx7k5kmfo X-Rspamd-Queue-Id: 1C26420006 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747646353-809278 X-HE-Meta: U2FsdGVkX1+u0Ot5Y0ljOZ9KM+4TwUVIDMVe7eaYezolARncgFCQ0uyU7gsrtQQoL95mBvKSOwxZJatHxQd3WMj7YzhIZI6vYLCWqGVXq7EteeOG6Q1U0in0cpsz6tDeei0sbv1a3K2b/CnmmCTTgtKLv3JlzoYpaTzfReWdqG29L65dJtDbwfRB6Hz495lm+M8SCICp9iYtz+ilYX9llRO3PRxjJTkN4GcDUtO7Ltp/ZhHo5j7E1pwDnleJ9vwMeO8TF7VxiMxoZmqtLXa3ZY1OvzjmlUHNHyyTssP279qdVQ9Nf93y/AEUMfxXdk+8eUkopgtlPIWyvjyN+DbyOAjadvfkA0onNQ+iyjHh/Nd/JQ5i+ziEKuQl5UY5zOVF04B7WUnNM1PyEnyVPo4dhcFLyJoXGMXfHrnc2IL+GlPA74TPFj2QB/DsdqLoda3V98UlfqwZwqq+Wgd25lpqk6+bKtyATvdWv1/4K8LV3SwLTm2m1rzQvgXHqo8jgeDbtPMAhL5RJVL+1ANX3vgVCHwB1fTzlswbncFLspg4RoK8UUWKMl7CeIvjZtwr06f/Y4EfPsiz5OmCVfEfkIqWFBbGgKHZNN5XaE8edRwQCqhObhFgm52+8r0UV5zI6nWcN8z7WbUI/GZNdoFiVov+HVg5wiSYxN4yDQt2ndn461+jd7Pjf2bI/9yTJQwbcMkXb+ayTKOTthZiWPEOow5/2RkWZZIYuPfuYAe0gleZnvqvYl4BN9m43C7q7CieaVGEtwHBRwUFv9EDPkGs0VB2K8345EtjZZWj2/EeMFIO3J8pd5odCCt3NOVf/vumiNWqwGLMdvSEyp2a+i9rPd/YByDPLPL0Cor8Jm+m2VtP324wj4LYTMXdu3EZnL+nzqvBlDEwVCDeGeMz4EAsq78NgTagfpSCk2twRCsIrpFsYw/s4ktW1APCuCR1K57mCx/iXN+97L/VS7Jer0gWZTO JK05bP+M FAMdi90n/DTxqbhbRIBHXCUg9t0zgPhsh1sUgOyDQXkZEWmPJ+0ybUuKaBf+WxlmMhouXuJu4BQwa0/fXpjUC9c7qI5RO/IsOCSc0WMrqeDG+mVLVDHnwG7bgpjKU3ZJ76QBk8+fN7/6lGWIAFnDbvhaSSiDn/BrDCAFjSasPpe7ibrPTNo/enKkblaLd472UDLuyeY8JGS7tWwVuyF7gyWCZspx6/LLOJxFYr4SeMDcjDWQUUJbPXae7hprhUsDnrvhC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For dept to function properly, dept_task()->hardirqs_enabled must be set correctly. If it fails to set this value to false, for example, dept may mistakenly think irq is still enabled even when it's not. Do dept_hardirqs_off() regardless of irq state not to miss any unexpected cases by any chance e.g. changes of the state by asm code. Signed-off-by: Byungchul Park --- include/linux/irqflags.h | 14 ++++++++++++++ kernel/dependency/dept.c | 1 + 2 files changed, 15 insertions(+) diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h index d8b9cf093f83..586f5bad4da7 100644 --- a/include/linux/irqflags.h +++ b/include/linux/irqflags.h @@ -214,6 +214,13 @@ extern void warn_bogus_irq_restore(void); raw_local_irq_disable(); \ if (!was_disabled) \ trace_hardirqs_off(); \ + /* \ + * Just in case that C code has missed \ + * trace_hardirqs_off() at the first \ + * place e.g. disabling irq at asm code.\ + */ \ + else \ + dept_hardirqs_off(); \ } while (0) #define local_irq_save(flags) \ @@ -221,6 +228,13 @@ extern void warn_bogus_irq_restore(void); raw_local_irq_save(flags); \ if (!raw_irqs_disabled_flags(flags)) \ trace_hardirqs_off(); \ + /* \ + * Just in case that C code has missed \ + * trace_hardirqs_off() at the first \ + * place e.g. disabling irq at asm code.\ + */ \ + else \ + dept_hardirqs_off(); \ } while (0) #define local_irq_restore(flags) \ diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c index a08d0e16978b..4ca1cc04293c 100644 --- a/kernel/dependency/dept.c +++ b/kernel/dependency/dept.c @@ -2248,6 +2248,7 @@ void noinstr dept_hardirqs_off(void) */ dept_task()->hardirqs_enabled = false; } +EXPORT_SYMBOL_GPL(dept_hardirqs_off); void noinstr dept_update_cxt(void) { -- 2.17.1