From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D77C3DA6D for ; Mon, 19 May 2025 09:20:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B84E6B00BB; Mon, 19 May 2025 05:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93B446B00BD; Mon, 19 May 2025 05:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F9D16B00BB; Mon, 19 May 2025 05:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 276AF6B00BC for ; Mon, 19 May 2025 05:19:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E7C8B1418D0 for ; Mon, 19 May 2025 09:19:14 +0000 (UTC) X-FDA: 83459108628.30.7989E0C Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf15.hostedemail.com (Postfix) with ESMTP id 263D5A0006 for ; Mon, 19 May 2025 09:19:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747646353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=9HMbQF45WNvfIQQ3dm14gSFuJIJ+8PLsYR47OXuqIws=; b=umSwGtXs2MUPVzLGI7vXyVAjiia5EOvpVeeuXc7QtSOAgdguiZiyG6njl4Hzu5axl/oc4v nhMUz/kvgosi4nfkptOrGxc71XYx6Pay8SFMn0bExWap0i7IWoE+btmAd5TmbyE0MdTGhU hT9T5PwjtyD79V+XOpL3X6pmluOKkc0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747646353; a=rsa-sha256; cv=none; b=Mr+jAEnAiK798EttCSJG13v/OodzIynfoyEFzyEFT5+MO1SZFdngDb0NdC9IH7amz38GTJ IPHXKcs6hAn5Pp4E5TjSXiaD/ZSthiT6PEUlO1XChm5Z+Qof3lzUIsvBbcMJGyv1Qj6bFf EhyVcoh57n1nOD7EVGMzdVm0oovKd5A= X-AuditID: a67dfc5b-669ff7000002311f-44-682af771e118 From: Byungchul Park To: linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, yskelg@gmail.com, yunseong.kim@ericsson.com, yeoreum.yun@arm.com, netdev@vger.kernel.org, matthew.brost@intel.com, her0gyugyu@gmail.com Subject: [PATCH v16 40/42] dept: introduce event_site() to disable event tracking if it's recoverable Date: Mon, 19 May 2025 18:18:24 +0900 Message-Id: <20250519091826.19752-41-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250519091826.19752-1-byungchul@sk.com> References: <20250519091826.19752-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzXSbUwTdxgA8P3/d727FuuOyvB8yWaaGJVFBaPm+SAGEsVbsg0TkyXqFneR 29oIRVtEmJoAIkE6iJpApwi2vNSmLVpbM0EoshIK6OZAWXkZolRlIiAGaRFEXYH45ckvz+uX hyEUrZLljFqTJmo1QrKSkpGysUWm9UemolTRN++vg8BkPgmXrtkp6LhqQ2C/kY1huGUXdAdH Ebz9628CDMUdCEyDDwm44R1A4LbkUPDg6WLoCoxT0F6sp+BU5TUKOkdmMfSXnMdgc34Dj8xD JNw9W4HBMExBqeEUDoXnGKbNVhrMWavBb7lIw+xgDLQP+CTg7vsSLpT3U9DgbifBW+vH8ODW JQoG7B8kcNfbRkKwaAV0nCuUQM3LCgpGgmYCzIFxGu43GTF4jZHgyA0tzHv9XgKthU0Y8qqu Y+jqrUfQmP8Yg9Puo6A5MIrB5SwmYOZKCwJ/0RgNp3+dpqE0uwiB/nQJCbn9W+Dtm9DlsskY yL7sIKHmnQ/FxfL2cjvim0fHCT7XdYyfCfxD8e6gkeTvVHB83cWHNJ/b2EfzRudR3mWJ4isb hjFvmghIeKf1DMU7J87TfMFYF+Zf3rtH7165T7YtSUxWp4vajdt/lKn+PVeFDj/5PCMnrwZn oWquAEkZjt3MDZnq0EfnzDyeN8Wu4Xp6pok5R7CrOFfhkKQAyRiC9YVx3WW9801LWJFz+Kbw nEl2Nfeu/hk1Zzm7lfNXdhILS7/gbI6meUtD+T598/ysgt3CddnKyYUeg5Trm/x+wcu4Pyw9 5FkkN6JPrEih1qSnCOrkzRtUmRp1xoaDqSlOFHov88nZ/bVoomOPB7EMUi6SO9zrVAqJkK7L TPEgjiGUEXKra61KIU8SMn8RtakHtEeTRZ0HrWBI5VL5puCxJAX7s5AmHhLFw6L2YxUz0uVZ aFl4+d5Dv8d9NvKG/DQorR6s7pY6diT0xvu8utLiaE/S17u3e76a+lDLGO7Qi18FI4deTIYn 7EjbJv3ptuVZzprO1CNl3/5ZcuKHpfq242HxpWZbQoU/MT/juyyb/bdG6wl9XFjsdWtllcEk 1Mb/t5FdWRep6bwQmyrs2+mjNzUn5ilJnUqIiSK0OuF/EerFUloDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSf0zMcRjHfT7fX3eXs+9O4yvz68ZUfrbJHmOG2XwxstnY/KOj79xRp+4q YqjrtPSLY2n0w1Wcdnfp3N0fyFkr4kSicymVOkQTbXSpU7gy/zx77f1+nvf7n0dEyMxUmEil ThY0akW8nJaQkp1rM5cl/YxUruzuCgH/UDYJJTVWGlpuWRBYnRkY+h9tgbbhAQS/nr8goKiw BUF5bxcBzsZuBK4qHQ2tH6aBxz9Ig7swl4bMyhoaXn4Zw9B5+SIGi30HvDP1kdB0oQJDUT8N xUWZODg+Yxg1mRkwpS8CX9VVBsZ6o8Dd7aWgodRNgatjCVwp66ThvstNQuMdH4bWeyU0dFv/ UNDU+ISE4YLZ0GLIp6D6WwUNX4ZNBJj8gwy8qjNiaDTOAJs+mJr14zcFj/PrMGRdv43B016L 4EF2Dwa71UtDg38Ag8NeSEDg5iMEvoKvDJzNG2WgOKMAQe7ZyyToO6Ph10iwuXQoCjKu2Uio HveiDet5a5kV8Q0DgwSvdxzjA/7XNO8aNpL80wqOv3u1i+H1DzoY3mhP4R1VkXzl/X7Ml3/3 U7zdfI7m7d8vMnzOVw/mvzU3M7vm7JOsixPiVamCZsX6WInyreE6Snw/97guqxqnoxtcDhKL OHYVpwv0oAmm2cXcmzejxASHsvM5R34flYMkIoL1hnBtpe2TS9NZgbN5f+IJJtlF3HjtR3qC pexqzlf5kvgXOo+z2OomWRzUO3IbJm9lbDTnsZSRF5DEiKaYUahKnZqgUMVHL9ceUaapVceX HzyaYEfBDzKdGjPcQUOtW+oRK0LyqVKbK0IpoxSp2rSEesSJCHmo1OwIV8qkcYq0E4Lm6H5N SrygrUezRaR8pnTbXiFWxh5SJAtHBCFR0Px3sUgclo4SLb3TH37a7FmQadg7smNj8Xnxk/DT csq/oscXeJon3fWs79S6kllD+wf3OJ0rI0JeoXnGZ4bx5L6Tn03O+pEzsWJ3ufSSLqZ57r3A uTVhMYfb1oRv2rTQk1g7NvXK5tzftqW4IE5v+dO227wx+UDe4qRbj29uT8reoF6oyzJund+0 VU5qlYqoSEKjVfwFKydO1T0DAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 263D5A0006 X-Stat-Signature: ih4g3hcfsgtp5grf5wtb37kat8pyqft3 X-Rspam-User: X-HE-Tag: 1747646352-228488 X-HE-Meta: U2FsdGVkX1+hO/ydssWTvSY9u02ik6K7T3U15fCLRQobAnex/NUXheudZwu/ZNeP2Mr1LzRlUGNoBaHcQWZJv92ygbAOFtPneckg2/4UN/1uJTWCe7PsDUxmU2XWEDUl9JYJGa30HWB/m8iCT0f1JZ/jo+8gw7jBjxVmGi6miwb/nTYGmmfT8SNiPBHvkTU+w2o5j5ARrM2oJLSRvEmVIKI8pbtx9FrfMJcOCD/n04pD6UWmEAufwuQmZ9RJ2ODDU+maTKIGm/Csyv2Eys6A2ZMwNAp9dv7x9dC3vEgg5krKfoQENiCpNNkqIsbsQ7WmSMFCcl2Qd5nH2Cl/aO2VFZ0P8clC2UwtZ9Wax12sEKj29bn1O37hPc1hMTEOSwzkolhGeCoxzRONMjj1qF1n5q6l3UlgVbNEUqqz/n0B/mLMEFviSMdfZ9pi6elftbswweOKUeftJvV22AelU+Fp78pZrdUawsCKzsRTGQQ1o9LWxn4S0MM8A9DULlj63CMNlwUMH3XCC5iZjd41Cz+AskV21omHlC4St5uDw9ctqXhqxrf8qOk+Tki2YjdmAES0QqKeaauQPWG4cwuCvQxRWuqle1aAcw6iT4bMaoeNSGo0fdeC8NgVxmgvMWN216ex0TS1ss3tn8MTPYnJgo7JbDE3UeVYt3n2AtAOGMfOPtlUf6840LhC892bWFFP8J51TVRcVayWVZaVMBIAqiWd7vHVHuEEGgMw5RkMklHMfqtg/LZ2uo7wNOBjY3Sbrjy6f8GZTe4ymUIPjOaUnqWKWJa6JCWPl/bCww9RDUcyYgUUbDn3Fd40ZPuRqQnGFhPOUd0khYLWdAfoesPa8t6yW1R95ADB8x2j+L6qxDnDbBCG5E1RmD0JhSUDDUbma9BC3GRIfCO3bbxncGujLmINqn5j1q4q+P9SyguuJElmhp2jPErWWJdv09oC9rIToTQ8bIcsVunvBdyOTIHara7 iYFmLApg 6jCOZxX6jO+g+Km3fqEg6UqDDKmWI+3mxeqxmeOATVWA7pLHh4yFtQiyVF/K9iMnOFuQHLc6zJ9lceSHyRCaVKL7iyMr6+jVNL92kA58p52c9+sXRFbdv2uf70BIvlXNJsIRj/dondG610Z9VpsKV1xG6sJ2nHOAiv9m0Ba1UMgr28tsdWmgLl8dJhY1XEOGpjJvp06NR//WIMa7nDP+OW6UeKMSVGbQaTEMLjr60Rwu1il56xqqApO+zZ+brVAAnSZhu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With multi event sites for a single wait, dept allows to skip tracking an event that is recoverable by other recover paths. Introduce an API, event_site(), to skip tracking the event in the case. Signed-off-by: Byungchul Park --- include/linux/dept.h | 30 ++++++++++++++++++++++++++++++ include/linux/sched.h | 6 ++++++ kernel/dependency/dept.c | 20 ++++++++++++++++++++ 3 files changed, 56 insertions(+) diff --git a/include/linux/dept.h b/include/linux/dept.h index 25fdd324614a..0ac13129f308 100644 --- a/include/linux/dept.h +++ b/include/linux/dept.h @@ -487,6 +487,31 @@ extern void dept_task_exit(struct task_struct *t); extern void dept_free_range(void *start, unsigned int sz); extern void dept_mark_event_site_used(void *start, void *end); +extern void disable_event_track(void); +extern void enable_event_track(void); + +#define event_site(es, evt_func, ...) \ +do { \ + unsigned long _flags; \ + bool _disable; \ + \ + local_irq_save(_flags); \ + dept_event_site_used(es); \ + /* \ + * If !list_empty(&(es)->dept_head), the event site can be \ + * recovered by others. Do not track event dependency if so. \ + */ \ + _disable = !list_empty(&(es)->dep_head); \ + if (_disable) \ + disable_event_track(); \ + \ + evt_func(__VA_ARGS__); \ + \ + if (_disable) \ + enable_event_track(); \ + local_irq_restore(_flags); \ +} while (0) + extern void dept_map_init(struct dept_map *m, struct dept_key *k, int sub_u, const char *n); extern void dept_map_reinit(struct dept_map *m, struct dept_key *k, int sub_u, const char *n); extern void dept_ext_wgen_init(struct dept_ext_wgen *ewg); @@ -550,6 +575,11 @@ struct dept_event_site { }; #define dept_task_exit(t) do { } while (0) #define dept_free_range(s, sz) do { } while (0) #define dept_mark_event_site_used(s, e) do { } while (0) +#define event_site(es, evt_func, ...) \ +do { \ + (void)(es); \ + evt_func(__VA_ARGS__); \ +} while (0) #define dept_map_init(m, k, su, n) do { (void)(n); (void)(k); } while (0) #define dept_map_reinit(m, k, su, n) do { (void)(n); (void)(k); } while (0) diff --git a/include/linux/sched.h b/include/linux/sched.h index 43927e61921b..44a77b7116b7 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -873,6 +873,11 @@ struct dept_task { */ int missing_ecxt; + /* + * not to track events + */ + int disable_event_track_cnt; + /* * for tracking IRQ-enable state */ @@ -910,6 +915,7 @@ struct dept_task { .stage_wait_stack = NULL, \ .stage_lock = (arch_spinlock_t)__ARCH_SPIN_LOCK_UNLOCKED,\ .missing_ecxt = 0, \ + .disable_event_track_cnt = 0, \ .hardirqs_enabled = false, \ .softirqs_enabled = false, \ .task_exit = false, \ diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c index baa60bd0fb93..c65bb0c6dad2 100644 --- a/kernel/dependency/dept.c +++ b/kernel/dependency/dept.c @@ -2573,6 +2573,23 @@ static void __dept_wait(struct dept_map *m, unsigned long w_f, } } +void disable_event_track(void) +{ + dept_task()->disable_event_track_cnt++; +} +EXPORT_SYMBOL_GPL(disable_event_track); + +void enable_event_track(void) +{ + dept_task()->disable_event_track_cnt--; +} +EXPORT_SYMBOL_GPL(enable_event_track); + +static bool event_track_disabled(void) +{ + return !!dept_task()->disable_event_track_cnt; +} + /* * Called between dept_enter() and dept_exit(). */ @@ -2585,6 +2602,9 @@ static void __dept_event(struct dept_map *m, struct dept_map *real_m, struct dept_key *k; int e; + if (event_track_disabled()) + return; + e = find_first_bit(&e_f, DEPT_MAX_SUBCLASSES_EVT); if (DEPT_WARN_ON(e >= DEPT_MAX_SUBCLASSES_EVT)) -- 2.17.1