From: Byungchul Park <byungchul@sk.com>
To: linux-kernel@vger.kernel.org
Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org,
damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, will@kernel.org,
tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org,
sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com,
johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu,
willy@infradead.org, david@fromorbit.com, amir73il@gmail.com,
gregkh@linuxfoundation.org, kernel-team@lge.com,
linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org,
minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com,
sj@kernel.org, jglisse@redhat.com, dennis@kernel.org,
cl@linux.com, penberg@kernel.org, rientjes@google.com,
vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org,
josef@toxicpanda.com, linux-fsdevel@vger.kernel.org,
jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com,
hch@infradead.org, djwong@kernel.org,
dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com,
melissa.srw@gmail.com, hamohammed.sa@gmail.com,
harry.yoo@oracle.com, chris.p.wilson@intel.com,
gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com,
boqun.feng@gmail.com, longman@redhat.com, yskelg@gmail.com,
yunseong.kim@ericsson.com, yeoreum.yun@arm.com,
netdev@vger.kernel.org, matthew.brost@intel.com,
her0gyugyu@gmail.com
Subject: [PATCH v16 12/42] dept: record the latest one out of consecutive waits of the same class
Date: Mon, 19 May 2025 18:17:56 +0900 [thread overview]
Message-ID: <20250519091826.19752-13-byungchul@sk.com> (raw)
In-Reply-To: <20250519091826.19752-1-byungchul@sk.com>
The current code records all the waits for later use to track relation
between waits and events within each context. However, since the same
class is handled the same way, it'd be okay to record only one on behalf
of the others if they all have the same class.
Even though it's the ideal to search the whole history buffer for that,
since it'd cost too high, alternatively, let's keep the latest one when
the same class'ed waits consecutively appear.
Signed-off-by: Byungchul Park <byungchul@sk.com>
---
kernel/dependency/dept.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c
index ad443e063fdc..a2384f3148c5 100644
--- a/kernel/dependency/dept.c
+++ b/kernel/dependency/dept.c
@@ -1486,9 +1486,28 @@ static struct dept_wait_hist *new_hist(void)
return wh;
}
+static struct dept_wait_hist *last_hist(void)
+{
+ int pos_n = hist_pos_next();
+ struct dept_wait_hist *wh_n = hist(pos_n);
+
+ /*
+ * This is the first try.
+ */
+ if (!pos_n && !wh_n->wait)
+ return NULL;
+
+ return hist(pos_n + DEPT_MAX_WAIT_HIST - 1);
+}
+
static void add_hist(struct dept_wait *w, unsigned int wg, unsigned int ctxt_id)
{
- struct dept_wait_hist *wh = new_hist();
+ struct dept_wait_hist *wh;
+
+ wh = last_hist();
+
+ if (!wh || wh->wait->class != w->class || wh->ctxt_id != ctxt_id)
+ wh = new_hist();
if (likely(wh->wait))
put_wait(wh->wait);
--
2.17.1
next prev parent reply other threads:[~2025-05-19 9:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 9:17 [PATCH v16 00/42] DEPT(DEPendency Tracker) Byungchul Park
2025-05-19 9:17 ` [PATCH v16 01/42] llist: move llist_{head,node} definition to types.h Byungchul Park
2025-05-19 9:17 ` [PATCH v16 02/42] dept: implement DEPT(DEPendency Tracker) Byungchul Park
2025-05-19 9:17 ` [PATCH v16 03/42] dept: add single event dependency tracker APIs Byungchul Park
2025-05-19 9:17 ` [PATCH v16 04/42] dept: add lock " Byungchul Park
2025-05-19 9:17 ` [PATCH v16 05/42] dept: tie to lockdep and IRQ tracing Byungchul Park
2025-05-19 9:17 ` [PATCH v16 06/42] dept: add proc knobs to show stats and dependency graph Byungchul Park
2025-05-19 9:17 ` [PATCH v16 07/42] dept: distinguish each kernel context from another Byungchul Park
2025-05-19 9:17 ` [PATCH v16 08/42] x86_64, dept: add support CONFIG_ARCH_HAS_DEPT_SUPPORT to x86_64 Byungchul Park
2025-05-19 9:17 ` [PATCH v16 09/42] arm64, dept: add support CONFIG_ARCH_HAS_DEPT_SUPPORT to arm64 Byungchul Park
2025-05-19 9:17 ` [PATCH v16 10/42] dept: distinguish each work from another Byungchul Park
2025-05-19 9:17 ` [PATCH v16 11/42] dept: add a mechanism to refill the internal memory pools on running out Byungchul Park
2025-05-19 9:17 ` Byungchul Park [this message]
2025-05-19 9:17 ` [PATCH v16 13/42] dept: apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete() Byungchul Park
2025-05-19 9:17 ` [PATCH v16 14/42] dept: apply sdt_might_sleep_{start,end}() to swait Byungchul Park
2025-05-19 9:17 ` [PATCH v16 15/42] dept: apply sdt_might_sleep_{start,end}() to waitqueue wait Byungchul Park
2025-05-19 9:18 ` [PATCH v16 16/42] dept: apply sdt_might_sleep_{start,end}() to hashed-waitqueue wait Byungchul Park
2025-05-19 9:18 ` [PATCH v16 17/42] dept: apply sdt_might_sleep_{start,end}() to dma fence Byungchul Park
2025-05-19 9:18 ` [PATCH v16 18/42] dept: track timeout waits separately with a new Kconfig Byungchul Park
2025-05-19 9:18 ` [PATCH v16 19/42] dept: apply timeout consideration to wait_for_completion()/complete() Byungchul Park
2025-05-19 9:18 ` [PATCH v16 20/42] dept: apply timeout consideration to swait Byungchul Park
2025-05-19 9:18 ` [PATCH v16 21/42] dept: apply timeout consideration to waitqueue wait Byungchul Park
2025-05-19 9:18 ` [PATCH v16 22/42] dept: apply timeout consideration to hashed-waitqueue wait Byungchul Park
2025-05-19 9:18 ` [PATCH v16 23/42] dept: apply timeout consideration to dma fence wait Byungchul Park
2025-05-19 9:18 ` [PATCH v16 24/42] dept: make dept able to work with an external wgen Byungchul Park
2025-05-19 9:18 ` [PATCH v16 25/42] dept: track PG_locked with dept Byungchul Park
2025-05-19 9:18 ` [PATCH v16 26/42] dept: print staged wait's stacktrace on report Byungchul Park
2025-05-19 9:18 ` [PATCH v16 27/42] locking/lockdep: prevent various lockdep assertions when lockdep_off()'ed Byungchul Park
2025-05-19 9:18 ` [PATCH v16 28/42] dept: add documentation for dept Byungchul Park
2025-05-19 9:18 ` [PATCH v16 29/42] cpu/hotplug: use a weaker annotation in AP thread Byungchul Park
2025-05-19 9:18 ` [PATCH v16 30/42] fs/jbd2: use a weaker annotation in journal handling Byungchul Park
2025-05-19 9:18 ` [PATCH v16 31/42] dept: assign dept map to mmu notifier invalidation synchronization Byungchul Park
2025-05-19 9:18 ` [PATCH v16 32/42] dept: assign unique dept_key to each distinct dma fence caller Byungchul Park
2025-05-19 9:18 ` [PATCH v16 33/42] dept: make dept aware of lockdep_set_lock_cmp_fn() annotation Byungchul Park
2025-05-19 9:18 ` [PATCH v16 34/42] dept: make dept stop from working on debug_locks_off() Byungchul Park
2025-05-19 9:18 ` [PATCH v16 35/42] i2c: rename wait_for_completion callback to wait_for_completion_cb Byungchul Park
2025-05-19 9:18 ` [PATCH v16 36/42] dept: assign unique dept_key to each distinct wait_for_completion() caller Byungchul Park
2025-05-19 9:18 ` [PATCH v16 37/42] completion, dept: introduce init_completion_dmap() API Byungchul Park
2025-05-19 9:18 ` [PATCH v16 38/42] dept: introduce a new type of dependency tracking between multi event sites Byungchul Park
2025-05-19 9:18 ` [PATCH v16 39/42] dept: add module support for struct dept_event_site and dept_event_site_dep Byungchul Park
2025-05-19 9:18 ` [PATCH v16 40/42] dept: introduce event_site() to disable event tracking if it's recoverable Byungchul Park
2025-05-19 9:18 ` [PATCH v16 41/42] dept: implement a basic unit test for dept Byungchul Park
2025-05-19 9:18 ` [PATCH v16 42/42] dept: call dept_hardirqs_off() in local_irq_*() regardless of irq state Byungchul Park
2025-07-25 2:09 ` [PATCH v16 00/42] DEPT(DEPendency Tracker) Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250519091826.19752-13-byungchul@sk.com \
--to=byungchul@sk.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=chris.p.wilson@intel.com \
--cc=cl@linux.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david@fromorbit.com \
--cc=dennis@kernel.org \
--cc=djwong@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duyuyang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwan-gyeong.mun@intel.com \
--cc=hamohammed.sa@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=hch@infradead.org \
--cc=her0gyugyu@gmail.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jlayton@kernel.org \
--cc=joel@joelfernandes.org \
--cc=johannes.berg@intel.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@lge.com \
--cc=kernel_team@skhynix.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=matthew.brost@intel.com \
--cc=max.byungchul.park@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sj@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yeoreum.yun@arm.com \
--cc=yskelg@gmail.com \
--cc=yunseong.kim@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox